[chromium-dev] Re: How do I filter CC'd code reviews in Gmail?

2009-07-31 Thread Ben Goodger (Google)
I get a lot of mail since I set up a watchlist filter on browser/. -Ben On Fri, Jul 31, 2009 at 7:28 PM, Mohamed Mansour wrote: > I thought all those cc's from code reviews, is about the last couple of > people who edited that part of the code in the past. I have been getting a > couple of code

[chromium-dev] Re: How do I filter CC'd code reviews in Gmail?

2009-07-31 Thread Mohamed Mansour
I thought all those cc's from code reviews, is about the last couple of people who edited that part of the code in the past. I have been getting a couple of code reviews cc's and the code I was cc'd is what I have touched within a month or so. I could imagine Ben receiving a ton of reviews, he touc

[chromium-dev] Re: Copy URL as plain text instead of HTML

2009-07-31 Thread Tony Chang
I already filed a bug for this: http://code.google.com/p/chromium/issues/detail?id=18194 On Fri, Jul 31, 2009 at 7:06 PM, Evan Stade wrote: > > Ah, I am eating my words. So you don't like the > targets/flavors/formats we write to when copying from the omnibox, > correct? If you plan to create a p

[chromium-dev] Re: Copy URL as plain text instead of HTML

2009-07-31 Thread Evan Stade
Ah, I am eating my words. So you don't like the targets/flavors/formats we write to when copying from the omnibox, correct? If you plan to create a patch to change this, here would be the place to discuss the technical details. If you are simply requesting a change, you might be better served fili

[chromium-dev] Re: Temporarily disable tcmalloc in build

2009-07-31 Thread cpu
What are the results of this experiment? On Jul 30, 12:15 pm, Huan Ren wrote: > I just submitted a change (22080) that disables tcmalloc used on > Windows platform. The plan is keeping it in trunk for 24 hours and > then reverting it. The intentions are >    - Having another round of performance

[chromium-dev] Re: my patch fails compile on try servers because png file isn't updated?

2009-07-31 Thread Tony Chang
The patch file doesn't include binary content. If it's just pngs, I normally just check in the new files in a separate change before doing the code change. On Fri, Jul 31, 2009 at 5:41 PM, Bradley Nelson wrote: > I believe the tryserver doesn't take binaries. > -BradN > On Fri, Jul 31, 2009 at 5

[chromium-dev] Re: How do I filter CC'd code reviews in Gmail?

2009-07-31 Thread Rahul Kuchhal
I thought to: and -cc: would work in this case? Have you tried using that in "Has the words" on Filter edit screen? On Fri, Jul 31, 2009 at 5:18 PM, Brett Wilson wrote: > > I added myself to some watchlists and I get a bunch of email about a > lot of reviews > > But this has confused my Gmail fi

[chromium-dev] Re: How do I filter CC'd code reviews in Gmail?

2009-07-31 Thread Ben Goodger (Google)
I would be interested in knowing this too. I think I'm going to create a second email address (e.g. ben-cc) to handle CC'ed reviews. -Ben On Fri, Jul 31, 2009 at 5:18 PM, Brett Wilson wrote: > > I added myself to some watchlists and I get a bunch of email about a > lot of reviews > > But this ha

[chromium-dev] Re: my patch fails compile on try servers because png file isn't updated?

2009-07-31 Thread Bradley Nelson
I believe the tryserver doesn't take binaries.-BradN On Fri, Jul 31, 2009 at 5:40 PM, Tim Steele wrote: > My patch keeps failing to > compile > on > the try

[chromium-dev] my patch fails compile on try servers because png file isn't updated?

2009-07-31 Thread Tim Steele
My patch keeps failing to compile on the try servers because the update

[chromium-dev] Re: Copy URL as plain text instead of HTML

2009-07-31 Thread ptr727
> By "copying the URL from the UI" do you mean copying the URL from the > Omnibox? Or copying from the webpage contents, using ctrl-c? The edit box where you type the URL. Click in it with the mouse (give it focus), press Ctrl-A (select all), press Ctrl-C (copy). This results in the clipboard ha

[chromium-dev] How do I filter CC'd code reviews in Gmail?

2009-07-31 Thread Brett Wilson
I added myself to some watchlists and I get a bunch of email about a lot of reviews But this has confused my Gmail filters, which automatic ally label and archive code reviews not addressed directly to me, and all of my CCd code reviews show up in my inbox. Anybody know how to reliably detect th

[chromium-dev] Re: browser/sync is moving in

2009-07-31 Thread Tim Steele
On Fri, Jul 31, 2009 at 3:59 PM, Caleb Eggensperger wrote: > The doc says: > >- Provide a web interface to access stored / synced bookmarks, likely >via the docs.google.com doclist. > > What about google.com/bookmarks? Shouldn't be difficult -- toolbar syncs > to there currently. > It's m

[chromium-dev] Re: browser/sync is moving in

2009-07-31 Thread Mohamed Mansour
Awesome! Many people will like this. -- Mohamed Mansour On Fri, Jul 31, 2009 at 6:08 PM, Tim Steele wrote: > > Yep, what Peter said. In the coming weeks, we will check in the full > protocol definition itself, which is what we used to build the Google > service for Google Chrome users. > > > O

[chromium-dev] Re: browser/sync is moving in

2009-07-31 Thread Tim Steele
Yep, what Peter said. In the coming weeks, we will check in the full protocol definition itself, which is what we used to build the Google service for Google Chrome users. On Fri, Jul 31, 2009 at 3:05 PM, Peter Kasting wrote: > On Fri, Jul 31, 2009 at 3:04 PM, Mohamed Mansour wrote: > >> So we

[chromium-dev] Re: browser/sync is moving in

2009-07-31 Thread Peter Kasting
On Fri, Jul 31, 2009 at 3:04 PM, Mohamed Mansour wrote: > So we are going to tie up Chromium sync to just Google Services? Why not > make the protocol open so any service could use it. The protocol _is_ open. Protobufs are open source and the sync spec built on them is also open source. PK -

[chromium-dev] Re: browser/sync is moving in

2009-07-31 Thread Mohamed Mansour
So we are going to tie up Chromium sync to just Google Services? Why not make the protocol open so any service could use it. So if anyone wants to sync, they will install an extension to do so, instead of coupling it directly to Google services. -- Mohamed Mansour On Fri, Jul 31, 2009 at 5:14 PM,

[chromium-dev] Re: `git pull` timeout

2009-07-31 Thread Nico Weber
That fixed it, thanks. On Fri, Jul 31, 2009 at 2:14 PM, Evan Martin wrote: > On Fri, Jul 31, 2009 at 2:14 PM, Evan Martin wrote: >> See the note on the page about "if you're within the Google corporate >> network". > > the page = http://code.google.com/p/chromium/wiki/UsingGit > >> >> (I should

[chromium-dev] Re: browser/sync is moving in

2009-07-31 Thread Peter Kasting
On Fri, Jul 31, 2009 at 2:07 PM, Tim Steele wrote: > Check out the sync developer > page > if > you're interested in low-level goals and technical details. > Since I suspect it will be a FAQ: According to that webpag

[chromium-dev] Re: `git pull` timeout

2009-07-31 Thread Evan Martin
On Fri, Jul 31, 2009 at 2:14 PM, Evan Martin wrote: > See the note on the page about "if you're within the Google corporate > network". the page = http://code.google.com/p/chromium/wiki/UsingGit > > (I should probably amend that for the public: it's just a routing > issue related to how git.chr

[chromium-dev] Re: `git pull` timeout

2009-07-31 Thread Evan Martin
See the note on the page about "if you're within the Google corporate network". (I should probably amend that for the public: it's just a routing issue related to how git.chromium.org lives in a DMZ.) On Fri, Jul 31, 2009 at 1:49 PM, Nico Weber wrote: > > Hi, > > `git pull` times out for me: > >

[chromium-dev] Re: Copy URL as plain text instead of HTML

2009-07-31 Thread Ojan Vafai
This is kind of off topic, but should we consider adding a copy/cut-as-plain-text keyboard shortcut (ctrl+shift+c/x). That would be nicely symmetrical with ctrl+shift+v for paste-as-plain-text. Ojan On Fri, Jul 31, 2009 at 4:57 PM, Scott Violet wrote: > > I just happen to be looking at clipboard

[chromium-dev] browser/sync is moving in

2009-07-31 Thread Tim Steele
Hi! A bunch of us have been working on a feature to sync user data in Chromium with a Google account. (Surprise! :)) The great news is that we'll be starting to work directly in the Chromium project this week, and let me tell you, are we excited to do that! This email discusses how we're planni

[chromium-dev] Re: Copy URL as plain text instead of HTML

2009-07-31 Thread Scott Violet
I just happen to be looking at clipboard code for page contents. Here's the code for writing a URL: void WebClipboardImpl::writeURL(const WebURL& url, const WebString& title) { ScopedClipboardWriterGlue scw(ClipboardGetClipboard()); scw.WriteBookmark(title, url.spec()); scw.WriteHTML(UTF8T

[chromium-dev] `git pull` timeout

2009-07-31 Thread Nico Weber
Hi, `git pull` times out for me: thakis-macbookpro:~/src/chrome-git/src thakis$ git pull git.chromium.org[0: 74.125.54.202]: errno=Operation timed out fatal: unable to connect a socket (Operation timed out) thakis-macbookpro:~/src/chrome-git/src thakis$ ping 74.125.54.202 PING 74.125.54.202 (74.

[chromium-dev] Re: Copy URL as plain text instead of HTML

2009-07-31 Thread Evan Stade
I have a feeling you are talking about the render view, and you should be asking these questions 'round webkit way -- Evan Stade On Fri, Jul 31, 2009 at 12:34 PM, Peter Kasting wrote: > On Fri, Jul 31, 2009 at 12:00 PM, ptr727 wrote: >> >> To summarize, in Chrome copying the URL from the UI i

[chromium-dev] Re: Topcrash on OSX - crbug.com/17555 - Renderer dies on WTF::HastSet

2009-07-31 Thread Jeremy Moskovich
No, we don't have a repro, but what you mentioned sounds promising. Thanks, Jeremy On Fri, Jul 31, 2009 at 11:48 AM, Jeremy Orlow wrote: > On Fri, Jul 31, 2009 at 11:42 AM, Jeremy Moskovich wrote: > >> This is the top crash on OSX by far as of 3.0.196.0. >> From Dimitri's comment on the bug: >>

[chromium-dev] Re: Copy URL as plain text instead of HTML

2009-07-31 Thread Peter Kasting
On Fri, Jul 31, 2009 at 12:00 PM, ptr727 wrote: > To summarize, in Chrome copying the URL from the UI is not the same as > right click copy link. By "copying the URL from the UI" do you mean copying the URL from the Omnibox? Or copying from the webpage contents, using ctrl-c? Right click copy

[chromium-dev] Re: PSA: Consider upgrading to VS2008.

2009-07-31 Thread Ben Goodger (Google)
I would like to. It's just a matter of time and effort... and it's not been a top priority for me to date. Please feel free to gather requirements and develop a plan however. -Ben On Fri, Jul 31, 2009 at 11:11 AM, Mohamed Mansour wrote: > Are we planning to remove ATL so we can make Express peop

[chromium-dev] Re: Copy URL as plain text instead of HTML

2009-07-31 Thread ptr727
As I was writing this and testing steps to replicate, I found that the HTML formatting did not always happen. I found the answer using the Windows ClipBook Viewer (it is only available on XP as clipbrd.exe, but works on Vista). When placing contents in the clipbook, the application that saves the

[chromium-dev] Re: Topcrash on OSX - crbug.com/17555 - Renderer dies on WTF::HastSet

2009-07-31 Thread Jeremy Orlow
On Fri, Jul 31, 2009 at 11:48 AM, Jeremy Orlow wrote: > On Fri, Jul 31, 2009 at 11:42 AM, Jeremy Moskovich wrote: > >> This is the top crash on OSX by far as of 3.0.196.0. >> From Dimitri's comment on the bug: >> """ >> >> It appears that somehow a message from BrowserRenderProcessHost catches th

[chromium-dev] Re: Topcrash on OSX - crbug.com/17555 - Renderer dies on WTF::HastSet

2009-07-31 Thread Jeremy Orlow
On Fri, Jul 31, 2009 at 11:42 AM, Jeremy Moskovich wrote: > This is the top crash on OSX by far as of 3.0.196.0. > From Dimitri's comment on the bug: > """ > > It appears that somehow a message from BrowserRenderProcessHost catches the > RenderProcess with its pants down, where WebView hasn't been

[chromium-dev] Topcrash on OSX - crbug.com/17555 - Renderer dies on WTF::HastSet

2009-07-31 Thread Jeremy Moskovich
This is the top crash on OSX by far as of 3.0.196.0. >From Dimitri's comment on the bug: """ It appears that somehow a message from BrowserRenderProcessHost catches the RenderProcess with its pants down, where WebView hasn't been created and the WebCore::Page constructor hasn't been called yet. "

[chromium-dev] Re: PSA: Consider upgrading to VS2008.

2009-07-31 Thread Mohamed Mansour
Are we planning to remove ATL so we can make Express people happy. We can do a project plan and figure out a timeline on how to remove ATL. It will make many people happy. -- Mohamed Mansour On Fri, Jul 31, 2009 at 2:01 PM, Ben Goodger (Google) wrote: > > A few changes are coming soon that mean

[chromium-dev] PSA: Consider upgrading to VS2008.

2009-07-31 Thread Ben Goodger (Google)
A few changes are coming soon that mean using VS2008 is desirable: - /MP will be enabled by default for VS2008 debug builds, which will make your builds faster on newer multicore machines without you having to patch any files in your local tree. - We will eventually update the required SDK to the

[chromium-dev] Re: Copy URL as plain text instead of HTML

2009-07-31 Thread Tony Chang
Can you elaborate on how you're copying a URL from Chrome? Are you using Ctrl+C, the page menu item, or the context menu? When I use the context menu, I only get the plain text of the URL. In the other two cases, doesn't every browser paste as HTML? On Fri, Jul 31, 2009 at 10:28 AM, ptr727 wro

[chromium-dev] Re: Copy URL as plain text instead of HTML

2009-07-31 Thread Jeremy Orlow
On Fri, Jul 31, 2009 at 10:41 AM, PhistucK wrote: > Though, at least on Windows, that is what they (and the external > application) are expecting, I mean, they expect the formatting not to > change. > Word, Outlook and rest are automatically turning the URL into a link if it > is not already a li

[chromium-dev] Re: Copy URL as plain text instead of HTML

2009-07-31 Thread PhistucK
Though, at least on Windows, that is what they (and the external application) are expecting, I mean, they expect the formatting not to change. Word, Outlook and rest are automatically turning the URL into a link if it is not already a link, anyway. GMail does not, true. But any other browser (I thi

[chromium-dev] Re: Copy URL as plain text instead of HTML

2009-07-31 Thread Peter Kasting
On Fri, Jul 31, 2009 at 10:28 AM, ptr727 wrote: > I can think of no particular reason why the URL or a link needs to be > formatted in anything other than plain text. Most people tend to prefer links to be formatted as links, so they can click them. Can the URL and link copy code please be cha

[chromium-dev] Copy URL as plain text instead of HTML

2009-07-31 Thread ptr727
Hi This is my first post in this group, so if there is more appropriate place to post a requests like this, please let me know. I often copy and past the browser URL or link URL's in documents or emails. IE copies the URL as plain text, and when pasting the URL in a document, the pasted text has

[chromium-dev] Re: Question about chromium sandbox on Mac OSX

2009-07-31 Thread Jeremy Moskovich
If you're just doing this for debugging purposes, an easier route would be to pass in the --no-sandbox flag to temporarily disable the sandbox entirely, documented here: http://sites.google.com/a/chromium.org/dev/developers/debugging-on-os-x On Thu, Jul 30, 2009 at 8:00 PM, n179911 wrote: > > Th

[chromium-dev] Re: gyp scons generator temporary glitch

2009-07-31 Thread Paweł Hajdan Jr .
On Thu, Jul 30, 2009 at 18:52, Evan Martin wrote: > For now you can pass the "mode" flag to make it work: > hammer --mode=Debug This worked for me. Thanks. Easier than manually rolling back DEPS. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-

[chromium-dev] Re: gcl upload can't support proxy

2009-07-31 Thread Marc-Antoine Ruel
Python's urllib looks at the HTTP_PROXY environment variable. Try setting it before using gcl. Official doc: http://docs.python.org/library/urllib.html M-A On Thu, Jul 30, 2009 at 1:11 PM, Evan Martin wrote: > > The proxy suggestion already provided i

[chromium-dev] Re: Mozilla design challenge

2009-07-31 Thread Ben Laurie
On Wed, Jul 22, 2009 at 6:08 PM, Brian Rakowski wrote: > The most promising things I found from the design challenge were the history > view in "Favitabs n' Drawers" (see attached image). The cool thing about it > is that it shows how long the tabs were open. I find other history views > that only