[GitHub] XD-DENG commented on issue #3724: [AIRFLOW-2878] Fix www_rbac display issue

2018-08-10 Thread GitBox
XD-DENG commented on issue #3724: [AIRFLOW-2878] Fix www_rbac display issue URL: https://github.com/apache/incubator-airflow/pull/3724#issuecomment-412246789 Hi @verdan , FYI, this commit is already reverted via https://github.com/apache/incubator-airflow/pull/3737 . Thanks.

[GitHub] XD-DENG edited a comment on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY

2018-08-10 Thread GitBox
XD-DENG edited a comment on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY URL: https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412227570 Hi @feng-tao , in cluster mode, given the `.cfg` files are initiated on different nodes, the SECRET_KEY will be different.

[GitHub] kaxil commented on issue #3733: [WIP] [AIRFLOW-491] Add cache parameter in BigQuery query method

2018-08-10 Thread GitBox
kaxil commented on issue #3733: [WIP] [AIRFLOW-491] Add cache parameter in BigQuery query method URL: https://github.com/apache/incubator-airflow/pull/3733#issuecomment-412239088 Don't remove any previous parameters, just add support to add new ones

[GitHub] XD-DENG edited a comment on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY

2018-08-10 Thread GitBox
XD-DENG edited a comment on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY URL: https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412227570 Hi @feng-tao , in cluster mode, given the `.cfg` files are initiated on different nodes, the SECRET_KEY will be different.

[GitHub] XD-DENG edited a comment on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY

2018-08-10 Thread GitBox
XD-DENG edited a comment on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY URL: https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412227570 Hi @feng-tao , in cluster mode, given the `.cfg` files are initiated on different nodes, the SECRET_KEY will be different.

[GitHub] XD-DENG edited a comment on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY

2018-08-10 Thread GitBox
XD-DENG edited a comment on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY URL: https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412227570 Hi @feng-tao , in cluster mode, given the `.cfg` files are initiated on different nodes, the SECRET_KEY will be different.

[GitHub] XD-DENG commented on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY

2018-08-10 Thread GitBox
XD-DENG commented on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY URL: https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412227570 Hi @feng-tao , in cluster mode, given the `.cfg` files are initiated on different nodes, the SECRET_KEY will be different. That's also

[GitHub] amir656 commented on issue #3739: [AIRFLOW-2868] Extend mesos_executor

2018-08-10 Thread GitBox
amir656 commented on issue #3739: [AIRFLOW-2868] Extend mesos_executor URL: https://github.com/apache/incubator-airflow/pull/3739#issuecomment-412219056 I am not sure where to add details about this change to the documentation. There doesn't seem to be documentation about the

[jira] [Updated] (AIRFLOW-2868) Mesos Executor should use executor_config to specify CPU, Memory and Docker image on the task level

2018-08-10 Thread Amir Shahatit (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amir Shahatit updated AIRFLOW-2868: --- External issue URL: https://github.com/apache/incubator-airflow/pull/3739 > Mesos Executor

[jira] [Commented] (AIRFLOW-2868) Mesos Executor should use executor_config to specify CPU, Memory and Docker image on the task level

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576881#comment-16576881 ] ASF GitHub Bot commented on AIRFLOW-2868: - amir656 opened a new pull request #3739:

[GitHub] amir656 opened a new pull request #3739: [AIRFLOW-2868] Extend mesos_executor

2018-08-10 Thread GitBox
amir656 opened a new pull request #3739: [AIRFLOW-2868] Extend mesos_executor URL: https://github.com/apache/incubator-airflow/pull/3739 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following

[jira] [Created] (AIRFLOW-2887) Add to BigQueryBaseCursor methods for creating and updating datasets

2018-08-10 Thread Iuliia Volkova (JIRA)
Iuliia Volkova created AIRFLOW-2887: --- Summary: Add to BigQueryBaseCursor methods for creating and updating datasets Key: AIRFLOW-2887 URL: https://issues.apache.org/jira/browse/AIRFLOW-2887

[jira] [Updated] (AIRFLOW-2887) Add to BigQueryBaseCursor methods for creating and updating datasets

2018-08-10 Thread Iuliia Volkova (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Iuliia Volkova updated AIRFLOW-2887: Description: In BigQueryBaseCursor exist only: def delete_dataset(self, project_id,

[GitHub] feng-tao commented on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY

2018-08-10 Thread GitBox
feng-tao commented on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY URL: https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412192087 hey @XD-DENG , it seems that it will still be an issue if we have a cluster for webservers based on the comment in

[jira] [Commented] (AIRFLOW-2866) Missing CSRF Token Error on Web UI Create/Update Operations

2018-08-10 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576793#comment-16576793 ] Tao Feng commented on AIRFLOW-2866: --- Thanks [~craigf] . Let me comment that back to ticket / pr. >

[jira] [Commented] (AIRFLOW-2866) Missing CSRF Token Error on Web UI Create/Update Operations

2018-08-10 Thread Craig Forster (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576717#comment-16576717 ] Craig Forster commented on AIRFLOW-2866: [~TaoFeng] Running locally with that branch seems to

[GitHub] troychen728 commented on a change in pull request #3658: [AIRFLOW-2524] Add Amazon SageMaker Training

2018-08-10 Thread GitBox
troychen728 commented on a change in pull request #3658: [AIRFLOW-2524] Add Amazon SageMaker Training URL: https://github.com/apache/incubator-airflow/pull/3658#discussion_r209352239 ## File path: airflow/contrib/hooks/sagemaker_hook.py ## @@ -0,0 +1,239 @@ +# -*- coding:

[jira] [Commented] (AIRFLOW-2866) Missing CSRF Token Error on Web UI Create/Update Operations

2018-08-10 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576674#comment-16576674 ] Tao Feng commented on AIRFLOW-2866: --- [~craigf] , I don't have the setup in my mac. Could you apply

[jira] [Commented] (AIRFLOW-2866) Missing CSRF Token Error on Web UI Create/Update Operations

2018-08-10 Thread Craig Forster (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576657#comment-16576657 ] Craig Forster commented on AIRFLOW-2866: Yes, it looks related to that. I explicitly set a

[jira] [Commented] (AIRFLOW-2844) Airflow Logs BrokenPipeException

2018-08-10 Thread Kyle Bridenstine (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576658#comment-16576658 ] Kyle Bridenstine commented on AIRFLOW-2844: --- *Root Cause Of Issue:* *

[jira] [Commented] (AIRFLOW-2866) Missing CSRF Token Error on Web UI Create/Update Operations

2018-08-10 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576627#comment-16576627 ] Tao Feng commented on AIRFLOW-2866: --- which version did you run? Could it be related to AIRFLOW-2809?

[GitHub] feng-tao edited a comment on issue #3732: Fix typos detected by github.com/client9/misspell

2018-08-10 Thread GitBox
feng-tao edited a comment on issue #3732: Fix typos detected by github.com/client9/misspell URL: https://github.com/apache/incubator-airflow/pull/3732#issuecomment-412148787 hey @seratch , the tool looks very useful :). Your change lgtm. But could you help to create a jira ticket and

[jira] [Commented] (AIRFLOW-2866) Missing CSRF Token Error on Web UI Create/Update Operations

2018-08-10 Thread Craig Forster (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576602#comment-16576602 ] Craig Forster commented on AIRFLOW-2866: Looks related to AIRFLOW-2866? > Missing CSRF Token

[GitHub] xnuinside commented on issue #3733: [WIP] [AIRFLOW-491] Add cache parameter in BigQuery query method

2018-08-10 Thread GitBox
xnuinside commented on issue #3733: [WIP] [AIRFLOW-491] Add cache parameter in BigQuery query method URL: https://github.com/apache/incubator-airflow/pull/3733#issuecomment-412147816 @kaxil , how do you think need I to remove other params relative to "query" like use_legacy? and just

[GitHub] XD-DENG commented on issue #3737: Revert "[AIRFLOW-2878] Fix www_rbac display issue"

2018-08-10 Thread GitBox
XD-DENG commented on issue #3737: Revert "[AIRFLOW-2878] Fix www_rbac display issue" URL: https://github.com/apache/incubator-airflow/pull/3737#issuecomment-412147753 Thanks @feng-tao This is an automated message from the

[jira] [Commented] (AIRFLOW-2866) Missing CSRF Token Error on Web UI Create/Update Operations

2018-08-10 Thread Craig Forster (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576600#comment-16576600 ] Craig Forster commented on AIRFLOW-2866: I'm seeing this on master as well. > Missing CSRF

[jira] [Commented] (AIRFLOW-2878) "/www_rbac" Layout/UI Display Issue

2018-08-10 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576596#comment-16576596 ] ASF subversion and git services commented on AIRFLOW-2878: -- Commit

[jira] [Commented] (AIRFLOW-2878) "/www_rbac" Layout/UI Display Issue

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576595#comment-16576595 ] ASF GitHub Bot commented on AIRFLOW-2878: - feng-tao closed pull request #3737: Revert

[GitHub] feng-tao closed pull request #3737: Revert "[AIRFLOW-2878] Fix www_rbac display issue"

2018-08-10 Thread GitBox
feng-tao closed pull request #3737: Revert "[AIRFLOW-2878] Fix www_rbac display issue" URL: https://github.com/apache/incubator-airflow/pull/3737 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] XD-DENG commented on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY

2018-08-10 Thread GitBox
XD-DENG commented on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY URL: https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412146841 @feng-tao @Fokko PTAL. We need to have random SECRET_KEY for Flask App, while it must be consistent among workers. So I

[jira] [Commented] (AIRFLOW-2886) Secure Flask SECRET_KEY

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576591#comment-16576591 ] ASF GitHub Bot commented on AIRFLOW-2886: - XD-DENG opened a new pull request #3738:

[GitHub] XD-DENG opened a new pull request #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY

2018-08-10 Thread GitBox
XD-DENG opened a new pull request #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY URL: https://github.com/apache/incubator-airflow/pull/3738 ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the

[jira] [Created] (AIRFLOW-2886) Secure Flask SECRET_KEY

2018-08-10 Thread Xiaodong DENG (JIRA)
Xiaodong DENG created AIRFLOW-2886: -- Summary: Secure Flask SECRET_KEY Key: AIRFLOW-2886 URL: https://issues.apache.org/jira/browse/AIRFLOW-2886 Project: Apache Airflow Issue Type: Bug

[GitHub] feng-tao commented on issue #3734: Revert "[AIRFLOW-2878] Fix www_rbac display issue"

2018-08-10 Thread GitBox
feng-tao commented on issue #3734: Revert "[AIRFLOW-2878] Fix www_rbac display issue" URL: https://github.com/apache/incubator-airflow/pull/3734#issuecomment-412138578 @XD-DENG , I think directly revertting your pr in github may revert other prs that get merged after yours. But never

[GitHub] feng-tao commented on issue #3734: Revert "[AIRFLOW-2878] Fix www_rbac display issue"

2018-08-10 Thread GitBox
feng-tao commented on issue #3734: Revert "[AIRFLOW-2878] Fix www_rbac display issue" URL: https://github.com/apache/incubator-airflow/pull/3734#issuecomment-412139622 @XD-DENG , will do. This is an automated message from

[GitHub] XD-DENG commented on issue #3734: Revert "[AIRFLOW-2878] Fix www_rbac display issue"

2018-08-10 Thread GitBox
XD-DENG commented on issue #3734: Revert "[AIRFLOW-2878] Fix www_rbac display issue" URL: https://github.com/apache/incubator-airflow/pull/3734#issuecomment-412139420 @feng-tao Or may I trouble you to do a separate commit to remove the three lines I added? i.e. it's actually reverting

[GitHub] feng-tao commented on issue #3737: Revert "[AIRFLOW-2878] Fix www_rbac display issue"

2018-08-10 Thread GitBox
feng-tao commented on issue #3737: Revert "[AIRFLOW-2878] Fix www_rbac display issue" URL: https://github.com/apache/incubator-airflow/pull/3737#issuecomment-412138003 This is based on the discussion in https://github.com/apache/incubator-airflow/pull/3724. cc @r39132

[jira] [Commented] (AIRFLOW-2878) "/www_rbac" Layout/UI Display Issue

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576546#comment-16576546 ] ASF GitHub Bot commented on AIRFLOW-2878: - feng-tao opened a new pull request #3737: Revert

[GitHub] feng-tao opened a new pull request #3737: Revert "[AIRFLOW-2878] Fix www_rbac display issue"

2018-08-10 Thread GitBox
feng-tao opened a new pull request #3737: Revert "[AIRFLOW-2878] Fix www_rbac display issue" URL: https://github.com/apache/incubator-airflow/pull/3737 This reverts commit 1f57dafd70ac41da8295f20793f8913b7f5a5dff.

[GitHub] feng-tao closed pull request #3734: Revert "[AIRFLOW-2878] Fix www_rbac display issue"

2018-08-10 Thread GitBox
feng-tao closed pull request #3734: Revert "[AIRFLOW-2878] Fix www_rbac display issue" URL: https://github.com/apache/incubator-airflow/pull/3734 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[jira] [Commented] (AIRFLOW-2878) "/www_rbac" Layout/UI Display Issue

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576536#comment-16576536 ] ASF GitHub Bot commented on AIRFLOW-2878: - XD-DENG opened a new pull request #3734: Revert

[GitHub] feng-tao commented on issue #3728: [AIRFLOW-2883] Not search dag owner if owners are missing

2018-08-10 Thread GitBox
feng-tao commented on issue #3728: [AIRFLOW-2883] Not search dag owner if owners are missing URL: https://github.com/apache/incubator-airflow/pull/3728#issuecomment-412137090 PTAL @r39132 , any other concern? This is an

[jira] [Commented] (AIRFLOW-2878) "/www_rbac" Layout/UI Display Issue

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576532#comment-16576532 ] ASF GitHub Bot commented on AIRFLOW-2878: - feng-tao closed pull request #3736: Revert

[GitHub] feng-tao commented on issue #3648: [AIRFLOW-2786] Fix editing Variable with empty key crashing

2018-08-10 Thread GitBox
feng-tao commented on issue #3648: [AIRFLOW-2786] Fix editing Variable with empty key crashing URL: https://github.com/apache/incubator-airflow/pull/3648#issuecomment-412134502 thanks @Noremac201 . Merge. This is an

[jira] [Commented] (AIRFLOW-2786) Variables view fails to render if a variable has an empty key

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576521#comment-16576521 ] ASF GitHub Bot commented on AIRFLOW-2786: - feng-tao closed pull request #3648: [AIRFLOW-2786]

[jira] [Commented] (AIRFLOW-2878) "/www_rbac" Layout/UI Display Issue

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576519#comment-16576519 ] ASF GitHub Bot commented on AIRFLOW-2878: - XD-DENG closed pull request #3734: Revert

[GitHub] feng-tao commented on issue #3734: Revert "[AIRFLOW-2878] Fix www_rbac display issue"

2018-08-10 Thread GitBox
feng-tao commented on issue #3734: Revert "[AIRFLOW-2878] Fix www_rbac display issue" URL: https://github.com/apache/incubator-airflow/pull/3734#issuecomment-412134197 I don't think we need another pull request. We directly revert the original request. I will do that.

[jira] [Commented] (AIRFLOW-2878) "/www_rbac" Layout/UI Display Issue

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576518#comment-16576518 ] ASF GitHub Bot commented on AIRFLOW-2878: - feng-tao opened a new pull request #3736: Revert

[GitHub] feng-tao opened a new pull request #3736: Revert "[AIRFLOW-2878] Fix www_rbac display issue"

2018-08-10 Thread GitBox
feng-tao opened a new pull request #3736: Revert "[AIRFLOW-2878] Fix www_rbac display issue" URL: https://github.com/apache/incubator-airflow/pull/3736 Reverts apache/incubator-airflow#3724 This is an automated message from

[jira] [Commented] (AIRFLOW-2878) "/www_rbac" Layout/UI Display Issue

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576514#comment-16576514 ] ASF GitHub Bot commented on AIRFLOW-2878: - feng-tao closed pull request #3735: Revert

[jira] [Commented] (AIRFLOW-2878) "/www_rbac" Layout/UI Display Issue

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576512#comment-16576512 ] ASF GitHub Bot commented on AIRFLOW-2878: - feng-tao opened a new pull request #3735: Revert

[GitHub] feng-tao closed pull request #3735: Revert "[AIRFLOW-2878] Fix www_rbac display issue"

2018-08-10 Thread GitBox
feng-tao closed pull request #3735: Revert "[AIRFLOW-2878] Fix www_rbac display issue" URL: https://github.com/apache/incubator-airflow/pull/3735 This is an automated message from the Apache Git Service. To respond to the

[GitHub] feng-tao opened a new pull request #3735: Revert "[AIRFLOW-2878] Fix www_rbac display issue"

2018-08-10 Thread GitBox
feng-tao opened a new pull request #3735: Revert "[AIRFLOW-2878] Fix www_rbac display issue" URL: https://github.com/apache/incubator-airflow/pull/3735 Reverts apache/incubator-airflow#3724 This is an automated message from

[GitHub] XD-DENG commented on issue #3729: [AIRFLOW-2884] Fix Flask SECRET_KEY security issue in www_rbac

2018-08-10 Thread GitBox
XD-DENG commented on issue #3729: [AIRFLOW-2884] Fix Flask SECRET_KEY security issue in www_rbac URL: https://github.com/apache/incubator-airflow/pull/3729#issuecomment-412133255 Thanks @kaxil This is an automated message

[GitHub] kaxil edited a comment on issue #3729: [AIRFLOW-2884] Fix Flask SECRET_KEY security issue in www_rbac

2018-08-10 Thread GitBox
kaxil edited a comment on issue #3729: [AIRFLOW-2884] Fix Flask SECRET_KEY security issue in www_rbac URL: https://github.com/apache/incubator-airflow/pull/3729#issuecomment-412132706 @XD-DENG I would be on holidays and hence unreachable, please ping @feng-tao or @Fokko when it is

[GitHub] kaxil commented on issue #3729: [AIRFLOW-2884] Fix Flask SECRET_KEY security issue in www_rbac

2018-08-10 Thread GitBox
kaxil commented on issue #3729: [AIRFLOW-2884] Fix Flask SECRET_KEY security issue in www_rbac URL: https://github.com/apache/incubator-airflow/pull/3729#issuecomment-412132706 @XD-DENG I would be on holdiays and hence unreachable, please ping @feng-tao or @Fokko when it is ready.

[GitHub] kaxil commented on issue #3733: [WIP] [AIRFLOW-491] Add cache parameter in BigQuery query method

2018-08-10 Thread GitBox
kaxil commented on issue #3733: [WIP] [AIRFLOW-491] Add cache parameter in BigQuery query method URL: https://github.com/apache/incubator-airflow/pull/3733#issuecomment-412132227 Hi @xnuinside Please add `src_fmt_configs` param to `run_query` method and the Operator.

[GitHub] XD-DENG commented on issue #3729: [AIRFLOW-2884] Fix Flask SECRET_KEY security issue in www_rbac

2018-08-10 Thread GitBox
XD-DENG commented on issue #3729: [AIRFLOW-2884] Fix Flask SECRET_KEY security issue in www_rbac URL: https://github.com/apache/incubator-airflow/pull/3729#issuecomment-412129544 Hi @kaxil , I have realised this method will cause CSRF error `The CSRF session token is missing` when we

[GitHub] Noremac201 commented on issue #3648: [AIRFLOW-2786] Fix editing Variable with empty key crashing

2018-08-10 Thread GitBox
Noremac201 commented on issue #3648: [AIRFLOW-2786] Fix editing Variable with empty key crashing URL: https://github.com/apache/incubator-airflow/pull/3648#issuecomment-412125247 Looks like it was a python 3.5 incompatibility -- fixed now Thanks!

[jira] [Commented] (AIRFLOW-1059) Reset_state_for_orphaned_task should operate in batch for the scheduler

2018-08-10 Thread Feng Lu (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576372#comment-16576372 ] Feng Lu commented on AIRFLOW-1059: -- [~saguziel] Could you elaborate a bit more why orphaned tasks from

[jira] [Commented] (AIRFLOW-2878) "/www_rbac" Layout/UI Display Issue

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576369#comment-16576369 ] ASF GitHub Bot commented on AIRFLOW-2878: - XD-DENG opened a new pull request #3734: Revert

[GitHub] jrderuiter commented on issue #3560: [AIRFLOW-2697] Drop snakebite in favour of hdfs3

2018-08-10 Thread GitBox
jrderuiter commented on issue #3560: [AIRFLOW-2697] Drop snakebite in favour of hdfs3 URL: https://github.com/apache/incubator-airflow/pull/3560#issuecomment-412103674 @Fokko As we discussed, I removed the deprecation code so we can merge this in preparation for Airflow 2.0. I want to do

[GitHub] XD-DENG opened a new pull request #3734: Revert "[AIRFLOW-2878] Fix www_rbac display issue"

2018-08-10 Thread GitBox
XD-DENG opened a new pull request #3734: Revert "[AIRFLOW-2878] Fix www_rbac display issue" URL: https://github.com/apache/incubator-airflow/pull/3734 Hi @r39132 , this is to revert my earlier PR https://github.com/apache/incubator-airflow/pull/3724. As pointed out by @verdan , I

[GitHub] xnuinside commented on issue #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method

2018-08-10 Thread GitBox
xnuinside commented on issue #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method URL: https://github.com/apache/incubator-airflow/pull/3733#issuecomment-412071257 maybe make sense add use_query_cache=False for check operators

[GitHub] xnuinside opened a new pull request #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method

2018-08-10 Thread GitBox
xnuinside opened a new pull request #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method URL: https://github.com/apache/incubator-airflow/pull/3733 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[jira] [Commented] (AIRFLOW-491) Add cache parameter in BigQuery query method

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576223#comment-16576223 ] ASF GitHub Bot commented on AIRFLOW-491: xnuinside opened a new pull request #3733:

[GitHub] XD-DENG commented on issue #3724: [AIRFLOW-2878] Fix www_rbac display issue

2018-08-10 Thread GitBox
XD-DENG commented on issue #3724: [AIRFLOW-2878] Fix www_rbac display issue URL: https://github.com/apache/incubator-airflow/pull/3724#issuecomment-412062778 Sure. @r39132 may you please revert this commit as @verdan suggested? Thanks for pointing this out!

[GitHub] verdan edited a comment on issue #3724: [AIRFLOW-2878] Fix www_rbac display issue

2018-08-10 Thread GitBox
verdan edited a comment on issue #3724: [AIRFLOW-2878] Fix www_rbac display issue URL: https://github.com/apache/incubator-airflow/pull/3724#issuecomment-412062054 perfect, thanks! Also, I believe we need to revert this change, as this change would include extra spaces on each page.

[GitHub] verdan commented on issue #3724: [AIRFLOW-2878] Fix www_rbac display issue

2018-08-10 Thread GitBox
verdan commented on issue #3724: [AIRFLOW-2878] Fix www_rbac display issue URL: https://github.com/apache/incubator-airflow/pull/3724#issuecomment-412062054 perfect, thanks! Also, I believe we need to revert this change, as this change would include extra spaces on each page. cc:

[GitHub] XD-DENG commented on issue #3724: [AIRFLOW-2878] Fix www_rbac display issue

2018-08-10 Thread GitBox
XD-DENG commented on issue #3724: [AIRFLOW-2878] Fix www_rbac display issue URL: https://github.com/apache/incubator-airflow/pull/3724#issuecomment-412061132 Hi @verdan, I installed from the ‘tar.gz’ file directly. Will check the setting-up you introduced later. Thanks.

[GitHub] verdan commented on issue #3724: [AIRFLOW-2878] Fix www_rbac display issue

2018-08-10 Thread GitBox
verdan commented on issue #3724: [AIRFLOW-2878] Fix www_rbac display issue URL: https://github.com/apache/incubator-airflow/pull/3724#issuecomment-412059984 @XD-DENG I believe you haven't built the frontend packages yet, causing all these issues. We've implemented the `npm` and

[jira] [Closed] (AIRFLOW-559) Add support for BigQuery kwarg parameters

2018-08-10 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik closed AIRFLOW-559. -- Resolution: Not A Problem We don't need this as we plan to deprecate use of *args and **kwargs and we

[jira] [Commented] (AIRFLOW-559) Add support for BigQuery kwarg parameters

2018-08-10 Thread Iuliia Volkova (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576123#comment-16576123 ] Iuliia Volkova commented on AIRFLOW-559: [~kaxilnaik] , can you close this task to avoid

[jira] [Comment Edited] (AIRFLOW-559) Add support for BigQuery kwarg parameters

2018-08-10 Thread Iuliia Volkova (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576123#comment-16576123 ] Iuliia Volkova edited comment on AIRFLOW-559 at 8/10/18 11:21 AM: --

[jira] [Resolved] (AIRFLOW-1874) Support standard SQL in Check, ValueCheck and IntervalCheck BigQuery operators

2018-08-10 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-1874. - Resolution: Fixed Resolved by https://github.com/apache/incubator-airflow/pull/3717 > Support

[jira] [Commented] (AIRFLOW-1874) Support standard SQL in Check, ValueCheck and IntervalCheck BigQuery operators

2018-08-10 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576092#comment-16576092 ] ASF subversion and git services commented on AIRFLOW-1874: -- Commit

[jira] [Commented] (AIRFLOW-1874) Support standard SQL in Check, ValueCheck and IntervalCheck BigQuery operators

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576091#comment-16576091 ] ASF GitHub Bot commented on AIRFLOW-1874: - kaxil closed pull request #3717: [AIRFLOW-1874]

[GitHub] kaxil closed pull request #3717: [AIRFLOW-1874] use_legacy_sql added to BigQueryCheck operators

2018-08-10 Thread GitBox
kaxil closed pull request #3717: [AIRFLOW-1874] use_legacy_sql added to BigQueryCheck operators URL: https://github.com/apache/incubator-airflow/pull/3717 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[jira] [Resolved] (AIRFLOW-2884) Fix Flask SECRET_KEY security issue in www_rbac

2018-08-10 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-2884. - Resolution: Fixed Fix Version/s: 2.0.0 Resolved by

[GitHub] kaxil commented on a change in pull request #3725: [AIRFLOW-2877] Make docs site URL consistent everywhere

2018-08-10 Thread GitBox
kaxil commented on a change in pull request #3725: [AIRFLOW-2877] Make docs site URL consistent everywhere URL: https://github.com/apache/incubator-airflow/pull/3725#discussion_r209215776 ## File path: README.md ## @@ -24,9 +24,9 @@ monitor progress, and troubleshoot

[GitHub] kaxil commented on a change in pull request #3725: [AIRFLOW-2877] Make docs site URL consistent everywhere

2018-08-10 Thread GitBox
kaxil commented on a change in pull request #3725: [AIRFLOW-2877] Make docs site URL consistent everywhere URL: https://github.com/apache/incubator-airflow/pull/3725#discussion_r209203140 ## File path: README.md ## @@ -24,9 +24,9 @@ monitor progress, and troubleshoot

[GitHub] ashb commented on a change in pull request #3725: [AIRFLOW-2877] Make docs site URL consistent everywhere

2018-08-10 Thread GitBox
ashb commented on a change in pull request #3725: [AIRFLOW-2877] Make docs site URL consistent everywhere URL: https://github.com/apache/incubator-airflow/pull/3725#discussion_r209202215 ## File path: README.md ## @@ -24,9 +24,9 @@ monitor progress, and troubleshoot

[GitHub] ashb commented on a change in pull request #3725: [AIRFLOW-2877] Make docs site URL consistent everywhere

2018-08-10 Thread GitBox
ashb commented on a change in pull request #3725: [AIRFLOW-2877] Make docs site URL consistent everywhere URL: https://github.com/apache/incubator-airflow/pull/3725#discussion_r209201782 ## File path: README.md ## @@ -24,9 +24,9 @@ monitor progress, and troubleshoot

[GitHub] ashb commented on a change in pull request #3725: [AIRFLOW-2877] Make docs site URL consistent everywhere

2018-08-10 Thread GitBox
ashb commented on a change in pull request #3725: [AIRFLOW-2877] Make docs site URL consistent everywhere URL: https://github.com/apache/incubator-airflow/pull/3725#discussion_r209201237 ## File path: README.md ## @@ -24,9 +24,9 @@ monitor progress, and troubleshoot

[GitHub] seratch opened a new pull request #3732: Fix typos detected by github.com/client9/misspell

2018-08-10 Thread GitBox
seratch opened a new pull request #3732: Fix typos detected by github.com/client9/misspell URL: https://github.com/apache/incubator-airflow/pull/3732 ### Description Fixing typos is sometimes very hard. It's not so easy to visually review them. Recently, I discovered a very useful

[jira] [Commented] (AIRFLOW-2885) A Bug in www_rbac.utils.get_params

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575938#comment-16575938 ] ASF GitHub Bot commented on AIRFLOW-2885: - XD-DENG opened a new pull request #3731:

[GitHub] XD-DENG opened a new pull request #3731: [AIRFLOW-2885] Fix a bug in www_rbac.utils.get_params

2018-08-10 Thread GitBox
XD-DENG opened a new pull request #3731: [AIRFLOW-2885] Fix a bug in www_rbac.utils.get_params URL: https://github.com/apache/incubator-airflow/pull/3731 ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and

[jira] [Created] (AIRFLOW-2885) A Bug in www_rbac.utils.get_params

2018-08-10 Thread Xiaodong DENG (JIRA)
Xiaodong DENG created AIRFLOW-2885: -- Summary: A Bug in www_rbac.utils.get_params Key: AIRFLOW-2885 URL: https://issues.apache.org/jira/browse/AIRFLOW-2885 Project: Apache Airflow Issue

[GitHub] Fokko commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py

2018-08-10 Thread GitBox
Fokko commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py URL: https://github.com/apache/incubator-airflow/pull/3691#issuecomment-412000219 I'd say that we would need to remove this tox install as well:

[GitHub] Fokko commented on a change in pull request #3730: [AIRFLOW-2882] Add import and export for pool cli using JSON

2018-08-10 Thread GitBox
Fokko commented on a change in pull request #3730: [AIRFLOW-2882] Add import and export for pool cli using JSON URL: https://github.com/apache/incubator-airflow/pull/3730#discussion_r209166353 ## File path: tests/cli/test_cli.py ## @@ -165,3 +166,38 @@ def

[GitHub] kaxil commented on a change in pull request #3725: [AIRFLOW-2877] Make docs site URL consistent everywhere

2018-08-10 Thread GitBox
kaxil commented on a change in pull request #3725: [AIRFLOW-2877] Make docs site URL consistent everywhere URL: https://github.com/apache/incubator-airflow/pull/3725#discussion_r209161488 ## File path: README.md ## @@ -24,9 +24,9 @@ monitor progress, and troubleshoot

[GitHub] feng-tao edited a comment on issue #3728: [AIRFLOW-2883] Not search dag owner if owners are missing

2018-08-10 Thread GitBox
feng-tao edited a comment on issue #3728: [AIRFLOW-2883] Not search dag owner if owners are missing URL: https://github.com/apache/incubator-airflow/pull/3728#issuecomment-411962160 hey @r39132 , the issue is because the owners field for the dag is