[GitHub] vardancse commented on issue #3709: [AIRFLOW-2861][Improvement] Added index on log table, will make delete dag optimized

vardancse commented on issue #3709: [AIRFLOW-2861][Improvement] Added index on log table, will make delete dag optimized URL: https://github.com/apache/incubator-airflow/pull/3709#issuecomment-410956941 @feng-tao @Fokko Thanks for reviewing and explaining process, I've added migration scr

[GitHub] bolkedebruin commented on issue #3709: [AIRFLOW-2861][Improvement] Added index on log table, will make delete dag optimized

bolkedebruin commented on issue #3709: [AIRFLOW-2861][Improvement] Added index on log table, will make delete dag optimized URL: https://github.com/apache/incubator-airflow/pull/3709#issuecomment-410962651 Please correct your commit message per guidelines (shorten, remove [improvement], u

[GitHub] codecov-io commented on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime

codecov-io commented on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime URL: https://github.com/apache/incubator-airflow/pull/3708#issuecomment-410963628 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3708?src=pr&el=h1) Report > Merging [#3708](https://codecov.i

[GitHub] codecov-io edited a comment on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime

codecov-io edited a comment on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime URL: https://github.com/apache/incubator-airflow/pull/3708#issuecomment-410963628 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3708?src=pr&el=h1) Report > Merging [#3708](https://c

[GitHub] verdan commented on issue #3656: [WIP][AIRFLOW-2803] Fix all ESLint issues

verdan commented on issue #3656: [WIP][AIRFLOW-2803] Fix all ESLint issues URL: https://github.com/apache/incubator-airflow/pull/3656#issuecomment-410965163 @r39132 @tedmiston I am working on extracting all inline JS from html files in another PR i.e., https://github.com/verdan/incubator-a

[GitHub] ashb commented on issue #3703: [AIRFLOW-2857] Fix verify_gpl_dependency for Read the Docs

ashb commented on issue #3703: [AIRFLOW-2857] Fix verify_gpl_dependency for Read the Docs URL: https://github.com/apache/incubator-airflow/pull/3703#issuecomment-410972072 Change the title of PR and Jira to "get RTD env working" or there abouts and I'm happy with the PR.

[GitHub] codecov-io edited a comment on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime

codecov-io edited a comment on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime URL: https://github.com/apache/incubator-airflow/pull/3708#issuecomment-410963628 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3708?src=pr&el=h1) Report > Merging [#3708](https://c

[GitHub] awelsh93 commented on a change in pull request #3710: [AIRFLOW-2860] Update tests for druid hook

awelsh93 commented on a change in pull request #3710: [AIRFLOW-2860] Update tests for druid hook URL: https://github.com/apache/incubator-airflow/pull/3710#discussion_r208147674 ## File path: airflow/hooks/druid_hook.py ## @@ -53,6 +54,8 @@ def __init__( self.max_

[GitHub] codecov-io edited a comment on issue #3710: [AIRFLOW-2860] Update tests for druid hook

codecov-io edited a comment on issue #3710: [AIRFLOW-2860] Update tests for druid hook URL: https://github.com/apache/incubator-airflow/pull/3710#issuecomment-410760084 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3710?src=pr&el=h1) Report > Merging [#3710](https:/

[jira] [Commented] (AIRFLOW-2219) Race condition to DagRun.verify_integrity between Scheduler and Webserver

[ https://issues.apache.org/jira/browse/AIRFLOW-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571348#comment-16571348 ] Giovanni Paolo Gibilisco commented on AIRFLOW-2219: --- When the issue o

[GitHub] codecov-io commented on issue #3709: [AIRFLOW-2861][Improvement] Added index on log table

codecov-io commented on issue #3709: [AIRFLOW-2861][Improvement] Added index on log table URL: https://github.com/apache/incubator-airflow/pull/3709#issuecomment-411000135 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3709?src=pr&el=h1) Report > Merging [#3709](http

[GitHub] vardancse commented on issue #3709: [AIRFLOW-2861][Improvement] Added index on log table

vardancse commented on issue #3709: [AIRFLOW-2861][Improvement] Added index on log table URL: https://github.com/apache/incubator-airflow/pull/3709#issuecomment-411019627 @bolkedebruin Done, thanks! This is an automated mess

[jira] [Updated] (AIRFLOW-2864) Incorrect docstrings for SubDagOperator

[ https://issues.apache.org/jira/browse/AIRFLOW-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik updated AIRFLOW-2864: Summary: Incorrect docstrings for SubDagOperator (was: Fix docstrings for SubDagOperator) > Inc

[jira] [Created] (AIRFLOW-2864) Fix docstrings for SubDagOperator

Kaxil Naik created AIRFLOW-2864: --- Summary: Fix docstrings for SubDagOperator Key: AIRFLOW-2864 URL: https://issues.apache.org/jira/browse/AIRFLOW-2864 Project: Apache Airflow Issue Type: Improv

[GitHub] kaxil opened a new pull request #3712: [AIRFLOW-2864] Fix docstrings for SubDagOperator

kaxil opened a new pull request #3712: [AIRFLOW-2864] Fix docstrings for SubDagOperator URL: https://github.com/apache/incubator-airflow/pull/3712 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.

[jira] [Commented] (AIRFLOW-2864) Incorrect docstrings for SubDagOperator

[ https://issues.apache.org/jira/browse/AIRFLOW-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571696#comment-16571696 ] ASF GitHub Bot commented on AIRFLOW-2864: - kaxil opened a new pull request #371

[GitHub] ashb commented on a change in pull request #3712: [AIRFLOW-2864] Fix docstrings for SubDagOperator

ashb commented on a change in pull request #3712: [AIRFLOW-2864] Fix docstrings for SubDagOperator URL: https://github.com/apache/incubator-airflow/pull/3712#discussion_r208243635 ## File path: airflow/operators/subdag_operator.py ## @@ -37,18 +49,6 @@ def __init__(

[GitHub] kaxil commented on a change in pull request #3712: [AIRFLOW-2864] Fix docstrings for SubDagOperator

kaxil commented on a change in pull request #3712: [AIRFLOW-2864] Fix docstrings for SubDagOperator URL: https://github.com/apache/incubator-airflow/pull/3712#discussion_r208247841 ## File path: airflow/operators/subdag_operator.py ## @@ -37,18 +49,6 @@ def __init__(

[GitHub] kaxil closed pull request #3712: [AIRFLOW-2864] Fix docstrings for SubDagOperator

kaxil closed pull request #3712: [AIRFLOW-2864] Fix docstrings for SubDagOperator URL: https://github.com/apache/incubator-airflow/pull/3712 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[jira] [Commented] (AIRFLOW-2864) Incorrect docstrings for SubDagOperator

[ https://issues.apache.org/jira/browse/AIRFLOW-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571727#comment-16571727 ] ASF GitHub Bot commented on AIRFLOW-2864: - kaxil closed pull request #3712: [AI

[jira] [Commented] (AIRFLOW-2864) Incorrect docstrings for SubDagOperator

[ https://issues.apache.org/jira/browse/AIRFLOW-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571728#comment-16571728 ] ASF subversion and git services commented on AIRFLOW-2864: -- Co

[jira] [Resolved] (AIRFLOW-2864) Incorrect docstrings for SubDagOperator

[ https://issues.apache.org/jira/browse/AIRFLOW-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-2864. - Resolution: Fixed Resolved by https://github.com/apache/incubator-airflow/pull/3712 > Incorrec

[jira] [Updated] (AIRFLOW-2857) Broken builds for Read the Docs

[ https://issues.apache.org/jira/browse/AIRFLOW-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik updated AIRFLOW-2857: Summary: Broken builds for Read the Docs (was: Fix verify_gpl_dependency for Read the Docs) > B

[GitHub] kaxil closed pull request #3703: [AIRFLOW-2857] Fix broken RTD env

kaxil closed pull request #3703: [AIRFLOW-2857] Fix broken RTD env URL: https://github.com/apache/incubator-airflow/pull/3703 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign p

[jira] [Commented] (AIRFLOW-2857) Broken builds for Read the Docs

[ https://issues.apache.org/jira/browse/AIRFLOW-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571738#comment-16571738 ] ASF subversion and git services commented on AIRFLOW-2857: -- Co

[jira] [Resolved] (AIRFLOW-2857) Broken builds for Read the Docs

[ https://issues.apache.org/jira/browse/AIRFLOW-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-2857. - Resolution: Fixed Fix Version/s: 2.0.0 Resolved by https://github.com/apache/incubator-a

[GitHub] kaxil commented on issue #3703: [AIRFLOW-2857] Fix broken RTD env

kaxil commented on issue #3703: [AIRFLOW-2857] Fix broken RTD env URL: https://github.com/apache/incubator-airflow/pull/3703#issuecomment-411073677 Thanks @tedmiston for the fix and @ashb for the quick review. This is an aut

[jira] [Commented] (AIRFLOW-2857) Broken builds for Read the Docs

[ https://issues.apache.org/jira/browse/AIRFLOW-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571737#comment-16571737 ] ASF GitHub Bot commented on AIRFLOW-2857: - kaxil closed pull request #3703: [AI

[GitHub] kaxil edited a comment on issue #3703: [AIRFLOW-2857] Fix broken RTD env

kaxil edited a comment on issue #3703: [AIRFLOW-2857] Fix broken RTD env URL: https://github.com/apache/incubator-airflow/pull/3703#issuecomment-411073677 Thanks @tedmiston for the fix and @ashb for the quick review. I have changed the title for the PR and Jira. -

[GitHub] codecov-io edited a comment on issue #3712: [AIRFLOW-2864] Fix docstrings for SubDagOperator

codecov-io edited a comment on issue #3712: [AIRFLOW-2864] Fix docstrings for SubDagOperator URL: https://github.com/apache/incubator-airflow/pull/3712#issuecomment-411079495 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3712?src=pr&el=h1) Report > Merging [#3712](h

[GitHub] tedmiston commented on issue #3703: [AIRFLOW-2857] Fix broken RTD env

tedmiston commented on issue #3703: [AIRFLOW-2857] Fix broken RTD env URL: https://github.com/apache/incubator-airflow/pull/3703#issuecomment-411079528 Thank you for the swift replies all! Excited to get this merged! This i

[GitHub] codecov-io commented on issue #3712: [AIRFLOW-2864] Fix docstrings for SubDagOperator

codecov-io commented on issue #3712: [AIRFLOW-2864] Fix docstrings for SubDagOperator URL: https://github.com/apache/incubator-airflow/pull/3712#issuecomment-411079495 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3712?src=pr&el=h1) Report > Merging [#3712](https://

[GitHub] bolkedebruin closed pull request #3710: [AIRFLOW-2860] Update tests for druid hook

bolkedebruin closed pull request #3710: [AIRFLOW-2860] Update tests for druid hook URL: https://github.com/apache/incubator-airflow/pull/3710 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As thi

[jira] [Commented] (AIRFLOW-2860) DruidHook: time variable is not updated correctly when checking for timeout

[ https://issues.apache.org/jira/browse/AIRFLOW-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571770#comment-16571770 ] ASF subversion and git services commented on AIRFLOW-2860: -- Co

[jira] [Commented] (AIRFLOW-2860) DruidHook: time variable is not updated correctly when checking for timeout

[ https://issues.apache.org/jira/browse/AIRFLOW-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571769#comment-16571769 ] ASF GitHub Bot commented on AIRFLOW-2860: - bolkedebruin closed pull request #37

[GitHub] brookskd commented on issue #3174: [AIRFLOW-2231] Fix relativedelta DAG schedule_interval

brookskd commented on issue #3174: [AIRFLOW-2231] Fix relativedelta DAG schedule_interval URL: https://github.com/apache/incubator-airflow/pull/3174#issuecomment-411082806 @kaxil It there anything else I can do for now to move this along? --

[GitHub] kaxil commented on issue #3174: [AIRFLOW-2231] Fix relativedelta DAG schedule_interval

kaxil commented on issue #3174: [AIRFLOW-2231] Fix relativedelta DAG schedule_interval URL: https://github.com/apache/incubator-airflow/pull/3174#issuecomment-411085048 Hi @brookskd , Sorry for the delay in getting this PR merged. I wanted the guys who initially reviewed the PR to have a

[GitHub] kaxil closed pull request #3174: [AIRFLOW-2231] Fix relativedelta DAG schedule_interval

kaxil closed pull request #3174: [AIRFLOW-2231] Fix relativedelta DAG schedule_interval URL: https://github.com/apache/incubator-airflow/pull/3174 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: A

[GitHub] kaxil edited a comment on issue #3174: [AIRFLOW-2231] Fix relativedelta DAG schedule_interval

kaxil edited a comment on issue #3174: [AIRFLOW-2231] Fix relativedelta DAG schedule_interval URL: https://github.com/apache/incubator-airflow/pull/3174#issuecomment-411085048 Hi @brookskd , Sorry for the delay in getting this PR merged. I wanted the guys who initially reviewed the PR to

[jira] [Commented] (AIRFLOW-2231) DAG with a relativedelta schedule_interval fails

[ https://issues.apache.org/jira/browse/AIRFLOW-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571782#comment-16571782 ] ASF subversion and git services commented on AIRFLOW-2231: -- Co

[jira] [Commented] (AIRFLOW-2231) DAG with a relativedelta schedule_interval fails

[ https://issues.apache.org/jira/browse/AIRFLOW-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571780#comment-16571780 ] ASF GitHub Bot commented on AIRFLOW-2231: - kaxil closed pull request #3174: [AI

[jira] [Commented] (AIRFLOW-2231) DAG with a relativedelta schedule_interval fails

[ https://issues.apache.org/jira/browse/AIRFLOW-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571784#comment-16571784 ] Kaxil Naik commented on AIRFLOW-2231: - Resolved by https://github.com/apache/incuba

[jira] [Commented] (AIRFLOW-1617) XSS Vulnerability in Variable endpoint

[ https://issues.apache.org/jira/browse/AIRFLOW-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571783#comment-16571783 ] Ax Sharma commented on AIRFLOW-1617: Could someone verify if CVE-2017-12614 covers

[jira] [Commented] (AIRFLOW-1617) XSS Vulnerability in Variable endpoint

[ https://issues.apache.org/jira/browse/AIRFLOW-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571785#comment-16571785 ] Ax Sharma commented on AIRFLOW-1617: ^^ [~criccomini] , [~jira-bot] > XSS Vulnerab

[jira] [Commented] (AIRFLOW-1617) XSS Vulnerability in Variable endpoint

[ https://issues.apache.org/jira/browse/AIRFLOW-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571789#comment-16571789 ] Bolke de Bruin commented on AIRFLOW-1617: - Yes it does. > XSS Vulnerability in

[jira] [Commented] (AIRFLOW-2857) Broken builds for Read the Docs

[ https://issues.apache.org/jira/browse/AIRFLOW-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571791#comment-16571791 ] ASF subversion and git services commented on AIRFLOW-2857: -- Co

[jira] [Commented] (AIRFLOW-2857) Broken builds for Read the Docs

[ https://issues.apache.org/jira/browse/AIRFLOW-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571792#comment-16571792 ] ASF subversion and git services commented on AIRFLOW-2857: -- Co

[GitHub] dmnpignaud opened a new pull request #3713: [AIRFLOW-2428] Add AutoScalingRole key to emr_hook

dmnpignaud opened a new pull request #3713: [AIRFLOW-2428] Add AutoScalingRole key to emr_hook URL: https://github.com/apache/incubator-airflow/pull/3713 ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-2428) ### Descri

[jira] [Commented] (AIRFLOW-2428) Add AutoScalingRole key to emr_hook

[ https://issues.apache.org/jira/browse/AIRFLOW-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571799#comment-16571799 ] ASF GitHub Bot commented on AIRFLOW-2428: - dmnpignaud opened a new pull request

[GitHub] ashb commented on a change in pull request #3713: [AIRFLOW-2428] Add AutoScalingRole key to emr_hook

ashb commented on a change in pull request #3713: [AIRFLOW-2428] Add AutoScalingRole key to emr_hook URL: https://github.com/apache/incubator-airflow/pull/3713#discussion_r208267811 ## File path: airflow/contrib/hooks/emr_hook.py ## @@ -63,6 +63,8 @@ def create_job_flow(se

[GitHub] feng-tao commented on a change in pull request #3698: [AIRFLOW-2855] Check Cron Expression Validity in DagBag.process_file()

feng-tao commented on a change in pull request #3698: [AIRFLOW-2855] Check Cron Expression Validity in DagBag.process_file() URL: https://github.com/apache/incubator-airflow/pull/3698#discussion_r208296250 ## File path: tests/models.py ## @@ -56,7 +56,7 @@ from airflow.ut

[GitHub] awelsh93 commented on issue #3710: [AIRFLOW-2860] Update tests for druid hook

awelsh93 commented on issue #3710: [AIRFLOW-2860] Update tests for druid hook URL: https://github.com/apache/incubator-airflow/pull/3710#issuecomment-47114 Thanks for merging this - can the change in #3707 get another review please? It was merged but then reverted due to tests failing

[GitHub] Noremac201 commented on issue #3711: [AIRFLOW-2863] Fix GKEClusterHook catching wrong exception

Noremac201 commented on issue #3711: [AIRFLOW-2863] Fix GKEClusterHook catching wrong exception URL: https://github.com/apache/incubator-airflow/pull/3711#issuecomment-49591 Done! Thanks This is an automated message f

[GitHub] feng-tao commented on issue #3711: [AIRFLOW-2863] Fix GKEClusterHook catching wrong exception

feng-tao commented on issue #3711: [AIRFLOW-2863] Fix GKEClusterHook catching wrong exception URL: https://github.com/apache/incubator-airflow/pull/3711#issuecomment-411127557 LGTM This is an automated message from the Apach

[GitHub] feng-tao closed pull request #3711: [AIRFLOW-2863] Fix GKEClusterHook catching wrong exception

feng-tao closed pull request #3711: [AIRFLOW-2863] Fix GKEClusterHook catching wrong exception URL: https://github.com/apache/incubator-airflow/pull/3711 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provena

[jira] [Commented] (AIRFLOW-2863) GKEClusterHook catches wrong exception

[ https://issues.apache.org/jira/browse/AIRFLOW-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571966#comment-16571966 ] ASF GitHub Bot commented on AIRFLOW-2863: - feng-tao closed pull request #3711:

[jira] [Commented] (AIRFLOW-2863) GKEClusterHook catches wrong exception

[ https://issues.apache.org/jira/browse/AIRFLOW-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571967#comment-16571967 ] ASF subversion and git services commented on AIRFLOW-2863: -- Co

[GitHub] tedmiston commented on issue #3656: [WIP][AIRFLOW-2803] Fix all ESLint issues

tedmiston commented on issue #3656: [WIP][AIRFLOW-2803] Fix all ESLint issues URL: https://github.com/apache/incubator-airflow/pull/3656#issuecomment-411134901 Hey all - thanks for bumping. Sorry for any delay here — my work sprint has been quite busy this past week. This PR is act

[GitHub] tedmiston commented on issue #3587: [WIP][AIRFLOW-2732] Remove hooks and operators from core

tedmiston commented on issue #3587: [WIP][AIRFLOW-2732] Remove hooks and operators from core URL: https://github.com/apache/incubator-airflow/pull/3587#issuecomment-411135195 Closing this PR for now as the next step for this issue is drafting an AIP. --

[GitHub] verdan commented on issue #3656: [WIP][AIRFLOW-2803] Fix all ESLint issues

verdan commented on issue #3656: [WIP][AIRFLOW-2803] Fix all ESLint issues URL: https://github.com/apache/incubator-airflow/pull/3656#issuecomment-411138672 @tedmiston sounds good to me!! 👍 This is an automated message from

[GitHub] tedmiston commented on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports

tedmiston commented on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports URL: https://github.com/apache/incubator-airflow/pull/3696#issuecomment-411139302 Thank you both for the review and initial comments! It sounds like the next step here is probably to get a quick thought

[jira] [Commented] (AIRFLOW-852) Docs: Cancel a triggered dag

[ https://issues.apache.org/jira/browse/AIRFLOW-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572113#comment-16572113 ] Quijano Flores commented on AIRFLOW-852: I get an error when I do this [~salad_k

[GitHub] jakahn commented on issue #3677: [AIRFLOW-2826] Add GoogleCloudKMSHook

jakahn commented on issue #3677: [AIRFLOW-2826] Add GoogleCloudKMSHook URL: https://github.com/apache/incubator-airflow/pull/3677#issuecomment-411156427 @Fokko PTAL when you can This is an automated message from the Apache Gi

[GitHub] bolkedebruin closed pull request #3700: [AIRFLOW-2140] Don't require kubernetes for the SparkSubmit hook

bolkedebruin closed pull request #3700: [AIRFLOW-2140] Don't require kubernetes for the SparkSubmit hook URL: https://github.com/apache/incubator-airflow/pull/3700 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[jira] [Commented] (AIRFLOW-2140) Add Kubernetes Scheduler to Spark Submit Operator

[ https://issues.apache.org/jira/browse/AIRFLOW-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572144#comment-16572144 ] ASF subversion and git services commented on AIRFLOW-2140: -- Co

[jira] [Commented] (AIRFLOW-2140) Add Kubernetes Scheduler to Spark Submit Operator

[ https://issues.apache.org/jira/browse/AIRFLOW-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572143#comment-16572143 ] ASF GitHub Bot commented on AIRFLOW-2140: - bolkedebruin closed pull request #37

[jira] [Created] (AIRFLOW-2865) Race condition between on_success_callback and LocalTaskJob's cleanup

Marcin Mejran created AIRFLOW-2865: -- Summary: Race condition between on_success_callback and LocalTaskJob's cleanup Key: AIRFLOW-2865 URL: https://issues.apache.org/jira/browse/AIRFLOW-2865 Project:

[jira] [Created] (AIRFLOW-2866) Missing CSRF Token Error on Web UI Create/Update Operations

Jasper Kahn created AIRFLOW-2866: Summary: Missing CSRF Token Error on Web UI Create/Update Operations Key: AIRFLOW-2866 URL: https://issues.apache.org/jira/browse/AIRFLOW-2866 Project: Apache Airflow

[GitHub] mistercrunch commented on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports

mistercrunch commented on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports URL: https://github.com/apache/incubator-airflow/pull/3696#issuecomment-411163359 I'm unclear as to why contributors went around their way to alias imports, but it appears to be 100% unnecessary. `git

[GitHub] mistercrunch closed pull request #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports

mistercrunch closed pull request #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports URL: https://github.com/apache/incubator-airflow/pull/3696 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[jira] [Commented] (AIRFLOW-2851) Canonicalize "as _..." etc imports

[ https://issues.apache.org/jira/browse/AIRFLOW-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572156#comment-16572156 ] ASF subversion and git services commented on AIRFLOW-2851: -- Co

[jira] [Commented] (AIRFLOW-2851) Canonicalize "as _..." etc imports

[ https://issues.apache.org/jira/browse/AIRFLOW-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572155#comment-16572155 ] ASF GitHub Bot commented on AIRFLOW-2851: - mistercrunch closed pull request #36

[GitHub] kaxil commented on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports

kaxil commented on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports URL: https://github.com/apache/incubator-airflow/pull/3696#issuecomment-411169973 @mistercrunch 🤔 I might have definitely done it on `gcs_hook`. Sorry about that. Not sure if I ever use `_os`. -

[GitHub] kaxil edited a comment on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports

kaxil edited a comment on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports URL: https://github.com/apache/incubator-airflow/pull/3696#issuecomment-411169973 @mistercrunch 🤔 I might have definitely done it on `gcs_hook`. Sorry about that. Not sure if I ever used `_os`. -

[jira] [Created] (AIRFLOW-2867) Airflow Python Code not compatible to coding guidelines and standards

Kaxil Naik created AIRFLOW-2867: --- Summary: Airflow Python Code not compatible to coding guidelines and standards Key: AIRFLOW-2867 URL: https://issues.apache.org/jira/browse/AIRFLOW-2867 Project: Apach

[GitHub] kaxil opened a new pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

kaxil opened a new pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira

[jira] [Commented] (AIRFLOW-2867) Airflow Python Code not compatible to coding guidelines and standards

[ https://issues.apache.org/jira/browse/AIRFLOW-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572266#comment-16572266 ] ASF GitHub Bot commented on AIRFLOW-2867: - kaxil opened a new pull request #371

[GitHub] ashb commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

ashb commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208371759 ## File path: airflow/contrib/operators/oracle_to_oracle_transfer.py ##

[GitHub] ashb commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

ashb commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208372051 ## File path: airflow/operators/s3_to_hive_operator.py ## @@ -261,9 +261

[GitHub] ashb commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

ashb commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208371591 ## File path: airflow/contrib/operators/dataflow_operator.py ## @@ -331,

[GitHub] ashb commented on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime

ashb commented on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime URL: https://github.com/apache/incubator-airflow/pull/3708#issuecomment-411189623 Can I help? This is an automated message from the Apache Git Service. T

[GitHub] ashb commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

ashb commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208371167 ## File path: airflow/configuration.py ## @@ -186,7 +186,8 @@ def _valid

[GitHub] kaxil commented on issue #3714: [WIP][AIRFLOW-2867] Refactor code to conform Python standards & guidelines

kaxil commented on issue #3714: [WIP][AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#issuecomment-411190182 Hi @ashb, Sorry, I need to sort couple of things here. I have added a WIP flag. Will ping you as soo

[GitHub] ashb opened a new pull request #3715: [AIRFLOW-XXX] Updating instructions about logging changes in 1.10

ashb opened a new pull request #3715: [AIRFLOW-XXX] Updating instructions about logging changes in 1.10 URL: https://github.com/apache/incubator-airflow/pull/3715 We had a few other logging changes that weren't mentioned in here that meant previous logs were not viewable anymore.

[GitHub] bolkedebruin closed pull request #3715: [AIRFLOW-XXX] Updating instructions about logging changes in 1.10

bolkedebruin closed pull request #3715: [AIRFLOW-XXX] Updating instructions about logging changes in 1.10 URL: https://github.com/apache/incubator-airflow/pull/3715 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] kaxil commented on issue #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

kaxil commented on issue #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#issuecomment-411194032 @ashb This is now ready for review. :) T

[GitHub] ashb commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

ashb commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208377732 ## File path: tests/core.py ## @@ -2423,7 +2423,7 @@ def test_init_proxy

[GitHub] bolkedebruin commented on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime

bolkedebruin commented on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime URL: https://github.com/apache/incubator-airflow/pull/3708#issuecomment-411195033 @ashb I think I finally nailed it. The issue was in my understanding how sqlalchemy was dealing with timezone information inside

[GitHub] ashb commented on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime

ashb commented on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime URL: https://github.com/apache/incubator-airflow/pull/3708#issuecomment-411195448 AIP-3: Drop support for Mysql :D This is an automated message f

[GitHub] bolkedebruin edited a comment on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime

bolkedebruin edited a comment on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime URL: https://github.com/apache/incubator-airflow/pull/3708#issuecomment-411195033 @ashb I think I finally nailed it. The issue was in my understanding how sqlalchemy was dealing with timezone informatio

[GitHub] bolkedebruin commented on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime

bolkedebruin commented on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime URL: https://github.com/apache/incubator-airflow/pull/3708#issuecomment-411195878 I think our google friends use mysql 5.7 for their cloud composer. Probably they won't be happy with us then ;-) --

[jira] [Created] (AIRFLOW-2868) Mesos Executor use executor_config to specify CPU, Memory and Docker image on the task level

Amir Shahatit created AIRFLOW-2868: -- Summary: Mesos Executor use executor_config to specify CPU, Memory and Docker image on the task level Key: AIRFLOW-2868 URL: https://issues.apache.org/jira/browse/AIRFLOW-2868

[jira] [Updated] (AIRFLOW-2868) Mesos Executor should use executor_config to specify CPU, Memory and Docker image on the task level

[ https://issues.apache.org/jira/browse/AIRFLOW-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amir Shahatit updated AIRFLOW-2868: --- Summary: Mesos Executor should use executor_config to specify CPU, Memory and Docker image

[jira] [Resolved] (AIRFLOW-2787) Airflow scheduler dies on DAGs with NULL DagRun run_id

[ https://issues.apache.org/jira/browse/AIRFLOW-2787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] George Leslie-Waksman resolved AIRFLOW-2787. Resolution: Fixed > Airflow scheduler dies on DAGs with NULL DagRun run_i

[GitHub] gwax commented on issue #2482: AIRFLOW-1460 clear "REMOVED" tis on DagRun update

gwax commented on issue #2482: AIRFLOW-1460 clear "REMOVED" tis on DagRun update URL: https://github.com/apache/incubator-airflow/pull/2482#issuecomment-411221356 This Issue has been resolved by https://github.com/apache/incubator-airflow/pull/3137 I will close this PR as a duplicat

[GitHub] gwax closed pull request #2482: AIRFLOW-1460 clear "REMOVED" tis on DagRun update

gwax closed pull request #2482: AIRFLOW-1460 clear "REMOVED" tis on DagRun update URL: https://github.com/apache/incubator-airflow/pull/2482 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[jira] [Commented] (AIRFLOW-1460) Tasks get stuck in the "removed" state

[ https://issues.apache.org/jira/browse/AIRFLOW-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572430#comment-16572430 ] ASF GitHub Bot commented on AIRFLOW-1460: - gwax closed pull request #2482: AIRF

[GitHub] feng-tao commented on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime

feng-tao commented on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime URL: https://github.com/apache/incubator-airflow/pull/3708#issuecomment-411222194 flake8 fails. This is an automated message from the Apache Git Serv

[GitHub] wdhorton opened a new pull request #3716: [AIRFLOW-XXX] Remove smart quote from default config

wdhorton opened a new pull request #3716: [AIRFLOW-XXX] Remove smart quote from default config URL: https://github.com/apache/incubator-airflow/pull/3716 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow Jira](https://issues.a

[GitHub] r39132 commented on issue #3716: [AIRFLOW-XXX] Remove smart quote from default config

r39132 commented on issue #3716: [AIRFLOW-XXX] Remove smart quote from default config URL: https://github.com/apache/incubator-airflow/pull/3716#issuecomment-411222958 +1 This is an automated message from the Apache Git Serv

  1   2   >