[GitHub] [fineract] Grandolf49 closed pull request #1229: FINERACT-838 Swagger Codegen Travis CI Setup

2020-08-01 Thread GitBox
Grandolf49 closed pull request #1229: URL: https://github.com/apache/fineract/pull/1229 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] Grandolf49 opened a new pull request #1229: FINERACT-838 Swagger Codegen Travis CI Setup

2020-08-01 Thread GitBox
Grandolf49 opened a new pull request #1229: URL: https://github.com/apache/fineract/pull/1229 ## Description Added build and test for generated Swagger Code in travis ci configuration file ## Checklist Please make sure these boxes are checked before submitting your pull request

[GitHub] [fineract] Grandolf49 commented on pull request #1228: FINERACT-838 Updated swagger-codegen-cli version

2020-08-01 Thread GitBox
Grandolf49 commented on pull request #1228: URL: https://github.com/apache/fineract/pull/1228#issuecomment-667628457 @vorburger Upon further local testing, I noticed that the build for generated code was failing due to incomplete base URL in [fineract.yml](https://github.com/apache/finerac

[fineract] branch develop updated: Use java8 instead of joda as dateLibrary in Swagger Client (FINERACT-838)

2020-08-01 Thread ptuomola
This is an automated email from the ASF dual-hosted git repository. ptuomola pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new c5c62de Use java8 instead of joda as date

[GitHub] [fineract] ptuomola merged pull request #1226: Use java8 instead of joda as dateLibrary in Swagger Client (FINERACT-838)

2020-08-01 Thread GitBox
ptuomola merged pull request #1226: URL: https://github.com/apache/fineract/pull/1226 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [fineract] ptuomola commented on pull request #1226: Use java8 instead of joda as dateLibrary in Swagger Client (FINERACT-838)

2020-08-01 Thread GitBox
ptuomola commented on pull request #1226: URL: https://github.com/apache/fineract/pull/1226#issuecomment-667620109 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [fineract] ptuomola commented on a change in pull request #1207: FINERACT-1095 Added status parameter in Clients API

2020-08-01 Thread GitBox
ptuomola commented on a change in pull request #1207: URL: https://github.com/apache/fineract/pull/1207#discussion_r464024948 ## File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/ClientTest.java ## @@ -143,4 +143,36 @@ public void testC

[GitHub] [fineract] ptuomola commented on pull request #1179: FINERACT-826 Migrate to java.time from Joda API

2020-08-01 Thread GitBox
ptuomola commented on pull request #1179: URL: https://github.com/apache/fineract/pull/1179#issuecomment-667618176 @vorburger I agree we should understand why tests are failing before merging this - if they are indications of some remaining issues that haven't been found, then the impact o

[GitHub] [fineract] Grandolf49 commented on a change in pull request #1227: Update dependency io.swagger.codegen.v3:swagger-codegen-cli to v3.0.21

2020-08-01 Thread GitBox
Grandolf49 commented on a change in pull request #1227: URL: https://github.com/apache/fineract/pull/1227#discussion_r463997071 ## File path: fineract-provider/build.gradle ## @@ -853,7 +853,7 @@ generateGitProperties.outputs.upToDateWhen { false } //This is for swagger code

[GitHub] [fineract] vorburger commented on a change in pull request #1227: Update dependency io.swagger.codegen.v3:swagger-codegen-cli to v3.0.21

2020-08-01 Thread GitBox
vorburger commented on a change in pull request #1227: URL: https://github.com/apache/fineract/pull/1227#discussion_r463996445 ## File path: fineract-provider/build.gradle ## @@ -853,7 +853,7 @@ generateGitProperties.outputs.upToDateWhen { false } //This is for swagger code

[GitHub] [fineract] Grandolf49 opened a new pull request #1228: FINERACT-838 Updated swagger-codegen-cli version

2020-08-01 Thread GitBox
Grandolf49 opened a new pull request #1228: URL: https://github.com/apache/fineract/pull/1228 ## Description Updated the `swagger-codegen-cli` version to `3.0.18` since all greater versions throw error. https://github.com/swagger-api/swagger-codegen/issues/10157 ## Checklist P

[GitHub] [fineract] Grandolf49 commented on a change in pull request #1227: Update dependency io.swagger.codegen.v3:swagger-codegen-cli to v3.0.21

2020-08-01 Thread GitBox
Grandolf49 commented on a change in pull request #1227: URL: https://github.com/apache/fineract/pull/1227#discussion_r463980202 ## File path: fineract-provider/build.gradle ## @@ -853,7 +853,7 @@ generateGitProperties.outputs.upToDateWhen { false } //This is for swagger code

[GitHub] [fineract] renovate-bot opened a new pull request #1227: Update dependency io.swagger.codegen.v3:swagger-codegen-cli to v3.0.21

2020-08-01 Thread GitBox
renovate-bot opened a new pull request #1227: URL: https://github.com/apache/fineract/pull/1227 This PR contains the following updates: | Package | Update | Change | |---|---|---| | io.swagger.codegen.v3:swagger-codegen-cli | patch | `3.0.20` -> `3.0.21` | --- ###

[GitHub] [fineract] fynmanoj commented on pull request #1209: AL-2-reschedule-loan-first-pay-day-holiday-fix

2020-08-01 Thread GitBox
fynmanoj commented on pull request #1209: URL: https://github.com/apache/fineract/pull/1209#issuecomment-667540215 We are planning to move all the tickets to fineract tracker, and I will correct the PR issues parallelly On Sat, 1 Aug, 2020, 19:44 Michael Vorburger ⛑️, wrote:

[GitHub] [fineract] vorburger commented on pull request #1220: AL-14-approppritae-interest-larger-than-emi

2020-08-01 Thread GitBox
vorburger commented on pull request #1220: URL: https://github.com/apache/fineract/pull/1220#issuecomment-667538352 @fynmanoj this PR needs to have a JIRA issue on the ASF JIRA, instead of referencing an issue on https://mifosforge.jira.com. ---

[GitHub] [fineract] vorburger commented on pull request #1209: AL-2-reschedule-loan-first-pay-day-holiday-fix

2020-08-01 Thread GitBox
vorburger commented on pull request #1209: URL: https://github.com/apache/fineract/pull/1209#issuecomment-667538338 @fynmanoj this PR needs to have a JIRA issue on the ASF JIRA, instead of referencing an issue on https://mifosforge.jira.com. ---

[GitHub] [fineract] vorburger commented on pull request #1211: AL-9-Custom-installment-in-reshedule

2020-08-01 Thread GitBox
vorburger commented on pull request #1211: URL: https://github.com/apache/fineract/pull/1211#issuecomment-667538268 @fynmanoj this PR needs to have a JIRA issue on the ASF JIRA, instead of referencing an issue from an issue tracker that is now a downstream redistribution of Fineract. ---

[GitHub] [fineract] vorburger commented on pull request #1210: AL-12-month-end-dates-reschedule-issue-fix

2020-08-01 Thread GitBox
vorburger commented on pull request #1210: URL: https://github.com/apache/fineract/pull/1210#issuecomment-667538165 @avikganguly01 knowing that @fynmanoj works with you, and assuming that you are still an active committer to this project (are you?), I was wondering if you would like to eng

[GitHub] [fineract] vorburger commented on pull request #1211: AL-9-Custom-installment-in-reshedule

2020-08-01 Thread GitBox
vorburger commented on pull request #1211: URL: https://github.com/apache/fineract/pull/1211#issuecomment-667538132 @avikganguly01 knowing that @fynmanoj works with you, and assuming that you are still an active committer to this project (are you?), I was wondering if you would like to eng

[GitHub] [fineract] vorburger commented on pull request #1032: FINERACT-1034-encryption-infra

2020-08-01 Thread GitBox
vorburger commented on pull request #1032: URL: https://github.com/apache/fineract/pull/1032#issuecomment-667538203 @avikganguly01 knowing that @fynmanoj works with you, and assuming that you are still an active committer to this project (are you?), I was wondering if you would like to eng

[GitHub] [fineract] vorburger commented on pull request #1209: AL-2-reschedule-loan-first-pay-day-holiday-fix

2020-08-01 Thread GitBox
vorburger commented on pull request #1209: URL: https://github.com/apache/fineract/pull/1209#issuecomment-667538085 @avikganguly01 knowing that @fynmanoj works with you, and assuming that you are still an active committer to this project (are you?), I was wondering if you would like to eng

[GitHub] [fineract] vorburger commented on pull request #1220: AL-14-approppritae-interest-larger-than-emi

2020-08-01 Thread GitBox
vorburger commented on pull request #1220: URL: https://github.com/apache/fineract/pull/1220#issuecomment-667538021 @avikganguly01 knowing that @fynmanoj works with you, and assuming that you are still an active committer to this project (are you?), I was wondering if you would like to eng

[GitHub] [fineract] Grandolf49 commented on pull request #1225: Update dependency gradle.plugin.org.hidetake:gradle-swagger-generator-plugin to v2.18.2

2020-08-01 Thread GitBox
Grandolf49 commented on pull request #1225: URL: https://github.com/apache/fineract/pull/1225#issuecomment-667537689 > LOL this didn't taken long after #1206 ... 😄 > > @Grandolf49 FYI, we (someone) will merge this when build passed. > > BTW let's discuss further in [FINERACT-8

[GitHub] [fineract] vorburger commented on pull request #1179: FINERACT-826 Migrate to java.time from Joda API

2020-08-01 Thread GitBox
vorburger commented on pull request #1179: URL: https://github.com/apache/fineract/pull/1179#issuecomment-667536156 > @vorburger @awasum @ptuomola Should I create a jira issue for the remaining test since it is proving quite difficult to reproduce. Hm. I'm quite torn how to proceed h

[GitHub] [fineract] vorburger opened a new pull request #1226: Use java8 instead of joda as dateLibrary in Swagger Client (FINERACT-838)

2020-08-01 Thread GitBox
vorburger opened a new pull request #1226: URL: https://github.com/apache/fineract/pull/1226 see FINERACT-838, this is a #1206 follow-up In light of @percyashu #1179 for FINERACT-826, IMHO we should promote Java 8 native JSR-310 and not Joda Time even for clients. @Grandolf49

[GitHub] [fineract] renovate-bot opened a new pull request #1225: Update dependency gradle.plugin.org.hidetake:gradle-swagger-generator-plugin to v2.18.2

2020-08-01 Thread GitBox
renovate-bot opened a new pull request #1225: URL: https://github.com/apache/fineract/pull/1225 This PR contains the following updates: | Package | Update | Change | |---|---|---| | gradle.plugin.org.hidetake:gradle-swagger-generator-plugin | patch | `2.18.1` -> `2.18.2` |

[fineract] branch vorburger-swagger-client-java8-instead-joda created (now 438a3bd)

2020-08-01 Thread vorburger
This is an automated email from the ASF dual-hosted git repository. vorburger pushed a change to branch vorburger-swagger-client-java8-instead-joda in repository https://gitbox.apache.org/repos/asf/fineract.git. at 438a3bd Use java8 instead of joda as dateLibrary in Swagger Client (FINER

[fineract] 01/01: Use java8 instead of joda as dateLibrary in Swagger Client (FINERACT-838)

2020-08-01 Thread vorburger
This is an automated email from the ASF dual-hosted git repository. vorburger pushed a commit to branch vorburger-swagger-client-java8-instead-joda in repository https://gitbox.apache.org/repos/asf/fineract.git commit 438a3bd90d6a6563058bc225b3b1f0662b427f4e Author: Michael Vorburger ⛑️ AuthorDa

[GitHub] [fineract] vorburger opened a new pull request #1224: minor Swagger clean-up in README

2020-08-01 Thread GitBox
vorburger opened a new pull request #1224: URL: https://github.com/apache/fineract/pull/1224 @Grandolf49 @thesmallstar @ptuomola OK for you? Merge. This is an automated message from the Apache Git Service. To respond to the m

[fineract] branch vorburger-swagger-README created (now 100d186)

2020-08-01 Thread vorburger
This is an automated email from the ASF dual-hosted git repository. vorburger pushed a change to branch vorburger-swagger-README in repository https://gitbox.apache.org/repos/asf/fineract.git. at 100d186 minor Swagger clean-up in README This branch includes the following new commits:

[fineract] 01/01: minor Swagger clean-up in README

2020-08-01 Thread vorburger
This is an automated email from the ASF dual-hosted git repository. vorburger pushed a commit to branch vorburger-swagger-README in repository https://gitbox.apache.org/repos/asf/fineract.git commit 100d1861017813882f8f05df89b77867bade48a2 Author: Michael Vorburger ⛑️ AuthorDate: Sat Aug 1 15:21

[GitHub] [fineract] vorburger merged pull request #1223: add ignore comment for FixedDepositTest

2020-08-01 Thread GitBox
vorburger merged pull request #1223: URL: https://github.com/apache/fineract/pull/1223 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[fineract] branch develop updated (bcd42b9 -> c91dc2a)

2020-08-01 Thread vorburger
This is an automated email from the ASF dual-hosted git repository. vorburger pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git. from bcd42b9 FINERACT-971 Added and enforced AvoidNoArgumentSuperConstructorCall Checkstyle add c91dc2a add

[GitHub] [fineract] vorburger merged pull request #1194: FINERACT-971 Added and enforced AvoidNoArgumentSuperConstructorCall Checkstyle

2020-08-01 Thread GitBox
vorburger merged pull request #1194: URL: https://github.com/apache/fineract/pull/1194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[fineract] branch develop updated: FINERACT-838 Added Swagger Codegen Support (#1206)

2020-08-01 Thread vorburger
This is an automated email from the ASF dual-hosted git repository. vorburger pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new 1f46261 FINERACT-838 Added Swagger Codeg

[fineract] branch develop updated: FINERACT-971 Added and enforced AvoidNoArgumentSuperConstructorCall Checkstyle

2020-08-01 Thread vorburger
This is an automated email from the ASF dual-hosted git repository. vorburger pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new bcd42b9 FINERACT-971 Added and enforced

[GitHub] [fineract] vorburger merged pull request #1206: FINERACT-838 Added Swagger Codegen Support

2020-08-01 Thread GitBox
vorburger merged pull request #1206: URL: https://github.com/apache/fineract/pull/1206 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] vorburger commented on pull request #1206: FINERACT-838 Added Swagger Codegen Support

2020-08-01 Thread GitBox
vorburger commented on pull request #1206: URL: https://github.com/apache/fineract/pull/1206#issuecomment-667529264 > Hi @vorburger Any more changes to be done here? Let me merge this as-is, as a first step... I'll raise a follow-up PR for your review to propose changing from Joda to

[GitHub] [fineract] vorburger commented on a change in pull request #1218: FINERACT-1098 - Catch JpaSystemException in jpa transactions

2020-08-01 Thread GitBox
vorburger commented on a change in pull request #1218: URL: https://github.com/apache/fineract/pull/1218#discussion_r463953157 ## File path: fineract-provider/src/main/java/org/apache/fineract/accounting/closure/service/GLClosureWritePlatformServiceJpaRepositoryImpl.java ## @@

[GitHub] [fineract] Grandolf49 commented on pull request #1206: FINERACT-838 Added Swagger Codegen Support

2020-08-01 Thread GitBox
Grandolf49 commented on pull request #1206: URL: https://github.com/apache/fineract/pull/1206#issuecomment-667500531 Hi @vorburger Any more changes to be done here? This is an automated message from the Apache Git Service. T