[GitHub] dabraude opened a new pull request #9860: Nnpack

dabraude opened a new pull request #9860: Nnpack URL: https://github.com/apache/incubator-mxnet/pull/9860 ## Description ## This is the first part of #9719 ## Checklist ## ### Essentials ### - [X] Passed code style checking (`make lint`) - [X] Changes are complete (i.e

[GitHub] lupesko commented on issue #9858: softsign activation function

lupesko commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367608109 @szha This will help MXNet users who can't migrate from 0.11 to 1.0 just yet, but need the operator. --

[GitHub] dabraude commented on issue #9573: Fix bug with symbol loading

dabraude commented on issue #9573: Fix bug with symbol loading URL: https://github.com/apache/incubator-mxnet/pull/9573#issuecomment-367613732 failed tests relate to #9856 This is an automated message from the Apache Git Servi

[GitHub] dabraude commented on issue #9573: Fix bug with symbol loading

dabraude commented on issue #9573: Fix bug with symbol loading URL: https://github.com/apache/incubator-mxnet/pull/9573#issuecomment-367613732 failed tests relate to #9856 This is an automated message from the Apache Git Servi

[GitHub] juliusshufan commented on issue #9805: Enable the reporting of cross-entropy or nll loss value when training CNN network using the models defined by example/image-classification

juliusshufan commented on issue #9805: Enable the reporting of cross-entropy or nll loss value when training CNN network using the models defined by example/image-classification URL: https://github.com/apache/incubator-mxnet/pull/9805#issuecomment-366863185 ### I rerun the failed GPU case

[GitHub] juliusshufan commented on issue #9805: Enable the reporting of cross-entropy or nll loss value when training CNN network using the models defined by example/image-classification

juliusshufan commented on issue #9805: Enable the reporting of cross-entropy or nll loss value when training CNN network using the models defined by example/image-classification URL: https://github.com/apache/incubator-mxnet/pull/9805#issuecomment-367618399 @szha Hi, I noticed the preci ha

[GitHub] juliusshufan commented on issue #9805: Enable the reporting of cross-entropy or nll loss value when training CNN network using the models defined by example/image-classification

juliusshufan commented on issue #9805: Enable the reporting of cross-entropy or nll loss value when training CNN network using the models defined by example/image-classification URL: https://github.com/apache/incubator-mxnet/pull/9805#issuecomment-366863185 # I rerun the failed GPU cas

[GitHub] dabraude commented on issue #9860: CMake NNPack support

dabraude commented on issue #9860: CMake NNPack support URL: https://github.com/apache/incubator-mxnet/pull/9860#issuecomment-367623208 The test that failed is flaky #9856 This is an automated message from the Apache Git Servi

[GitHub] yajiedesign commented on a change in pull request #9798: fix cmake

yajiedesign commented on a change in pull request #9798: fix cmake URL: https://github.com/apache/incubator-mxnet/pull/9798#discussion_r169942811 ## File path: CMakeLists.txt ## @@ -46,6 +46,11 @@ if(USE_CUDA AND NOT USE_OLDCMAKECUDA) (${CMAKE_VERSION} VERSION_GREA

[GitHub] marcoabreu commented on issue #9860: [WIP] CMake NNPack support

marcoabreu commented on issue #9860: [WIP] CMake NNPack support URL: https://github.com/apache/incubator-mxnet/pull/9860#issuecomment-367669600 That's a LOT of third party dependencies and they're coming from a private repository. ---

[GitHub] yajiedesign commented on issue #9798: fix cmake

yajiedesign commented on issue #9798: fix cmake URL: https://github.com/apache/incubator-mxnet/pull/9798#issuecomment-367669459 sorry for later. I originally set up CUDA_TOOLSET for the purpose of selecting the CUDA version in CI. I will try to add a default auto option.

[GitHub] marcoabreu commented on issue #9858: softsign activation function

marcoabreu commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367670741 We are not running any CI for v0.11 and as far as I remember, was the plan to only support the last two versions (in this case v1.0 and v1.1) wit

[GitHub] marcoabreu commented on issue #9858: softsign activation function

marcoabreu commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367671272 In my opinion, the right approach here would be that this change is getting done on the master and people who are interested in this operator che

[GitHub] marcoabreu commented on issue #9798: fix cmake

marcoabreu commented on issue #9798: fix cmake URL: https://github.com/apache/incubator-mxnet/pull/9798#issuecomment-367673339 I'm not on my computer right now. could you check whether cuda toolset is actually applied during compilation in CI?

[GitHub] yajiedesign commented on issue #9798: fix cmake

yajiedesign commented on issue #9798: fix cmake URL: https://github.com/apache/incubator-mxnet/pull/9798#issuecomment-367683536 @marcoabreu yes.the windows night build use it. This is an automated message from the Apache Git S

[GitHub] larroy commented on issue #9849: License tool

larroy commented on issue #9849: License tool URL: https://github.com/apache/incubator-mxnet/pull/9849#issuecomment-367686078 @marcoabreu please merge? This is an automated message from the Apache Git Service. To respond to t

[GitHub] ZiyueHuang commented on issue #9848: add infer_type for regression ops, fix issues#9847

ZiyueHuang commented on issue #9848: add infer_type for regression ops, fix issues#9847 URL: https://github.com/apache/incubator-mxnet/pull/9848#issuecomment-367688993 Unittest is written in symbolic mode while the issue is in imperative mode. In symbolic mode, infer_type pass has a defaul

[GitHub] KellenSunderland opened a new pull request #9861: Add CuDNN (v6) support to Jetson builds

KellenSunderland opened a new pull request #9861: Add CuDNN (v6) support to Jetson builds URL: https://github.com/apache/incubator-mxnet/pull/9861 ## Description ## Add CuDNN (v6) support to Jetson builds. This should make the builds for Jetson devices 20-35% faster for many tasks.

[GitHub] ZiyueHuang commented on issue #9848: add infer_type for regression ops, fix issues#9847

ZiyueHuang commented on issue #9848: add infer_type for regression ops, fix issues#9847 URL: https://github.com/apache/incubator-mxnet/pull/9848#issuecomment-367690061 By the way, `L2NormalizationOp` and `InstanceNormOp` don't have an infer_type function. -

[GitHub] KellenSunderland commented on a change in pull request #9861: Add CuDNN (v6) support to Jetson builds

KellenSunderland commented on a change in pull request #9861: Add CuDNN (v6) support to Jetson builds URL: https://github.com/apache/incubator-mxnet/pull/9861#discussion_r169964125 ## File path: docker_multiarch/Dockerfile.build.jetson ## @@ -21,13 +21,7 @@ ADD https://ap

[GitHub] marcoabreu commented on a change in pull request #9861: Add CuDNN (v6) support to Jetson builds

marcoabreu commented on a change in pull request #9861: Add CuDNN (v6) support to Jetson builds URL: https://github.com/apache/incubator-mxnet/pull/9861#discussion_r169963987 ## File path: docker_multiarch/Dockerfile.build.jetson ## @@ -21,13 +21,7 @@ ADD https://api.gith

[GitHub] marcoabreu commented on issue #9857: Core dump DROPOUT_PERF.TimingGPU

marcoabreu commented on issue #9857: Core dump DROPOUT_PERF.TimingGPU URL: https://github.com/apache/incubator-mxnet/issues/9857#issuecomment-367692383 No, this would waste too many resources. Generally, multiple failures can be fixed by one change. If we wouldn't follow fail-fast, a lot o

[GitHub] marcoabreu commented on issue #9798: fix cmake

marcoabreu commented on issue #9798: fix cmake URL: https://github.com/apache/incubator-mxnet/pull/9798#issuecomment-367693035 Thanks you. I just checked and it's not part of the PR test chain. Could you please make sure that it's also being used in https://github.com/apache/incubator-mxne

[GitHub] marcoabreu closed pull request #9849: License tool

marcoabreu closed pull request #9849: License tool URL: https://github.com/apache/incubator-mxnet/pull/9849 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] KellenSunderland commented on issue #9861: Add CuDNN (v6) support to Jetson builds

KellenSunderland commented on issue #9861: Add CuDNN (v6) support to Jetson builds URL: https://github.com/apache/incubator-mxnet/pull/9861#issuecomment-367693725 Checking a few things offline. This is an automated message fr

[incubator-mxnet] branch master updated: Improve license_header.py, add license to individual files (#9849)

This is an automated email from the ASF dual-hosted git repository. marcoabreu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 6d2b6e3 Improve license_header.py,

[GitHub] KellenSunderland closed pull request #9861: Add CuDNN (v6) support to Jetson builds

KellenSunderland closed pull request #9861: Add CuDNN (v6) support to Jetson builds URL: https://github.com/apache/incubator-mxnet/pull/9861 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] marcoabreu commented on issue #9859: How to run model trained with mxnet 1.0 on android

marcoabreu commented on issue #9859: How to run model trained with mxnet 1.0 on android URL: https://github.com/apache/incubator-mxnet/issues/9859#issuecomment-367694828 @larroy This is an automated message from the Apache G

[GitHub] dabraude commented on issue #9860: [WIP] CMake NNPack support

dabraude commented on issue #9860: [WIP] CMake NNPack support URL: https://github.com/apache/incubator-mxnet/pull/9860#issuecomment-367696110 The dependencies other than NNPack can be downloaded at configure time instead of being sub-modules if that is preferable.

[GitHub] KellenSunderland commented on issue #9861: Add CuDNN (v6) support to Jetson builds

KellenSunderland commented on issue #9861: Add CuDNN (v6) support to Jetson builds URL: https://github.com/apache/incubator-mxnet/pull/9861#issuecomment-367703404 Tested offline. Everything looks good, cudnn is working properly with Jetpack 3.1 ---

[GitHub] KellenSunderland opened a new pull request #9861: Add CuDNN (v6) support to Jetson builds

KellenSunderland opened a new pull request #9861: Add CuDNN (v6) support to Jetson builds URL: https://github.com/apache/incubator-mxnet/pull/9861 ## Description ## Add CuDNN (v6) support to Jetson builds. This should make the builds for Jetson devices 20-35% faster for many tasks.

[GitHub] pengzhao-intel commented on issue #9744: Performance regression when OMP_NUM_THREADS environment variable is not set

pengzhao-intel commented on issue #9744: Performance regression when OMP_NUM_THREADS environment variable is not set URL: https://github.com/apache/incubator-mxnet/issues/9744#issuecomment-367711172 @cjolivier01 Thanks for the fix. I have tested in my local with your code. The OMP_N

[GitHub] pengzhao-intel commented on issue #9744: Performance regression when OMP_NUM_THREADS environment variable is not set

pengzhao-intel commented on issue #9744: Performance regression when OMP_NUM_THREADS environment variable is not set URL: https://github.com/apache/incubator-mxnet/issues/9744#issuecomment-364357479 We found the similar issue that the performance will be worse if we don't set OMP_NUM_THRE

[GitHub] chsin closed issue #9855: Why no Codeowner for /cpp-package/?

chsin closed issue #9855: Why no Codeowner for /cpp-package/? URL: https://github.com/apache/incubator-mxnet/issues/9855 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHu

[GitHub] ZiyueHuang commented on issue #9770: eye operator, for default storage type

ZiyueHuang commented on issue #9770: eye operator, for default storage type URL: https://github.com/apache/incubator-mxnet/pull/9770#issuecomment-367719581 Thanks for your comments. Sorry for the late response. @piiswrong I increased the size and the number of trials and added M=0 cas

[GitHub] chsin commented on a change in pull request #9809: fix optimizer bug in CPP-Package

chsin commented on a change in pull request #9809: fix optimizer bug in CPP-Package URL: https://github.com/apache/incubator-mxnet/pull/9809#discussion_r169996703 ## File path: cpp-package/include/mxnet-cpp/optimizer.hpp ## @@ -125,13 +125,16 @@ inline float Optimizer::Get

[GitHub] cjolivier01 commented on issue #9744: Performance regression when OMP_NUM_THREADS environment variable is not set

cjolivier01 commented on issue #9744: Performance regression when OMP_NUM_THREADS environment variable is not set URL: https://github.com/apache/incubator-mxnet/issues/9744#issuecomment-367726497 I am only vaguely familiar with the KMP stuff. Can you please elaborate? Are you saying tha

[GitHub] cjolivier01 commented on issue #9744: Performance regression when OMP_NUM_THREADS environment variable is not set

cjolivier01 commented on issue #9744: Performance regression when OMP_NUM_THREADS environment variable is not set URL: https://github.com/apache/incubator-mxnet/issues/9744#issuecomment-367727199 Are you sauing I should set the environment variable in the code: KMP_AFFINITY=granularity=

[GitHub] cjolivier01 commented on issue #9744: Performance regression when OMP_NUM_THREADS environment variable is not set

cjolivier01 commented on issue #9744: Performance regression when OMP_NUM_THREADS environment variable is not set URL: https://github.com/apache/incubator-mxnet/issues/9744#issuecomment-367727199 Are you saying I should set the environment variable in the code: KMP_AFFINITY=granularity=

[GitHub] cjolivier01 commented on issue #9744: Performance regression when OMP_NUM_THREADS environment variable is not set

cjolivier01 commented on issue #9744: Performance regression when OMP_NUM_THREADS environment variable is not set URL: https://github.com/apache/incubator-mxnet/issues/9744#issuecomment-367727571 Can you also explain what these settings do? I know it's in a manual somewhere, but from your

[GitHub] cjolivier01 commented on a change in pull request #9770: eye operator, for default storage type

cjolivier01 commented on a change in pull request #9770: eye operator, for default storage type URL: https://github.com/apache/incubator-mxnet/pull/9770#discussion_r170006130 ## File path: src/operator/tensor/init_op.h ## @@ -428,6 +405,39 @@ void FillComputeZerosEx(const

[GitHub] szha commented on issue #9858: softsign activation function

szha commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367746320 Yeah, that would be the right approach. Semver doesn?t have to apply for 0.x, so cherry pick should be fine. -

[GitHub] Maratyszcza commented on issue #9860: [WIP] CMake NNPack support

Maratyszcza commented on issue #9860: [WIP] CMake NNPack support URL: https://github.com/apache/incubator-mxnet/pull/9860#issuecomment-367771148 PeachPy has `pre-generated` branch, which is a mirror of `master` branch after running `python setup.py generate`. I suggest you use the HEAD of t

[GitHub] Maratyszcza commented on a change in pull request #9860: [WIP] CMake NNPack support

Maratyszcza commented on a change in pull request #9860: [WIP] CMake NNPack support URL: https://github.com/apache/incubator-mxnet/pull/9860#discussion_r170047405 ## File path: CMakeLists.txt ## @@ -551,6 +552,66 @@ if(NOT EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/nnvm/CMakeLis

[GitHub] piiswrong commented on issue #9860: [WIP] CMake NNPack support

piiswrong commented on issue #9860: [WIP] CMake NNPack support URL: https://github.com/apache/incubator-mxnet/pull/9860#issuecomment-367772409 This is too many submodules. @Maratyszcza Do you have a bundled release or something like that? A single submodule that has a snap shot to all th

[GitHub] piiswrong commented on issue #9858: softsign activation function

piiswrong commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367773072 We retrofit critical bugfixes to previous releases. This is a new feature. If you do it for 0.11, then you'll need to do it for all the releases a

[GitHub] piiswrong commented on issue #9858: softsign activation function

piiswrong commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367773072 We retrofit critical bugfixes to previous releases. This is a new feature. If you do it for 0.11, then you'll need to do it for all the releases a

[GitHub] szha closed pull request #9805: Enable the reporting of cross-entropy or nll loss value when training CNN network using the models defined by example/image-classification

szha closed pull request #9805: Enable the reporting of cross-entropy or nll loss value when training CNN network using the models defined by example/image-classification URL: https://github.com/apache/incubator-mxnet/pull/9805 This is a PR merged from a forked repository. As GitHub hide

[incubator-mxnet] branch master updated: Enable the reporting of cross-entropy or nll loss value when training CNN network using the models defined by example/image-classification (#9805)

This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new e1d8c66 Enable the reporting of cros

[GitHub] nswamy commented on issue #9858: softsign activation function

nswamy commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367788415 @piiswrong @szha Some background: One of the customer is using MXNet-Scala Interface of 0.11 version. They are soon to go live with their prod

[GitHub] zheng-da commented on issue #9820: Flaky test_gluon_model_zoo_gpu.test_training @ Python3: MKLDNN-GPU

zheng-da commented on issue #9820: Flaky test_gluon_model_zoo_gpu.test_training @ Python3: MKLDNN-GPU URL: https://github.com/apache/incubator-mxnet/issues/9820#issuecomment-367791248 After one day of testing, I think I know where the problem is now. Basically, the current implementation

[GitHub] marcoabreu commented on issue #9820: Flaky test_gluon_model_zoo_gpu.test_training @ Python3: MKLDNN-GPU

marcoabreu commented on issue #9820: Flaky test_gluon_model_zoo_gpu.test_training @ Python3: MKLDNN-GPU URL: https://github.com/apache/incubator-mxnet/issues/9820#issuecomment-367792349 Great news, thanks for diving deep on this problem! ---

[GitHub] dabraude commented on issue #9860: [WIP] CMake NNPack support

dabraude commented on issue #9860: [WIP] CMake NNPack support URL: https://github.com/apache/incubator-mxnet/pull/9860#issuecomment-367794784 @piiswrong NNPack's CmakeLists.txt downloads the dependencies, I can change it so that they are not submodules. ---

[GitHub] wellner commented on issue #9656: Sparse Tensor support in scala api

wellner commented on issue #9656: Sparse Tensor support in scala api URL: https://github.com/apache/incubator-mxnet/issues/9656#issuecomment-367802177 I'd second this request for support of sparse tensors/ndarrays in Scala. Thanks!

[GitHub] Lorna-Liu commented on issue #9517: Check failed: err == CUDNN_STATUS_SUCCESS (6 vs. 0) CUDNN_STATUS_ARCH_MISMATCH

Lorna-Liu commented on issue #9517: Check failed: err == CUDNN_STATUS_SUCCESS (6 vs. 0) CUDNN_STATUS_ARCH_MISMATCH URL: https://github.com/apache/incubator-mxnet/issues/9517#issuecomment-367805855 @liangyong928 I was wondering if you have solve the problem. I just encountered exactly

[GitHub] Lorna-Liu commented on issue #9517: Check failed: err == CUDNN_STATUS_SUCCESS (6 vs. 0) CUDNN_STATUS_ARCH_MISMATCH

Lorna-Liu commented on issue #9517: Check failed: err == CUDNN_STATUS_SUCCESS (6 vs. 0) CUDNN_STATUS_ARCH_MISMATCH URL: https://github.com/apache/incubator-mxnet/issues/9517#issuecomment-367805855 @liangyong928 I was wondering if you have solve the problem. I just encountered exactly

[GitHub] marcoabreu commented on issue #9858: softsign activation function

marcoabreu commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367810206 Considering the fact that we are not making any releases for v0.11, it doesn't really make sense to work on that branch. Or does the customer w

[GitHub] cjolivier01 commented on issue #9858: softsign activation function

cjolivier01 commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367813362 Rules are nice, but IMHO, customer adoption right now trumps everything This is

[GitHub] cjolivier01 commented on issue #9858: softsign activation function

cjolivier01 commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367813362 Rules are nice, but IMHO, customer adoption right now trumps everything. Well, not EVERYHING, but it's important. -

[GitHub] marcoabreu commented on issue #9858: softsign activation function

marcoabreu commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367815373 Of course, but we can't guarantee correctness due to lacking CI and we'd have to make a formal release according to Apache in order to be able to

[GitHub] cjolivier01 commented on issue #9858: softsign activation function

cjolivier01 commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367818944 probably this discussion should occur on dev and see what the mentors think On Thu, Feb 22, 2018 at 12:42 PM, Marco de Abreu wrote:

[GitHub] szha commented on issue #9858: softsign activation function

szha commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367820170 The rules are standards we set for ourselves, and we probably don't want people to think this is a community that's OK to bend the rules whenever it's

[GitHub] szha commented on issue #9858: softsign activation function

szha commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367820170 The rules are standards we set for ourselves, and we probably don't want people to think this is a community that's OK with bending the rules whenever

[GitHub] sifmelcara commented on issue #9809: fix optimizer bug in CPP-Package

sifmelcara commented on issue #9809: fix optimizer bug in CPP-Package URL: https://github.com/apache/incubator-mxnet/pull/9809#issuecomment-367822502 Hello! Just got a ping from @chsin for this PR. I'm the author of the ODR fix. After some git blame, I found this bug was accidentally int

[GitHub] sifmelcara commented on issue #9809: fix optimizer bug in CPP-Package

sifmelcara commented on issue #9809: fix optimizer bug in CPP-Package URL: https://github.com/apache/incubator-mxnet/pull/9809#issuecomment-367822502 Hello! Just got a ping from @chsin for this PR. I'm the author of the ODR fix. After some git blame, I found this bug was accidentally int

[GitHub] sifmelcara commented on issue #9809: fix optimizer bug in CPP-Package

sifmelcara commented on issue #9809: fix optimizer bug in CPP-Package URL: https://github.com/apache/incubator-mxnet/pull/9809#issuecomment-367822502 Hello! Just got a ping from @chsin for this PR. I'm the author of the ODR fix. After some git blame, I found this bug was accidentally int

[GitHub] sifmelcara commented on issue #9809: fix optimizer bug in CPP-Package

sifmelcara commented on issue #9809: fix optimizer bug in CPP-Package URL: https://github.com/apache/incubator-mxnet/pull/9809#issuecomment-367824559 Hmm, in fact I think adding back `static int __make_ ## OptimizerType ## _ ## Name ## __ =` is a little bit better because local static varia

[GitHub] zheng-da opened a new pull request #9862: Fix a race condition in converting data layouts.

zheng-da opened a new pull request #9862: Fix a race condition in converting data layouts. URL: https://github.com/apache/incubator-mxnet/pull/9862 ## Description ## There is a race condition in data layout conversion in the MKLDNN implementation. Currently, when NDArray::data() is

[GitHub] marcoabreu commented on issue #9809: fix optimizer bug in CPP-Package

marcoabreu commented on issue #9809: fix optimizer bug in CPP-Package URL: https://github.com/apache/incubator-mxnet/pull/9809#issuecomment-367830881 @larroy This is an automated message from the Apache Git Service. To respon

[GitHub] cjolivier01 commented on issue #9858: softsign activation function

cjolivier01 commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367833441 "whenever it's convenient"? none of this seems terribly "convenient". Not sure where that framing came from. Customer obsessions is rarely ab

[GitHub] zheng-da commented on issue #9856: Flaky test_random.test_gamma_generator

zheng-da commented on issue #9856: Flaky test_random.test_gamma_generator URL: https://github.com/apache/incubator-mxnet/issues/9856#issuecomment-367839764 Is this problem related to MKLDNN? This is an automated message from

[GitHub] zheng-da commented on issue #9843: Flaky test_random.test_exponential_generator @ Python2: MKLDNN-CPU

zheng-da commented on issue #9843: Flaky test_random.test_exponential_generator @ Python2: MKLDNN-CPU URL: https://github.com/apache/incubator-mxnet/issues/9843#issuecomment-367840947 It seems this problem is related to https://github.com/apache/incubator-mxnet/issues/9856 --

[GitHub] marcoabreu commented on a change in pull request #9862: Fix a race condition in converting data layouts in MKLDNN.

marcoabreu commented on a change in pull request #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#discussion_r170113380 ## File path: tests/python/gpu/test_gluon_model_zoo_gpu.py ## @@ -105,6 +107,7

[GitHub] marcoabreu commented on a change in pull request #9862: Fix a race condition in converting data layouts in MKLDNN.

marcoabreu commented on a change in pull request #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#discussion_r170113340 ## File path: tests/python/gpu/test_gluon_model_zoo_gpu.py ## @@ -37,11 +37,11

[GitHub] marcoabreu closed pull request #9861: Add CuDNN (v6) support to Jetson builds

marcoabreu closed pull request #9861: Add CuDNN (v6) support to Jetson builds URL: https://github.com/apache/incubator-mxnet/pull/9861 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a f

[incubator-mxnet] branch master updated: Add CuDNN (v6) support to Jetson builds (#9861)

This is an automated email from the ASF dual-hosted git repository. marcoabreu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 18816a5 Add CuDNN (v6) support to

[GitHub] marcoabreu commented on a change in pull request #9862: Fix a race condition in converting data layouts in MKLDNN.

marcoabreu commented on a change in pull request #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#discussion_r170113089 ## File path: src/ndarray/ndarray.cc ## @@ -1017,6 +1017,7 @@ inline void CopyF

[GitHub] zheng-da commented on a change in pull request #9862: Fix a race condition in converting data layouts in MKLDNN.

zheng-da commented on a change in pull request #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#discussion_r170114168 ## File path: tests/python/gpu/test_gluon_model_zoo_gpu.py ## @@ -37,11 +37,11 @@

[GitHub] zheng-da commented on a change in pull request #9862: Fix a race condition in converting data layouts in MKLDNN.

zheng-da commented on a change in pull request #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#discussion_r170114324 ## File path: src/ndarray/ndarray.cc ## @@ -1017,6 +1017,7 @@ inline void CopyFro

[GitHub] zheng-da commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN.

zheng-da commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#issuecomment-367845835 @marcoabreu previously, I disabled the inference test. Now I enabled all tests. I also added some prints to clearly

[GitHub] zheng-da commented on issue #9853: Flaky test_operator.test_binary_op

zheng-da commented on issue #9853: Flaky test_operator.test_binary_op URL: https://github.com/apache/incubator-mxnet/issues/9853#issuecomment-367846746 It seems https://github.com/apache/incubator-mxnet/issues/9853 fails in the same test. It's strange how this fails. -

[GitHub] cjolivier01 commented on a change in pull request #9862: Fix a race condition in converting data layouts in MKLDNN.

cjolivier01 commented on a change in pull request #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#discussion_r170117170 ## File path: src/operator/nn/mkldnn/mkldnn_base.cc ## @@ -270,9 +270,24 @@ vo

[GitHub] cjolivier01 commented on a change in pull request #9862: Fix a race condition in converting data layouts in MKLDNN.

cjolivier01 commented on a change in pull request #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#discussion_r170116831 ## File path: src/operator/nn/mkldnn/mkldnn_base.cc ## @@ -270,9 +270,24 @@ vo

[GitHub] cjolivier01 commented on a change in pull request #9862: Fix a race condition in converting data layouts in MKLDNN.

cjolivier01 commented on a change in pull request #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#discussion_r170117620 ## File path: tests/python/gpu/test_gluon_model_zoo_gpu.py ## @@ -37,11 +37,11

[GitHub] marcoabreu opened a new pull request #9863: Fix broken website build and update version number

marcoabreu opened a new pull request #9863: Fix broken website build and update version number URL: https://github.com/apache/incubator-mxnet/pull/9863 Update website build script to point to the right file Add 1.1.0 to build_all_versions.sh Made build scripts fail fast with set -xe

[GitHub] sxjscience commented on issue #9843: Flaky test_random.test_exponential_generator @ Python2: MKLDNN-CPU

sxjscience commented on issue #9843: Flaky test_random.test_exponential_generator @ Python2: MKLDNN-CPU URL: https://github.com/apache/incubator-mxnet/issues/9843#issuecomment-367849367 As shown in the log, the chi-square value is above the 0.05 threshold (indicates the check has passed)

[GitHub] sxjscience commented on issue #9843: Flaky test_random.test_exponential_generator @ Python2: MKLDNN-CPU

sxjscience commented on issue #9843: Flaky test_random.test_exponential_generator @ Python2: MKLDNN-CPU URL: https://github.com/apache/incubator-mxnet/issues/9843#issuecomment-367849367 As shown in the log, the chi-square value is above the 0.05 threshold (indicates the check has passed)

[GitHub] marcoabreu commented on a change in pull request #9862: Fix a race condition in converting data layouts in MKLDNN.

marcoabreu commented on a change in pull request #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#discussion_r170119050 ## File path: src/ndarray/ndarray.cc ## @@ -1017,6 +1017,7 @@ inline void CopyF

[GitHub] cjolivier01 commented on issue #9853: Flaky test_operator.test_binary_op

cjolivier01 commented on issue #9853: Flaky test_operator.test_binary_op URL: https://github.com/apache/incubator-mxnet/issues/9853#issuecomment-367850176 Wasn't elemwise_add changed to use mkl? btw, was it verified that mkl is faster for all shapes and types? I saw it allocates memory

[GitHub] marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN.

marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#issuecomment-367850610 But would this re-enabled test have caught this error? Please explain how we're preventing this problem from reocc

[GitHub] cjolivier01 commented on issue #9848: add infer_type for regression ops, fix issues#9847

cjolivier01 commented on issue #9848: add infer_type for regression ops, fix issues#9847 URL: https://github.com/apache/incubator-mxnet/pull/9848#issuecomment-367852782 Makes sense. This is an automated message from the Apach

[GitHub] marcoabreu commented on issue #9848: add infer_type for regression ops, fix issues#9847

marcoabreu commented on issue #9848: add infer_type for regression ops, fix issues#9847 URL: https://github.com/apache/incubator-mxnet/pull/9848#issuecomment-367852882 Very nice catch, @ZiyueHuang! Sounds like a good idea. Th

[GitHub] cjolivier01 commented on issue #9848: add infer_type for regression ops, fix issues#9847

cjolivier01 commented on issue #9848: add infer_type for regression ops, fix issues#9847 URL: https://github.com/apache/incubator-mxnet/pull/9848#issuecomment-367853082 Please feel free to add infer type for the other ones if you like (not required for this PR, however). -

[GitHub] marcoabreu opened a new issue #9864: Flaky hanging @ Python3: MKLDNN-CPU

marcoabreu opened a new issue #9864: Flaky hanging @ Python3: MKLDNN-CPU URL: https://github.com/apache/incubator-mxnet/issues/9864 Test times out due to hang. http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/PR-9848/1/pipeline ``` tes

[GitHub] marcoabreu commented on issue #9864: Flaky hanging test_operator.test_laop_3 @ Python3: MKLDNN-CPU

marcoabreu commented on issue #9864: Flaky hanging test_operator.test_laop_3 @ Python3: MKLDNN-CPU URL: https://github.com/apache/incubator-mxnet/issues/9864#issuecomment-367853511 @asmushetzel would you like to investigate?

[GitHub] nswamy commented on issue #9858: softsign activation function

nswamy commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367855882 Ok, I registered the symbol under contrib. This is an automated message from the Apa

[GitHub] marcoabreu commented on issue #9858: softsign activation function

marcoabreu commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367857486 Contrib also sounds good to me. Are we going to make a formal release or will that customer just checkout the branch head and compile themselves?

[GitHub] marcoabreu commented on issue #9856: Flaky test_random.test_gamma_generator

marcoabreu commented on issue #9856: Flaky test_random.test_gamma_generator URL: https://github.com/apache/incubator-mxnet/issues/9856#issuecomment-367857691 No, it's using OpenBLAS. This is an automated message from the Apac

[GitHub] piiswrong commented on issue #9858: softsign activation function

piiswrong commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367857655 We can't just put stuff into arbitrary previous versions and then have it disappear later then reappear. I would just make a fork for this

[GitHub] cjolivier01 commented on issue #9858: softsign activation function

cjolivier01 commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367858332 +1 would have to go into all releases after 0.11 This is an automated message f

  1   2   >