[GitHub] merlimat commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

2018-02-17 Thread GitBox
merlimat commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r168927012 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerBuilde

[GitHub] merlimat commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

2018-02-16 Thread GitBox
merlimat commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r168892621 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerBuilde

[GitHub] merlimat commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

2018-02-15 Thread GitBox
merlimat commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r168642225 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ClientBuilder.

[GitHub] merlimat commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

2018-02-15 Thread GitBox
merlimat commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r168641196 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ClientBuilder.

[GitHub] merlimat commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

2018-02-14 Thread GitBox
merlimat commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r168237399 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ClientBuilder.

[GitHub] merlimat commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

2018-02-14 Thread GitBox
merlimat commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r168236993 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ClientBuilder.

[GitHub] merlimat commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

2018-02-14 Thread GitBox
merlimat commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r168236725 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerBuilde