[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1319: 请教华为的CSE架构与Apache的Servicecomb 架构,内部有什么区别吗?配置文件以及服务治理那些是通用的吗?

2019-10-16 Thread GitBox
liubao68 commented on issue #1319: 请教华为的CSE架构与Apache的Servicecomb 架构,内部有什么区别吗?配置文件以及服务治理那些是通用的吗? URL: https://github.com/apache/servicecomb-java-chassis/issues/1319#issuecomment-543005777 For java SDK java-chassis, they almost the same. See https://bbs.huaweicloud.com/blogs/107286

[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1354: 对接 Nacos 配置中心

2019-10-16 Thread GitBox
liubao68 commented on issue #1354: 对接 Nacos 配置中心 URL: https://github.com/apache/servicecomb-java-chassis/issues/1354#issuecomment-543004906 we do not have this yet. Do you mind contribute the client code ? ServiceComb use archorius API to add dynamic support and examles are

[GitHub] [servicecomb-pack] xiangyuQi commented on a change in pull request #572: fix issue #571

2019-10-16 Thread GitBox
xiangyuQi commented on a change in pull request #572: fix issue #571 URL: https://github.com/apache/servicecomb-pack/pull/572#discussion_r335805870 ## File path:

[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request #572: fix issue #571

2019-10-16 Thread GitBox
coolbeevip commented on a change in pull request #572: fix issue #571 URL: https://github.com/apache/servicecomb-pack/pull/572#discussion_r335805392 ## File path:

[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request #572: fix issue #571

2019-10-16 Thread GitBox
coolbeevip commented on a change in pull request #572: fix issue #571 URL: https://github.com/apache/servicecomb-pack/pull/572#discussion_r335799406 ## File path:

[GitHub] [servicecomb-pack] pengyu0929 opened a new issue #573: Failed to get reconnected sender, all alpha server is down

2019-10-16 Thread GitBox
pengyu0929 opened a new issue #573: Failed to get reconnected sender, all alpha server is down URL: https://github.com/apache/servicecomb-pack/issues/573 我现在有两个问题: 1. 我发现有人在之前提出了和我现在一样的问题, #326 ,不知道你们是否修复? 2.有两个服务 A 、B,在A中有两个接口 A1、A2,B中有两个接口

[GitHub] [servicecomb-pack] xiangyuQi commented on a change in pull request #572: fix issue #571

2019-10-16 Thread GitBox
xiangyuQi commented on a change in pull request #572: fix issue #571 URL: https://github.com/apache/servicecomb-pack/pull/572#discussion_r335796055 ## File path:

[GitHub] [servicecomb-pack] xiangyuQi commented on a change in pull request #572: fix issue #571

2019-10-16 Thread GitBox
xiangyuQi commented on a change in pull request #572: fix issue #571 URL: https://github.com/apache/servicecomb-pack/pull/572#discussion_r335796055 ## File path:

[GitHub] [servicecomb-pack] xiangyuQi commented on a change in pull request #572: fix issue #571

2019-10-16 Thread GitBox
xiangyuQi commented on a change in pull request #572: fix issue #571 URL: https://github.com/apache/servicecomb-pack/pull/572#discussion_r335794446 ## File path:

[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request #572: fix issue #571

2019-10-16 Thread GitBox
coolbeevip commented on a change in pull request #572: fix issue #571 URL: https://github.com/apache/servicecomb-pack/pull/572#discussion_r335791654 ## File path:

[servicecomb-website] branch asf-site updated (3f71f10 -> 71e895b)

2019-10-16 Thread ningjiang
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git. from 3f71f10 publish website add 6a38c51 Update the contributing guide new 793bc0c Merge

[servicecomb-website] 01/02: Merge branch 'master' into asf-site

2019-10-16 Thread ningjiang
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git commit 793bc0c36064a0657dfb571ea864ac2e72b1a9d6 Merge: 3f71f10 6a38c51 Author: Willem Jiang AuthorDate: Thu

[servicecomb-website] branch master updated (17326cd -> 6a38c51)

2019-10-16 Thread ningjiang
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git. from 17326cd Merge pull request #200 from ChinX/master add 6a38c51 Update the contributing guide

[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request #572: fix issue #571

2019-10-16 Thread GitBox
coolbeevip commented on a change in pull request #572: fix issue #571 URL: https://github.com/apache/servicecomb-pack/pull/572#discussion_r335787303 ## File path: omega/omega-transport/omega-transport-feign/pom.xml ## @@ -71,6 +83,12 @@ slf4j-simple

[GitHub] [servicecomb-pack] coolbeevip commented on issue #572: fix issue #571

2019-10-16 Thread GitBox
coolbeevip commented on issue #572: fix issue #571 URL: https://github.com/apache/servicecomb-pack/pull/572#issuecomment-542970207 > 非常感谢你能为ServiceComb Pack 提交patch。 > 建议单独添加一个Hystrix模块来处理这部分的功能, 因为Hystrix不但可以和Fegin联合使用,还有可能和其他的Transport模块组合在一起使用。 > > 还有我们需要添加单元测试,来验证线程切换的功能。

[GitHub] [servicecomb-pack] WillemJiang commented on a change in pull request #572: fix issue #571

2019-10-16 Thread GitBox
WillemJiang commented on a change in pull request #572: fix issue #571 URL: https://github.com/apache/servicecomb-pack/pull/572#discussion_r335783033 ## File path:

[GitHub] [servicecomb-pack] WillemJiang commented on a change in pull request #572: fix issue #571

2019-10-16 Thread GitBox
WillemJiang commented on a change in pull request #572: fix issue #571 URL: https://github.com/apache/servicecomb-pack/pull/572#discussion_r335783472 ## File path:

[GitHub] [servicecomb-pack] WillemJiang commented on a change in pull request #572: fix issue #571

2019-10-16 Thread GitBox
WillemJiang commented on a change in pull request #572: fix issue #571 URL: https://github.com/apache/servicecomb-pack/pull/572#discussion_r335782470 ## File path: omega/omega-transport/omega-transport-feign/pom.xml ## @@ -28,6 +28,18 @@ 4.0.0

[GitHub] [servicecomb-java-chassis] msnetc opened a new issue #1354: 对接 Nacos 配置中心

2019-10-16 Thread GitBox
msnetc opened a new issue #1354: 对接 Nacos 配置中心 URL: https://github.com/apache/servicecomb-java-chassis/issues/1354 nacos的动态配置服务让您能够以中心化、外部化和动态化的方式管理所有环境的配置。动态配置消除了配置变更时重新部署应用和服务的需要。配置中心化管理让实现无状态服务更简单,也让按需弹性扩展服务更容易。 能否提供java-chassis对接Nacos的配置中心的demo?

[GitHub] [servicecomb-pack] coveralls commented on issue #572: fix issue #571

2019-10-16 Thread GitBox
coveralls commented on issue #572: fix issue #571 URL: https://github.com/apache/servicecomb-pack/pull/572#issuecomment-542674110 [![Coverage Status](https://coveralls.io/builds/26347265/badge)](https://coveralls.io/builds/26347265) Coverage decreased (-1.1%) to 79.643% when

[servicecomb-java-chassis] branch master updated: [SCB-1523] Stopping retrying another server when no server available

2019-10-16 Thread liubao
This is an automated email from the ASF dual-hosted git repository. liubao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git The following commit(s) were added to refs/heads/master by this push: new 4595644 [SCB-1523] Stopping

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #1351: [SCB-1523] Stopping retrying another server when no server available

2019-10-16 Thread GitBox
liubao68 merged pull request #1351: [SCB-1523] Stopping retrying another server when no server available URL: https://github.com/apache/servicecomb-java-chassis/pull/1351 This is an automated message from the Apache Git

[GitHub] [servicecomb-kie] tianxiaoliang opened a new issue #43: eliminate cross dependency

2019-10-16 Thread GitBox
tianxiaoliang opened a new issue #43: eliminate cross dependency URL: https://github.com/apache/servicecomb-kie/issues/43 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [servicecomb-kie] tianxiaoliang closed pull request #41: add go sum

2019-10-16 Thread GitBox
tianxiaoliang closed pull request #41: add go sum URL: https://github.com/apache/servicecomb-kie/pull/41 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [servicecomb-pack] xiangyuQi commented on issue #571: omega 开启 hystrix,使用Feign调用bug

2019-10-16 Thread GitBox
xiangyuQi commented on issue #571: omega 开启 hystrix,使用Feign调用bug URL: https://github.com/apache/servicecomb-pack/issues/571#issuecomment-542660991 @WillemJiang @pengyu0929 @zhfeng 我提交了一个PR解决这个issue,有空可以看一下 This is an

[GitHub] [servicecomb-pack] xiangyuQi opened a new pull request #572: fix issue #571

2019-10-16 Thread GitBox
xiangyuQi opened a new pull request #572: fix issue #571 URL: https://github.com/apache/servicecomb-pack/pull/572 解决issue #571 OmegaContext 中使用了 InheritableThreadLocal 在feign调用开启hystrix时,hystrix会为每个feignClient创建线程池.

[GitHub] [servicecomb-kie] tianxiaoliang opened a new pull request #41: add go sum

2019-10-16 Thread GitBox
tianxiaoliang opened a new pull request #41: add go sum URL: https://github.com/apache/servicecomb-kie/pull/41 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [servicecomb-java-chassis] coveralls edited a comment on issue #1351: [SCB-1523] Stopping retrying another server when no server available

2019-10-16 Thread GitBox
coveralls edited a comment on issue #1351: [SCB-1523] Stopping retrying another server when no server available URL: https://github.com/apache/servicecomb-java-chassis/pull/1351#issuecomment-542487683 [![Coverage

[GitHub] [servicecomb-java-chassis] AngLi2 closed pull request #1353: [SCB-1528] Optimizing some code implementations

2019-10-16 Thread GitBox
AngLi2 closed pull request #1353: [SCB-1528] Optimizing some code implementations URL: https://github.com/apache/servicecomb-java-chassis/pull/1353 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [servicecomb-java-chassis] coveralls commented on issue #1352: [SCB-1511]when use method override, the generated swagger body is wro…

2019-10-16 Thread GitBox
coveralls commented on issue #1352: [SCB-1511]when use method override, the generated swagger body is wro… URL: https://github.com/apache/servicecomb-java-chassis/pull/1352#issuecomment-542608033 [![Coverage

[GitHub] [servicecomb-java-chassis] AngLi2 commented on issue #1353: [SCB-1528] Optimizing some code implementations

2019-10-16 Thread GitBox
AngLi2 commented on issue #1353: [SCB-1528] Optimizing some code implementations URL: https://github.com/apache/servicecomb-java-chassis/pull/1353#issuecomment-542603909 1. Iterating entrySet() is more efficent than entryKey() when call map.get(key) each time; 2. Collections.isEmpty()

[GitHub] [servicecomb-pack] pengyu0929 removed a comment on issue #571: omega 开启 hystrix,使用Feign调用bug

2019-10-16 Thread GitBox
pengyu0929 removed a comment on issue #571: omega 开启 hystrix,使用Feign调用bug URL: https://github.com/apache/servicecomb-pack/issues/571#issuecomment-542161447 这个还是你们自己写吧,链接中已经写的比较清楚了。但是要考虑到如果使用者在omega端已经实现了一个策略,可能在代理的时候出现问题。 还有这种方式的扩展性比较差,只要新增一个线程变量就要重写一个类。 其他的就没什么了。

[GitHub] [servicecomb-java-chassis] AngLi2 opened a new pull request #1353: [SCB-1528] Optimizing some code implementations

2019-10-16 Thread GitBox
AngLi2 opened a new pull request #1353: [SCB-1528] Optimizing some code implementations URL: https://github.com/apache/servicecomb-java-chassis/pull/1353 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA

[GitHub] [servicecomb-java-chassis] liubao68 opened a new pull request #1352: [SCB-1511]when use method override, the generated swagger body is wro…

2019-10-16 Thread GitBox
liubao68 opened a new pull request #1352: [SCB-1511]when use method override, the generated swagger body is wro… URL: https://github.com/apache/servicecomb-java-chassis/pull/1352 …ng (missed sorting) Follow this checklist to help us incorporate your contribution quickly and easily:

[servicecomb-website] branch little-cui-patch-2 created (now 45d5136)

2019-10-16 Thread littlecui
This is an automated email from the ASF dual-hosted git repository. littlecui pushed a change to branch little-cui-patch-2 in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git. at 45d5136 Update contributing.md No new revisions were added by this update.

[GitHub] [servicecomb-website] little-cui opened a new pull request #202: Update contributing.md

2019-10-16 Thread GitBox
little-cui opened a new pull request #202: Update contributing.md URL: https://github.com/apache/servicecomb-website/pull/202 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [servicecomb-website] little-cui closed pull request #201: Update contributing.md

2019-10-16 Thread GitBox
little-cui closed pull request #201: Update contributing.md URL: https://github.com/apache/servicecomb-website/pull/201 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[servicecomb-website] branch little-cui-patch-1 created (now ffbea89)

2019-10-16 Thread littlecui
This is an automated email from the ASF dual-hosted git repository. littlecui pushed a change to branch little-cui-patch-1 in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git. at ffbea89 Update contributing.md This branch includes the following new commits:

[GitHub] [servicecomb-website] little-cui opened a new pull request #201: Update contributing.md

2019-10-16 Thread GitBox
little-cui opened a new pull request #201: Update contributing.md URL: https://github.com/apache/servicecomb-website/pull/201 This is an automated message from the Apache Git Service. To respond to the message, please log on

[servicecomb-website] 01/01: Update contributing.md

2019-10-16 Thread littlecui
This is an automated email from the ASF dual-hosted git repository. littlecui pushed a commit to branch little-cui-patch-1 in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git commit ffbea890ecce555cf1012beba7659f8dce80bab6 Author: little-cui AuthorDate: Wed Oct 16 15:24:14

[GitHub] [servicecomb-pack] WillemJiang commented on issue #571: omega 开启 hystrix,使用Feign调用bug

2019-10-16 Thread GitBox
WillemJiang commented on issue #571: omega 开启 hystrix,使用Feign调用bug URL: https://github.com/apache/servicecomb-pack/issues/571#issuecomment-542556279 > 这个还是你们自己写吧,链接中已经写的比较清楚了。但是要考虑到如果使用者在omega端已经实现了一个策略,可能在代理的时候出现问题。 > 还有这种方式的扩展性比较差,只要新增一个线程变量就要重写一个类。 > 其他的就没什么了。

[GitHub] [servicecomb-java-chassis] AngLi2 commented on a change in pull request #1351: [SCB-1523] Stopping retrying another server when no server available

2019-10-16 Thread GitBox
AngLi2 commented on a change in pull request #1351: [SCB-1523] Stopping retrying another server when no server available URL: https://github.com/apache/servicecomb-java-chassis/pull/1351#discussion_r335304033 ## File path:

[GitHub] [servicecomb-kie] tianxiaoliang merged pull request #40: [SCB-1526] The contribution guide link is invalid in kie home page

2019-10-16 Thread GitBox
tianxiaoliang merged pull request #40: [SCB-1526] The contribution guide link is invalid in kie home page URL: https://github.com/apache/servicecomb-kie/pull/40 This is an automated message from the Apache Git Service. To

[servicecomb-kie] branch master updated: [SCB-1526] The contribution guide link is invalid in kie home page (#40)

2019-10-16 Thread tianxiaoliang
This is an automated email from the ASF dual-hosted git repository. tianxiaoliang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-kie.git The following commit(s) were added to refs/heads/master by this push: new 66c0b80 [SCB-1526] The

[GitHub] [servicecomb-pack] WillemJiang commented on issue #571: omega 开启 hystrix,使用Feign调用bug

2019-10-16 Thread GitBox
WillemJiang commented on issue #571: omega 开启 hystrix,使用Feign调用bug URL: https://github.com/apache/servicecomb-pack/issues/571#issuecomment-542543770 > 我也碰到用Feign调用时,子事务获取不到globalTxId,导致报错。没有用Hystrix,只是单纯的Feign调用,经测试将Feign改为Dubbo调用就没问题。 你是用Feign调用Dubbo服务吗?

[GitHub] [servicecomb-kie] little-cui opened a new pull request #40: [SCB-1526] The contribution guide link is invalid in kie home page

2019-10-16 Thread GitBox
little-cui opened a new pull request #40: [SCB-1526] The contribution guide link is invalid in kie home page URL: https://github.com/apache/servicecomb-kie/pull/40 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA