Re: RFR (S): 8076461: JSR292: remove unused native and constants

2015-04-07 Thread John Rose
On Apr 7, 2015, at 12:11 PM, Michael Haupt wrote: > > Dear all, > > please review and sponsor this change. Cross-posted to hs-comp and core-lib > as this is at the JVM/libraries boundary. This is a straightforward > refactoring change that removes many constants and unused API from MHNatives,

Re: String concatenation tweaks

2015-04-07 Thread Peter Levart
On 04/07/2015 11:10 PM, Louis Wasserman wrote: Could that actually be provided immutability-safely? I suppose an append-only, fixed-length builder would be potentially safe. I think the presented implementation *is* thread and immutability safe. It only allows mutations from the constructin

Re: String concatenation tweaks

2015-04-07 Thread Peter Levart
Hi Louis, This is nice. Amd could be even nicer. In case the estimated initial StringBuilder capacity is exactly the final String length, then constructing the String could skip the char[] copying step as the StringBuilder instance does not escape. But in order to be safe, this would have to

Re: String concatenation tweaks

2015-04-07 Thread Louis Wasserman
Could that actually be provided immutability-safely? I suppose an append-only, fixed-length builder would be potentially safe. Part of the trickiness there is with primitive parameters, where presizing and doing the actual append both require calculating the size of the primitive when converted t

Re: RFR (S): 8076461: JSR292: remove unused native and constants

2015-04-07 Thread Michael Haupt
Hello, in case anyone was wondering about the empty changeset in the webrev: that's fixed now. Thanks to Vladimir I. for pointing out the glitch in my webrev creation approach. :-) Best, Michael > Am 07.04.2015 um 21:11 schrieb Michael Haupt : > > Dear all, > > please review and sponsor thi

RFR (S): 8076461: JSR292: remove unused native and constants

2015-04-07 Thread Michael Haupt
Dear all, please review and sponsor this change. Cross-posted to hs-comp and core-lib as this is at the JVM/libraries boundary. This is a straightforward refactoring change that removes many constants and unused API from MHNatives, and places some constants used only in MemberName in that class

Re: Review Request for 8039440: Tidy warnings cleanup for org/omg

2015-04-07 Thread Lance Andersen
Hi Alexander, InTypeCode.java you might want to use {@code} vs so that you do not have to use > < Otherwise it is OK Best Lance On Apr 7, 2015, at 1:00 PM, alexander stepanov wrote: > Hello Roger, > > Thank you for the notes, fixed: > http://cr.openjdk.java.net/~avstepan/8039440/webrev.01

Re: Review Request for 8039440: Tidy warnings cleanup for org/omg

2015-04-07 Thread alexander stepanov
Hello Roger, Thank you for the notes, fixed: http://cr.openjdk.java.net/~avstepan/8039440/webrev.01/src/java.corba/share/classes/org/omg/CORBA/portable/package.html.udiff.html http://cr.openjdk.java.net/~avstepan/8039440/webrev.01/src/java.corba/share/classes/org/omg/CORBA/ShortHolder.java.udiff.

Re: Review Request for 8039440: Tidy warnings cleanup for org/omg

2015-04-07 Thread Roger Riggs
Hi, Just a few minor comments; no need for another webrev (on my account). The preferred form for code markup is {@code } instead of ... and ... but that may beyond the scope of the current issue. - Lowercase markup is preferred over uppercase but per file conventions should be consistent

Re: Review Request for 8039440: Tidy warnings cleanup for org/omg

2015-04-07 Thread Roger Riggs
Hi, I'll send some comments in a bit, there are a few things to fix. Roger On 4/7/2015 10:47 AM, alexander stepanov wrote: Thanks! On 07.04.2015 17:45, Yuri Nesterenko wrote: I'm not sure either but the fix looks OK to me. -yan On 04/07/2015 05:40 PM, alexander stepanov wrote: Hello, I'

Re: Review Request for 8039440: Tidy warnings cleanup for org/omg

2015-04-07 Thread alexander stepanov
Thanks! On 07.04.2015 17:45, Yuri Nesterenko wrote: I'm not sure either but the fix looks OK to me. -yan On 04/07/2015 05:40 PM, alexander stepanov wrote: Hello, I'm not if the mail list is correct, but could anyone please review the following fix? http://cr.openjdk.java.net/~avstepan/803944

Re: Review Request for 8039440: Tidy warnings cleanup for org/omg

2015-04-07 Thread Yuri Nesterenko
I'm not sure either but the fix looks OK to me. -yan On 04/07/2015 05:40 PM, alexander stepanov wrote: Hello, I'm not if the mail list is correct, but could anyone please review the following fix? http://cr.openjdk.java.net/~avstepan/8039440/webrev.01/ Bug: https://bugs.openjdk.java.net/brows

Review Request for 8039440: Tidy warnings cleanup for org/omg

2015-04-07 Thread alexander stepanov
Hello, I'm not if the mail list is correct, but could anyone please review the following fix? http://cr.openjdk.java.net/~avstepan/8039440/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8039440 Just an HTML markup fix for CORBA. Thanks, Alexander

Re: RFR (XS): 8033465: JSR292: InvokerBytecodeGenerator: convert a check for REF_invokeVirtual on an interface into an assert

2015-04-07 Thread Michael Haupt
... thank you very much, Vladimir! Best, Michael > Am 07.04.2015 um 14:17 schrieb Vladimir Ivanov : > > Looks good. > > I'll push it for you. > > Best regards, > Vladimir Ivanov > > On 4/7/15 1:23 PM, Michael Haupt wrote: >> Dear all, >> >> please review and sponsor this change. >> >> Bug:

Re: RFR (XS): 8033465: JSR292: InvokerBytecodeGenerator: convert a check for REF_invokeVirtual on an interface into an assert

2015-04-07 Thread Vladimir Ivanov
Looks good. I'll push it for you. Best regards, Vladimir Ivanov On 4/7/15 1:23 PM, Michael Haupt wrote: Dear all, please review and sponsor this change. Bug: https://bugs.openjdk.java.net/browse/JDK-8033465 Change: http://cr.openjdk.java.net/~mhaupt/8033465/webrev.00/ Thanks, Michael

RFR (XS): 8033465: JSR292: InvokerBytecodeGenerator: convert a check for REF_invokeVirtual on an interface into an assert

2015-04-07 Thread Michael Haupt
Dear all, please review and sponsor this change. Bug: https://bugs.openjdk.java.net/browse/JDK-8033465 Change: http://cr.openjdk.java.net/~mhaupt/8033465/webrev.00/ Thanks, Michael -- Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 |