Looks good.
On 11/8/2019 11:38 AM, Andy Herrick wrote:
Please review the revised jpackage fix for bug [1] at [3].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This webrev (webrev.03) addresses feedback from previous version
(webrev.02).
[1]
Looks good.
- Alexey
On 11/8/2019 2:38 PM, Andy Herrick wrote:
Please review the revised jpackage fix for bug [1] at [3].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This webrev (webrev.03) addresses feedback from previous version
Please review the revised jpackage fix for bug [1] at [3].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This webrev (webrev.03) addresses feedback from previous version
(webrev.02).
[1] https://bugs.openjdk.java.net/browse/JDK-8233636
[2]
On 11/7/2019 5:38 PM, Alexey Semenyuk wrote:
http://cr.openjdk.java.net/~herrick/8233636/webrev.02/test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JavaTool.java.sdiff.html:50
I'd suggest to replace
---
if (name.equals("jpackage"))
---
with more robust
---
if (this == JPACKAGE)
---
On 11/7/19 1:45 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This changes the module name, and base package name from jdk.jpackage
to jdk.incubator.jpackage.
This
Hi Andy,
Agree with Alexey comments. Otherwise looks good.
Thanks,
Alexander
On 11/7/2019 2:44 PM, Andy Herrick wrote:
On 11/7/2019 5:38 PM, Alexey Semenyuk wrote:
I guess the link for the review is
https://cr.openjdk.java.net/~herrick/8233636/webrev.02
sry: yes webrev is
On 11/7/2019 5:38 PM, Alexey Semenyuk wrote:
I guess the link for the review is
https://cr.openjdk.java.net/~herrick/8233636/webrev.02
sry: yes webrev is http://cr.openjdk.java.net/~herrick/8233636/webrev.02
I guess the link for the review is
https://cr.openjdk.java.net/~herrick/8233636/webrev.02
http://cr.openjdk.java.net/~herrick/8233636/webrev.02/test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JavaTool.java.sdiff.html:50
I'd suggest to replace
---
if (name.equals("jpackage"))
---
with more
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This changes the module name, and base package name from jdk.jpackage to
jdk.incubator.jpackage.
This removes the "provides" statement in