Re: [c3] Pipeline results

2009-01-13 Thread Steven Dolg
Grzegorz Kossakowski schrieb: Steven Dolg pisze: Configuration and setup is clearly not the most important aspect of a pipeline component. But AFAIK interfaces are not designed by what is most important or not, but by what is common to the implementating classes and by what is really necessar

Re: [c3] Pipeline results

2009-01-13 Thread Grzegorz Kossakowski
Steven Dolg pisze: > Configuration and setup is clearly not the most important aspect of a > pipeline component. > But AFAIK interfaces are not designed by what is most important or not, > but by what is common to the implementating classes and by what is > really necessary for the caller of that i

Re: [c3] Pipeline results

2009-01-13 Thread Grzegorz Kossakowski
Peter Hunsberger pisze: > > I guess part of the debate is whether it is worth defining some > additional method, eg: > > CocoonOutput execute( CocoonInput genericInput) throws ?; > > or > > Object execute( Object genericInput) throws ?; > > I really can't see that the CocoonOuput and Cocoo

Re: [c3] Pipeline results

2009-01-13 Thread Peter Hunsberger
On Tue, Jan 13, 2009 at 12:00 PM, Carsten Ziegeler wrote: > Grzegorz Kossakowski wrote: >> Your problem made me to analyze Cocoon3 Pipeline API very carefully and >> think about it for a while. What I found rather >> strange is PipelineComponent interface, see: >> >> public interface PipelineComp

Re: [c3] Pipeline results

2009-01-13 Thread Steven Dolg
Grzegorz Kossakowski schrieb: Reinhard Pötz pisze: Thanks Grek! But there is no need to hurry because neither Carsten nor I will work on this until Steven has finished his refactorings. Actually, for me there was a hurry as another series of exams in coming and I wanted to contribute

Re: [c3] Pipeline results

2009-01-13 Thread Carsten Ziegeler
Grzegorz Kossakowski wrote: > Your problem made me to analyze Cocoon3 Pipeline API very carefully and think > about it for a while. What I found rather > strange is PipelineComponent interface, see: > > public interface PipelineComponent { > > void setConfiguration(Map configuration); > >

Re: [c3] Pipeline results

2009-01-12 Thread Grzegorz Kossakowski
Reinhard Pötz pisze: > > Thanks Grek! But there is no need to hurry because neither Carsten nor I > will work on this until Steven has finished his refactorings. > Actually, for me there was a hurry as another series of exams in coming and I wanted to contribute something useful before February

Re: [c3] Pipeline results

2009-01-10 Thread Reinhard Pötz
Grzegorz Kossakowski wrote: > Reinhard Pötz pisze: >> TBH I'm still not fully convinced of the parameters approach. If >> none is faster than me I will prepare patches for both solutions so >> that we see what it means at code level. >> >> I would also be interested in what others think about the

Re: [c3] Pipeline results

2009-01-10 Thread Grzegorz Kossakowski
Reinhard Pötz pisze: > > TBH I'm still not fully convinced of the parameters approach. If none is > faster than me I will prepare patches for both solutions so that we see > what it means at code level. > > I would also be interested in what others think about the two solutions > or maybe there a

Re: [c3] Pipeline results

2009-01-08 Thread Carsten Ziegeler
Reinhard Pötz wrote: > TBH I'm still not fully convinced of the parameters approach. If none is > faster than me I will prepare patches for both solutions so that we see > what it means at code level. > I can write a patch - but I would like to wait for Steven's changes first. Carsten -- Carste

Re: [c3] Pipeline results

2009-01-08 Thread Reinhard Pötz
Carsten Ziegeler wrote: > Carsten Ziegeler wrote: >> Reinhard Pötz wrote: >>> I want to provide a SAX buffer to the pipeline and the serializer just >>> passes the SAX events to it. >> Ah, ok. >> As the output stream is a runtime object for the finisher it should be treated like other obj

Re: [c3] Pipeline results

2009-01-05 Thread Carsten Ziegeler
Carsten Ziegeler wrote: > Reinhard Pötz wrote: >> I want to provide a SAX buffer to the pipeline and the serializer just >> passes the SAX events to it. > Ah, ok. > >>> As the output stream is a runtime object for the finisher it should be >>> treated like other objects of this kind (the src url f

Re: [c3] Pipeline results

2009-01-05 Thread Carsten Ziegeler
Reinhard Pötz wrote: > I want to provide a SAX buffer to the pipeline and the serializer just > passes the SAX events to it. Ah, ok. >> As the output stream is a runtime object for the finisher it should be >> treated like other objects of this kind (the src url for the file >> generator for examp

Re: [c3] Pipeline results

2009-01-05 Thread Reinhard Pötz
Carsten Ziegeler wrote: > Reinhard Pötz wrote: >> Yes and I don't think that there speaks anything against it: One >> serializer can produce one particular result type. > Yes, or maybe two (output stream and writer). > >> The problem that I want to solve is that a pipeline can produce other >> res

Re: [c3] Pipeline results

2009-01-05 Thread Peter Hunsberger
On Mon, Jan 5, 2009 at 2:36 AM, Carsten Ziegeler wrote: > Reinhard Pötz wrote: > Ok, so let's throw in some other ideas: > The pipeline interface has the execute method, we could change the > return type of that method from void to Object. So the execution of the > pipeline returns the result (if

Re: [c3] Pipeline results

2009-01-05 Thread Carsten Ziegeler
Reinhard Pötz wrote: > Yes and I don't think that there speaks anything against it: One > serializer can produce one particular result type. Yes, or maybe two (output stream and writer). > The problem that I want to solve is that a pipeline can produce other > results than OutputStreams which impo

Re: [c3] Pipeline results

2009-01-04 Thread Reinhard Pötz
Carsten Ziegeler wrote: > Reinhard Pötz wrote: >> Reinhard Pötz wrote: >>> Carsten Ziegeler wrote: >>> There is a slight overlap between the serializer and the result - for example if you want to get java objects out of the pipeline, you might want to use a special serializer. So may

Re: [c3] Pipeline results

2008-12-29 Thread Carsten Ziegeler
Reinhard Pötz wrote: > Reinhard Pötz wrote: >> Carsten Ziegeler wrote: >> >>> There is a slight overlap between the serializer and the result - for >>> example if you want to get java objects out of the pipeline, you might >>> want to use a special serializer. So maybe we can merge the two? >> I wa

Re: [c3] Pipeline results

2008-12-24 Thread Reinhard Pötz
Reinhard Pötz wrote: > Carsten Ziegeler wrote: >> Reinhard Pötz wrote: >>> But still there is one limitation that has bugged me several times: The >>> result of all pipelines is that they write something into an output stream. >>> That's the original use case for pipelines used in servlet environme

Re: [c3] Pipeline results

2008-12-23 Thread Simone Tripodi
Hi Reinhard, thanks to mentioned me :P I like your proposal and, indeed, is what we start thinking when I submitted the Digester Finisher[1] patch; in the testcase, there's the demonstration that the Finisher had to be "forced" using a null OutputStream - otherwise the Pipeline couldn't start - the

Re: [c3] Pipeline results

2008-12-23 Thread Reinhard Pötz
Carsten Ziegeler wrote: > Reinhard Pötz wrote: >> But still there is one limitation that has bugged me several times: The >> result of all pipelines is that they write something into an output stream. >> That's the original use case for pipelines used in servlet environments >> and probably true in

Re: [c3] Pipeline results

2008-12-22 Thread Carsten Ziegeler
Reinhard Pötz wrote: > But still there is one limitation that has bugged me several times: The > result of all pipelines is that they write something into an output stream. > That's the original use case for pipelines used in servlet environments > and probably true in many cases but not in all. >

[c3] Pipeline results

2008-12-22 Thread Reinhard Pötz
Triggered by some discussions that Steven and I had with our students we were thinking again about the pipeline API. Compared to previous pipeline implementations we already made one improvement by making the pipeline unaware of the data that flows between its components. This means that the Cocoo