Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/254#issuecomment-119840437
There is also an update to the docs that is needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
But I think the FileHelper class should be moved somewhere else (not sure
where), so other plugins can use it and not just the camera plugin.
I have a file chooser plugin and I use very similar code to get the real
urls
2015-07-08 23:52 GMT+02:00 Joe Bowser :
> I just tried it and it doesn't work
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34224410
--- Diff: template/cordova/lib/package.js ---
@@ -130,58 +145,47 @@ module.exports.findDevice = function (target) {
};
// returns arr
Github user AndyChenW commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-119817738
device.isVirtual +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-119817528
Ah, gotcha.
I actually think I like isVirtual better as it sidesteps all the sim/emu
discussions.
I'll let this pr sit for a bit and see i
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-119813107
Heh, I wasn't wanting to start a semantics argument, just after consistency.
My understanding is that the usual terminology is "simulator" for iO
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-119811586
2 other 'offers'
device.isVirtual
Or the opposite
device.isDevice
---
If your project is set up for it, you can reply to this em
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-119809686
Attempting to avoid a semantics argument, I chose to overlook this.
do we really need to add 2 properties? iOS simulator IS a simulator.
---
I
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-119804386
Should this be "Emulator" rather than "Simulator" (that's the terminology
used elsewhere in Cordova, isn't it? And the typical terminology for Android
a
Github user kant2002 closed the pull request at:
https://github.com/apache/cordova-docs/pull/295
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user AndyChenW commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/32#issuecomment-119792320
https://github.com/apache/cordova-plugin-device/pull/35
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AndyChenW commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/32#issuecomment-119792313
a new pr is created for isSimulator.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AndyChenW closed the pull request at:
https://github.com/apache/cordova-plugin-device/pull/32
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
GitHub user AndyChenW opened a pull request:
https://github.com/apache/cordova-plugin-device/pull/35
add isSimulator for iOS & Android device
@purplecabbage change pr and property name to isSimulator.
You can merge this pull request into a Git repository by running:
$ git pull
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/125#issuecomment-119771695
Hi edades,
I don't think that is relevant to this pull request, I have this plugin
(with and without this pull request) in my project and it works
Thanks, Nikhil.
Looking forward to it.
--
tommy-carlos williams
On 9 July 2015 at 08:18:24, Nikhil Khandelwal (nikhi...@microsoft.com) wrote:
I'm closing the doodle now. Thursday July 16th 12 - 2 PM PST has the maximum
folks. Please add it to your calendars. I will send out a hangout link cl
Made whitelist changes to mobilespec and added the whitelist plugin. I
think these issues should be resolved but a build are not triggered, how I
can I trigger an iOS build?
On Mon, Jun 29, 2015 at 9:18 PM, Dmitry Blotsky
wrote:
> Hey folks,
>
> We’ve seen two issues pop up in iOS in the past tw
I'm closing the doodle now. Thursday July 16th 12 - 2 PM PST has the maximum
folks. Please add it to your calendars. I will send out a hangout link closer
to the event.
Thanks,
Nikhil
-Original Message-
From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
Sent: Tuesday, July 7, 20
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/254#discussion_r34204394
--- Diff: cordova-lib/src/plugman/plugman.js ---
@@ -169,35 +160,6 @@ plugman.commands = {
}
});
},
-
yes yes yes!
Is it sufficient to simply make the win8.1 project the startup project in
the 2013 sln?
If there are still nags, we can remove the windows8.0 project entirely from
the 2013 sln.
My team is hiring!
@purplecabbage
risingj.com
On Wed, Jul 8, 2015 at 2:57 PM, Rob Paveza wrote:
> I've
I've been tackling a couple quality-of-life improvements and I've been thinking
about this issue. In VS 2012 and 2013, Windows 8 is supported, but in VS 2015,
it isn't (you can use VS 2015 to target Windows 8.1 and 10).
We have the following projects in our solutions:
- Windows 8
- Windows 8.1
I just tried it and it doesn't work. I think we should probably adopt
this, since I don't have a better solution to this problem. I'll pull it
in tomorrow if I don't see any objections.
On Wed, Jul 8, 2015 at 1:32 PM Joe Bowser wrote:
> That makes sense. I'll whitelist the Content URI and see
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/254#discussion_r34200986
--- Diff: cordova-lib/src/plugman/plugman.js ---
@@ -169,35 +160,6 @@ plugman.commands = {
}
});
},
-
-
+1
* unpacked and tested/verified the changes
* ran coho verify-archive
-Original Message-
From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
Sent: Tuesday, July 7, 2015 11:25 AM
To: dev@cordova.apache.org
Subject: [VOTE] Plugins release - cordova-plugin-file-transfer
Please revie
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/295#issuecomment-119734093
Thanks for the contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/295#issuecomment-119734040
I merged this one 2f620e6. I had a typo in my commit message and this PR
remained open. Can you please close it?
---
If your project is set up for it, you can re
As a committer working on the master branch using npm link, it has been useful
to have '-dev' prefix and do a "cordova --version".
I vote for (3).
Thanks,
Nikhil
-Original Message-
From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
Sent: Wednesday, July 8, 2015 7:28 AM
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/295#issuecomment-119730497
I see - I can take a stab at updating all the older versions on the svn
repo that has our website.
---
If your project is set up for it, you can reply to this em
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-119727865
@stevengill @infil00p Any possibility of reviewing this before the next
release?
---
If your project is set up for it, you can reply to this email
That makes sense. I'll whitelist the Content URI and see if that resolves
the issue. I do think we need something to get real URIs on Android but
this seems like the wrong place for it.
On Wed, Jul 8, 2015, 1:21 PM Nikhil Khandelwal
wrote:
> I remember seeing a PR, that mentioned content:// wa
I remember seeing a PR, that mentioned content:// was not working because of
the whitelist plugin not supporting it when '*' was specified and/or because
CSP did not include it. That PR and discussion did not go anywhere:
https://github.com/apache/cordova-plugin-whitelist/pull/6
I have myself n
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/32#issuecomment-119703244
This looks good, I will look at adding it to windows+wp8
Please change the new property to `isSimulator` instead of `is_simulator`.
---
If your
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-globalization/pull/38
CB-9336 Fix Globalization plugin init on Windows 10
[Jira issue](https://issues.apache.org/jira/browse/CB-9336)
You can merge this pull request into a Git repository by running:
> The docs mention SHOULD be supported, but CSP is the way to go.
> > >
> > > Therefore needs to be supported on iOS for native code
> requests
> > > (see failing FileTransfer tests CB-9329) since CSP is only in the
> context
> > > of the UIWebView. This is duplication of definitions unless we
Hey
Since for some reason the browser doesn't resolve content URIs anymore, I'm
tempted to pull this into Camera.
https://github.com/apache/cordova-plugin-camera/pull/93
The problem I have with it is the large amount of code that is being added,
and I want some more people to look at it before I
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/93#issuecomment-119692899
Does this have a corresponding JIRA issue? Also, I'm going to talk about
this on the dev list before pulling it in.
---
If your project is set up for it
On Wed, Jul 8, 2015 at 4:47 AM, Shazron wrote:
> FYI, we get to revisit this whitelist stuff again for iOS 9 with it's
> Application Transport Security (ATS):
>
> https://developer.apple.com/library/prerelease/ios/technotes/App-Transport-Security-Technote/index.html#//apple_ref/doc/uid/TP40016240
Hey
After discussing the release of Cordova-Android 4.0.3, and looking at the
commit log on Master, we should probably just do a 4.1.0 release instead.
This is a minor release with enough bug fixes to justify it. I'm wondering
if there's any reason we shouldn't do a 4.1.0 release? If not, I'll s
OK, Going to start a new discuss thread for 4.1.0
On Tue, Jul 7, 2015 at 5:49 PM Joe Bowser wrote:
> We could do a 4.1.0 release, but I don't think I'd say it was overdue.
> I'm not even sure if there's any real reason to do a 4.1.x release other
> than cadence, which we stopped following when w
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34168225
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,275 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34168004
--- Diff: template/cordova/lib/target-list.js ---
@@ -17,20 +17,21 @@
under the License.
*/
-var devices = require('./packa
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34167789
--- Diff: template/cordova/lib/run.js ---
@@ -155,7 +155,8 @@ module.exports.help = function () {
console.log('--appx=<8.1-win|8.1-phone|
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34167364
--- Diff: template/cordova/lib/package.js ---
@@ -113,16 +112,32 @@ function getPackageName(platformPath) {
// returns one of available de
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34167579
--- Diff: template/cordova/lib/package.js ---
@@ -130,58 +145,47 @@ module.exports.findDevice = function (target) {
};
// returns arra
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34166300
--- Diff: template/cordova/lib/package.js ---
@@ -113,16 +112,32 @@ function getPackageName(platformPath) {
// returns one of available de
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34166637
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,275 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34166452
--- Diff: template/cordova/lib/package.js ---
@@ -113,16 +112,32 @@ function getPackageName(platformPath) {
// returns one of available de
Thanks for the feedback!
Maybe I could determine in the cordova plugin if there is a browser
implementation with “getOriginalSymbol(window, 'navigator.battery');” and
return the browser object from navigator.getBattery or return the cordova
implementation. I’ll be working on a patch toward that an
Github user edades commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/125#issuecomment-119638131
Hi, sorry for write here.
I have a problem with this plugin, this interrupt the load of cordova.js,
and my page refresh all the time.
And this proble
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34165767
--- Diff: template/cordova/lib/target-list.js ---
@@ -17,20 +17,21 @@
under the License.
*/
-var devices = require('./pack
GitHub user spirann opened a pull request:
https://github.com/apache/cordova-android/pull/195
CB-9334 loop on CordovaPlugins before returning remapped Uri
This is a fix for https://issues.apache.org/jira/browse/CB-9334
Because sometimes you need more than one plugin to hand
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34164434
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,275 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34164191
--- Diff: template/cordova/lib/run.js ---
@@ -155,7 +155,8 @@ module.exports.help = function () {
console.log('--appx=<8.1-win|8.1-phone
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34164096
--- Diff: template/cordova/lib/package.js ---
@@ -130,58 +145,47 @@ module.exports.findDevice = function (target) {
};
// returns arr
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34163912
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,275 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34163428
--- Diff: spec/unit/deployment.spec.js ---
@@ -0,0 +1,282 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or
Hey, guys.
I've found another reason to drop this while testing cordova-lib with updated
dependencies (see https://issues.apache.org/jira/browse/CB-9332)
It appears, that starting from 4.x.x semver treats prerelease versions in a
very different way.
For example:
require('semver').satisfies
Hi,
this commit
https://github.com/apache/cordova-plugin-console/commit/d58f218b9149d362ebb0b8ce697cf403569d14cd#diff-53f390d375398624afe1cfe1125f42bfR36
moved the common code from the platforms up one level into the common space
in plugin.xml.
Please revert this change.
On Android this change
FYI, we get to revisit this whitelist stuff again for iOS 9 with it's
Application Transport Security (ATS):
https://developer.apple.com/library/prerelease/ios/technotes/App-Transport-Security-Technote/index.html#//apple_ref/doc/uid/TP40016240
Should be relatively simple --> convert access tags to
Related: https://issues.apache.org/jira/browse/CB-9329
>From the README: https://github.com/apache/cordova-plugin-whitelist
The Android whitelist supports , and
.
The iOS whitelist supports only currently.
The docs mention SHOULD be supported, but CSP is the way to go.
Therefore needs to be
Hey, guys. Here is PRs, which removes 'publish' & Co.
Plugman: https://github.com/apache/cordova-plugman/pull/84
Cordova-lib: https://github.com/apache/cordova-lib/pull/254
Corresponding JIRA: https://issues.apache.org/jira/browse/CB-9330
The next step will be npm and semver update according to
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/254
CB-9330 Removes 'plugman publish' related functionality
See [CB-9330](https://issues.apache.org/jira/browse/CB-9330) for more
details.
You can merge this pull request into a Git repos
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-plugman/pull/84
CB-9330 Adds notice about removed plugman commands
See [CB-9330](https://issues.apache.org/jira/browse/CB-9330) for more
details
You can merge this pull request into a Git reposito
Github user kant2002 commented on the pull request:
https://github.com/apache/cordova-docs/pull/295#issuecomment-119465537
To update the file index.js should be distributed to all versions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user kant2002 commented on the pull request:
https://github.com/apache/cordova-docs/pull/295#issuecomment-119465461
Ok, so I drop it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
GitHub user ghenry22 opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/125
CB-9331 cordova-plugin-file
resolves CB-9331, correct the value queried on iOS devices so that free
getFreeDiskSpace() returns a valid value instead of always returning 0.
You can mer
66 matches
Mail list logo