[dpdk-dev] [PATCH 0/2 v4] Fix two compile issues with i686 platform

2014-12-11 Thread Thomas Monjalon
2014-12-11 15:28, Qiu, Michael: > On 2014/12/11 21:26, Neil Horman wrote: > > On Thu, Dec 11, 2014 at 01:56:06AM +0100, Thomas Monjalon wrote: > >>> These two issues are both introuduced by commit b77b5639: > >>> mem: add huge page sizes for IBM Power > >>> > >>> Michael Qiu (2): > >>> Fi

[dpdk-dev] lib: include rte_memory.h for __rte_cache_aligned

2014-12-11 Thread Thomas Monjalon
2014-12-11 09:17, Neil Horman: > On Thu, Dec 11, 2014 at 01:36:54AM +0100, Thomas Monjalon wrote: > > Hi Neil, > > > > 2014-12-10 19:28, Neil Horman: > > > On Wed, Dec 10, 2014 at 07:09:03PM +, Jia Yu wrote: > > > > Hi Neil, > > > > > > > > Moving __rte_cache_aligned right after struct keywor

[dpdk-dev] [PATCH v2] vmxnet3: set txq_flags in default TX conf

2014-12-11 Thread Pablo de Lara
Since commit fbde27f19ab8f "get default Rx/Tx configuration from dev info", a default RX/TX configuration can be used for all PMDs. In case of vmxnet3, the whole structure was zeroed and not filled out. The PMD does not support multi segments or offload functions, so txq_flags should have those fla

[dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support

2014-12-11 Thread Xie, Huawei
> -Original Message- > From: Xie, Huawei > Sent: Thursday, December 11, 2014 10:13 AM > To: 'Linhaifeng'; dev at dpdk.org > Cc: haifeng.lin at intel.com > Subject: RE: [dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user > support > > > > > Only support one vhost-user port ? > >

[dpdk-dev] [PATCH] vmxnet3: set txq_flags in default TX conf

2014-12-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Thursday, December 11, 2014 5:08 PM > To: dev at dpdk.org > Cc: root > Subject: [dpdk-dev] [PATCH] vmxnet3: set txq_flags in default TX conf > > Since commit fbde27f19ab8f "get default Rx

[dpdk-dev] i40e 3rdparty QSFP module support

2014-12-11 Thread Michael Marchetti
Hi, I have an i40e card with a Finisar QSFP (40G) module. The dpdk driver does not seem to detect the correct mac type for this QSFP module. Inside: STATIC enum i40e_media_type i40e_get_media_type(struct i40e_hw *hw) hw->phy.link_info.phy_type has value 0, which does not match up (I40E_PHY_TYP

[dpdk-dev] Build sucess DPDK 1.7.1 in UBunutu, testpmd failed with librte_distributor.so

2014-12-11 Thread sothy shan
Hi! I am trying these commands. based on suggestion http://dpdk.org/ml/archives/dev/2014-October/006247.html $RTE_TARGET=/x86_64-ivshmem-linuxapp-gcc $make CONFIG_RTE_BUILD_COMBINE_LIBS=y CONFIG_RTE_BUILD_SHARED_LIB=y install T="$RTE_TARGET" EXTRA_LDFLAGS=--no-as-needed Build sucessfully. B

[dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support

2014-12-11 Thread Xie, Huawei
> > Only support one vhost-user port ? Do you mean vhost server by "port"? If that is the case, yes, now only one vhost server is supported for multiple virtio devices. As stated in the cover letter, we have requirement and plan for multiple server support, though I am not sure if it is absolut

[dpdk-dev] [PATCH] vmxnet3: set txq_flags in default TX conf

2014-12-11 Thread Pablo de Lara
Since commit fbde27f19ab8f "get default Rx/Tx configuration from dev info", a default RX/TX configuration can be used for all PMDs. In case of vmxnet3, the whole structure was zeroed and not filled out. The PMD does not support multi segments or offload functions, so txq_flags should have those fla

[dpdk-dev] [PATCH v2] ixgbe: fix multi-process support

2014-12-11 Thread Bruce Richardson
On Thu, Dec 11, 2014 at 04:58:42PM +, Pattan, Reshma wrote: > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > > Sent: Friday, December 5, 2014 1:46 PM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH v2] ixgbe: fix multi-pr

[dpdk-dev] [PATCH v2] ixgbe: fix multi-process support

2014-12-11 Thread Pattan, Reshma
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > Sent: Friday, December 5, 2014 1:46 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2] ixgbe: fix multi-process support > > When using multiple processes, the TX function used in all

[dpdk-dev] [PATCH v3 25/28] eal/pci: Remove pci_probe/close_all_drivers()

2014-12-11 Thread Tetsuya Mukawa
(2014/12/11 15:02), Qiu, Michael wrote: > Why you do not call pci_invoke_all_drivers() directly in former patches? > > What you do is first modify then remove I have received comments for former patches internally. And you know, this patch series are long. For those reviewers, I didn't want to

[dpdk-dev] [PATCH v3 23/28] eal/pci: Add rte_eal_pci_probe_one and rte_eal_pci_close_one

2014-12-11 Thread Tetsuya Mukawa
(2014/12/11 14:54), Qiu, Michael wrote: > On 12/9/2014 2:34 PM, Tetsuya Mukawa wrote: >> The functions are used for probe and close a device. >> First the function tries to find a device that has the specfied PCI address. >> Then, probe or close the device. >> >> Signed-off-by: Tetsuya Mukawa >> -

[dpdk-dev] [PATCH v3 20/28] eal/pci: Add rte_eal_pci_close_one_driver

2014-12-11 Thread Qiu, Michael
On 2014/12/11 17:56, Richardson, Bruce wrote: > On Thu, Dec 11, 2014 at 03:41:06AM +, Qiu, Michael wrote: >> On 12/9/2014 2:33 PM, Tetsuya Mukawa wrote: >>> The function is used for closing the specified driver and device. >>> >>> Signed-off-by: Tetsuya Mukawa >>> --- >>> lib/librte_eal/commo

[dpdk-dev] [PATCH 0/2 v4] Fix two compile issues with i686 platform

2014-12-11 Thread Qiu, Michael
On 2014/12/11 21:26, Neil Horman wrote: > On Thu, Dec 11, 2014 at 01:56:06AM +0100, Thomas Monjalon wrote: >>> These two issues are both introuduced by commit b77b5639: >>> mem: add huge page sizes for IBM Power >>> >>> Michael Qiu (2): >>> Fix compile issue with hugepage_sz in 32-bit sys

[dpdk-dev] rte_config.h missing in DPDK 1.7.1

2014-12-11 Thread sothy shan
Hi Marc! Thank for your response. But I tried double check.Propelly set those values. Actually I found the file inside x86_64-native-linuxapp-gcc/include/rte_config.h. But when I compile DPDK OVS, it does not find the file. I got same error/ lib/dpdk-link.c:25:24: fatal error: rte_config.h: No suc

[dpdk-dev] [PATCH v3 18/28] eal/pci: Prevent double registrations for pci_device_list

2014-12-11 Thread Tetsuya Mukawa
(2014/12/11 12:24), Qiu, Michael wrote: > If you modify one function, make sure all places, where call the > function, have been modified accordingly in same patch. > > Please do not split it. Because we must make sure every patch could > make dpdk work( I think without this patch, it will have so

[dpdk-dev] [PULL REQUEST] doc: modifications to user guides

2014-12-11 Thread Bernard Iremonger
These changes are DPDK 1.8 modifications and some corrections to the Programmers Guide, the Sample Application User Guide and the Release Notes. The following changes since commit 199aec302e16670869f07df40642d58fcf304a80: i40e: fix build with 16-byte descriptors (2014-12-11 10:02:55 +) are

[dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support

2014-12-11 Thread Linhaifeng
On 2014/12/11 5:37, Huawei Xie wrote: > vhost-user support > > > Signed-off-by: Huawei Xie > --- > lib/librte_vhost/Makefile | 5 +- > lib/librte_vhost/vhost-net.h | 4 + > lib/librte_vhost/vhost_cuse/virtio-net-cdev.c | 9 + > lib/librte_vhost/vhost

[dpdk-dev] [PATCH v3 21/28] eal/pci: Fix pci_probe_all_drivers to share code with closing function

2014-12-11 Thread Tetsuya Mukawa
(2014/12/11 13:46), Qiu, Michael wrote: > On 12/11/2014 11:52 AM, Qiu, Michael wrote: >> On 12/9/2014 2:34 PM, Tetsuya Mukawa wrote: >>> pci_close_all_drivers() will be implemented after the patch. >>> To share a part of code between thses 2 functions, The patch fixes >>> pci_probe_all_drivers() fi

[dpdk-dev] [PATCH v3 13/28] eal/pci: Prevent double registration for devargs_list

2014-12-11 Thread Tetsuya Mukawa
Hi Michael, (2014/12/09 23:55), Qiu, Michael wrote: > On 2014/12/9 14:33, Tetsuya Mukawa wrote: >> The patch fixes rte_eal_devargs_add() not to register same device twice. >> >> Signed-off-by: Tetsuya Mukawa >> --- >> lib/librte_eal/common/eal_common_devargs.c | 35 >> ++

[dpdk-dev] [PATCH v3 07/28] ethdev: Add functions to know which port is attached or detached

2014-12-11 Thread Tetsuya Mukawa
(2014/12/11 12:35), Qiu, Michael wrote: > On 12/11/2014 11:12 AM, Tetsuya Mukawa wrote: >> Hi Michael, >> >> (2014/12/09 23:39), Qiu, Michael wrote: >>> On 2014/12/9 14:32, Tetsuya Mukawa wrote: The patch adds rte_eth_dev_save() and rte_eth_dev_get_changed_port(). rte_eth_dev_save() is us

[dpdk-dev] [PATCH] app/test: fix multiprocess unit test when device is bound to uio

2014-12-11 Thread Pablo de Lara
Since commit a155d4301 "support link bonding device initialization", EAL probes drivers to the PCI devices in rte_eal_init, then PCI resources are mapped if a device is bound to igb_uio driver, for instance. Therefore, test app probes all the devices and multiprocess unit test tries to map resource

[dpdk-dev] [PATCH] doc: add bsd license to svg file

2014-12-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bernard Iremonger > Sent: Monday, December 08, 2014 5:19 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] doc: add bsd license to svg file > > > Signed-off-by: Bernard Iremonger Acked-by: Pablo de Lar

[dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support

2014-12-11 Thread Linhaifeng
On 2014/12/11 5:37, Huawei Xie wrote: > vhost-user support > > > Signed-off-by: Huawei Xie > --- > lib/librte_vhost/Makefile | 5 +- > lib/librte_vhost/vhost-net.h | 4 + > lib/librte_vhost/vhost_cuse/virtio-net-cdev.c | 9 + > lib/librte_vhost/vhost

[dpdk-dev] [PATCH] librte_net: fix TX checksum offload problem with IPv6 packet.

2014-12-11 Thread Olivier MATZ
Hi Konstantin, On 12/11/2014 12:49 PM, Konstantin Ananyev wrote: > For rte_ipv6_phdr_cksum() gcc 4.8.* with "-O3" not always generates > correct code. > Sometimes it 'forgets' to put len and proto fields of psd_header on the stack. > To overcome that problem and speedup things a bit, refactored rt

[dpdk-dev] [PATCH] kni: fix build on RHEL6.5

2014-12-11 Thread Jincheng Miao
RHEL6.5 kernel is based on 2.6.32. But there are two changing from 2.6.35: 1. socket struct is changed It wrappered previous wait_queue_head_t of socket to struct socket_wq. So for the kernel older than 2.6.35, we should directly use socket->wait instead. 2. new function sk_sleep() This function i

[dpdk-dev] [PATCH 14/15] app/test: turn off cpu flag checks for tile architecture

2014-12-11 Thread Tony Lu
>-Original Message- >From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman >Sent: Tuesday, December 09, 2014 11:03 PM >To: Zhigang Lu >Cc: dev at dpdk.org >Subject: Re: [dpdk-dev] [PATCH 14/15] app/test: turn off cpu flag checks for tile >architecture > >On Mon, Dec 08, 2014 a

[dpdk-dev] rte_config.h missing in DPDK 1.7.1

2014-12-11 Thread Marc Sune
This usually shows up when you are attempting to compile your DPDK application without properly defining RTE_SDK and RTE_TARGET (where DPDK source resides). Just double check if they are properly defined and exported marc On 11/12/14 12:17, sothy shan wrote: > Hi! > I am seeking help on instal

[dpdk-dev] rte_config.h missing in DPDK 1.7.1

2014-12-11 Thread sothy shan
Hi! I am seeking help on installing DPDK OVS with DPDK 1.7.1 on ubuntu 14.04. If any body knows solutin, please let me. I compile in a typical way for DPDK 1.7.1 with x86_64_native-linuxaap-gcc. command: make config T=x86_64-native-linuxapp-gcc make It compiled and worked. I am able to run testp

[dpdk-dev] [PATCH v4] mbuf: fix of enabling all newly added RX error flags

2014-12-11 Thread Olivier MATZ
Hi Helin, On 12/10/2014 11:29 PM, Zhang, Helin wrote: > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -83,12 +83,7 @@ extern "C" { > #define PKT_RX_RSS_HASH (1ULL << 1) /**< RX packet with >> RSS hash result. */ > #define PKT_RX_FDIR

[dpdk-dev] [PATCH v3 15/28] eal/pci: Add probe and close function for virtual drivers

2014-12-11 Thread Tetsuya Mukawa
Hi Michael, (2014/12/10 0:51), Qiu, Michael wrote: > On 2014/12/9 14:33, Tetsuya Mukawa wrote: >> The patch adds rte_eal_dev_init_one() and rte_eal_dev_close_one(). >> These are used for attaching and detaching virtual devices. >> >> Signed-off-by: Tetsuya Mukawa >> --- >> lib/librte_eal/common/

[dpdk-dev] [PATCH v3 07/28] ethdev: Add functions to know which port is attached or detached

2014-12-11 Thread Tetsuya Mukawa
Hi Michael, (2014/12/09 23:39), Qiu, Michael wrote: > On 2014/12/9 14:32, Tetsuya Mukawa wrote: >> The patch adds rte_eth_dev_save() and rte_eth_dev_get_changed_port(). >> rte_eth_dev_save() is used for saving current rte_eth_dev structures. >> rte_eth_dev_get_changed_port() receives the rte_eth_d

[dpdk-dev] [PATCH v3 03/28] eal/pci: Replace pci address comparison code by eal_compare_pci_addr

2014-12-11 Thread Tetsuya Mukawa
Hi Michael, (2014/12/09 23:22), Qiu, Michael wrote: > On 2014/12/9 14:32, Tetsuya Mukawa wrote: >> This patch replaces pci_addr_comparison() and memcmp() of pci addresses by >> eal_compare_pci_addr(). >> >> Signed-off-by: Tetsuya Mukawa >> --- >> lib/librte_eal/bsdapp/eal/eal_pci.c | 16 +-

[dpdk-dev] [PATCH v3 3/3] app/testpmd:change tx_checksum command and csum forwarding engine

2014-12-11 Thread Olivier MATZ
Hi Jijiang, Some more comments, in addition to the one I've made in the cover letter. Reference link for patchwork readers: http://dpdk.org/ml/archives/dev/2014-December/009886.html On 12/10/2014 02:03 AM, Jijiang Liu wrote: > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -316,

[dpdk-dev] [PATCH] librte_net: fix TX checksum offload problem with IPv6 packet.

2014-12-11 Thread Konstantin Ananyev
For rte_ipv6_phdr_cksum() gcc 4.8.* with "-O3" not always generates correct code. Sometimes it 'forgets' to put len and proto fields of psd_header on the stack. To overcome that problem and speedup things a bit, refactored rte_raw_cksum() by splitting ipv6 pseudo-header csum calculation into 3 phas

[dpdk-dev] In DPDK 1.7.1, the link status of the interface using virtio driver is always down.

2014-12-11 Thread Fu, Weiyi (NSN - CN/Hangzhou)
Hi Changchun, I found you had done follow change to allow the virtio interface startup when the link is down. Is there any scenario causing link down for virtio interface? diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c b/lib/librte_pmd_virtio/virtio_ethdev.c index 78018f9..4bff0fe 100644 --

[dpdk-dev] [PATCH v3 2/3] i40e:support outer IPv4 checksum capability

2014-12-11 Thread Olivier MATZ
On 12/10/2014 02:03 AM, Jijiang Liu wrote: > The DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM flag is added in i40e capability set, > which means the i40e supports TX checksum offload of tunneling packet. > > Signed-off-by: Jijiang Liu > --- > lib/librte_pmd_i40e/i40e_ethdev.c |3 ++- > 1 files changed

[dpdk-dev] [PATCH v3 1/3] librte_ether:add outer IP offload capability flag

2014-12-11 Thread Olivier MATZ
On 12/10/2014 02:03 AM, Jijiang Liu wrote: > If the flag is set in a PMD, which means the NIC(s) support TX checksum > offload of tunneling packet. > > Signed-off-by: Jijiang Liu > --- > lib/librte_ether/rte_ethdev.h |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a

[dpdk-dev] [PATCH] igb_uio: fix Xen compatibility with kernel 3.18

2014-12-11 Thread Shu Shen
This patch fixes build failing with undefined symbol _PAGE_IOMAP with kernel 3.18. The Xen-specific _PAGE_IOMAP PTE flag was removed in kernel 3.18 and could be used for other purpose in future. This patch ensures that _PAGE_IOMAP flag is only used for kernels before 3.18. Signed-off-by: Shu Shen

[dpdk-dev] [PATCH RFC v2 00/12] lib/librte_vhost: vhost-user support

2014-12-11 Thread Tetsuya Mukawa
Hi Xie, (2014/12/11 7:04), Xie, Huawei wrote: > This patch set is based on latest vhost. > It fixes vhost-user memory map/unmap alignment issue. > It uses VHOST_USER_GET_VRING_BASE as the message for vhost device stop > in vhost-user. > It uses VHOST_SET_VRING_KICK as the messa

[dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine

2014-12-11 Thread Olivier MATZ
Hi Jijiang, Sorry for the late review, I was very busy these last days. Please find my comments below. On 12/10/2014 02:03 AM, Jijiang Liu wrote: > In the current codes, the "tx_checksum set (ip|udp|tcp|sctp|vxlan) (hw|sw) > (port-id)" command is not easy to understand and extend, so the patch s

[dpdk-dev] [PATCH v4 0/4] compatibility fallback and replacement of kernel function invoking

2014-12-11 Thread Jincheng Miao
On 12/11/2014 09:00 AM, Thomas Monjalon wrote: >> The related kernel function is: >> - pci_num_vf, it is introduced from upstream linux-2.6.34. For RHEL-based >> kernel, it is defined from RHEL5.9. >> >> - kstrtoul, this function is united kernel API to replace strict_strtoul in >> the furture. It

[dpdk-dev] [PATCH v3 14/28] eal/pci: Add rte_eal_devargs_remove

2014-12-11 Thread Tetsuya Mukawa
Hi Michael, (2014/12/10 0:36), Qiu, Michael wrote: > I don't know if other reviewers ask you to split so many patches. But I > would like merge some of them, because some are doing same affairs(just > using different args), others should be add/remove affairs. Those could > be merge to one patch,

[dpdk-dev] [PATCH v3 3/3] doc: add VM power mgmt app

2014-12-11 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, December 9, 2014 12:02 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v3 3/3] doc: add VM power mgmt app > > Added new section in sample app UG for > the new VM power manage

[dpdk-dev] [PATCH v3 2/3] doc: add vm power mgmt request sequence svg

2014-12-11 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, December 9, 2014 12:02 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v3 2/3] doc: add vm power mgmt request sequence svg > > Added second of the two figures in the VM power

[dpdk-dev] A question about hugepage initialization time

2014-12-11 Thread Bruce Richardson
On Wed, Dec 10, 2014 at 07:16:59PM +, L?szl? Vadkerti wrote: > na ez :) > > On Wed, 10 Dec 2014, Bruce Richardson wrote: > > > On Wed, Dec 10, 2014 at 09:29:26AM -0500, Neil Horman wrote: > >> On Wed, Dec 10, 2014 at 10:32:25AM +, Bruce Richardson wrote: > >>> On Tue, Dec 09, 2014 at 02:1

[dpdk-dev] [PATCH v3 1/3] doc: add vm power mgmt overview svg

2014-12-11 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, December 9, 2014 12:02 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v3 1/3] doc: add vm power mgmt overview svg > > Added first of the two figures in the VM power manageme

[dpdk-dev] [PATCH] doc: fix typos in ring lib

2014-12-11 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, December 9, 2014 12:28 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] doc: fix typos in ring lib > > Ring library section in PG had a couple of typos, in the text and in on

[dpdk-dev] [PATCH] replaced O(n^2) sort in sort_by_physaddr() with qsort() from standard library

2014-12-11 Thread Jay Rolette
Signed-off-by: Jay Rolette --- lib/librte_eal/linuxapp/eal/eal_memory.c | 59 +++- 1 file changed, 20 insertions(+), 39 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c index bae2507..3656515 100644 --- a/li

[dpdk-dev] [RFC PATCH 7/7] eal: macro for cpuset w/ or w/o CPU_ALLOC

2014-12-11 Thread Cunming Liang
Signed-off-by: Cunming Liang --- lib/librte_eal/linuxapp/eal/eal_thread.c | 144 +-- 1 file changed, 81 insertions(+), 63 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_thread.c b/lib/librte_eal/linuxapp/eal/eal_thread.c index a584e3b..05cebe4 100644 ---

[dpdk-dev] [RFC PATCH 6/7] sample: add new sample for multi-pthread

2014-12-11 Thread Cunming Liang
Signed-off-by: Cunming Liang --- examples/multi-pthread/Makefile | 57 ++ examples/multi-pthread/main.c | 232 examples/multi-pthread/main.h | 46 3 files changed, 335 insertions(+) create mode 100644 examples/multi-pthread/Makefil

[dpdk-dev] [RFC PATCH 5/7] testpmd: support multi-pthread mode

2014-12-11 Thread Cunming Liang
Signed-off-by: Cunming Liang --- app/test-pmd/cmdline.c | 41 app/test-pmd/testpmd.c | 84 +- app/test-pmd/testpmd.h | 1 + 3 files changed, 125 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-

[dpdk-dev] [RFC PATCH 4/7] eal: add simple API for multi-pthread

2014-12-11 Thread Cunming Liang
Signed-off-by: Cunming Liang --- config/common_linuxapp | 1 + lib/librte_eal/common/include/rte_eal.h | 10 +++ lib/librte_eal/linuxapp/eal/eal_thread.c | 105 ++- 3 files changed, 115 insertions(+), 1 deletion(-) diff --git a/config/common_lin

[dpdk-dev] [RFC PATCH 3/7] ring: use linear-tid as ring debug stats index

2014-12-11 Thread Cunming Liang
Signed-off-by: Cunming Liang --- lib/librte_ring/rte_ring.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h index 3920830..c038a4f 100644 --- a/lib/librte_ring/rte_ring.h +++ b/lib/librte_ring/rte_ring.h @@ -189,9

[dpdk-dev] [RFC PATCH 2/7] mempool: use linear-tid as mempool cache index

2014-12-11 Thread Cunming Liang
Signed-off-by: Cunming Liang --- lib/librte_mempool/rte_mempool.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h index 3314651..bf4117b 100644 --- a/lib/librte_mempool/rte_mempool.h

[dpdk-dev] [RFC PATCH 1/7] eal: add linear thread id as pthread-local variable

2014-12-11 Thread Cunming Liang
Signed-off-by: Cunming Liang --- lib/librte_eal/common/include/rte_eal.h | 5 ++ lib/librte_eal/common/include/rte_lcore.h | 12 lib/librte_eal/linuxapp/eal/eal_thread.c | 115 -- 3 files changed, 126 insertions(+), 6 deletions(-) diff --git a/lib/librte_e

[dpdk-dev] [RFC PATCH 0/7] support multi-phtread per lcore

2014-12-11 Thread Cunming Liang
Scope & Usage Scenario DPDK usually pin pthread per core to avoid task switch overhead. It gains performance a lot, but it's not efficient in all cases. In some cases, it may too expensive to use the whole core for a lightweight workload. It's a reasonable demand to

[dpdk-dev] librte_distributor.so: cannot open shared object file: No such file or directory

2014-12-11 Thread sothy shan
Hi! I compiled DPDK v1.7.1 on ubunutu 14.04. I used following commands to compille. cd DPDKexport RTE_SDK=$(pwd)export RTE_TARGET="x86_64-ivshmem-linuxapp-gcc" make CONFIG_RTE_BUILD_COMBINE_LIBS=y CONFIG_RTE_BUILD_SHARED_LIB=y install T="$RTE_TARGET" I mounted hugepages and

[dpdk-dev] Pipeline and RTE_CORE_MAX=128

2014-12-11 Thread Walukiewicz, Miroslaw
Hello, After last change for RTE_CORE_MAX=128 the rte_pipeline still supports only 64 ports as it is optimized to work on u64 variables. Are there any plans to extend pipeline design to use 128, 256 or even 512 ports using AVX/SSE extensions available? Regards, Mirek

[dpdk-dev] [RFC PATCH 0/7] support multi-phtread per lcore

2014-12-11 Thread Walukiewicz, Miroslaw
Thank you Cunming for explanation. What about DPDK timers? They also depend on rte_lcore_id() to avoid spinlocks. Mirek > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Cunming Liang > Sent: Thursday, December 11, 2014 3:05 AM > To: dev at dpdk.org > Subje

[dpdk-dev] [PATCH v2] app/test: fix memory needs after RTE_MAX_LCORE was increased to 128

2014-12-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, December 11, 2014 1:11 AM > To: De Lara Guarch, Pablo > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] app/test: fix memory needs after > RTE_MAX_LCORE was increased to 128 > >

[dpdk-dev] [PATCH v3 20/28] eal/pci: Add rte_eal_pci_close_one_driver

2014-12-11 Thread Bruce Richardson
On Thu, Dec 11, 2014 at 03:41:06AM +, Qiu, Michael wrote: > On 12/9/2014 2:33 PM, Tetsuya Mukawa wrote: > > The function is used for closing the specified driver and device. > > > > Signed-off-by: Tetsuya Mukawa > > --- > > lib/librte_eal/common/eal_private.h | 15 + > > lib/librte_

[dpdk-dev] [PATCH v3] test-pmd: Fix pointer aliasing error

2014-12-11 Thread r k
Thomas, Michael, Wouldn't it cause unaligned memory access (new changes as well as the previous code)? Wondering if get_unaligned/put_unaligned macros similar to the ones used in kernel be ported to user-space? Thanks, Ravi On Wed, Dec 10, 2014 at 4:54 PM, Thomas Monjalon wrote: > > > > app/tes

[dpdk-dev] lib: include rte_memory.h for __rte_cache_aligned

2014-12-11 Thread Neil Horman
On Thu, Dec 11, 2014 at 01:36:54AM +0100, Thomas Monjalon wrote: > Hi Neil, > > 2014-12-10 19:28, Neil Horman: > > On Wed, Dec 10, 2014 at 07:09:03PM +, Jia Yu wrote: > > > Hi Neil, > > > > > > Moving __rte_cache_aligned right after struct keyword will help. On the > > > other hand, enforcing

[dpdk-dev] In DPDK 1.7.1, the link status of the interface using virtio driver is always down.

2014-12-11 Thread Fu, Weiyi (NSN - CN/Hangzhou)
Hi, The result is still the same. [root at EIPU-0(KVMCluster) /root] # ./testpmd -c 3 -n 4 -- --burst=64 -i --txq=1 --rxq=1 --txqflags=0x EAL: Cannot read numa node link for lcore 0 - using physical package id instead EAL: Detected lcore 0 as core 0 on socket 0 EAL: Cannot read numa node li

[dpdk-dev] [PATCH 14/15] app/test: turn off cpu flag checks for tile architecture

2014-12-11 Thread Neil Horman
On Thu, Dec 11, 2014 at 12:43:36PM +0800, Tony Lu wrote: > >-Original Message- > >From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman > >Sent: Tuesday, December 09, 2014 11:03 PM > >To: Zhigang Lu > >Cc: dev at dpdk.org > >Subject: Re: [dpdk-dev] [PATCH 14/15] app/test: turn

[dpdk-dev] [PATCH 0/2 v4] Fix two compile issues with i686 platform

2014-12-11 Thread Neil Horman
On Thu, Dec 11, 2014 at 01:56:06AM +0100, Thomas Monjalon wrote: > > These two issues are both introuduced by commit b77b5639: > > mem: add huge page sizes for IBM Power > > > > Michael Qiu (2): > > Fix compile issue with hugepage_sz in 32-bit system > > Fix compile issue of eal with i

[dpdk-dev] In DPDK 1.7.1, the link status of the interface using virtio driver is always down.

2014-12-11 Thread Ouyang, Changchun
Hi, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Fu, Weiyi (NSN - > CN/Hangzhou) > Sent: Thursday, December 11, 2014 3:57 PM > To: dev at dpdk.org > Subject: [dpdk-dev] In DPDK 1.7.1, the link status of the interface using > virtio > driver is always down

[dpdk-dev] In DPDK 1.7.1, the link status of the interface using virtio driver is always down.

2014-12-11 Thread Fu, Weiyi (NSN - CN/Hangzhou)
Hi, We are using the l2fwd based on DPDK 1.7.1 and found out that the link status of the interface using virtio driver is always down. Is there any precondition to let the link up? # ./pci_unbind.py --status Network devices using IGB_UIO driver :00:04.0

[dpdk-dev] [PATCH v3 0/6] i40e VMDQ support

2014-12-11 Thread Cao, Min
Tested-by: Min Cao Patch name: i40e VMDQ support Brief description: Test Flag: Tested-by Tester name:min.cao at intel.com Result summary: total 1 cases, 1 passed, 0 failed Test Case 1: Name: perf_vmd

[dpdk-dev] [PATCH v3 25/28] eal/pci: Remove pci_probe/close_all_drivers()

2014-12-11 Thread Qiu, Michael
Why you do not call pci_invoke_all_drivers() directly in former patches? What you do is first modify then remove Thanks, Michael On 12/9/2014 2:34 PM, Tetsuya Mukawa wrote: > These functions are actually wrappers of pci_invoke_all_drivers(). > Just call it directly. > > Signed-off-by: Tetsuy

[dpdk-dev] [PATCH v2 0/2] examples/vmdq: support new VMDQ API

2014-12-11 Thread Cao, Min
Tested-by: Min Cao Patch name: examples/vmdq: support new VMDQ API Brief description: Test Flag: Tested-by Tester name:min.cao at intel.com Result summary: total 1 cases, 1 passed, 0 failed Test Case 1: Name:

[dpdk-dev] [PATCH v3 23/28] eal/pci: Add rte_eal_pci_probe_one and rte_eal_pci_close_one

2014-12-11 Thread Qiu, Michael
On 12/9/2014 2:34 PM, Tetsuya Mukawa wrote: > The functions are used for probe and close a device. > First the function tries to find a device that has the specfied PCI address. > Then, probe or close the device. > > Signed-off-by: Tetsuya Mukawa > --- > lib/librte_eal/common/eal_common_pci.c |

[dpdk-dev] In DPDK 1.7.1, the link status of the interface using virtio driver is always down.

2014-12-11 Thread Vijayakumar Muthuvel Manickam
Hi, I have seen this issue happen on older kernels like 2.6.32-220.el6.x86_64 while it works with no issues on a recent kernel like 3.10.x. Further, I found this issue was happening due to /sys/bus/pci/devices//msi_irqs dir not being enumerated in older kernels resulting in hw->use_msix=0. This c

[dpdk-dev] [PATCH RFC v2 12/12] lib/librte_vhost: cleanup when vhost user socket connection is closed

2014-12-11 Thread Huawei Xie
close the memory region file descriptor close the kick/callfd vSwitch needs to run endlessly. resource leak is deadly issue. Signed-off-by: Huawei Xie --- lib/librte_vhost/vhost_user/vhost-net-user.c | 7 ++-- lib/librte_vhost/vhost_user/virtio-net-user.c | 59 +++ li

[dpdk-dev] [PATCH RFC v2 11/12] lib/librte_vhost: kick/callfd fix

2014-12-11 Thread Huawei Xie
Signed-off-by: Huawei Xie --- lib/librte_vhost/vhost_user/virtio-net-user.c | 4 ++-- lib/librte_vhost/virtio-net.c | 13 +++-- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/lib/librte_vhost/vhost_user/virtio-net-user.c b/lib/librte_vhost/vhost_user/vir

[dpdk-dev] [PATCH RFC v2 10/12] lib/librte_vhost: vhost-user memory region map

2014-12-11 Thread Huawei Xie
deals with vhost user memory map/unmap alignment Signed-off-by: Huawei Xie --- lib/librte_vhost/rte_virtio_net.h | 2 + lib/librte_vhost/vhost-net.h | 2 - lib/librte_vhost/vhost_user/vhost-net-user.h | 3 +- lib/librte_vhost/vhost_user/virtio-net-user.c | 105

[dpdk-dev] [PATCH RFC v2 09/12] lib/librte_vhost: minor fix

2014-12-11 Thread Huawei Xie
Signed-off-by: Huawei Xie --- lib/librte_vhost/vhost_user/vhost-net-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost_user/vhost-net-user.c b/lib/librte_vhost/vhost_user/vhost-net-user.c index 841d7e6..6b9ebd7 100644 --- a/lib/librte_vhost/vhost_us

[dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support

2014-12-11 Thread Huawei Xie
vhost-user support Signed-off-by: Huawei Xie --- lib/librte_vhost/Makefile | 5 +- lib/librte_vhost/vhost-net.h | 4 + lib/librte_vhost/vhost_cuse/virtio-net-cdev.c | 9 + lib/librte_vhost/vhost_user/vhost-net-user.c | 422 ++

[dpdk-dev] [PATCH RFC v2 07/12] lib/librte_vhost: async event and callback

2014-12-11 Thread Huawei Xie
Signed-off-by: Huawei Xie --- lib/librte_vhost/vhost_user/fd_man.c | 205 +++ lib/librte_vhost/vhost_user/fd_man.h | 64 +++ 2 files changed, 269 insertions(+) create mode 100644 lib/librte_vhost/vhost_user/fd_man.c create mode 100644 lib/librte_vhost/v

[dpdk-dev] [PATCH RFC v2 06/12] lib/librte_vhost: cuse_set_memory_table

2014-12-11 Thread Huawei Xie
cuse_set_memory_table Signed-off-by: Huawei Xie --- lib/librte_vhost/Makefile | 2 +- lib/librte_vhost/vhost-net.h | 4 +- lib/librte_vhost/vhost_cuse/vhost-net-cdev.c | 7 +- lib/librte_vhost/vhost_cuse/virtio-net-cdev.c | 85 +++ lib/librte_vhos

[dpdk-dev] [PATCH RFC v2 05/12] lib/librte_vhost: host_memory_map refine

2014-12-11 Thread Huawei Xie
host_memory_map only maps partial memory of target process into current process through shared backed file. Signed-off-by: Huawei Xie --- lib/librte_vhost/vhost_cuse/virtio-net-cdev.c | 43 +-- 1 file changed, 20 insertions(+), 23 deletions(-) diff --git a/lib/librte_vh

[dpdk-dev] [PATCH RFC v2 04/12] lib/librte_vhost: copy of host_memory_map from virtio-net.c to new file virtio-net-cdev.c

2014-12-11 Thread Huawei Xie
create virtio-net-cdev.c and copy host_memory_map into it. Signed-off-by: Huawei Xie --- lib/librte_vhost/vhost_cuse/virtio-net-cdev.c | 258 ++ 1 file changed, 258 insertions(+) create mode 100644 lib/librte_vhost/vhost_cuse/virtio-net-cdev.c diff --git a/lib/librte_vh

[dpdk-dev] [PATCH RFC v2 03/12] lib/librte_vhost: move event_copy logic from virtio-net.c to vhost-net-cdev.c

2014-12-11 Thread Huawei Xie
virtio-net.c implements the common message handler for vhost cuse and user. Signed-off-by: Huawei Xie --- lib/librte_vhost/vhost_cuse/vhost-net-cdev.c | 82 lib/librte_vhost/virtio-net.c| 57 +-- 2 files changed, 74 insertions(+), 65

[dpdk-dev] [PATCH RFC v2 02/12] lib/librte_vhost: rename vhost-net-cdev.h as vhost-net.h

2014-12-11 Thread Huawei Xie
vhost-net.h is the shared header file for both vhost-cuse and vhost-user Signed-off-by: Huawei Xie --- lib/librte_vhost/vhost-net-cdev.h| 113 --- lib/librte_vhost/vhost-net.h | 113 +++ lib/librte_vhost/vhost_cuse/vhost

[dpdk-dev] [PATCH RFC v2 01/12] lib/librte_vhost: mov vhost-cuse implementation to vhost_cuse directory

2014-12-11 Thread Huawei Xie
create vhost_cuse directory and move vhost-net-cdev.c to vhost_cuse directory Signed-off-by: Huawei Xie --- lib/librte_vhost/Makefile| 4 +- lib/librte_vhost/vhost-net-cdev.c| 389 --- lib/librte_vhost/vhost_cuse/vhost-net-cdev.c | 389 ++

[dpdk-dev] [PATCH RFC v2 00/12] lib/librte_vhost: vhost-user support

2014-12-11 Thread Huawei Xie
This patchset refines vhost library to support both vhost-cuse and vhost-user. Huawei Xie (12): create vhost_cuse directory and move vhost-net-cdev.c to vhost_cuse directory rename vhost-net-cdev.h as vhost-net.h move eventfd_copy logic out from virtio-net.c to vhost-net-cdev.c exact copy

[dpdk-dev] [PATCH v3 22/28] eal/pci: Add pci_close_all_drivers

2014-12-11 Thread Qiu, Michael
On 12/9/2014 2:33 PM, Tetsuya Mukawa wrote: > The function tries to find a driver for the specified device, and then > close the driver. > > Signed-off-by: Tetsuya Mukawa > --- > lib/librte_eal/common/eal_common_pci.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/l

[dpdk-dev] [PATCH v3 21/28] eal/pci: Fix pci_probe_all_drivers to share code with closing function

2014-12-11 Thread Qiu, Michael
On 12/11/2014 11:52 AM, Qiu, Michael wrote: > On 12/9/2014 2:34 PM, Tetsuya Mukawa wrote: >> pci_close_all_drivers() will be implemented after the patch. >> To share a part of code between thses 2 functions, The patch fixes >> pci_probe_all_drivers() first. >> >> Signed-off-by: Tetsuya Mukawa >> -

[dpdk-dev] [PATCH v3 21/28] eal/pci: Fix pci_probe_all_drivers to share code with closing function

2014-12-11 Thread Qiu, Michael
On 12/9/2014 2:34 PM, Tetsuya Mukawa wrote: > pci_close_all_drivers() will be implemented after the patch. > To share a part of code between thses 2 functions, The patch fixes > pci_probe_all_drivers() first. > > Signed-off-by: Tetsuya Mukawa > --- > lib/librte_eal/common/eal_common_pci.c | 28 ++

[dpdk-dev] [PATCH v3 20/28] eal/pci: Add rte_eal_pci_close_one_driver

2014-12-11 Thread Qiu, Michael
On 12/9/2014 2:33 PM, Tetsuya Mukawa wrote: > The function is used for closing the specified driver and device. > > Signed-off-by: Tetsuya Mukawa > --- > lib/librte_eal/common/eal_private.h | 15 + > lib/librte_eal/linuxapp/eal/eal_pci.c | 61 > +++ > 2

[dpdk-dev] [PATCH v3 07/28] ethdev: Add functions to know which port is attached or detached

2014-12-11 Thread Qiu, Michael
On 12/11/2014 11:12 AM, Tetsuya Mukawa wrote: > Hi Michael, > > (2014/12/09 23:39), Qiu, Michael wrote: >> On 2014/12/9 14:32, Tetsuya Mukawa wrote: >>> The patch adds rte_eth_dev_save() and rte_eth_dev_get_changed_port(). >>> rte_eth_dev_save() is used for saving current rte_eth_dev structures. >>

[dpdk-dev] [PATCH v3 18/28] eal/pci: Prevent double registrations for pci_device_list

2014-12-11 Thread Qiu, Michael
If you modify one function, make sure all places, where call the function, have been modified accordingly in same patch. Please do not split it. Because we must make sure every patch could make dpdk work( I think without this patch, it will have some issue after you applied "Replace pci address c

[dpdk-dev] [PATCH v2] add one option memory-only for secondary processes

2014-12-11 Thread Hiroshi Shimamoto
Hi, sorry for the delay. > Subject: RE: [dpdk-dev] [PATCH v2] add one option memory-only for secondary > processes > > Hi, Hiroshi, > Yes, you are right, in order to avoid such problem, while create the mempool, > which shall be shared between the primary > process and those secondary Processe

[dpdk-dev] [RFC PATCH 0/7] support multi-phtread per lcore

2014-12-11 Thread Jayakumar, Muthurajan
Steve, Great write up. Nice explanation of 1) per-lcore numbering and 2) Multi-producer/consumer enqueue -dequeue. Thanks, -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Cunming Liang Sent: Wednesday, December 10, 2014 6:05 PM To: dev at dpdk.org Subject: [dpdk

[dpdk-dev] [PATCH] mk: fix link to combined library

2014-12-11 Thread Hiroshi Shimamoto
From: Hiroshi Shimamoto The application should be linked to the single combined library in the condition that both of CONFIG_RTE_BUILD_COMBINE_LIB and CONFIG_RTE_BUILD_SHARED_LIB are enabled. The current makefile generates an application that links to each library. This patch fixes to link the s

[dpdk-dev] [dpdk-announce] release candidate 1.8.0-rc4

2014-12-11 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: http://dpdk.org/browse/dpdk/tag/?id=v1.8.0-rc4 This release candidate includes many build fixes. Changelog (main changes since rc3) - fixes for: * building * cache line alignment * b

[dpdk-dev] [PATCH v2] app/test: fix memory needs after RTE_MAX_LCORE was increased to 128

2014-12-11 Thread Thomas Monjalon
2014-12-10 15:40, Thomas Monjalon: > 2014-12-09 10:11, Pablo de Lara: > > Since commit b91c67e5a693211862aa7dc3b78630b4e856c2af, > > maximum number of cores is 128, which has increase > > the total memory necessary for a rte_mempool structure, > > as the per-lcore local cache has been doubled in si

[dpdk-dev] Added Spinlock to l3fwd-vf example to prevent race conditioning

2014-12-11 Thread Thomas Monjalon
> > Signed-off-by: Daniel Mrzyglod > > Acked-by: Neil Horman Applied Thanks -- Thomas

  1   2   >