flake8 checks were run for both python 2.7 and 3.4
There were some style issues as:
- Line width > 79
- No double blank line before function definition
- No double blank space before inline comment
- Some other minor issues
Signed-off-by: Mauricio Vasquez B
---
tools/dpdk_nic_bind.py | 165
It removes the i40evf_set_mac_type() defined in PMD, and reuses
i40e_set_mac_type() defined in base driver.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/i40e_ethdev_vf.c | 22 +-
1 file changed, 1 insertion(+), 21 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.
As required, rx control registers have to be read/written by
rx control functions, otherwise if may fail to read/write
when under stress small traffic.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/i40e_ethdev.c| 66 ---
drivers/net/i40e/i40e_ethdev_vf.c
It adds several new device IDs, and also removed one which is
not used at all.
Signed-off-by: Helin Zhang
---
doc/guides/rel_notes/release_16_04.rst | 15 +++
drivers/net/i40e/i40e_ethdev.h | 2 +-
drivers/net/i40e/i40e_rxtx.c| 8 --
It adds base driver release information such as release date,
for better tracking in the future.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/Makefile b/drivers/net/i40e/Makefile
index 033ee4a..6dd6eaa 100644
--- a/
Several structures and macros are added or updated, such
as 'struct i40e_aqc_get_link_status',
'struct i40e_aqc_run_phy_activity' and
'struct i40e_aqc_lldp_set_local_mib_resp'.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_adminq_cmd.h | 45 ++---
drivers/
It adds the new AQ command and struct for managing a
thermal sensor.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_adminq_cmd.h | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h
b/drivers/net/i40e/base/i40e_adminq_cmd.h
in
X722 supports Expanded version of TCP, UDP PCTYPES for RSS.
Add a Virtchnl offload to support this.
Without this patch VF drivers will not be able to support
the correct PCTYPES for X722 and UDP flows will not fan out.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_virtchnl.h | 1 +
1
This patch adds 7 new register definitions for programming the
parser, flow director and RSS blocks in the HW.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_register.h | 48 +++
drivers/net/i40e/i40e_ethdev.c| 11 ++--
2 files changed, 50 i
RX control register read/write functions are added, as directly
read/write may fail when under stress small traffic. After the
adminq is ready, all rx control registers should be read/written
by dedicated functions.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_adminq_cmd.h | 16 +++
It adds coding style fixes.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_common.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/net/i40e/base/i40e_common.c
b/drivers/net/i40e/base/i40e_common.c
index 9a0b787..e94f726 100644
--- a/d
When updating a VSI, save off the number of allocated and
unallocated VSIs as we do when adding a VSI.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_common.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/i40e/base/i40e_common.c
b/drivers/net/i40e/base/i40e_co
When linking with particular PHY types (ex: copper PHY), the amount of
time it takes for the GLGEN_RSTAT_DEVSTATE to be set increases greatly,
which can lead to a timeout and failure to load the driver.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_common.c | 6 +++---
1 file changed
In MFP mode particularly when we were setting the PF VSI in limited
promiscuous, the HW switch was still mirroring the outgoing packets
from other VSIs (VF/VMdq) onto the PF VSI.
With this new bit set, the mirroring doesn't happen any more and so
we are in limited promiscuous on the PF VSI in MFP w
This patch adds functions to blink led on devices using
Coppervale PHY since MAC registers used in other designs
do not work in this device configuration.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_common.c| 329 +
drivers/net/i40e/base/i40e_pro
Add the support code for calling the AdminQ API call
aq_set_switch_config.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_adminq_cmd.h | 12
drivers/net/i40e/base/i40e_common.c | 28
drivers/net/i40e/base/i40e_prototype.h | 3 +++
3 file
With the latest firmware, statistics gathering can now be enabled and
disabled in the HW switch, so we need to add a parameter to allow the
driver to set it as desired. At the same time, the L2 cloud filtering
parameter has been removed as it was never used.
Older drivers working with the newer fir
This patch implements necessary functions related to port
mirroring features such as add/delete mirror rule, function
to set promiscuous VLAN mode for VSI if mirror rule_type is
"VLAN Mirroring".
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_common.c| 162
Add the use of the new Shared MAC filter bit for multicast
and broadcast filters in order to make better use of the
filters available from the device. The FW folks have assured
that setting this bit on older FW will have no affect, so it
doesn't need a version check.
Signed-off-by: Helin Zhang
--
This patch fixes a problem where the NVMUpdate Tool, when
using the PHY NVM feature, gets bad data from the PHY because
of contention on the MDIO interface from get phy capability
calls from the driver during regular operations. The problem
is fixed by adding a check if media is available before ca
The device capabilities were defined in two places, and neither had
all the definitions. It really belongs with the AQ API definition,
so this patch removes the other set of definitions and fills out the
missing item.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_adminq_cmd.h | 1 +
The recently added opcodes should be available only with X722
SUPPORT, so move them into the #ifdef, and reorder these to be
in numerical order with the rest of the opcodes. Several structs
that were added are unnecessary, so they are removed here.
Signed-off-by: Helin Zhang
---
drivers/net/i40e
Add new Device ID's for backplane and QSFP+ adapters, and delete
deprecated one for backplane.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_common.c | 12 ++--
drivers/net/i40e/base/i40e_devids.h | 10 +-
2 files changed, 19 insertions(+), 3 deletions(-)
diff --git
In one obscure corner case, it was possible to clear the NVM update
wait flag when no update_done message was actually received. This
patch cleans the event descriptor before use, and moves the opcode
check to where it won't get done if there was no event to clean.
Signed-off-by: Helin Zhang
---
The standard way to check if the AQ is enabled is to look at the
count field. So it should only set this field after it has
successfully allocated memory. To do otherwise is to incite
panic among the populace.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_adminq.c | 4 ++--
1 file ch
It's possible that while waiting for the spinlock, another
entity (that owns the spinlock) has shut down the admin queue.
If it then attempts to use the queue, it will panic.
It adds a check for this condition on the receive side. This
matches an existing check on the send queue side.
Signed-off-b
XL710/X710 devices requires FW version checks to properly handle
DCB configurations from the FW while other devices (e.g. X722)
do not, so limit these checks to XL710/X710 only.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_dcb.c | 34 +-
1 file change
In X722, NVM reads can't be done through SRCTL registers.
And require AQ calls, which require grabbing the NVM lock.
Unfortunately some paths need the lock to be acquired once
and do a whole bunch of stuff and then release it.
This patch creates an unsafe version of the read calls, so
that it can b
Instead of doing the MAC check, use a flag that gets set per
MAC. This way there are less chances of user error and it
can enable multiple MACs with the capability in a single place
rather than cluttering the code with MAC checks.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_common.
It needs to acquire the NVM before issuing an AQ read to the
X722 NVM otherwise it will get EBUSY from the FW. Also release
when done.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_nvm.c | 35 +--
1 file changed, 29 insertions(+), 6 deletions(-)
diff
Current implementation generates compilation warnings.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_lan_hmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/base/i40e_lan_hmc.c
b/drivers/net/i40e/base/i40e_lan_hmc.c
index 6511767..2260648 1
i40e base driver is updated, to support new X722 device IDs, and
use rx control AQ commands to read/write rx control registers.
Of cause, fixes and enhancements are added as listed as below.
v3:
- As release_2_3.rst has been renamed to release_16_04.rst, then
all modifications in release_2_3.r
On Thu, Feb 18, 2016 at 03:39:26PM +0200, Panu Matilainen wrote:
> On 02/18/2016 03:25 PM, Yuanhan Liu wrote:
> >On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote:
> >>Commit d0cf91303d73 added dependency on librte_net headers to vhost
> >>but did not add this to the Makefile, which m
A malicious guest may easily forge some illegal vring desc buf.
To make our vhost robust, we need make sure desc->next will not
go beyond the vq->desc[] array.
Suggested-by: Rich Lane
Signed-off-by: Yuanhan Liu
---
lib/librte_vhost/vhost_rxtx.c | 15 +++
1 file changed, 11 insertion
We need make sure that desc->len is bigger than the size of virtio net
header, otherwise, unexpected behaviour might happen due to "desc_avail"
would become a huge number with for following code:
desc_avail = desc->len - vq->vhost_hlen;
For dequeue code path, it will try to allocate enou
VIRTIO_NET_F_MRG_RXBUF is a default feature supported by vhost.
Adding unlikely for VIRTIO_NET_F_MRG_RXBUF detection doesn't
make sense to me at all.
Signed-off-by: Yuanhan Liu
---
lib/librte_vhost/vhost_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_vhost/
First of all, rte_memcpy() is mostly useful for coping big packets
by leveraging hardware advanced instructions like AVX. But for virtio
net hdr, which is 12 bytes at most, invoking rte_memcpy() will not
introduce any performance boost.
And, to my suprise, rte_memcpy() is VERY huge. Since rte_memc
Current virtio_dev_merge_rx() implementation just looks like the
old rte_vhost_dequeue_burst(), full of twisted logic, that you
can see same code block in quite many different places.
However, the logic of virtio_dev_merge_rx() is quite similar to
virtio_dev_rx(). The big difference is that the m
This is a simple refactor, as there isn't any twisted logic in old
code. Here I just broke the code and introduced two helper functions,
reserve_avail_buf() and copy_mbuf_to_desc() to make the code more
readable.
Also, it saves nearly 1K bytes of binary code size.
Signed-off-by: Yuanhan Liu
---
The current rte_vhost_dequeue_burst() implementation is a bit messy
and logic twisted. And you could see repeat code here and there: it
invokes rte_pktmbuf_alloc() three times at three different places!
However, rte_vhost_dequeue_burst() acutally does a simple job: copy
the packet data from vring
Here is a patchset for refactoring vhost rxtx code, mainly for
improving readability.
The first 3 patches refactor 3 major functions at vhost_rxtx.c,
respectively. It simplifies the code logic, making it more readable.
On the other hand, it reduces binary code size, due to a lot of
duplicate code
On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote:
> Commit d0cf91303d73 added dependency on librte_net headers to vhost
> but did not add this to the Makefile, which makes builds
> non-deterministic. Curiously it is non-parallel build that is
> consistently broken by this missing dep
2016-02-18 21:25, Yuanhan Liu:
> On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote:
> > Commit d0cf91303d73 added dependency on librte_net headers to vhost
> > but did not add this to the Makefile, which makes builds
> > non-deterministic. Curiously it is non-parallel build that is
>
The variable AESNI_MULTI_BUFFER_LIB_PATH is not required for
make clean
Signed-off-by: Thomas Monjalon
---
drivers/crypto/aesni_mb/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/crypto/aesni_mb/Makefile b/drivers/crypto/aesni_mb/Makefile
index 3bf83d1..ec65291 100
Hi,
Some minor comments below in order to get a consistent set of release notes.
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Marc Sune
> Sent: Sunday, February 14, 2016 10:18 PM
> To: dev at dpdk.org; Lu, Wenzhuo ; Zhang, Helin
> ; Harish Patil ; Chen,
>
This patch add some options in tunnel_filter command to test IP in GRE packet
classification on i40e.
Signed-off-by: Xutao Sun
Signed-off-by: Jijiang Liu
---
app/test-pmd/cmdline.c | 36
1 file changed, 24 insertions(+), 12 deletions(-)
diff --git a/app/te
Signed-off-by: Xutao Sun
Signed-off-by: Jijiang Liu
---
drivers/net/i40e/i40e_ethdev.c | 32
1 file changed, 24 insertions(+), 8 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 7c22358..a33fef5 100644
--- a/drivers
Signed-off-by: Xutao Sun
Signed-off-by: Jijiang Liu
---
lib/librte_ether/rte_eth_ctrl.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_ether/rte_eth_ctrl.h b/lib/librte_ether/rte_eth_ctrl.h
index 30cbde7..0e948a1 100644
--- a/lib/librte_ether/rte_eth_ctrl.h
+++ b/lib/librte_ether
Change the fields of outer_mac and inner_mac from pointer to struct in order to
keep the code's readability.
Signed-off-by: Xutao Sun
Signed-off-by: Jijiang Liu
---
app/test-pmd/cmdline.c | 6 --
doc/guides/rel_notes/deprecation.rst | 5 -
doc/guides/rel_notes/relea
This patch set adds tunnel filter support for IP in GRE on i40e.
v2 changes:
Fix the byte order problem.
v3 changes:
Remove the deprecation notice and update the release notes.
v4 changes:
Modify the mistakes in cmdline.c in the old patch
Xutao Sun (4):
lib/ether: optimize the'rte_eth_t
On Wed, Feb 17, 2016 at 05:14:49PM +, Bruce Richardson wrote:
> On Fri, Jan 29, 2016 at 11:31:57AM +0100, Adrien Mazarguil wrote:
> > To preserve compatibility with Mellanox OFED 3.1, flow director and RX VLAN
> > stripping code is only enabled if compiled with 3.2.
> >
> This description woul
Hi Bruce,
On Wed, Feb 17, 2016 at 05:13:44PM +, Bruce Richardson wrote:
> On Fri, Jan 29, 2016 at 11:32:01AM +0100, Adrien Mazarguil wrote:
> > From: Yaacov Hazan
> >
> > Add support for flow director filters (RTE_FDIR_MODE_PERFECT and
> > RTE_FDIR_MODE_PERFECT_MAC_VLAN modes).
> >
> > This
Hello!
With the aforementioned fix (disabling src_ip_filter if zero) i've got the
patch series working. Now i have some more notes on
usability:
> 2)Start proc_info(runs as secondary process by default)application with new
> parameters for
> tcpdump.
> ex: sudo ./build/app/proc_info/dpdk_pro
On 02/18/2016 03:56 PM, Yuanhan Liu wrote:
> On Thu, Feb 18, 2016 at 03:39:26PM +0200, Panu Matilainen wrote:
>> On 02/18/2016 03:25 PM, Yuanhan Liu wrote:
>>> On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote:
Commit d0cf91303d73 added dependency on librte_net headers to vhost
>
On 15/02/16 16:45, Pablo de Lara wrote:
> cryptodev_aesni_mb_init was returning the device id of
> the device just created, but rte_eal_vdev_init
> (the function that calls the first one), was expecting 0 or
> negative value.
> This made impossible to create more than one aesni_mb device
> from com
On 02/18/2016 03:25 PM, Yuanhan Liu wrote:
> On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote:
>> Commit d0cf91303d73 added dependency on librte_net headers to vhost
>> but did not add this to the Makefile, which makes builds
>> non-deterministic. Curiously it is non-parallel build t
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara
> Sent: Thursday, February 18, 2016 3:21 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: add known clang compilation issues
>
> Add known issue about DPDK not compiling on some CPUs wit
Add known issue about DPDK not compiling on some CPUs
with clang versions older than 3.7.0.
Signed-off-by: Pablo de Lara
---
doc/guides/rel_notes/known_issues.rst | 20
1 file changed, 20 insertions(+)
diff --git a/doc/guides/rel_notes/known_issues.rst
b/doc/guides/rel_not
2016-02-18 10:18, Burakov, Anatoly:
> > > --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > > +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > > @@ -904,7 +904,7 @@ pci_vfio_enable(void)
> > >
> > > /* return 0 if VFIO modules not loaded */
> > > if (module_vfio_type1 == 0) {
> > > -
2016-02-18 10:55, Santosh Shukla:
> >> Acked-by: Anatoly Burakov
> >
> > Acked-by: David Marchand
> >
>
> Thomas, Can you pl. merge this patch?
I must merge the whole series but there are still some comments to address.
If you want to split the series, you're allowed to do it by re-sending a su
Hi Thomas,
> 2016-02-18 10:18, Burakov, Anatoly:
> > > > --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > > > +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > > > @@ -904,7 +904,7 @@ pci_vfio_enable(void)
> > > >
> > > > /* return 0 if VFIO modules not loaded */
> > > > if
It removes the i40evf_set_mac_type() defined in PMD, and reuses
i40e_set_mac_type() defined in base driver.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/i40e_ethdev_vf.c | 22 +-
1 file changed, 1 insertion(+), 21 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.
As required, rx control registers have to be read/written by
rx control functions, otherwise if may fail to read/write
when under stress small traffic.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/i40e_ethdev.c| 66 ---
drivers/net/i40e/i40e_ethdev_vf.c
It adds several new device IDs, and also removed one which is
not used at all.
Signed-off-by: Helin Zhang
---
doc/guides/rel_notes/release_2_3.rst| 91 +
drivers/net/i40e/i40e_ethdev.h | 2 +-
drivers/net/i40e/i40e_rxtx.c|
It adds base driver release information such as release date,
for better tracking in the future.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/Makefile b/drivers/net/i40e/Makefile
index 033ee4a..6dd6eaa 100644
--- a/
Several structures and macros are added or updated, such
as 'struct i40e_aqc_get_link_status',
'struct i40e_aqc_run_phy_activity' and
'struct i40e_aqc_lldp_set_local_mib_resp'.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_adminq_cmd.h | 45 ++---
drivers/
It adds the new AQ command and struct for managing a
thermal sensor.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_adminq_cmd.h | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h
b/drivers/net/i40e/base/i40e_adminq_cmd.h
in
X722 supports Expanded version of TCP, UDP PCTYPES for RSS.
Add a Virtchnl offload to support this.
Without this patch VF drivers will not be able to support
the correct PCTYPES for X722 and UDP flows will not fan out.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_virtchnl.h | 1 +
1
This patch adds 7 new register definitions for programming the
parser, flow director and RSS blocks in the HW.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_register.h | 48 +++
drivers/net/i40e/i40e_ethdev.c| 11 ++--
2 files changed, 50 i
RX control register read/write functions are added, as directly
read/write may fail when under stress small traffic. After the
adminq is ready, all rx control registers should be read/written
by dedicated functions.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_adminq_cmd.h | 16 +++
It adds coding style fixes.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_common.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/net/i40e/base/i40e_common.c
b/drivers/net/i40e/base/i40e_common.c
index 9a0b787..e94f726 100644
--- a/d
When updating a VSI, save off the number of allocated and
unallocated VSIs as we do when adding a VSI.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_common.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/i40e/base/i40e_common.c
b/drivers/net/i40e/base/i40e_co
When linking with particular PHY types (ex: copper PHY), the amount of
time it takes for the GLGEN_RSTAT_DEVSTATE to be set increases greatly,
which can lead to a timeout and failure to load the driver.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_common.c | 6 +++---
1 file changed
In MFP mode particularly when we were setting the PF VSI in limited
promiscuous, the HW switch was still mirroring the outgoing packets
from other VSIs (VF/VMdq) onto the PF VSI.
With this new bit set, the mirroring doesn't happen any more and so
we are in limited promiscuous on the PF VSI in MFP w
This patch adds functions to blink led on devices using
Coppervale PHY since MAC registers used in other designs
do not work in this device configuration.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_common.c| 329 +
drivers/net/i40e/base/i40e_pro
Add the support code for calling the AdminQ API call
aq_set_switch_config.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_adminq_cmd.h | 12
drivers/net/i40e/base/i40e_common.c | 28
drivers/net/i40e/base/i40e_prototype.h | 3 +++
3 file
With the latest firmware, statistics gathering can now be enabled and
disabled in the HW switch, so we need to add a parameter to allow the
driver to set it as desired. At the same time, the L2 cloud filtering
parameter has been removed as it was never used.
Older drivers working with the newer fir
This patch implements necessary functions related to port
mirroring features such as add/delete mirror rule, function
to set promiscuous VLAN mode for VSI if mirror rule_type is
"VLAN Mirroring".
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_common.c| 162
Add the use of the new Shared MAC filter bit for multicast
and broadcast filters in order to make better use of the
filters available from the device. The FW folks have assured
that setting this bit on older FW will have no affect, so it
doesn't need a version check.
Signed-off-by: Helin Zhang
--
This patch fixes a problem where the NVMUpdate Tool, when
using the PHY NVM feature, gets bad data from the PHY because
of contention on the MDIO interface from get phy capability
calls from the driver during regular operations. The problem
is fixed by adding a check if media is available before ca
The device capabilities were defined in two places, and neither had
all the definitions. It really belongs with the AQ API definition,
so this patch removes the other set of definitions and fills out the
missing item.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_adminq_cmd.h | 1 +
The recently added opcodes should be available only with X722
SUPPORT, so move them into the #ifdef, and reorder these to be
in numerical order with the rest of the opcodes. Several structs
that were added are unnecessary, so they are removed here.
Signed-off-by: Helin Zhang
---
drivers/net/i40e
Add new Device ID's for backplane and QSFP+ adapters, and delete
deprecated one for backplane.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_common.c | 12 ++--
drivers/net/i40e/base/i40e_devids.h | 10 +-
2 files changed, 19 insertions(+), 3 deletions(-)
diff --git
In one obscure corner case, it was possible to clear the NVM update
wait flag when no update_done message was actually received. This
patch cleans the event descriptor before use, and moves the opcode
check to where it won't get done if there was no event to clean.
Signed-off-by: Helin Zhang
---
The standard way to check if the AQ is enabled is to look at the
count field. So it should only set this field after it has
successfully allocated memory. To do otherwise is to incite
panic among the populace.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_adminq.c | 4 ++--
1 file ch
It's possible that while waiting for the spinlock, another
entity (that owns the spinlock) has shut down the admin queue.
If it then attempts to use the queue, it will panic.
It adds a check for this condition on the receive side. This
matches an existing check on the send queue side.
Signed-off-b
XL710/X710 devices requires FW version checks to properly handle
DCB configurations from the FW while other devices (e.g. X722)
do not, so limit these checks to XL710/X710 only.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_dcb.c | 34 +-
1 file change
In X722, NVM reads can't be done through SRCTL registers.
And require AQ calls, which require grabbing the NVM lock.
Unfortunately some paths need the lock to be acquired once
and do a whole bunch of stuff and then release it.
This patch creates an unsafe version of the read calls, so
that it can b
Instead of doing the MAC check, use a flag that gets set per
MAC. This way there are less chances of user error and it
can enable multiple MACs with the capability in a single place
rather than cluttering the code with MAC checks.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_common.
It needs to acquire the NVM before issuing an AQ read to the
X722 NVM otherwise it will get EBUSY from the FW. Also release
when done.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_nvm.c | 35 +--
1 file changed, 29 insertions(+), 6 deletions(-)
diff
Current implementation generates compilation warnings.
Signed-off-by: Helin Zhang
---
drivers/net/i40e/base/i40e_lan_hmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/base/i40e_lan_hmc.c
b/drivers/net/i40e/base/i40e_lan_hmc.c
index 6511767..2260648 1
i40e base driver is updated, to support new X722 device IDs, and
use rx control AQ commands to read/write rx control registers.
Of cause, fixes and enhancements are added as listed as below.
v2:
- Used i40e_set_mac_type() in base driver to replace the similar
in PMD source files, in order to s
On 02/18/2016 01:47 PM, Jan Viktorin wrote:
> This patch fixes the following build regression:
>
> lib/librte_vhost/vhost_rxtx.c: At top level:
> lib/librte_vhost/vhost_rxtx.c:41:20: fatal error: rte_ip.h: No such file or
> directory
> #include
> ^
> compi
This patch fixes the following build regression:
lib/librte_vhost/vhost_rxtx.c: At top level:
lib/librte_vhost/vhost_rxtx.c:41:20: fatal error: rte_ip.h: No such file or
directory
#include
^
compilation terminated.
Fixes: d0cf91303d73 ("vhost: add Tx off
Hello,
I've noticed a build regression for vhost library. See the log. I'll
send a fix for this very soon.
Regards
Jan
On 17/02/16 17:23, Bruce Richardson wrote:
> On Fri, Jan 29, 2016 at 04:47:58PM +, Paul Atkins wrote:
>> Hi Thomas,
>>
>> On 29/01/16 16:31, Thomas Monjalon wrote:
>>> Hi Paul,
>>>
>>> 2016-01-29 16:18, Paul Atkins:
This patchset adds functionality to the null driver help when testing
>>
Hi Xutao,
> -Original Message-
> From: Sun, Xutao
> Sent: Thursday, February 18, 2016 9:58 AM
> To: dev at dpdk.org
> Cc: Zhang, Helin; Wu, Jingjing; De Lara Guarch, Pablo; Sun, Xutao; Liu,
> Jijiang
> Subject: [PATCH v4 4/4] app/test-pmd: test tunnel filter for IP in GRE
>
> This patch
On Wed, Feb 17, 2016 at 11:50:22PM +0100, Thomas Monjalon wrote:
> Hi Yuanhan,
>
> 2015-12-03 14:06, Yuanhan Liu:
> > Vhost rxtx code is derived from vhost-switch example, which is very
> > likely the most messy code in DPDK. Unluckily, the move also brings
> > over the bad merits: twisted logic,
On Mon, Feb 15, 2016 at 02:16:16PM +0100, David Marchand wrote:
Hello,
>
> On Sun, Feb 14, 2016 at 4:25 AM, Wu, Jingjing
> wrote:
> >> -Original Message-
> >> From: David Marchand [mailto:david.marchand at 6wind.com]
> >> Having this infrastructure is one thing, but the initial problem w
Hi Cristian
Thanks for detailed response.
Your solution works so long as I have four queues in my current
implementation.
Following are the two issues I have now
1. I have 8 queues in the current implementation. This means I need to map
the existing 8 queues to two sets of 4 queues across two diff
1 - 100 of 141 matches
Mail list logo