Fix Maxime's mail.
On Fri, Nov 24, 2023 at 10:18:27AM +0100, Edwin Brossette wrote:
> Hello,
>
> I noticed a small inconsistency in the virtio pmd's xstats.
> The stat "rx_q0_errors" appears twice.
> I also think the stats "rx_q0_packets", "rx_q0_bytes", "tx_q0_packets" and
> "tx_q0_bytes" are du
Hello,
On Tue, Oct 17, 2023 at 04:35:50PM +, Konstantin Ananyev wrote:
>
> > >
> > > > On Tue, Oct 17, 2023 at 04:27:37PM +0200, Olivier Matz wrote:
> > > > > Unfortunatly I don't have enough time to undertake my maintainer role
> > >
Unfortunatly I don't have enough time to undertake my maintainer role at
the expected level. It will probably not going to get better anytime
soon, so remove myself from maintainers.
Signed-off-by: Olivier Matz
---
MAINTAINERS | 6 --
1 file changed, 6 deletions(-)
diff --git a/MAINTA
> Sent: Wednesday, July 26, 2023 11:25 AM
> > To: Olivier Matz
> > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Nithin
> > Kumar Dabilpuram ; Rakesh Kudurumalla
> >
> > Subject: [PATCH v2 1/1] app/test: resolve mbuf_test application failure
app/test: fix extern
Hi David,
On Tue, Aug 22, 2023 at 09:32:44AM +0200, David Marchand wrote:
> The L4 checksum offloading API does not require l4_len to be set.
> Make the driver discover the L4 headers size by itself.
>
> Fixes: 6546e76056e3 ("net/tap: calculate checksums of multi segs packets")
> Cc: sta...@dpdk.
Hello Julien,
On Tue, Aug 22, 2023 at 08:34:53AM +0200, jhascoet wrote:
> From: Julien Hascoet
>
> In case of ring full state, we retry the enqueue
> operation in order to avoid mbuf loss.
>
> Fixes: af75078fece ("first public release")
>
> Signed-off-by: Julien Hascoet
> ---
> app/test/test
Hi,
On Wed, Aug 16, 2023 at 01:33:46PM +0100, Bruce Richardson wrote:
> On Wed, Aug 16, 2023 at 01:40:41PM +0200, David Marchand wrote:
> > On Wed, Aug 16, 2023 at 1:15 PM David Marchand
> > wrote:
> > >
> > > On Wed, Aug 16, 2023 at 1:02 PM Bruce Richardson
> > > wrote:
> > > > These lines here
Hi Rakesh,
On Tue, May 23, 2023 at 03:39:53PM +, Rakesh Kudurumalla wrote:
> Ping
>
> Regards,
> Rakesh
>
> > -Original Message-
> > From: Rakesh Kudurumalla
> > Sent: Wednesday, April 26, 2023 2:58 PM
> > To: Olivier Matz
> > Cc: dev
don't think we need to Cc stable or add a "Fixes:" tag, as this
feature was not supported by any driver before your series.
Acked-by: Olivier Matz
> ---
> lib/net/rte_ip.h | 4 ++--
> lib/net/rte_net.h | 5 +++--
> 2 files changed, 5 insertions(+), 4 deletions(-)
&
Hi,
Sorry for the late feedback, please see some comments below.
To be honest, I have some doubts about the usefulness of the patch,
especially the function that strips all the MPLS headers.
On Sat, Feb 25, 2023 at 06:53:43PM +0500, Tanzeel-inline wrote:
> From: Tanzeel Ahmed
>
> This patch is
Hi Tyler,
Few comments below.
On Fri, Jun 02, 2023 at 12:45:07PM -0700, Tyler Retzlaff wrote:
> Replace the use of rte_atomic.h types and functions, instead use GCC
> supplied C++11 memory model builtins.
>
> Signed-off-by: Tyler Retzlaff
> Acked-by: Morten Brørup
> Acked-by: Bruce Richardson
> Fixes: 0fd1386c30c3 ("app/testpmd: cleanup cleanly from signal")
> Bugzilla ID: 1180
> Signed-off-by: Stephen Hemminger
Acked-by: Olivier Matz
Thank you
On Wed, Mar 15, 2023 at 10:31:32AM -0700, Stephen Hemminger wrote:
> The setting in terminal handling for both Unix style and
> Windows was not ensuring that Ctrl-C character would
> cause interrupt.
>
> This is a first release bug. Testpmd interactive mode has
> always disabled control-c handling
Hi Stephen,
Thank you for having a look at this.
On Wed, Mar 15, 2023 at 10:31:31AM -0700, Stephen Hemminger wrote:
> The cmdline library poll function is broken on Windows
> and was never tested, don't use it.
>
> Instead, use sigaction() to cancel read character on Unix OS's
> and a new helper
s_header=is_header@entry=1) at ../lib/mbuf/rte_mbuf.c:384
>384rte_panic("%s\n", reason);
>(gdb) p/d m->pkt_len
>$4 = 1500
>
> Fixes: efc6f9104c80 ("mbuf: fix reset on mbuf free")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Pavel Ivashchenko
Acked-by: Olivier Matz
Hello,
On Wed, Mar 15, 2023 at 11:29:50AM +0100, David Marchand wrote:
> Hello,
>
> On Mon, Mar 13, 2023 at 5:57 PM Pavel Ivashchenko
> wrote:
>
> app: fix mbuf_autotest in case of defined RTE_LIBRTE_MBUF_DEBUG
I suggest this title instead:
test/mbuf: fix mbuf autotest when mbuf debug is enabl
; But where there is no detailed definition of 'value' maybe NULL, so
-where
maybe -> may be
> this patch adds it.
>
> Cc: sta...@dpdk.org
>
> Signed-off-by: Chengwen Feng
With this:
Acked-by: Olivier Matz
Thanks!
> ---
> lib/kvargs/rte_kvargs.h | 14
On Mon, Feb 27, 2023 at 10:48:09AM +0100, Morten Brørup wrote:
> > From: Olivier Matz [mailto:olivier.m...@6wind.com]
> > Sent: Monday, 27 February 2023 10.10
> >
> > Hi,
> >
> > On Sun, Feb 26, 2023 at 11:45:48AM +0100, Morten Brørup wrote:
> > >
Hi,
On Sun, Feb 26, 2023 at 11:45:48AM +0100, Morten Brørup wrote:
> > From: Harris, James R [mailto:james.r.har...@intel.com]
> > Sent: Friday, 24 February 2023 17.43
> >
> > > On Feb 24, 2023, at 6:56 AM, Honnappa Nagarahalli
> > wrote:
> > >
> > >> From: Morten Brørup
> > >> Sent: Friday, Fe
Hello,
Thank you for this work, and sorry for the late feedback too.
On Mon, Feb 13, 2023 at 04:29:51AM +, Honnappa Nagarahalli wrote:
>
>
> > > > +/**
> > > > + * @internal used by rte_mempool_cache_zc_put_bulk() and
> > > > rte_mempool_do_generic_put().
> > > > + *
> > > > + * Zero-copy p
Hello Zhichao,
Sorry for the delayed response.
On Thu, Jan 12, 2023 at 05:26:08PM +0800, Zhichao Zeng wrote:
> Add UDP pseudo-header processing for UDP segmentation offload
> by adding the UDP_SEG flag.
>
> Signed-off-by: Zhichao Zeng
> ---
> lib/net/rte_ip.h | 2 +-
> 1 file changed, 1 insert
> > +#include
> > >
> > > -#define OBJ_NAME_LEN_MAX 64
> > > +#define OBJ_NAME_LEN_MAX sizeof(cmdline_fixed_string_t)
> > >
> > > struct object {
> > > SLIST_ENTRY(object) next;
> >
> > I confirm it solves the build warni
Hi,
On Tue, Nov 15, 2022 at 08:35:02PM +0800, Fengnan Chang wrote:
> rte_mempool_create put tailq entry into rte_mempool_tailq list before
> populate, and pool_data set when populate. So in multi process, if
> process A create mempool, and process B can get mempool through
> rte_mempool_lookup bef
Hi,
On Tue, Nov 15, 2022 at 08:47:15AM +0100, David Marchand wrote:
> On Tue, Nov 15, 2022 at 2:51 AM Fengnan Chang
> wrote:
> >
> > David Marchand 于2022年11月15日周二 04:44写道：
> > >
> > > On Mon, Nov 14, 2022 at 9:13 AM changfengnan
> > > wrote:
> > > >
> > > > rte_mempool_create put tailq entry i
On Thu, Oct 27, 2022 at 02:11:29PM +0200, Morten Brørup wrote:
> > From: Olivier Matz [mailto:olivier.m...@6wind.com]
> > Sent: Thursday, 27 October 2022 13.43
> >
> > On Thu, Oct 27, 2022 at 11:22:07AM +0200, Morten Brørup wrote:
> > > > From: Olivier
On Thu, Oct 27, 2022 at 11:22:07AM +0200, Morten Brørup wrote:
> > From: Olivier Matz [mailto:olivier.m...@6wind.com]
> > Sent: Thursday, 27 October 2022 10.35
> >
> > Hi Morten,
> >
> > On Wed, Oct 26, 2022 at 04:44:36PM +0200, Morten Brørup wrote:
>
s are not returned immediatly
to the pool, they may stay in the hw tx ring during some time, which is
a driver decision.
After processing traffic on cores 8 and 24 with this testpmd, I get:
cache_count[0]=231
cache_count[8]=123
cache_count[24]=122
In my opinion, it is not realistic to
D: 1105
Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by default")
Signed-off-by: Olivier Matz
---
v2:
* fix typo (-SOCKET_ID_ANY instead of SOCKET_ID_ANY)
app/test/test_pmd_perf.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/app
D: 1105
Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by default")
Signed-off-by: Olivier Matz
---
app/test/test_pmd_perf.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c
index fe765c
On Fri, Oct 14, 2022 at 04:02:02PM +0200, Olivier Matz wrote:
> Hi Robin,
>
> On Thu, Oct 13, 2022 at 03:41:25PM +0200, Robin Jarry wrote:
> > Some environments (buildroot) do not have the ldd utility installed by
> > default. However, ldd is often only a wrapper shell
Add the queue id and/or the port id in some logs, so it is easier to
understand what happens.
Signed-off-by: Olivier Matz
Reviewed-by: Maxime Coquelin
---
v2
* use %u instead of %d for unsigned types
drivers/net/virtio/virtio_ethdev.c | 6 --
drivers/net/virtio/virtio_rxtx.c | 3 ++-
2
Hi Chenbo,
On Mon, Oct 17, 2022 at 06:58:59AM +, Xia, Chenbo wrote:
> Hi Olivier,
>
> > -Original Message-
> > From: Olivier Matz
> > Sent: Thursday, September 29, 2022 8:22 PM
> > To: dev@dpdk.org
> > Cc: Maxime Coquelin ; Xia, Chenbo
> >
The log should display the value, not the id.
Fixes: e21df4b062b5 ("test/eventdev: add SW xstats tests")
Cc: sta...@dpdk.org
Signed-off-by: Olivier Matz
---
drivers/event/sw/sw_evdev_selftest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/driver
w id.
Bugzilla ID: 1101
Fixes: e21df4b062b5 ("test/eventdev: add SW xstats tests")
Cc: sta...@dpdk.org
Signed-off-by: Olivier Matz
---
drivers/event/sw/sw_evdev_selftest.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/event/sw/sw_evdev_selftest.c
b/drivers/event/sw/sw_evdev_selfte
On Fri, Oct 14, 2022 at 05:57:39PM +0200, Morten Brørup wrote:
> > From: Olivier Matz [mailto:olivier.m...@6wind.com]
> > Sent: Friday, 14 October 2022 16.01
> >
> > Hi Morten, Andrew,
> >
> > On Sun, Oct 09, 2022 at 05:08:39PM +0200, Morten Brørup w
nge dpdk-pmdinfo.py to actually "execute" the files provided on the
> command line with LD_TRACE_LOADED_OBJECTS=1 set. Ensure that the files
> are valid dynamically executable ELF programs to avoid obscure and
> confusing errors.
>
> Reported-by: Olivier Matz
> Signed-off-by: Robin Jarry
Tested on buildroot without ldd.
Reviewed-by: Olivier Matz
On Sat, Oct 08, 2022 at 10:56:06PM +0200, Thomas Monjalon wrote:
> 07/10/2022 12:44, Andrew Rybchenko:
> > From: Morten Brørup
> >
> > A flush threshold for the mempool cache was introduced in DPDK version
> > 1.3, but rte_mempool_do_generic_get() was not completely updated back
> > then, and som
On Sun, Oct 09, 2022 at 04:44:08PM +0200, Morten Brørup wrote:
> > From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru]
> > Sent: Sunday, 9 October 2022 15.38
> > To: Olivier Matz
> > Cc: dev@dpdk.org; Morten Brørup; Bruce Richardson
> > Subject: [PATC
to avoid needless emptying of cache.
> > > - */
> > > - void *objs[RTE_MEMPOOL_CACHE_MAX_SIZE * 3]; /**< Cache objects */
> > > + /**
> > > + * Cache objects
> > > + *
> > > + * Cache is allocated to this size to allow it to overflow in
> > certain
> > > + * cases to avoid needless emptying of cache.
> > > + */
> > > + void *objs[RTE_MEMPOOL_CACHE_MAX_SIZE * 2] __rte_cache_aligned;
> > > } __rte_cache_aligned;
> >
> > I think aligning objs on cacheline should be a separate patch.
>
> Good point. I'll let you do it. :-)
>
> PS: Thank you for following up on this patch series, Andrew!
Many thanks for this rework.
Acked-by: Olivier Matz
Hi Wenjun,
On Mon, Oct 10, 2022 at 01:30:54AM +, Wu, Wenjun1 wrote:
> Hi Olivier,
>
> > -Original Message-
> > From: Olivier Matz
> > Sent: Thursday, September 29, 2022 8:22 PM
> > To: dev@dpdk.org
> > Cc: Yang, Qiming ; Wu, Wenjun1
> > ; Zh
e pyelftools 0.26. The script
> > will only work with Python 3.6 and later.
> >
> > Update the minimal system requirements, docs and release notes.
> >
> > Signed-off-by: Robin Jarry
> > Tested-by: Ferruh Yigit
> > Tested-by: Olivier Matz
> > Ac
| 26 +--
> lib/mbuf/rte_mbuf_dyn.c | 3 ++
> lib/meson.build | 3 ++
> lib/pipeline/rte_table_action.c | 2 +-
> lib/vhost/vhost.h| 2 +-
> lib/vhost/vhost_crypto.c | 25 ++-
> meson_options.txt| 2 +
> 60 files changed, 210 insertions(+), 151 deletions(-)
>
> --
> 2.25.1
>
for the series:
Acked-by: Olivier Matz
There are few minor comments but I think it can go in rc1 anyway.
On Wed, Sep 21, 2022 at 07:26:20PM +0530, Shijith Thotton wrote:
> Enabled the flag pmd_iova_as_va in cnxk driver build files as they work
> with IOVA as VA. Updated cn9k and cn10k soc build configurations to
> enable the IOVA as VA build by default.
>
> Signed-off-by: Shijith Thotton
> ---
> co
On Sat, Oct 08, 2022 at 01:00:24AM +0530, Shijith Thotton wrote:
> Used rte_mbuf_data_iova API to get the physical address of mbuf data.
>
> Signed-off-by: Shijith Thotton
> ---
> app/test/test_dmadev.c | 33 ++---
> 1 file changed, 14 insertions(+), 19 deletions(-)
>
Hi,
On Sat, Oct 08, 2022 at 01:00:23AM +0530, Shijith Thotton wrote:
> Added APIs rte_mbuf_iova_set and rte_mbuf_iova_get to set and get the
> physical address of an mbuf respectively. Updated applications and
> library to use the same.
>
> Signed-off-by: Shijith Thotton
> ---
> app/test-bbdev/
Hi David,
On Wed, Oct 05, 2022 at 10:52:49AM +0200, David Marchand wrote:
> On Tue, Oct 4, 2022 at 4:59 PM Olivier Matz wrote:
> >
> > The dev->device.numa_node field is set by each bus driver for
> > every device it manages to indicate on which NUMA node this device
ers
when the NUMA information is unavailable. This change impacts
rte_eth_dev_socket_id() in the same manner.
Signed-off-by: Olivier Matz
---
v2
* use SOCKET_ID_ANY instead of -1 in drivers/dma/idxd (David)
* document the behavior change of rte_eth_dev_socket_id()
* fix few examples wh
On Fri, Sep 30, 2022 at 09:10:55AM +0200, David Marchand wrote:
> On Thu, Sep 29, 2022 at 2:05 PM Olivier Matz wrote:
> >
> > The dev->device.numa_node field is set by each bus driver for
> > every device it manages to indicate on which NUMA node this device lies.
> >
ss support")
Signed-off-by: Olivier Matz
---
lib/eal/include/rte_memzone.h | 3 ---
lib/mbuf/rte_mbuf.h | 3 ---
lib/mempool/rte_mempool.h | 1 -
lib/ring/rte_ring.h | 1 -
lib/ring/rte_ring_elem.h | 1 -
5 files changed, 9 deletions(-)
diff --git a/
Add the queue id and/or the port id in some logs, so it is easier to
understand what happens.
Signed-off-by: Olivier Matz
---
drivers/net/virtio/virtio_ethdev.c | 6 --
drivers/net/virtio/virtio_rxtx.c | 3 ++-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/net
This function is not defined, remove its declaration.
Fixes: c1f86306a026 ("virtio: add new driver")
Signed-off-by: Olivier Matz
---
drivers/net/virtio/virtqueue.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtque
- restorting the proper mode (none or allmulti) when we disable
promiscuous mode
Fixes: 1f4564ed7696 ("net/ixgbevf: enable promiscuous mode")
Signed-off-by: Olivier Matz
---
Hi,
For reference, this was tested with this plan:
echo 8 > "/sys/bus/pci/devices/:01:00.1/sriov_numvf
ixgbe: support VF promiscuous by PF driver")
Link:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7bb0fb7c63df
Signed-off-by: Olivier Matz
---
drivers/net/ixgbe/ixgbe_pf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
default in ixgbe_vf_reset_event() on VF reset.
A similar patch was accepted in Linux kernel (see link).
Fixes: 0355c379b71f ("net/ixgbe: support VF promiscuous by PF driver")
Link:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=803e9895ea2b
Signed-off-b
These 2 patches have been submitted and accepted to the kernel (see
links in the patches).
They also apply smoothly to DPDK, however I didn't have the opportunity
to test them with a PF managed by DPDK.
Given this is exactly the same code, I think it could be applied anyway.
Olivier Ma
ers
when the NUMA information is unavailable.
Signed-off-by: Olivier Matz
---
doc/guides/rel_notes/deprecation.rst | 7 ---
doc/guides/rel_notes/release_22_11.rst | 6 ++
drivers/bus/auxiliary/auxiliary_common.c | 8 ++--
drivers/bus/auxiliary/linux/auxiliary.c |
The CDEV_LOG_* macros already add a '\n' at the end of
the line. Remove it from format strings to avoid duplicated
newlines.
Signed-off-by: Olivier Matz
---
lib/cryptodev/cryptodev_pmd.c | 4 ++--
lib/cryptodev/cryptodev_pmd.h | 2 +-
lib/cryptodev/rte_crypto
ines to checkpatch.pl.
The problem is visible since the introduction of this check in linux
checkpatch.pl in version 4.19 (see link below).
Link:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cd2614967d8b
Fixes: 8005feef421d ("scripts: add standard input to
On Thu, Sep 29, 2022 at 06:19:32AM +, Shijith Thotton wrote:
> >> Enabled the flag pmd_iova_as_va in cnxk driver build files as they work
> >> with IOVA as VA. Updated cn9k and cn10k soc build configurations to
> >> enable the IOVA as VA build by default.
> >>
> >> Signed-off-by: Shijith Thotto
n other libs could include this rte_cman.h without
> > > > > having a
> > > > > strong dependency on ethdev.
> > > > >
> > > > > Deal?
> > > > >
> > > > Would rte_net also be an option? Alternatively, is thi
On Wed, Sep 28, 2022 at 05:52:51PM +0530, Akhil Goyal wrote:
> Added MACsec protocol header to be used for supporting
> MACsec protocol offload in hardware or directly in the application.
>
> Signed-off-by: Akhil Goyal
Acked-by: Olivier Matz
Thanks
On Wed, Sep 21, 2022 at 07:26:20PM +0530, Shijith Thotton wrote:
> Enabled the flag pmd_iova_as_va in cnxk driver build files as they work
> with IOVA as VA. Updated cn9k and cn10k soc build configurations to
> enable the IOVA as VA build by default.
>
> Signed-off-by: Shijith Thotton
> ---
> co
On Wed, Sep 21, 2022 at 07:26:19PM +0530, Shijith Thotton wrote:
> Swapped position of mbuf next pointer and second dynamic field (dynfield2)
> if the build is configured to use IOVA as VA. This is to move the mbuf
> next pointer to first cache line. kni library is disabled for this
> change as it
On Wed, Sep 28, 2022 at 09:24:51AM +0200, Thomas Monjalon wrote:
> 21/09/2022 15:56, Shijith Thotton:
> > mbuf physical address field is not used in builds which only uses VA. It
> > is used to expand the dynamic field area.
> >
> > Signed-off-by: Shijith Thotton
>
> We cannot condition the use
Hi,
On Wed, Sep 21, 2022 at 07:26:18PM +0530, Shijith Thotton wrote:
> mbuf physical address field is not used in builds which only uses VA. It
> is used to expand the dynamic field area.
>
> Signed-off-by: Shijith Thotton
> ---
> lib/mbuf/rte_mbuf_core.h | 26 +-
> lib/
On Wed, Sep 21, 2022 at 07:26:17PM +0530, Shijith Thotton wrote:
> IOVA mode in DPDK is either PA or VA. The new build option iova_as_va
> configures the mode to VA at compile time and prevents setting it to PA
> at runtime. For now, all drivers which are not always enabled are
> disabled with this
Hi Shijith,
On Wed, Sep 21, 2022 at 07:26:16PM +0530, Shijith Thotton wrote:
> This is a continuation of the discussions[1] to add mbuf physical address
> field to dynamic field.
> Previous version was to add PA field to dynamic field area based on the EAL
> IOVA mode option. It was
> deemed uns
Hi Akhil,
Few comments below.
On Mon, Aug 15, 2022 at 12:16:18AM +0530, Akhil Goyal wrote:
> Added MACsec protocol header to be used for supporting
> MACsec protocol offload in hardware or directly in the application.
>
> Signed-off-by: Akhil Goyal
> ---
> doc/api/doxy-api-index.md | 3 ++-
>
support is only available since pyelftools 0.26. The script
> will only work with Python 3.6 and later. Update the minimal system
> requirements, docs and release notes.
>
> Cc: Olivier Matz
> Cc: Ferruh Yigit
> Cc: Bruce Richardson
> Signed-off-by: Robin Jarry
Tested-by: Olivier Matz
On Mon, Aug 22, 2022 at 05:26:34PM +0200, David Marchand wrote:
> On Fri, Aug 5, 2022 at 10:03 AM Andrew Rybchenko
> wrote:
> >
> > Remove deprecated ``PKT_*`` flags. Use corresponding flags with
> > ``RTE_MBUF_F_`` prefix instead.
> >
> > Signed-off-by: Andre
l.h | 14 --
> > 3 files changed, 11 insertions(+), 25 deletions(-)
For the series,
Acked-by: Olivier Matz
Thanks
Olivier
construct/lib/container.py", line 5, in
> from collections import MutableMapping
> ImportError: cannot import name 'MutableMapping' from 'collections'
>
> Python 3.10 support is only available since pyelftools 0.26. The script
> will only work with Python 3.6 and later. Update the minimal system
> requirements and release notes.
>
> NB: The output produced by the legacy -r/--raw flag can be obtained with
> the following command:
>
> strings build/app/dpdk-testpmd | sed -n 's/^PMD_INFO_STRING= //p'
>
> Cc: Olivier Matz
> Cc: Ferruh Yigit
> Cc: Bruce Richardson
> Signed-off-by: Robin Jarry
Tested-by: Olivier Matz
Hi Morten,
Yes, you are right. These 2 conditions are also needed if one wants to use
rte_mbuf_raw_free() or rte_mempool_put*() functions to free the mbufs.
Olivier
On Thu, Jul 14, 2022 at 12:46:24PM +0200, Morten Brørup wrote:
> Looking at rte_pktmbuf_prefree_seg() [1], the list of described re
tps://patches.dpdk.org/project/dpdk/patch/20211026090610.10823-1-houssem.bouh...@6wind.com/
Signed-off-by: Olivier Matz
---
doc/guides/rel_notes/deprecation.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst
b/doc/guides/rel_notes/deprecation.rst
in
ze.
>
> Performance impact seems to range from none to a very slight
> regression.
>
> Bugzilla ID: 1035
> Cc: sta...@dpdk.org
Fixes: 6006818cfb26 ("net: new checksum functions")
> ---
>
> v3:
> * Use RTE_ALIGN_FLOOR() in the pointer arithmeti
off-by: Mattias Rönnblom
Acked-by: Olivier Matz
Thank you!
On Mon, Jul 11, 2022 at 10:42:37AM +, Mattias Rönnblom wrote:
> On 2022-07-11 11:47, Olivier Matz wrote:
> > Hi Mattias,
> >
> > Please see few comments below.
> >
> > On Fri, Jul 08, 2022 at 02:56:07PM +0200, Mattias Rönnblom wrote:
> >> Add perform
Hi,
On Fri, Jul 08, 2022 at 02:56:08PM +0200, Mattias Rönnblom wrote:
> __rte_raw_cksum() (used by rte_raw_cksum() among others) accessed its
> data through an uint16_t pointer, which allowed the compiler to assume
> the data was 16-bit aligned. This in turn would, with certain
> architectures and
1 +
> app/test/test_cksum_perf.c | 118 +
> 3 files changed, 120 insertions(+)
> create mode 100644 app/test/test_cksum_perf.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c923712946..2a4c99e05a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@
Hi,
On Thu, Jun 30, 2022 at 05:55:21PM +0100, Bruce Richardson wrote:
> On Thu, Jun 30, 2022 at 09:55:16PM +0530, Shijith Thotton wrote:
> > If all devices are configured to run in IOVA mode as VA, physical
> > address field of mbuf (buf_iova) won't be used. In such cases, buf_iova
> > space is fr
On Fri, Jun 10, 2022 at 03:08:49PM +0100, Bruce Richardson wrote:
> On Tue, Jun 07, 2022 at 10:08:30AM +0200, Olivier Matz wrote:
> > Hi Bruce,
> >
> > Just few minor comments below.
> >
> > On Fri, May 20, 2022 at 04:12:39PM +0100, Bruce Richardson wrote:
> &
Members Attending
=
9/11
- Aaron
- Bruce
- Hemant
- Jerin
- Kevin
- Maxime
- Olivier (chair)
- Stephen
- Thomas
NOTE: The technical board meetings are on every second Wednesday at
https://meet.jit.si/DPDK at 3 pm UTC. Meetings are public, and DPDK
community members are welcome to
"test: take test names from command line")
> Bugzilla ID: 1002
>
> Signed-off-by: Bruce Richardson
Acked-by: Olivier Matz
_parse_check(struct cmdline *cl, const char *buf);
> +
> /**
> * complete() must be called with *state==0 (try to complete) or
> * with *state==-1 (just display choices), then called without
> diff --git a/lib/cmdline/version.map b/lib/cmdline/version.map
> index b9bbb87510..fc7fdd6ea4 100644
> --- a/lib/cmdline/version.map
> +++ b/lib/cmdline/version.map
> @@ -81,5 +81,8 @@ EXPERIMENTAL {
> rdline_get_history_buffer_size;
> rdline_get_opaque;
>
> + # added in 22.07
> + cmdline_parse_check;
> +
> local: *;
> };
> --
> 2.34.1
>
With these changes:
Acked-by: Olivier Matz
;
> > >> Enable printing of the outer vlan if flags indicate it is present.
> > >>
> > >> Signed-off-by: Ben Magistro
Acked-by: Olivier Matz
> > >>
> > >> ---
> > >>
> > >> While troubleshooting some QinQ offload
r, so we can simply remove
> strlen().
>
> Fixes: 7b295dceea07 ("test/mbuf: add unit test cases")
> Cc: sta...@dpdk.org
>
> Signed-off-by: David Marchand
Acked-by: Olivier Matz
Hi Tianli,
On Wed, Nov 10, 2021 at 11:57:19PM +0800, Tianli Lai wrote:
> the primary program(such as ofp app) run first, then run the secondary
> program(such as dpdk-pdump), the primary program would receive signal
> SIGSEGV. the function stack as follow:
>
> aived signal SIGSEGV, Segmentation f
Hi,
On Tue, Jan 11, 2022 at 05:45:49PM +0100, Thomas Monjalon wrote:
> 14/12/2021 08:56, Gaoxiang Liu:
> > Because dynamic fields are registered by the DPDK application,
> > so it is up to the application to decide whether to copy the value of
> > dynamic fields.
> > So delete dynamic fields copy
Hi Morten,
On Mon, Jan 24, 2022 at 06:20:49PM +0100, Morten Brørup wrote:
> > From: Olivier Matz [mailto:olivier.m...@6wind.com]
> > Sent: Monday, 24 January 2022 16.00
> >
> > From: Morten Brørup
> >
> > "What gets measured gets done."
> >
Hi Zhiheng,
Thank you for your patch proposal.
On Thu, Dec 23, 2021 at 10:07:41AM +, Zhiheng Chen wrote:
> In rte_mempool_ring.c, the committer uses the symbol ENOBUFS to
> describe the return value of function common_ring_sc_dequeue,
> but in rte_mempool.h, the symbol ENOENT is used to descr
On Mon, Jan 24, 2022 at 04:38:58PM +0100, Olivier Matz wrote:
> On Fri, Jan 14, 2022 at 05:36:50PM +0100, Morten Brørup wrote:
> > --- a/lib/mempool/rte_mempool.h
> > +++ b/lib/mempool/rte_mempool.h
> > @@ -1443,6 +1443,10 @@ rte_mempool_put(struct rte_m
On Mon, Jan 10, 2022 at 09:40:48AM +, Bruce Richardson wrote:
> On Sat, Jan 08, 2022 at 12:00:17PM +0100, Morten Brørup wrote:
> > > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > > Sent: Friday, 7 January 2022 16.12
> > >
> > > On Tue, Dec 28, 2021 at 03:28:45PM +0100, Morten
Hi Morten,
On Wed, Jan 19, 2022 at 04:03:01PM +0100, Morten Brørup wrote:
> mempool: fix put objects to mempool with cache
>
> This patch optimizes the rte_mempool_do_generic_put() caching algorithm,
> and fixes a bug in it.
I think we should avoid grouping fixes and optimizations in one
patch.
Hi Morten,
Few comments below.
On Fri, Jan 14, 2022 at 05:36:50PM +0100, Morten Brørup wrote:
> A flush threshold for the mempool cache was introduced in DPDK version
> 1.3, but rte_mempool_do_generic_get() was not completely updated back
> then, and some inefficiencies were introduced.
>
> This
ate_persec=917582643
get_bulk=32 put_bulk=32 keep=32 constant_n=false rate_persec=871248691
get_bulk=32 put_bulk=32 keep=32 constant_n=true rate_persec=1134021836
Signed-off-by: Morten Brørup
Signed-off-by: Olivier Matz
---
Hi Morten,
Here is the updated patch.
I launched the mempool_perf on
On Mon, Jan 24, 2022 at 03:53:09PM +0100, Olivier Matz wrote:
> From: Morten Brørup
>
> "What gets measured gets done."
>
> This patch adds mempool performance tests where the number of objects to
> put and get is constant at compile time, which may significantly
ate_persec=917582643
get_bulk=32 put_bulk=32 keep=32 constant_n=false rate_persec=871248691
get_bulk=32 put_bulk=32 keep=32 constant_n=true rate_persec=1134021836
Signed-off-by: Morten Brørup
Signed-off-by: Olivier Matz
---
Hi Morten,
Here is the updated patch.
I launched the mempool_perf on
Hi Morten,
Thank you for enhancing the mempool test. Please see some comments
below.
On Wed, Jan 19, 2022 at 12:37:32PM +0100, Morten Brørup wrote:
> "What gets measured gets done."
>
> This patch adds mempool performance tests where the number of objects to
> put and get is constant at compile
On Thu, Jan 06, 2022 at 11:50:54AM +0100, Morten Brørup wrote:
> > From: Olivier Matz [mailto:olivier.m...@6wind.com]
> > Sent: Thursday, 6 January 2022 10.49
>
> Thank you for the thorough explanation, Olivier.
>
> Somewhat exotic scenarios, but they do make sense
#x27;<'.
>
> This is not a functional error since we fall back to the loop with
> correct checks on indexes. Just a minor suboptimal behaviour for the
> case when we want to enqueue/dequeue exactly the number of elements that
> we have in the ring before wrapping to its beginni
1 - 100 of 1001 matches
Mail list logo
