Re: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe

2018-08-09 Thread Ferruh Yigit
On 7/24/2018 3:36 AM, Wei Zhao wrote: > There is CRC related ifdefs for ixgbe: > CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=n > It is used in VF drivers ixgbevf_dev_configure() functions. > VF cannot change the CRC strip behavior and based on what PF > configured it needs to response proper to us

Re: [dpdk-dev] How to run tests

2018-08-09 Thread Burakov, Anatoly
On 08-Aug-18 9:10 PM, Vivian Kong wrote: Hi everyone, Got a newbie question - I was able to build the source with `make install DESTDIR=~/dpdk-install T=x86_64-native-linuxapp-gcc`. How do I go about running the tests? I looked into the directory "x86_64-native-linuxapp-gcc" but I didn't see

Re: [dpdk-dev] Questions about TX descriptors run out occasionally

2018-08-09 Thread Bruce Richardson
On Thu, Jul 26, 2018 at 07:13:50PM -0700, Hui Liu wrote: > Hi Experts, > > I'm developing my own dpdk-based application via Intel 82599ES port. My > Application is doing a job to send ICMP requests (packet size varies from > 64 bytes to 1472 bytes, 200,000 pps, 1.1Gbps) and receive responses, with

Re: [dpdk-dev] [PATCH 1/1] kni: fix segfault in rte_kni_get

2018-08-09 Thread Ferruh Yigit
On 6/28/2018 11:58 PM, Dan Gora wrote: > Fix a segmentation fault which occurs when the kni_autotest is run > in the 'test' application. > > This segmenation fault occurs when rte_kni_get() is called with a > NULL value for 'name'. > > Fixes: 0c6bc8ef70ba ("kni: memzone pool for alloc and release

Re: [dpdk-dev] [PATCH 1/1] kni: fix segfault in rte_kni_get

2018-08-09 Thread Thomas Monjalon
09/08/2018 11:44, Ferruh Yigit: > On 6/28/2018 11:58 PM, Dan Gora wrote: > > Fix a segmentation fault which occurs when the kni_autotest is run > > in the 'test' application. > > > > This segmenation fault occurs when rte_kni_get() is called with a > > NULL value for 'name'. > > > > Fixes: 0c6bc8

Re: [dpdk-dev] [PATCH] kni: fix build on RHEL 7.5

2018-08-09 Thread Ferruh Yigit
On 8/6/2018 1:06 PM, Drocula wrote: > Signed-off-by: Drocula +1 for fixing build error, hence Acked-by: Ferruh Yigit But it would be better to have more detail on the build error, why and when this change required in RedHat side, it would be good if this information can make on time, but not I

Re: [dpdk-dev] [PATCH] net/mlx5: fix minimum size of Multi-Packet Rx queue

2018-08-09 Thread Thomas Monjalon
08/08/2018 21:32, Yongseok Koh: > The size of Rx queue is determined by dividing the number of descriptors by > the number of strides. As device can't support single slot queue, if the > number of descriptors is same as the number of strides, MPRQ shouldn't be > enabled. Otherwise, this will cause

[dpdk-dev] [PATCH] kni: fix kni rx fifo producer synchronization

2018-08-09 Thread Kiran Kumar
With existing code in kni_fifo_put, rx_q values are not being updated before updating fifo_write. While reading rx_q in kni_net_rx_normal, This is causing the sync issue on other core. So adding a write barrier to make sure the values being synced before updating fifo_write. Fixes: 3fc5ca2f6352 ("

Re: [dpdk-dev] [PATCH] kni: fix build on RHEL 7.5

2018-08-09 Thread Drocula
This patch Fix compilation errors on Centos 7.4 when CONFIG_RTE_KNI_KMOD_ETHTOOL is set to 'y'. On Thu, Aug 9, 2018, 17:59 Ferruh Yigit wrote: > On 8/6/2018 1:06 PM, Drocula wrote: > > Signed-off-by: Drocula > > +1 for fixing build error, hence > Acked-by: Ferruh Yigit > > But it would be bett

Re: [dpdk-dev] [PATCH] kni: fix build on RHEL 7.5

2018-08-09 Thread Drocula
Sorry for my mistake, This patch fixes compilation errors on Centos 7.5 when CONFIG_RTE_KNI_KMOD_ETHTOOL is set to 'y'. On RHEL75 ndo_change_mtu has changed to ndo_change_mtu_rh74. See commit 37d477b6863e5c06e20be434b559d3a03d89f46a -- Drocula Lambda Thanks On Aug 9, 2018 18:25, "Drocula" wro

Re: [dpdk-dev] [PATCH] bus/pci: check if 5-level paging is enabled when testing IOMMU address width

2018-08-09 Thread Burakov, Anatoly
On 05-Aug-18 7:41 PM, Drocula wrote: The kernel version 4.14 released with the support of 5-level paging. When PML5 enabled, user-space virtual addresses uses up to 56 bits. see kernel's Documentation/x86/x86_64/mm.txt. Signed-off-by: Drocula --- drivers/bus/pci/linux/pci.c | 27 +

Re: [dpdk-dev] [PATCH] kni: fix kni rx fifo producer synchronization

2018-08-09 Thread Ferruh Yigit
On 8/9/2018 11:23 AM, Kiran Kumar wrote: > With existing code in kni_fifo_put, rx_q values are not being updated > before updating fifo_write. While reading rx_q in kni_net_rx_normal, > This is causing the sync issue on other core. So adding a write > barrier to make sure the values being synced be

[dpdk-dev] [PATCH v1] doc: update release notes for 18.08

2018-08-09 Thread John McNamara
Fix grammar, spelling and formatting of DPDK 18.08 release notes. Signed-off-by: John McNamara --- Note, I removed the following unused sections of the doc: * ABI Changes * Removed Items * Known Issues doc/guides/rel_notes/release_18_08.rst | 90 ++ 1 file cha

[dpdk-dev] [PATCH v2] kni: fix build on RHEL 7.5

2018-08-09 Thread Drocula
This patch fixes compilation errors on Centos 7.5 when CONFIG_RTE_KNI_KMOD_ETHTOOL is set to 'y'. On RHEL75 ndo_change_mtu has changed to ndo_change_mtu_rh74. See commit 37d477b6863e5c06 ("kni: fix build on RHEL 7.5") Signed-off-by: Drocula Lambda --- kernel/linux/kni/ethtool/igb/kcompat.h | 5

Re: [dpdk-dev] [PATCH] devtools: fix symbol check for dash

2018-08-09 Thread Ferruh Yigit
On 8/5/2018 10:38 AM, Thomas Monjalon wrote: > The script check-symbol-change.sh was not running when > /bin/sh redirects to dash. > > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") > Cc: nhor...@tuxdriver.com > > Reported-by: Stephen Hemminger > Signed-off-by: Thomas Monja

Re: [dpdk-dev] [PATCH v2] kni: fix build on RHEL 7.5

2018-08-09 Thread Ferruh Yigit
On 8/9/2018 1:09 PM, Drocula wrote: > This patch fixes compilation errors on Centos 7.5 when > CONFIG_RTE_KNI_KMOD_ETHTOOL is set to 'y'. > On RHEL75 ndo_change_mtu has changed to ndo_change_mtu_rh74. > > See commit 37d477b6863e5c06 ("kni: fix build on RHEL 7.5") > > Signed-off-by: Drocula Lambda

Re: [dpdk-dev] [PATCH] lib/librte_ip_frag:fix ip_frag_key_cmp bug

2018-08-09 Thread Ferruh Yigit
On 8/2/2018 3:01 AM, Li Han wrote: > in struct ip_frag_key,src_dst[] type is uint64_t. > but "val" which to store the calc restult ,type is uint32_t. > we may lost high 32 bit key. and function return value is int, > but it won't return < 0. > > Signed-off-by: Li Han Fix looks good to me [1], bu

Re: [dpdk-dev] [PATCH 1/2] doc: add multithread description to hash library

2018-08-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Sunday, August 5, 2018 9:29 PM > To: De Lara Guarch, Pablo ; Mcnamara, John > ; Kovacevic, Marko > Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson, > Bruce > Subject: Re: [dpdk-dev] [PATCH 1

Re: [dpdk-dev] [PATCH 2/2] hash: add more accurate thread-safety comments

2018-08-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Wang, Yipeng1 > Sent: Thursday, July 26, 2018 6:56 PM > To: De Lara Guarch, Pablo ; Mcnamara, John > ; Kovacevic, Marko > Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson, > Bruce > Subject: [PATCH 2/2] hash: add more accurate thread-safety comments > > Descri

Re: [dpdk-dev] eventdev: method for finding out unlink status

2018-08-09 Thread Van Haaren, Harry
> From: Elo, Matias (Nokia - FI/Espoo) [mailto:matias@nokia.com] > Sent: Wednesday, August 8, 2018 11:05 AM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Jerin Jacob > Subject: Re: [dpdk-dev] eventdev: method for finding out unlink status > > > >>> > >>> I think the end result we're h

[dpdk-dev] [PATCH] doc/qat: clarify build config options

2018-08-09 Thread Fiona Trahe
Clarified documentation structure between compressedev, cryptodev and common build parts. Clarified build configuration options. Added Testing section. Fixed typos and made some cosmetic improvements. Signed-off-by: Fiona Trahe --- doc/guides/compressdevs/qat_comp.rst | 6 +- doc/guides/crypto

Re: [dpdk-dev] [PATCH v2] kni: fix build on RHEL 7.5

2018-08-09 Thread Thomas Monjalon
> Signed-off-by: Drocula Lambda I am not sure we should accept anonymous authors. Does it really comply with https://developercertificate.org/ ?

Re: [dpdk-dev] [PATCH v2] kni: fix build on RHEL 7.5

2018-08-09 Thread Thomas Monjalon
09/08/2018 14:15, Ferruh Yigit: > On 8/9/2018 1:09 PM, Drocula wrote: > > This patch fixes compilation errors on Centos 7.5 when > > CONFIG_RTE_KNI_KMOD_ETHTOOL is set to 'y'. > > On RHEL75 ndo_change_mtu has changed to ndo_change_mtu_rh74. > > > > See commit 37d477b6863e5c06 ("kni: fix build on R

Re: [dpdk-dev] How to run tests

2018-08-09 Thread Vivian Kong
Thanks Anatoly. I can find the test application now. Is there a set of tests I can run to verify the build? Regards, Vivian Kong Linux on z Systems Open Source Ecosystem IBM Canada Toronto Lab "Burakov, Anatoly" wrote on 2018/08/09 04:48:21 AM: > On 08-Aug-18 9:10 PM, Vivian Kong wrote: > >

Re: [dpdk-dev] eventdev: method for finding out unlink status

2018-08-09 Thread Jerin Jacob
-Original Message- > Date: Thu, 9 Aug 2018 13:14:40 + > From: "Van Haaren, Harry" > To: "Elo, Matias (Nokia - FI/Espoo)" > CC: "dev@dpdk.org" , Jerin Jacob > > Subject: RE: [dpdk-dev] eventdev: method for finding out unlink status > > > From: Elo, Matias (Nokia - FI/Espoo) [mailto:

[dpdk-dev] [PATCH] lib/Makefile: cleanup file to be readable

2018-08-09 Thread Keith Wiles
The Makefile was getting large and adding new libraries was becoming difficult to determine the location to place the information. The list of dirs and dependencies were split up and sorted to help find and place new libraries. Signed-off-by: Keith Wiles --- lib/Makefile | 215 ++

Re: [dpdk-dev] [PATCH] devtools: fix symbol check for dash

2018-08-09 Thread Neil Horman
On Thu, Aug 09, 2018 at 01:14:23PM +0100, Ferruh Yigit wrote: > On 8/5/2018 10:38 AM, Thomas Monjalon wrote: > > The script check-symbol-change.sh was not running when > > /bin/sh redirects to dash. > > > > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") > > Cc: nhor...@tuxdri

[dpdk-dev] [PATCH] mk: fix permissions when using make install

2018-08-09 Thread Bruce Richardson
When using make install, the permissions of the resulting file should be those of the user using make install, not those of the user who ran the build. This would not be the case when a user explicitly runs: "make && sudo make install" Fix this by changing "cp -a", which preserves all attribut

Re: [dpdk-dev] [PATCH] doc: update deprecation notice about devargs

2018-08-09 Thread Thomas Monjalon
09/08/2018 00:31, Thomas Monjalon: > The devargs parsing function has changed in 18.08. > The devargs rework should be completed in 18.11. > > Fixes: a23bc2c4e01b ("devargs: add non-variadic parsing function") > > Signed-off-by: Thomas Monjalon Applied

Re: [dpdk-dev] [PATCH] bus/pci: remove rte_pci_remove_device() declaration

2018-08-09 Thread Thomas Monjalon
07/08/2018 21:09, Rami Rosen: > This patch removes the forward declaration of rte_pci_remove_device() > method. In the past, this forward decalaration was needed for > rte_pci_detach(), which is now removed from pci_common.c. > > Fixes: e690338a7b85 ("bus/pci: remove unused function to detach by

Re: [dpdk-dev] [PATCH] bus/pci: remove unneeded include

2018-08-09 Thread Thomas Monjalon
08/08/2018 20:40, Rami Rosen: > This trivial patch removes an uneeded include > from drivers/bus/pci/linux/pci.c. > > Signed-off-by: Rami Rosen Applied, thanks

Re: [dpdk-dev] How to run tests

2018-08-09 Thread Burakov, Anatoly
On 09-Aug-18 2:54 PM, Vivian Kong wrote: Thanks Anatoly. Is there a set of tests I can run to verify the build? Generally, most unit tests in the test app will do what you require. Additionally, if you're using make build system, you can run "make test" and it'll run an autotest script. Some

Re: [dpdk-dev] [PATCH] Fix a doxygen comment of rte_eth_dev_allocate()

2018-08-09 Thread Thomas Monjalon
07/08/2018 17:44, Ferruh Yigit: > On 8/5/2018 9:03 PM, Rami Rosen wrote: > > This patch fixes a doxygen comment of the rte_eth_dev_allocate() > > method. There is no parameter named "type" for this > > method; so this patch removes the doxygen comment about it. > > > > Signed-off-by: Rami Rosen

[dpdk-dev] [PATCH] vhost: suppress error if numa is not available

2018-08-09 Thread Ilya Maximets
It's a common case that 'get_mempolicy' fails on systems without NUMA support. No need to flag an error in log for this situation. Signed-off-by: Ilya Maximets --- lib/librte_vhost/vhost.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost.c b/lib/librte

Re: [dpdk-dev] [PATCH] devtools: fix symbol check for dash

2018-08-09 Thread Thomas Monjalon
09/08/2018 17:14, Neil Horman: > On Thu, Aug 09, 2018 at 01:14:23PM +0100, Ferruh Yigit wrote: > > On 8/5/2018 10:38 AM, Thomas Monjalon wrote: > > > The script check-symbol-change.sh was not running when > > > /bin/sh redirects to dash. > > > > > > Fixes: 4bec48184e33 ("devtools: add checks for A

Re: [dpdk-dev] [dpdk-stable] [PATCH] mk: fix permissions when using make install

2018-08-09 Thread Thomas Monjalon
09/08/2018 17:22, Bruce Richardson: > When using make install, the permissions of the resulting file should be > those of the user using make install, not those of the user who ran the > build. This would not be the case when a user explicitly runs: > >"make && sudo make install" > > Fix this

Re: [dpdk-dev] How to run tests

2018-08-09 Thread Bruce Richardson
On Thu, Aug 09, 2018 at 04:54:36PM +0100, Burakov, Anatoly wrote: > On 09-Aug-18 2:54 PM, Vivian Kong wrote: > > Thanks Anatoly. > > > > Is there a set of tests I can run to verify the build? > > Generally, most unit tests in the test app will do what you require. > Additionally, if you're using

Re: [dpdk-dev] [PATCH] maintainers: claim maintainership for ARM v7 and v8

2018-08-09 Thread Thomas Monjalon
> > Claim the maintainership as Jianbo Liu is not working on this any more. > > Aslo remove the co-maintainership for Marvel mvpp2 amd mrvl crypto driver > > and doc. > > > > Cc: sta...@dpdk.org > > Cc: jianbo@arm.com > > > > > Signed-off-by: Gavin Hu > > Reviewed-by: Song Zhu > > Review

Re: [dpdk-dev] [PATCH] doc: move and update experimental API description

2018-08-09 Thread Thomas Monjalon
25/05/2018 17:37, Ferruh Yigit: > On 5/25/2018 1:22 PM, Luca Boccassi wrote: > > On Fri, 2018-05-25 at 17:37 +0530, Shreyansh Jain wrote: > >> Experimental API text has been moved into a sub-section of ABI > >> Policy. > >> A paragraph has been added to explain the process for removal of an > >> ex

Re: [dpdk-dev] How to run tests

2018-08-09 Thread Vivian Kong
Thanks all! Regards, Vivian Kong Linux on z Systems Open Source Ecosystem IBM Canada Toronto Lab Bruce Richardson wrote on 2018/08/09 12:17:23 PM: > > On Thu, Aug 09, 2018 at 04:54:36PM +0100, Burakov, Anatoly wrote: > > On 09-Aug-18 2:54 PM, Vivian Kong wrote: > > > Thanks Anatoly. > > > > >

[dpdk-dev] [PATCH v2 1/8] doc/qat: add limitations to compressdev PMD

2018-08-09 Thread Fiona Trahe
Signed-off-by: Fiona Trahe --- doc/guides/compressdevs/qat_comp.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/guides/compressdevs/qat_comp.rst b/doc/guides/compressdevs/qat_comp.rst index 8b1270b70..b45f4a626 100644 --- a/doc/guides/compressdevs/qat_comp.rst +++

[dpdk-dev] [PATCH v2 0/8] doc/qat: clarify build config options

2018-08-09 Thread Fiona Trahe
Clarified documentation structure between compressedev, cryptodev and common build parts. Clarified build configuration options. Added Testing section. Fixed typos and made some cosmetic improvements. v2 changes - split into patchset - changed test path from build/build/test/test to build/app -

[dpdk-dev] [PATCH v2 2/8] doc/qat: add information on how to test

2018-08-09 Thread Fiona Trahe
Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 20 1 file changed, 20 insertions(+) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index bdc58eb2c..7df49ca44 100644 --- a/doc/guides/cryptodevs/qat.rst +++ b/doc/guides/cryptodevs/qa

[dpdk-dev] [PATCH v2 3/8] doc/qat: fix typos and make cosmetic changes

2018-08-09 Thread Fiona Trahe
Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index 7df49ca44..bfa4327b7 100644 --- a/doc/guides/cryptodevs/qat.rst +++ b/

[dpdk-dev] [PATCH v2 4/8] doc/qat: add overview of doc sections

2018-08-09 Thread Fiona Trahe
Add overview of QAT doc sections and link between them. Indent to next level all sections within the crypto and common sections. Signed-off-by: Fiona Trahe --- doc/guides/compressdevs/qat_comp.rst | 2 +- doc/guides/cryptodevs/qat.rst| 46 +++- 2 files ch

[dpdk-dev] [PATCH v2 5/8] doc/qat: remove unnecessary text

2018-08-09 Thread Fiona Trahe
Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 5 - 1 file changed, 5 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index ab15e234b..e6d78ac16 100644 --- a/doc/guides/cryptodevs/qat.rst +++ b/doc/guides/cryptodevs/qat.rst @@ -169,12 +

[dpdk-dev] [PATCH v2] doc/qat: describe build config options

2018-08-09 Thread Fiona Trahe
Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 31 +++ 1 file changed, 31 insertions(+) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index 6e4927697..68cfd9e3e 100644 --- a/doc/guides/cryptodevs/qat.rst +++ b/doc/guides/cr

[dpdk-dev] [PATCH v2 6/8] doc/qat: update kernel dependency section

2018-08-09 Thread Fiona Trahe
Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index e6d78ac16..2f233ec9d 100644 --- a/doc/guides/cryptodevs/qat.rst +++ b/doc/guides/crypto

[dpdk-dev] [PATCH v2 7/8] doc/qat: update PMD build section

2018-08-09 Thread Fiona Trahe
Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 76 --- 1 file changed, 49 insertions(+), 27 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index 2f233ec9d..6e4927697 100644 --- a/doc/guides/cryptodev

Re: [dpdk-dev] [PATCH] bus/pci: check if 5-level paging is enabled when testing IOMMU address width

2018-08-09 Thread Stephen Hemminger
Thanks for the patch, there are some minor style/cleanups that could be done. > #if defined(RTE_ARCH_X86) Isn't this going to apply to 64 bit only? > +/* > + * Try to detect whether the system uses 5-level page table. > + */ > +static bool > +system_uses_PML5(void) > +{ > + void *page_4k,

Re: [dpdk-dev] [PATCH v2 0/8] doc/qat: clarify build config options

2018-08-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Thursday, August 9, 2018 5:50 PM > To: dev@dpdk.org; De Lara Guarch, Pablo ; > Jozwiak, TomaszX > Cc: Trahe, Fiona > Subject: [PATCH v2 0/8] doc/qat: clarify build config options > > Clarified documentation structure between compressed

Re: [dpdk-dev] [PATCH v2] kni: fix build on RHEL 7.5

2018-08-09 Thread Stephen Hemminger
On Thu, 09 Aug 2018 16:03:15 +0200 Thomas Monjalon wrote: > > Signed-off-by: Drocula Lambda > > I am not sure we should accept anonymous authors. > Does it really comply with https://developercertificate.org/ ? > > > No we can't accept patches from pseudonym's. DCO is a legal signature an

Re: [dpdk-dev] [dpdk-stable] [PATCH] mk: fix permissions when using make install

2018-08-09 Thread Ferruh Yigit
On 8/9/2018 5:16 PM, Thomas Monjalon wrote: > 09/08/2018 17:22, Bruce Richardson: >> When using make install, the permissions of the resulting file should be >> those of the user using make install, not those of the user who ran the >> build. This would not be the case when a user explicitly runs:

Re: [dpdk-dev] [PATCH] mk: fix permissions when using make install

2018-08-09 Thread Yongseok Koh
> On Aug 9, 2018, at 8:22 AM, Bruce Richardson > wrote: > > When using make install, the permissions of the resulting file should be > those of the user using make install, not those of the user who ran the > build. This would not be the case when a user explicitly runs: > > "make && sudo m

[dpdk-dev] [PATCH 1/4] netvsc: chimney buffer size error handling

2018-08-09 Thread Stephen Hemminger
Fix the error handling in setting up transmit buffer. If setting up chimney buffer fails, then it is not connected so no need to send disconnect. Allow for some unused area if full area is not used. Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_nvs.c | 13 - 1 file chan

[dpdk-dev] [PATCH 0/4] netvsc performance enhancements

2018-08-09 Thread Stephen Hemminger
Some more netvsc performance related changes. The biggest benefit comes from lowering the hypervisor polling rate from 100us to 50us. Supporting tx_done_cleanup can also help some applications get through the send completions faster. Stephen Hemminger (4): netvsc: chimney buffer size error hand

[dpdk-dev] [PATCH 2/4] bus/vmbus: add host latency tuning function

2018-08-09 Thread Stephen Hemminger
Add vmbus API to allow tuning the scan interval on the host side. Signed-off-by: Stephen Hemminger --- drivers/bus/vmbus/rte_bus_vmbus.h | 15 drivers/bus/vmbus/rte_bus_vmbus_version.map | 1 + drivers/bus/vmbus/vmbus_channel.c | 26 + 3 file

[dpdk-dev] [PATCH 3/4] netvsc: set lower host latency

2018-08-09 Thread Stephen Hemminger
Tune the vmbus connection so the host scans faster. This improves transmit performance. The host default value is 100us but setting to 50us reduces packet loss significantly. Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 6 ++ drivers/net/netvsc/hn_var.h| 3 +++ 2

[dpdk-dev] [PATCH 4/4] netvsc: implement tx_done_cleanup

2018-08-09 Thread Stephen Hemminger
Add tx_done_cleanup ethdev hook to allow application to control if/when it wants completions to be handled. Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 1 + drivers/net/netvsc/hn_rndis.c | 2 +- drivers/net/netvsc/hn_rxtx.c | 26 +- drivers/

[dpdk-dev] [PATCH] net/virtio-user: check negotiated features before set

2018-08-09 Thread Allain Legacy
From: eric zhang This patch checks negotiated features to see if necessary to offload before set the tap device offload capabilities. It also checks if kernel support the TUNSETOFFLOAD operation. Signed-off-by: eric zhang Signed-off-by: Allain Legacy --- drivers/net/virtio/virtio_user/vhost_k

Re: [dpdk-dev] [PATCH v3] doc: add note for builtin-net-driver option

2018-08-09 Thread Thomas Monjalon
> > Very simple version of vhost-user driver in vhost sample will be used if > > builtin-net-driver option is enabled. This driver is based on generic vhost > > lib APIs. Unfortunately, the implementation is incompatible with QEMU as > > protocol feature is not supported. > > > > Signed-off-by: Ma

Re: [dpdk-dev] [PATCH v2 6/8] doc/qat: update kernel dependency section

2018-08-09 Thread Thomas Monjalon
09/08/2018 18:50, Fiona Trahe: > --- a/doc/guides/cryptodevs/qat.rst > +++ b/doc/guides/cryptodevs/qat.rst > @@ -120,10 +120,8 @@ Quick instructions are as follows: > make > > > -.. _qat_kernel_installation: > - > Dependency on the QAT kernel driver >

Re: [dpdk-dev] [PATCH v2 7/8] doc/qat: update PMD build section

2018-08-09 Thread Thomas Monjalon
09/08/2018 18:50, Fiona Trahe: > +Quick instructions for QAT compressdev PMD are as follows: > > +.. code-block:: console > + > + cd to the top-level DPDK directory > + make defconfig > + make This code block seems too much obvious. > +.. _qat_kernel: > + > +Dependency on the QAT k

Re: [dpdk-dev] [PATCH v2 0/8] doc/qat: clarify build config options

2018-08-09 Thread Thomas Monjalon
09/08/2018 18:50, Fiona Trahe: > Clarified documentation structure between > compressedev, cryptodev and common build parts. > Clarified build configuration options. > Added Testing section. > Fixed typos and made some cosmetic improvements. > > v2 changes > - split into patchset I am not sure a

Re: [dpdk-dev] [PATCH 1/2] doc: add multithread description to hash library

2018-08-09 Thread Thomas Monjalon
> > Pablo, Marko, review please? > > Sorry Thomas, I missed this. > > > > > 26/07/2018 19:56, Yipeng Wang: > > > Added multithreading related description into programmer guide of hash > > > library. > > > > > > Signed-off-by: Yipeng Wang > > Acked-by: Pablo de Lara Series applied, thanks

Re: [dpdk-dev] [PATCH] examples/performance-thread: convert license headers to SPDX

2018-08-09 Thread Thomas Monjalon
04/06/2018 09:35, Dmitry Vyukov: > On Fri, May 25, 2018 at 12:10 PM, Thomas Monjalon wrote: > > 20/04/2018 11:53, Pablo de Lara: > >> Convert dual license headers with Intel and Dmitry Vyukov > >> names to SPDX. > >> > >> Signed-off-by: Pablo de Lara > >> --- > >> examples/performance-thread/com

Re: [dpdk-dev] [PATCH v2] doc: add SPDX and copyright to rel notes

2018-08-09 Thread Thomas Monjalon
27/07/2018 06:54, Hemant Agrawal: > using "The DPDK Contributors" as decided by techboard. > > Signed-off-by: Hemant Agrawal Applied, thanks

Re: [dpdk-dev] [PATCH] doc: add SPDX and copyright to contributing guide

2018-08-09 Thread Thomas Monjalon
05/06/2018 09:50, Hemant Agrawal: > Signed-off-by: Hemant Agrawal Acked-by: Thomas Monjalon Applied, thanks

Re: [dpdk-dev] [PATCH v1] doc: update release notes for 18.08

2018-08-09 Thread Thomas Monjalon
09/08/2018 14:08, John McNamara: > Fix grammar, spelling and formatting of DPDK 18.08 release notes. > > Signed-off-by: John McNamara > --- > -Supported ACTION_PORT_ID, ACTION_DROP, ACTION_OF_POP_VLAN, > +Added supported for ACTION_PORT_ID, ACTION_DROP, ACTION_OF_POP_VLAN, Fixed to "Adde

[dpdk-dev] [dpdk-announce] DPDK 18.08 released

2018-08-09 Thread Thomas Monjalon
A new major release is available: http://fast.dpdk.org/rel/dpdk-18.08.tar.xz It is a short release after the huge 18.05: 898 patches from 124 authors 1020 files changed, 72041 insertions(+), 27305 deletions(-) Highlights for 18.08: - big work on vhost/virtio (in-or

[dpdk-dev] [PATCH v14 2/6] eal: enable hotplug on multi-process

2018-08-09 Thread Qi Zhang
We are going to introduce the solution to handle hotplug in multi-process, it includes the below scenario: 1. Attach a device from the primary 2. Detach a device from the primary 3. Attach a device from a secondary 4. Detach a device from a secondary In the primary-secondary process model, we ass

[dpdk-dev] [PATCH v14 1/6] ethdev: add function to release port in secondary process

2018-08-09 Thread Qi Zhang
Add driver API rte_eth_release_port_secondary to support the case when an ethdev need to be detached on a secondary process. Local state is set to unused and shared data will not be reset so the primary process can still use it. Signed-off-by: Qi Zhang --- lib/librte_ethdev/rte_ethdev.c

[dpdk-dev] [PATCH v14 0/6] enable hotplug on multi-process

2018-08-09 Thread Qi Zhang
v14: - rebase. - All changes belongs to patch 1/6. 1) rename rte_eth_dev_release_port_private to rte_eth_dev_release_port_seondary since it is only used by secondary process. 2) in rte_eth_dev_pci_generic_remove, even on the secondary process, I think its better to call rte_eth_dev_r

[dpdk-dev] [PATCH v14 3/6] eal: support attach or detach share device from secondary

2018-08-09 Thread Qi Zhang
This patch cover the multi-process hotplug case when a device attach/detach request be issued from a secondary process device attach on secondary: a) secondary send sync request to the primary. b) primary receive the request and attach the new device if failed goto i). c) primary forward attach

[dpdk-dev] [PATCH v14 4/6] drivers/net: enable hotplug on secondary process

2018-08-09 Thread Qi Zhang
Attach port from secondary should ignore devargs since the private device is not necessary to support. Also previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_dev_release_port_second

[dpdk-dev] [PATCH v14 5/6] drivers/net: enable device detach on secondary

2018-08-09 Thread Qi Zhang
With the enabling for hotplug on multi-process, it is not necessary to prevent detaching a device from a secondary process. Signed-off-by: Qi Zhang --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- drivers/net/ena/ena_ethdev.c | 2 +- drivers/net/liquidio/lio_ethdev.c | 2 +- drivers/net/vir

[dpdk-dev] [PATCH v14 6/6] examples/multi_process: add hotplug sample

2018-08-09 Thread Qi Zhang
The sample code demonstrates device (ethdev only) management at a multi-process environment. The user can attach/detach a device on primary process and see it is synced on secondary process automatically. How to start? ./hotplug_mp --proc-type=auto Command Line Example: >help >list /* attach a

Re: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and FDIR

2018-08-09 Thread Xing, Beilei
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, August 6, 2018 5:31 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Lu, Wenzhuo ; Wu, Jingjing > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and > FDIR > > 06/08/201

Re: [dpdk-dev] [PATCH] vhost: suppress error if numa is not available

2018-08-09 Thread Tiwei Bie
[PATCH] vhost: suppress error if numa is not available s/numa/NUMA/ Otherwise check-git-log.sh [1] will complain: Wrong headline lowercase: vhost: suppress error if numa is not available Apart from that, Reviewed-by: Tiwei Bie [1] https://github.com/DPDK/dpdk/blob/11a1f847d281/dev

Re: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and FDIR

2018-08-09 Thread Jerin Jacob
-Original Message- > Date: Mon, 6 Aug 2018 13:45:35 +0800 > From: Beilei Xing > To: wenzhuo...@intel.com, jingjing...@intel.com > CC: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and FDIR > X-Mailer: git-send-email 2.5.5 > > > This patch adds bitmask su