Ferruh,
Stephen has passed on support of his patches to me, I will be the main
point of contact going forward. I'm still ramping up on the code, expect patch
updates to come from me in the future.
-Original Message-
From: Ferruh Yigit
Sent: Monday, February 7, 2022 11:04 AM
To
sable' not all fiber ixgbe devs use
SDP3 as TX_DISABLE
Fixes: 1ca05831b9b ("net/ixgbe: fix link status")
Fixes: ff8162cb957 ("net/ixgbe: fix link status")
Cc: sta...@dpdk.org
Signed-off-by: Jeff Daly
---
doc/guides/nics/ixgbe.rst| 17 ++
dr
> -Original Message-
> From: Thomas Monjalon
> Sent: Wednesday, May 11, 2022 10:51 AM
> To: Jeff Daly ; Zhang, Qi Z
> Cc: Yang, Qiming ; Wu, Wenjun1
> ; Zhao1, Wei ; Xiao Zhang
> ; Xiaolong Ye ; Lunyuan Cui
> ; dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [P
Currently the ixgbe driver does not ID any SFP except for the first one
plugged in. This can lead to no-link, or incorrect speed conditions.
For example:
* If link is initially established with a 1G SFP, and later a 1G/10G
multispeed part is later installed, then the MAC link setup functions are
Rather than run-to-completion, allow the link update thread to be
periodic. This will set the stage for properly handling hot-plugging.
Signed-off-by: Jeff Daly
Inspired-by: Stephen Douthit
---
drivers/net/ixgbe/base/ixgbe_common.c | 4 +-
drivers/net/ixgbe/ixgbe_ethdev.c | 180
The link update originally direct coded into the periodic service thread
and is made separate in preparation for additional SFP handling code.
Signed-off-by: Jeff Daly
Inspired-by: Stephen Douthit
---
drivers/net/ixgbe/ixgbe_ethdev.c | 99 ++--
drivers/net/ixgbe
.
Signed-off-by: Jeff Daly
Inspired-by: Stephen Douthit
---
drivers/net/ixgbe/ixgbe_ethdev.c | 272 ++-
drivers/net/ixgbe/ixgbe_ethdev.h | 8 +
2 files changed, 273 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe
Currently the ixgbe driver does not ID any SFP except for the first one
plugged in. This can lead to no-link, or incorrect speed conditions.
For example:
* If link is initially established with a 1G SFP, and later a 1G/10G
multispeed part is later installed, then the MAC link setup functions are
Rather than run-to-completion, allow the link update thread to be
periodic. This will set the stage for properly handling hot-plugging.
Signed-off-by: Jeff Daly
Inspired-by: Stephen Douthit
---
drivers/net/ixgbe/base/ixgbe_common.c | 4 +-
drivers/net/ixgbe/ixgbe_ethdev.c | 180
The link update originally direct coded into the periodic service thread
and is made separate in preparation for additional SFP handling code.
Signed-off-by: Jeff Daly
Inspired-by: Stephen Douthit
---
drivers/net/ixgbe/ixgbe_ethdev.c | 99 ++--
drivers/net/ixgbe
.
Signed-off-by: Jeff Daly
Inspired-by: Stephen Douthit
---
drivers/net/ixgbe/ixgbe_ethdev.c | 272 ++-
drivers/net/ixgbe/ixgbe_ethdev.h | 8 +
2 files changed, 273 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe
userspace
request), and then get cleared once the requested subtask has been
completed.
Fixes: af75078fece ("first public release")
Cc: sta...@dpdk.org
Jeff Daly (3):
ixgbe: make link update thread periodic
ixgbe: move periodic link service work into separate function
ixgbe: make hotplug
Rather than run-to-completion, allow the link update thread to be
periodic. This will set the stage for properly handling hot-plugging.
Signed-off-by: Jeff Daly
Suggested-by: Stephen Douthit
---
drivers/net/ixgbe/base/ixgbe_common.c | 4 +-
drivers/net/ixgbe/ixgbe_ethdev.c | 180
The link update originally direct coded into the periodic service thread
and is made separate in preparation for additional SFP handling code.
Signed-off-by: Jeff Daly
Suggested-by: Stephen Douthit
---
drivers/net/ixgbe/ixgbe_ethdev.c | 99 ++--
drivers/net/ixgbe
.
Signed-off-by: Jeff Daly
Suggested-by: Stephen Douthit
---
drivers/net/ixgbe/ixgbe_ethdev.c | 272 ++-
drivers/net/ixgbe/ixgbe_ethdev.h | 8 +
2 files changed, 272 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe
Rather than run-to-completion, allow the link update thread to be
periodic. This will set the stage for properly handling hot-plugging.
Signed-off-by: Jeff Daly
Suggested-by: Stephen Douthit
---
drivers/net/ixgbe/base/ixgbe_common.c | 4 +-
drivers/net/ixgbe/ixgbe_ethdev.c | 180
The link update originally direct coded into the periodic service thread
and is made separate in preparation for additional SFP handling code.
Signed-off-by: Jeff Daly
Suggested-by: Stephen Douthit
---
drivers/net/ixgbe/ixgbe_ethdev.c | 99 ++--
drivers/net/ixgbe
.
Signed-off-by: Jeff Daly
Suggested-by: Stephen Douthit
---
drivers/net/ixgbe/ixgbe_ethdev.c | 272 ++-
drivers/net/ixgbe/ixgbe_ethdev.h | 8 +
2 files changed, 272 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe
> -Original Message-
> From: Zhang, Qi Z
> Sent: Thursday, May 19, 2022 8:15 PM
> To: Thomas Monjalon ; dev@dpdk.org
> Cc: Stephen Douthit ; Jeff Daly usa.com>; Yang, Qiming ; Wu, Wenjun1
>
> Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X55
> -Original Message-
> From: Zhang, Qi Z
> Sent: Monday, May 23, 2022 1:37 AM
> To: Jeff Daly ; Thomas Monjalon
> ; dev@dpdk.org
> Cc: Stephen Douthit ; Yang, Qiming
> ; Wu, Wenjun1
> Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550
> de
> -Original Message-
> From: Zhang, Qi Z
> Sent: Monday, May 23, 2022 7:22 PM
> To: Jeff Daly ; Thomas Monjalon
> ; dev@dpdk.org
> Cc: Stephen Douthit ; Yang, Qiming
> ; Wu, Wenjun1
> Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550
> de
> -Original Message-
> From: Zhang, Qi Z
> Sent: Wednesday, May 11, 2022 9:27 PM
> To: Jeff Daly ; dev@dpdk.org
> Cc: sta...@dpdk.org; Stephen Douthit
> Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on
> hotplug
>
> Caution: This i
abled via the allow_unsupported_sfps parameter
inherited from the mainline Linux driver.
Signed-off-by: Jeff Daly
Suggested-by: Stephen Douthit
---
v2:
* Introduced cu_sfp_as_sx option, default off.
---
doc/guides/nics/ixgbe.rst | 16 ++
drivers/net/ixgbe/base/ixgbe_type.h
> -Original Message-
> From: Zhang, Qi Z
> Sent: Sunday, May 29, 2022 6:49 PM
> To: Jeff Daly ; dev@dpdk.org
> Cc: Stephen Douthit ; Yang, Qiming
> ; Wu, Wenjun1
> Subject: RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550
> devices
>
>
> -Original Message-
> From: Zhang, Qi Z
> Sent: Sunday, May 29, 2022 7:25 PM
> To: Jeff Daly ; dev@dpdk.org; Yang, Qiming
> ; Wu, Wenjun1
> Cc: Stephen Douthit
> Subject: RE: [PATCH 1/3] ixgbe: make link update thread periodic
>
> Caution: This is an
> -Original Message-
> From: Zhang, Qi Z
> Sent: Monday, May 30, 2022 10:21 AM
> To: Jeff Daly ; dev@dpdk.org; Yang, Qiming
> ; Wu, Wenjun1
> Cc: Stephen Douthit
> Subject: RE: [PATCH 1/3] ixgbe: make link update thread periodic
>
> Caution: This is an
> -Original Message-
> From: Zhang, Qi Z
> Sent: Monday, May 30, 2022 9:51 AM
> To: Jeff Daly ; dev@dpdk.org
> Cc: Stephen Douthit ; Yang, Qiming
> ; Wu, Wenjun1
> Subject: RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550
> devices
>
>
s of patches to refactor the
initial work that Stephen Douthit submitted last year, splitting the
issues into separate logical series.
---
v3:
* Moved code back out of base.
Jeff Daly (2):
net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices
net/ixgbe: Fix SFP detection and lin
From: Stephen Douthit
Currently all X500EM* MAC types fallthrough to the default case and get
reported as non-SFP regardless of media type, which isn't correct.
Fixes: 0790adeb567 ("ixgbe/base: support X550em_a device")
Cc: sta...@dpdk.org
Signed-off-by: Stephen Douthit
Sign
, not all fiber ixgbe devs use
SDP3 as TX_DISABLE
Fixes: 1ca05831b9b ("net/ixgbe: fix link status")
Fixes: ff8162cb957 ("net/ixgbe: fix link status")
Cc: sta...@dpdk.org
Signed-off-by: Jeff Daly
---
drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1
userspace
request), and then get cleared once the requested subtask has been
completed.
Fixes: af75078fece ("first public release")
Cc: sta...@dpdk.org
Signed-off-by: Stephen Douthit
Signed-off-by: Jeff Daly
---
drivers/net/ixgbe/ixgbe_ethdev.c | 687 +--
drivers
userspace
request), and then get cleared once the requested subtask has been
completed.
Fixes: af75078fece ("first public release")
Cc: sta...@dpdk.org
Signed-off-by: Stephen Douthit
Signed-off-by: Jeff Daly
---
drivers/net/ixgbe/ixgbe_ethdev.c | 499 +++
drivers
From: Stephen Douthit
Currently all X500EM* MAC types fallthrough to the default case and get
reported as non-SFP regardless of media type, which isn't correct.
Fixes: 0790adeb567 ("ixgbe/base: support X550em_a device")
Cc: sta...@dpdk.org
Signed-off-by: Stephen Douthit
Sign
s of patches to refactor the
initial work that Stephen Douthit submitted last year, splitting the
issues into separate logical series.
---
v3:
* Moved code back out of base.
v4:
* Revert accidental tabification
Jeff Daly (2):
net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices
net
, not all fiber ixgbe devs use
SDP3 as TX_DISABLE
Fixes: 1ca05831b9b ("net/ixgbe: fix link status")
Fixes: ff8162cb957 ("net/ixgbe: fix link status")
Cc: sta...@dpdk.org
Signed-off-by: Jeff Daly
---
drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1
userspace
request), and then get cleared once the requested subtask has been
completed.
Fixes: af75078fece ("first public release")
Cc: sta...@dpdk.org
Signed-off-by: Stephen Douthit
Signed-off-by: Jeff Daly
---
drivers/net/ixgbe/ixgbe_ethdev.c | 499 +++
drivers
> -Original Message-
> From: Thomas Monjalon
> Sent: Sunday, March 6, 2022 12:56 PM
> To: Wang, Haiyue ; Zhang, Qi Z
> ; ferruh.yi...@intel.com
> Cc: Jeff Daly ; dev@dpdk.org; sta...@dpdk.org;
> Stephen Douthit ; Lu, Wenzhuo
>
> Subject: Re: [PATCH v4 1/3]
> -Original Message-
> From: Jeff Daly
> Sent: Monday, February 28, 2022 10:30 AM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Stephen Douthit ; Haiyue
> Wang
> Subject: [PATCH v4 3/3] net/ixgbe: Fix SFP detection and linking on hotplug
>
> Caution: This is an
Some SFP link partners exhibit a disinclination to autonegotiate
with X550 configured in SFI mode. This patch enables a manual AN-37
restart to work around the problem.
Signed-off-by: Jeff Daly
---
drivers/net/ixgbe/base/ixgbe_type.h | 1 +
drivers/net/ixgbe/base/ixgbe_x550.c | 51
Some SFP link partners exhibit a disinclination to autonegotiate
with X550 configured in SFI mode. This patch enables a manual AN-37
restart to work around the problem.
--
v2 fixed whitespace
Signed-off-by: Jeff Daly
---
drivers/net/ixgbe/base/ixgbe_type.h | 1 +
drivers/net/ixgbe/base
v5:
* Restore missing patch pieces preventing interrupts on Linux from
working correctly.
sable' not all fiber ixgbe devs use
SDP3 as TX_DISABLE
Fixes: 1ca05831b9b ("net/ixgbe: fix link status")
Fixes: ff8162cb957 ("net/ixgbe: fix link status")
Cc: sta...@dpdk.org
Signed-off-by: Jeff Daly
---
drivers/net/ixgbe/ixgbe_ethdev.c | 39
userspace
request), and then get cleared once the requested subtask has been
completed.
Fixes: af75078fece ("first public release")
Cc: sta...@dpdk.org
Signed-off-by: Stephen Douthit
Signed-off-by: Jeff Daly
---
drivers/net/ixgbe/ixgbe_ethdev.c | 533 +++
drivers
v6:
* Fixed minor coding style issue in patch 1/2
sable' not all fiber ixgbe devs use
SDP3 as TX_DISABLE
Fixes: 1ca05831b9b ("net/ixgbe: fix link status")
Fixes: ff8162cb957 ("net/ixgbe: fix link status")
Cc: sta...@dpdk.org
Signed-off-by: Jeff Daly
---
drivers/net/ixgbe/ixgbe_ethdev.c | 39
userspace
request), and then get cleared once the requested subtask has been
completed.
Fixes: af75078fece ("first public release")
Cc: sta...@dpdk.org
Signed-off-by: Stephen Douthit
Signed-off-by: Jeff Daly
---
drivers/net/ixgbe/ixgbe_ethdev.c | 533 +++
drivers
> -Original Message-
> From: Morten Brørup
> Sent: Wednesday, April 13, 2022 3:20 AM
> To: Wang, Haiyue ; Jeff Daly usa.com>; dev@dpdk.org
> Cc: sta...@dpdk.org; Stephen Douthit ; Yang,
> Qiming
> Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection
> -Original Message-
> From: Wang, Haiyue
> Sent: Tuesday, April 12, 2022 9:22 PM
> To: Jeff Daly ; dev@dpdk.org
> Cc: sta...@dpdk.org; Xiaolong Ye ; Xiao Zhang
> ; Zhao1, Wei ; Lunyuan Cui
>
> Subject: RE: [PATCH v6 1/2] net/ixgbe: Limit SDP3 check of TX_
> -Original Message-
> From: Wang, Haiyue
> Sent: Wednesday, April 13, 2022 11:00 PM
> To: Jeff Daly ; dev@dpdk.org
> Cc: sta...@dpdk.org; Stephen Douthit
> Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on
> hotplug
>
> Caution
> -Original Message-
> From: Wang, Haiyue
> Sent: Tuesday, April 12, 2022 10:47 PM
> To: Jeff Daly ; dev@dpdk.org
> Cc: sta...@dpdk.org; Stephen Douthit ; Yang,
> Qiming
> Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on
> hotplug
> -Original Message-
> From: Jeff Daly
> Sent: Thursday, April 14, 2022 6:50 AM
> To: Wang, Haiyue ; dev@dpdk.org
> Cc: sta...@dpdk.org; Yang, Qiming
> Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on
> hotplug
>
> Caution: This i
> -Original Message-
> From: Thomas Monjalon
> Sent: Thursday, April 14, 2022 8:19 AM
> To: Wang, Haiyue
> Cc: Jeff Daly ; dev@dpdk.org; Stephen Douthit
> ; qi.z.zh...@intel.com;
> john.mcnam...@intel.com
> Subject: Re: [PATCH] net/ixgbe: Treat 1G Cu S
> -Original Message-
> From: Wang, Haiyue
> Sent: Thursday, April 14, 2022 8:11 AM
> To: Jeff Daly ; dev@dpdk.org
> Cc: sta...@dpdk.org
> Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on
> hotplug
>
> Caution: This is an external e
> -Original Message-
> From: Wang, Haiyue
> Sent: Monday, April 18, 2022 10:05 PM
> To: Jeff Daly ; dev@dpdk.org
> Cc: sta...@dpdk.org; Yang, Qiming
> Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on
> hotplug
>
> Caution: This is an
> -Original Message-
> From: Wang, Haiyue
> Sent: Tuesday, April 19, 2022 9:09 PM
> To: Jeff Daly ; dev@dpdk.org
> Cc: sta...@dpdk.org; Yang, Qiming
> Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on
> hotplug
>
> Caution: This is an
The devargs option for the IXGBE driver is introduced in order to
inform the driver to skip checking SDP3 as an indicator of laser
enable/disable for SFP modules.
Signed-off-by: Jeff Daly
---
doc/guides/nics/ixgbe.rst | 17 +
1 file changed, 17 insertions(+)
diff --git a/doc
56 matches
Mail list logo
