Feel free to submit a pull request against the master branch, and
ask @chickenlj to review. I happen to know he's working on this area too.
Thanks,
-Ian.
On Thu, Mar 14, 2019 at 7:18 PM 雷舜宇 wrote:
> If you have a plan, please let me know in time, I will solve it as soon as
> possible, I will
If you have a plan, please let me know in time, I will solve it as soon as
possible, I will always follow up
Ian Luo 于2019年3月14日周四 下午3:51写道:
> Maple, we will consider it in 2.7.2 release.
>
> Thanks,
> -Ian.
>
> On Wed, Mar 13, 2019 at 9:57 AM 雷舜宇 wrote:
>
> > issues
Maple, we will consider it in 2.7.2 release.
Thanks,
-Ian.
On Wed, Mar 13, 2019 at 9:57 AM 雷舜宇 wrote:
> issues address:https://github.com/apache/incubator-dubbo/issues/3483
>
> Do you have any opinion on this question, do you need to add a new field,
> or do you have any better suggestions?
>
issues address:https://github.com/apache/incubator-dubbo/issues/3483
Do you have any opinion on this question, do you need to add a new field,
or do you have any better suggestions?
Since filter may execute its methods in different threads, first of all we
cannot use thread local to pass the information. Because of this, this
leads us no room but method parameters, in this case, they are invoker and
invocation, to store and extract the extra info when necessary. Based on
Hi,ian
Several reasons:
1. It seems that the attachment is based on the convention. We need to put
the information other than the rpc parameter into the attachment. We need
to ensure that the information and the temporary information (start in the
timeoutFilter) do not overlap.
2. The attachment
Yuhang,
Why it's a bad idea to use invocation#attachments to store the temp data?
Thanks,
-Ian.
On Fri, Feb 15, 2019 at 2:55 PM yuhang xiu wrote:
> Hi, everyone
>
> Recently, I found that dubbo does not handle the data generated during the
> call process when it is asynchronous.
>
> For
Hi, everyone
Recently, I found that dubbo does not handle the data generated during the
call process when it is asynchronous.
For example, in TimeoutFilter, we used invocation#attachments to hold the
data that needs to be passed (start time in TimeoutFilter). But I don't
think this way is good,