Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/#review175684 --- Ship it! Ship It! - Daniel Dai On May 22, 2017, 7:06 p.m., V

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/ --- (Updated May 22, 2017, 7:06 p.m.) Review request for hive, Daniel Dai and Theja

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/ --- (Updated May 22, 2017, 9:04 a.m.) Review request for hive, Daniel Dai and Theja

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/ --- (Updated May 21, 2017, 7:12 p.m.) Review request for hive, Daniel Dai and Theja

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/ --- (Updated May 19, 2017, 8:41 p.m.) Review request for hive, Daniel Dai and Theja

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/ --- (Updated May 19, 2017, 2:38 a.m.) Review request for hive, Daniel Dai and Theja

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/ --- (Updated May 18, 2017, 7:14 p.m.) Review request for hive, Daniel Dai and Theja

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/#review175354 --- metastore/src/java/org/apache/hadoop/hive/metastore/cache/CachedS

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/ --- (Updated May 17, 2017, 6:47 p.m.) Review request for hive, Daniel Dai and Theja

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/ --- (Updated May 17, 2017, 8:24 a.m.) Review request for hive, Daniel Dai and Theja

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/ --- (Updated May 17, 2017, 7:49 a.m.) Review request for hive, Daniel Dai and Theja

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/ --- (Updated May 16, 2017, 5:59 p.m.) Review request for hive, Daniel Dai and Theja

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/#review175116 --- metastore/src/java/org/apache/hadoop/hive/metastore/cache/SharedC

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/ --- (Updated May 16, 2017, 8:10 a.m.) Review request for hive, Daniel Dai and Theja

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/ --- (Updated May 16, 2017, 3:27 a.m.) Review request for hive, Daniel Dai and Theja

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/ --- (Updated May 16, 2017, 3:25 a.m.) Review request for hive, Daniel Dai and Theja

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/ --- (Updated May 15, 2017, 10:27 p.m.) Review request for hive, Daniel Dai and Thej

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

> On May 15, 2017, 8:19 a.m., Thejas Nair wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > > Line 281 (original), 284 (patched) > > > > > > This needs to be TimeUnit.MILLISECO

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/#review174936 --- metastore/src/java/org/apache/hadoop/hive/metastore/cache/CachedS

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/ --- (Updated May 15, 2017, 7:59 a.m.) Review request for hive, Daniel Dai and Theja

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

> On May 14, 2017, 7:38 a.m., Daniel Dai wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > > Lines 528 (patched) > > > > > > If using dirty flag, databaseCacheLock can be removed

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

> On May 14, 2017, 7:38 a.m., Daniel Dai wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > > Line 381 (original), 526 (patched) > > > > > > I think we only need a dirty flag, it

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

> On May 14, 2017, 7:38 a.m., Daniel Dai wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > > Lines 528 (patched) > > > > > > If using dirty flag, databaseCacheLock can be removed

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/#review174906 --- metastore/src/java/org/apache/hadoop/hive/metastore/cache/CachedS

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/#review174907 --- metastore/src/java/org/apache/hadoop/hive/metastore/cache/CachedS

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/#review174905 --- metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDire

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/ --- (Updated May 14, 2017, 5:19 a.m.) Review request for hive, Daniel Dai and Theja

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/ --- (Updated May 14, 2017, 2:21 a.m.) Review request for hive, Daniel Dai and Theja

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/ --- (Updated May 14, 2017, 1:28 a.m.) Review request for hive, Daniel Dai and Theja

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/#review174841 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Line 90

Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/ --- Review request for hive, Daniel Dai and Thejas Nair. Bugs: HIVE-16579 https