Re: [VOTE] Release Apache httpd 2.4.15 as GA

2015-06-29 Thread William A Rowe Jr
On Mon, Jun 22, 2015 at 2:01 PM, André Malo wrote: > * Yann Ylavic wrote: > > > It seems that RedirectMatch isn't documented without the third (URL) > > argument, unless in . > > Huh? Actually it is (or maybe I'm not getting something here). I checked at > least back until 2.0. > > http://httpd.a

Re: svn commit: r1688339 - /httpd/httpd/trunk/modules/filters/mod_substitute.c

2015-06-29 Thread William A Rowe Jr
On Mon, Jun 29, 2015 at 9:44 PM, William A Rowe Jr wrote: > You ALWAYS preserve unset state. How else do you perform the THIRD merge? > To be more specific, httpd is allowed to merge whatever merges it likes. If it wants to optimize for the directory and then merge the base server to the merged

Re: svn commit: r1688339 - /httpd/httpd/trunk/modules/filters/mod_substitute.c

2015-06-29 Thread William A Rowe Jr
You ALWAYS preserve unset state. How else do you perform the THIRD merge? On Mon, Jun 29, 2015 at 9:01 PM, Yann Ylavic wrote: > This won't work for eg, this second level inheritance: server context > is on, vhost and inner Location are unset. > Location->inherit_before will be unset whereas i

Re: svn commit: r1688339 - /httpd/httpd/trunk/modules/filters/mod_substitute.c

2015-06-29 Thread Yann Ylavic
This won't work for eg, this second level inheritance: server context is on, vhost and inner Location are unset. Location->inherit_before will be unset whereas it should be on. We should not preserve the unset state IMHO. On Tue, Jun 30, 2015 at 3:27 AM, wrote: > Author: wrowe > Date: Tue Jun 30

Re: svn commit: r1688339 - /httpd/httpd/trunk/modules/filters/mod_substitute.c

2015-06-29 Thread William A Rowe Jr
For 2.2/2.4 the delta is a one line change to trunk's behavior; On Mon, Jun 29, 2015 at 8:27 PM, wrote: > Author: wrowe > Date: Tue Jun 30 01:27:42 2015 > New Revision: 1688339 > > URL: http://svn.apache.org/r1688339 > Log: > Very difficult to read, and therefore was wrong. > > Assert that the S

Re: svn commit: r1688331 - /httpd/httpd/trunk/modules/filters/mod_substitute.c

2015-06-29 Thread William A Rowe Jr
On Mon, Jun 29, 2015 at 8:06 PM, Yann Ylavic wrote: > Maybe defining (naming) inherit_before tristate values would help: > Not really... +a->inherit_before = (over->inherit_before == INHERIT_ON > + || (over->inherit_before == INHERIT_UNSET > +

Re: svn commit: r1688331 - /httpd/httpd/trunk/modules/filters/mod_substitute.c

2015-06-29 Thread Yann Ylavic
Maybe defining (naming) inherit_before tristate values would help: Index: modules/filters/mod_substitute.c === --- modules/filters/mod_substitute.c(revision 1688331) +++ modules/filters/mod_substitute.c(working copy) @@ -68,6

Re: svn commit: r1688331 - /httpd/httpd/trunk/modules/filters/mod_substitute.c

2015-06-29 Thread William A Rowe Jr
I was literally switching between a dead and live box repairing a corrupted boot volume, so you may be right or I might have studied a stale patch. Will refresh trunk in a few minutes here with suggested changes. On Jun 29, 2015 7:42 PM, "Yann Ylavic" wrote: > On Tue, Jun 30, 2015 at 2:03 AM, Wi

Re: svn commit: r1688331 - /httpd/httpd/trunk/modules/filters/mod_substitute.c

2015-06-29 Thread Yann Ylavic
On Tue, Jun 30, 2015 at 2:03 AM, William A Rowe Jr wrote: > I can't approve this semantic mess. > > EITHER it is inherit_before on trunk-2.4-2.2 with a change of default > behavior, or it is inherit_after, again across all branches with a change of > default behavior. The delta should consist of

Re: svn commit: r1688331 - /httpd/httpd/trunk/modules/filters/mod_substitute.c

2015-06-29 Thread William A Rowe Jr
I can't approve this semantic mess. EITHER it is inherit_before on trunk-2.4-2.2 with a change of default behavior, or it is inherit_after, again across all branches with a change of default behavior. The delta should consist of a one line difference, evaluating inheritance behavior within the me

Re: LimitRequestBody is broken in 2.4.13-2.4.15

2015-06-29 Thread Yann Ylavic
On Mon, Jun 29, 2015 at 7:58 PM, Yann Ylavic wrote: > On Mon, Jun 29, 2015 at 6:57 PM, Michael Kaufmann > wrote: >> LimitRequestBody is broken in the (unreleased) Apache versions 2.4.13-2.4.15 >> because of this change: http://svn.apache.org/r1684515 >> >> In http_filters.c, ap_http_filter(): The

Re: LimitRequestBody is broken in 2.4.13-2.4.15

2015-06-29 Thread Yann Ylavic
On Mon, Jun 29, 2015 at 6:57 PM, Michael Kaufmann wrote: > LimitRequestBody is broken in the (unreleased) Apache versions 2.4.13-2.4.15 > because of this change: http://svn.apache.org/r1684515 > > In http_filters.c, ap_http_filter(): The variable "totalread" is > uninitialized if readbytes is 0. >

LimitRequestBody is broken in 2.4.13-2.4.15

2015-06-29 Thread Michael Kaufmann
Hi, LimitRequestBody is broken in the (unreleased) Apache versions 2.4.13-2.4.15 because of this change: http://svn.apache.org/r1684515 In http_filters.c, ap_http_filter(): The variable "totalread" is uninitialized if readbytes is 0. Messages similar to this one are logged: "AH01591: Read

Re: Using UPN from subjectAltName with SSLUserName

2015-06-29 Thread Jan Pazdziora
On Mon, Jun 29, 2015 at 01:47:45PM +0200, Jan Pazdziora wrote: > On Sun, Jun 28, 2015 at 05:11:57PM +0200, Kaspar Brand wrote: > > On 22.06.2015 10:37, Jan Pazdziora wrote: > > > Please find a new patch attached which I hope covers all the > > > parts you've outlined, for SSL_CLIENT_SAN_OTHER_msUPN

Re: Using UPN from subjectAltName with SSLUserName

2015-06-29 Thread Jan Pazdziora
On Sun, Jun 28, 2015 at 05:11:57PM +0200, Kaspar Brand wrote: > On 22.06.2015 10:37, Jan Pazdziora wrote: > > Please find a new patch attached which I hope covers all the > > parts you've outlined, for SSL_CLIENT_SAN_OTHER_msUPN_*. > > Thanks. Your implementation assumes that only a single otherNa