[jira] [Commented] (KAFKA-2327) broker doesn't start if config defines advertised.host but not advertised.port

[ https://issues.apache.org/jira/browse/KAFKA-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621176#comment-14621176 ] Edward Ribeiro commented on KAFKA-2327: --- Left some minor review comments, hope you d

[jira] [Commented] (KAFKA-2210) KafkaAuthorizer: Add all public entities, config changes and changes to KafkaAPI and kafkaServer to allow pluggable authorizer implementation.

[ https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627292#comment-14627292 ] Edward Ribeiro commented on KAFKA-2210: --- Hi [~parth.brahmbhatt], left some minor com

[jira] [Commented] (KAFKA-2335) Javadoc for Consumer says that it's thread-safe

[ https://issues.apache.org/jira/browse/KAFKA-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628365#comment-14628365 ] Edward Ribeiro commented on KAFKA-2335: --- I was going to work on this, but go ahead.

[jira] [Commented] (KAFKA-2335) Javadoc for Consumer says that it's thread-safe

[ https://issues.apache.org/jira/browse/KAFKA-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628383#comment-14628383 ] Edward Ribeiro commented on KAFKA-2335: --- LOL, no need to apologize. :) I have just j

[jira] [Commented] (KAFKA-2335) Javadoc for Consumer says that it's thread-safe

[ https://issues.apache.org/jira/browse/KAFKA-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629030#comment-14629030 ] Edward Ribeiro commented on KAFKA-2335: --- Thanks [~hachikuji]! Going to tackle it asa

[jira] [Updated] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2338: -- Attachment: KAFKA-2338.patch > Warn users if they change max.message.bytes that they also need t

[jira] [Commented] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631784#comment-14631784 ] Edward Ribeiro commented on KAFKA-2338: --- Created reviewboard https://reviews.apache.

[jira] [Commented] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631785#comment-14631785 ] Edward Ribeiro commented on KAFKA-2338: --- Hi [~ewencp], as this my first official Kaf

[jira] [Commented] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632244#comment-14632244 ] Edward Ribeiro commented on KAFKA-2338: --- Updated reviewboard https://reviews.apache.

[jira] [Updated] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2338: -- Attachment: KAFKA-2338_2015-07-18_00:37:31.patch > Warn users if they change max.message.bytes t

[jira] [Commented] (KAFKA-2350) Add KafkaConsumer pause capability

[ https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634296#comment-14634296 ] Edward Ribeiro commented on KAFKA-2350: --- Nit: wouldn't the inverse of ``pause`` to b

[jira] [Commented] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634465#comment-14634465 ] Edward Ribeiro commented on KAFKA-2338: --- Hi [~gwenshap], whenever you have a free cy

[jira] [Commented] (KAFKA-251) The ConsumerStats MBean's PartOwnerStats attribute is a string

[ https://issues.apache.org/jira/browse/KAFKA-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635208#comment-14635208 ] Edward Ribeiro commented on KAFKA-251: -- [~ijuma] Hi, if it is still relevant and no on

[jira] [Commented] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635216#comment-14635216 ] Edward Ribeiro commented on KAFKA-2338: --- Oh, ignore the previous message, [~gwenshap

[jira] [Commented] (KAFKA-251) The ConsumerStats MBean's PartOwnerStats attribute is a string

[ https://issues.apache.org/jira/browse/KAFKA-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635224#comment-14635224 ] Edward Ribeiro commented on KAFKA-251: -- I cannot. Afaik, it depends on the project, an

[jira] [Commented] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635330#comment-14635330 ] Edward Ribeiro commented on KAFKA-2338: --- Updated reviewboard https://reviews.apache.

[jira] [Updated] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2338: -- Attachment: KAFKA-2338_2015-07-21_13:21:19.patch > Warn users if they change max.message.bytes t

[jira] [Commented] (KAFKA-2345) Attempt to delete a topic already marked for deletion throws ZkNodeExistsException

[ https://issues.apache.org/jira/browse/KAFKA-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635596#comment-14635596 ] Edward Ribeiro commented on KAFKA-2345: --- [~singhashish], [~gwenshap], sorry, late to

[jira] [Commented] (KAFKA-2354) setting log.dirs property makes tools fail if there is a comma

[ https://issues.apache.org/jira/browse/KAFKA-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635864#comment-14635864 ] Edward Ribeiro commented on KAFKA-2354: --- Hi [~Skandragon], unfortunately, I was unab

[jira] [Created] (KAFKA-2355) Creating a unit test to validate the deletion of a partition marked as deleted

Edward Ribeiro created KAFKA-2355: - Summary: Creating a unit test to validate the deletion of a partition marked as deleted Key: KAFKA-2355 URL: https://issues.apache.org/jira/browse/KAFKA-2355 Projec

[jira] [Updated] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2355: -- Summary: Add an unit test to validate the deletion of a partition marked as deleted (was: Creat

[jira] [Updated] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2355: -- Attachment: KAFKA-2355.patch > Add an unit test to validate the deletion of a partition marked a

[jira] [Commented] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636116#comment-14636116 ] Edward Ribeiro commented on KAFKA-2355: --- Created reviewboard https://reviews.apache.

[jira] [Commented] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636119#comment-14636119 ] Edward Ribeiro commented on KAFKA-2355: --- Hi [~singhashish] and [~gwenshap]. I hope y

[jira] [Updated] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2355: -- Affects Version/s: 0.8.2.1 Status: Patch Available (was: Open) > Add an unit tes

[jira] [Updated] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2355: -- Issue Type: Test (was: Sub-task) Parent: (was: KAFKA-2345) > Add an unit test to va

[jira] [Commented] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637984#comment-14637984 ] Edward Ribeiro commented on KAFKA-2355: --- Updated reviewboard https://reviews.apache.

[jira] [Updated] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2355: -- Attachment: KAFKA-2355_2015-07-22_21:37:51.patch > Add an unit test to validate the deletion of

[jira] [Commented] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637996#comment-14637996 ] Edward Ribeiro commented on KAFKA-2355: --- Hi [~ijuma] and [~granthenke], I have updat

[jira] [Commented] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638036#comment-14638036 ] Edward Ribeiro commented on KAFKA-2355: --- Updated reviewboard https://reviews.apache.

[jira] [Updated] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2355: -- Attachment: KAFKA-2355_2015-07-22_22:23:13.patch > Add an unit test to validate the deletion of

[jira] [Commented] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639011#comment-14639011 ] Edward Ribeiro commented on KAFKA-2355: --- Hi [~ijuma], no problem, mate. If it looks

[jira] [Commented] (KAFKA-2355) Add an unit test to validate the deletion of a partition marked as deleted

[ https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639095#comment-14639095 ] Edward Ribeiro commented on KAFKA-2355: --- Oh, thanks [~gwenshap]! Sorry for any incon

[jira] [Assigned] (KAFKA-1811) ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro reassigned KAFKA-1811: - Assignee: Edward Ribeiro > ensuring registered broker host:port is unique > -

[jira] [Created] (KAFKA-2418) Typo on official KAFKA documentation

Edward Ribeiro created KAFKA-2418: - Summary: Typo on official KAFKA documentation Key: KAFKA-2418 URL: https://issues.apache.org/jira/browse/KAFKA-2418 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-2418) Typo on official KAFKA documentation

[ https://issues.apache.org/jira/browse/KAFKA-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2418: -- Attachment: KAFKA-2418.patch Adding a patch to web site documentation. > Typo on official KAFKA

[jira] [Updated] (KAFKA-2418) Typo on official KAFKA documentation

[ https://issues.apache.org/jira/browse/KAFKA-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2418: -- Affects Version/s: 0.8.0 0.8.1 0.8.2.0 > Typo on o

[jira] [Updated] (KAFKA-2418) Typo on official KAFKA documentation

[ https://issues.apache.org/jira/browse/KAFKA-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2418: -- Status: Patch Available (was: Open) > Typo on official KAFKA documentation > --

[jira] [Commented] (KAFKA-2418) Typo on official KAFKA documentation

[ https://issues.apache.org/jira/browse/KAFKA-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693984#comment-14693984 ] Edward Ribeiro commented on KAFKA-2418: --- Hi folks, if you have any free time could s

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705442#comment-14705442 ] Edward Ribeiro commented on KAFKA-873: -- [~granthenke], [~fpj], [~ijuma] Please, count

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705911#comment-14705911 ] Edward Ribeiro commented on KAFKA-873: -- Sorry, I didn't follow here. Guava is not alre

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705909#comment-14705909 ] Edward Ribeiro commented on KAFKA-873: -- Sorry, I didn't follow here. Guava is not alre

[jira] [Work started] (KAFKA-1811) ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-1811 started by Edward Ribeiro. - > ensuring registered broker host:port is unique >

[jira] [Work stopped] (KAFKA-1811) ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-1811 stopped by Edward Ribeiro. - > ensuring registered broker host:port is unique >

[jira] [Updated] (KAFKA-1811) ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-1811: -- Attachment: KAFKA-1811-2.patch A tentative (git) patch cut for addressing this issue. > ensurin

[jira] [Commented] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709685#comment-14709685 ] Edward Ribeiro commented on KAFKA-2338: --- Updated reviewboard https://reviews.apache.

[jira] [Updated] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2338: -- Attachment: KAFKA-2338_2015-08-24_14:32:38.patch > Warn users if they change max.message.bytes t

[jira] [Updated] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2338: -- Status: Patch Available (was: In Progress) > Warn users if they change max.message.bytes that t

[jira] [Commented] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709707#comment-14709707 ] Edward Ribeiro commented on KAFKA-2338: --- Hi, [~gwenshap], thanks for the kind words.

[jira] [Updated] (KAFKA-1811) ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-1811: -- Status: Patch Available (was: Open) > ensuring registered broker host:port is unique >

[jira] [Updated] (KAFKA-1811) ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-1811: -- Attachment: KAFKA-1811.patch > ensuring registered broker host:port is unique >

[jira] [Commented] (KAFKA-1811) ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709767#comment-14709767 ] Edward Ribeiro commented on KAFKA-1811: --- Created reviewboard https://reviews.apache.

[jira] [Updated] (KAFKA-1811) ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-1811: -- Attachment: (was: KAFKA-1811-2.patch) > ensuring registered broker host:port is unique > ---

[jira] [Commented] (KAFKA-1811) ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709794#comment-14709794 ] Edward Ribeiro commented on KAFKA-1811: --- Hi [~gwenshap] and [~nehanarkhede], I have

[jira] [Issue Comment Deleted] (KAFKA-1811) ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-1811: -- Comment: was deleted (was: A tentative (git) patch cut for addressing this issue.) > ensuring r

[jira] [Comment Edited] (KAFKA-1811) ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709794#comment-14709794 ] Edward Ribeiro edited comment on KAFKA-1811 at 8/24/15 6:42 PM:

[jira] [Updated] (KAFKA-1811) Ensuring registered broker host:port is unique

[ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-1811: -- Summary: Ensuring registered broker host:port is unique (was: ensuring registered broker host:p

[jira] [Commented] (KAFKA-2473) Not able to find release version with patch jira-1591

[ https://issues.apache.org/jira/browse/KAFKA-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712009#comment-14712009 ] Edward Ribeiro commented on KAFKA-2473: --- Hi Amar, please, post this kind of question

[jira] [Comment Edited] (KAFKA-2473) Not able to find release version with patch jira-1591

[ https://issues.apache.org/jira/browse/KAFKA-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712009#comment-14712009 ] Edward Ribeiro edited comment on KAFKA-2473 at 8/25/15 9:30 PM:

[jira] [Comment Edited] (KAFKA-2473) Not able to find release version with patch jira-1591

[ https://issues.apache.org/jira/browse/KAFKA-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712009#comment-14712009 ] Edward Ribeiro edited comment on KAFKA-2473 at 8/25/15 9:33 PM:

[jira] [Commented] (KAFKA-2498) need build steps/instruction while building apache kafka from source github branch 0.8.2

[ https://issues.apache.org/jira/browse/KAFKA-2498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725882#comment-14725882 ] Edward Ribeiro commented on KAFKA-2498: --- Hi [~gundun], I am afraid you lost me here.

[jira] [Commented] (KAFKA-2499) kafka-producer-perf-test should use something more realistic than empty byte arrays

[ https://issues.apache.org/jira/browse/KAFKA-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726069#comment-14726069 ] Edward Ribeiro commented on KAFKA-2499: --- Hi [~benstopford], I have a tidy bit of pre

[jira] [Commented] (KAFKA-2499) kafka-producer-perf-test should use something more realistic than empty byte arrays

[ https://issues.apache.org/jira/browse/KAFKA-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726134#comment-14726134 ] Edward Ribeiro commented on KAFKA-2499: --- okay, thanks! > kafka-producer-perf-test

[jira] [Updated] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2338: -- Attachment: KAFKA-2338_2015-09-02_19:27:17.patch > Warn users if they change max.message.bytes t

[jira] [Commented] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14728149#comment-14728149 ] Edward Ribeiro commented on KAFKA-2338: --- Updated reviewboard https://reviews.apache.

[jira] [Commented] (KAFKA-2515) handle oversized messages properly in new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744102#comment-14744102 ] Edward Ribeiro commented on KAFKA-2515: --- [~onurkaraman], isn't this issue related to

[jira] [Commented] (KAFKA-2515) handle oversized messages properly in new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744252#comment-14744252 ] Edward Ribeiro commented on KAFKA-2515: --- Ewen was able to simulate the bug with a si

[jira] [Commented] (KAFKA-2563) Version number major.major.minor.fix in kafka-merge-pr.py

[ https://issues.apache.org/jira/browse/KAFKA-2563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901212#comment-14901212 ] Edward Ribeiro commented on KAFKA-2563: --- This is a duplicate of KAFKA-2548. ;) >

[jira] [Commented] (KAFKA-2578) Client Metadata internal state should be synchronized

[ https://issues.apache.org/jira/browse/KAFKA-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934269#comment-14934269 ] Edward Ribeiro commented on KAFKA-2578: --- Hey, [~hachikuji], this patch is so trivial

[jira] [Assigned] (KAFKA-2578) Client Metadata internal state should be synchronized

[ https://issues.apache.org/jira/browse/KAFKA-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro reassigned KAFKA-2578: - Assignee: Edward Ribeiro (was: Jason Gustafson) > Client Metadata internal state should

[jira] [Commented] (KAFKA-2578) Client Metadata internal state should be synchronized

[ https://issues.apache.org/jira/browse/KAFKA-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934290#comment-14934290 ] Edward Ribeiro commented on KAFKA-2578: --- Thanks, mate! :) > Client Metadata interna

[jira] [Created] (KAFKA-2599) Metadata#getClusterForCurrentTopics can throw NPE even with null checking

Edward Ribeiro created KAFKA-2599: - Summary: Metadata#getClusterForCurrentTopics can throw NPE even with null checking Key: KAFKA-2599 URL: https://issues.apache.org/jira/browse/KAFKA-2599 Project: Ka

[jira] [Updated] (KAFKA-2599) Metadata#getClusterForCurrentTopics can throw NPE even with null checking

[ https://issues.apache.org/jira/browse/KAFKA-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2599: -- Description: While working on another issue I have just seen the following: {code} private

[jira] [Comment Edited] (KAFKA-2578) Client Metadata internal state should be synchronized

[ https://issues.apache.org/jira/browse/KAFKA-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934290#comment-14934290 ] Edward Ribeiro edited comment on KAFKA-2578 at 9/29/15 9:35 PM:

[jira] [Comment Edited] (KAFKA-2578) Client Metadata internal state should be synchronized

[ https://issues.apache.org/jira/browse/KAFKA-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934290#comment-14934290 ] Edward Ribeiro edited comment on KAFKA-2578 at 9/29/15 9:36 PM:

[jira] [Updated] (KAFKA-2599) Metadata#getClusterForCurrentTopics can throw NPE even with null checking

[ https://issues.apache.org/jira/browse/KAFKA-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2599: -- Status: Patch Available (was: Open) > Metadata#getClusterForCurrentTopics can throw NPE even wi

[jira] [Updated] (KAFKA-2578) Client Metadata internal state should be synchronized

[ https://issues.apache.org/jira/browse/KAFKA-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2578: -- Status: Patch Available (was: Open) > Client Metadata internal state should be synchronized > -

[jira] [Assigned] (KAFKA-2601) ConsoleProducer tool shows stacktrace on invalid command parameters

[ https://issues.apache.org/jira/browse/KAFKA-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro reassigned KAFKA-2601: - Assignee: Edward Ribeiro > ConsoleProducer tool shows stacktrace on invalid command param

[jira] [Comment Edited] (KAFKA-2601) ConsoleProducer tool shows stacktrace on invalid command parameters

[ https://issues.apache.org/jira/browse/KAFKA-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939213#comment-14939213 ] Edward Ribeiro edited comment on KAFKA-2601 at 10/1/15 3:17 AM:

[jira] [Commented] (KAFKA-2601) ConsoleProducer tool shows stacktrace on invalid command parameters

[ https://issues.apache.org/jira/browse/KAFKA-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939213#comment-14939213 ] Edward Ribeiro commented on KAFKA-2601: --- Excuse me, Gabriel, I jumped too soon on th

[jira] [Updated] (KAFKA-2601) ConsoleProducer tool shows stacktrace on invalid command parameters

[ https://issues.apache.org/jira/browse/KAFKA-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2601: -- Assignee: (was: Edward Ribeiro) > ConsoleProducer tool shows stacktrace on invalid command p

[jira] [Updated] (KAFKA-2601) ConsoleProducer tool shows stacktrace on invalid command parameters

[ https://issues.apache.org/jira/browse/KAFKA-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2601: -- Reviewer: (was: Edward Ribeiro) > ConsoleProducer tool shows stacktrace on invalid command par

[jira] [Commented] (KAFKA-2601) ConsoleProducer tool shows stacktrace on invalid command parameters

[ https://issues.apache.org/jira/browse/KAFKA-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940026#comment-14940026 ] Edward Ribeiro commented on KAFKA-2601: --- Hi [~GabrielNicolasAvellaneda], LGTM, but

[jira] [Updated] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2338: -- Assignee: (was: Edward Ribeiro) > Warn users if they change max.message.bytes that they also

[jira] [Commented] (KAFKA-2659) Warn user, if increasing max message bytes, to also increase on consumer

[ https://issues.apache.org/jira/browse/KAFKA-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14959455#comment-14959455 ] Edward Ribeiro commented on KAFKA-2659: --- [~gwenshap], Oh, it's KAFKA-2338, but I did

[jira] [Updated] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2338: -- Assignee: Ben Stopford > Warn users if they change max.message.bytes that they also need to upda

[jira] [Assigned] (KAFKA-2685) "alter topic" on non-existent topic exits without error

[ https://issues.apache.org/jira/browse/KAFKA-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro reassigned KAFKA-2685: - Assignee: Edward Ribeiro > "alter topic" on non-existent topic exits without error >

[jira] [Commented] (KAFKA-1227) Code dump of new producer

[ https://issues.apache.org/jira/browse/KAFKA-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882758#comment-13882758 ] Edward Ribeiro commented on KAFKA-1227: --- Hello folks, I've just started to look int

[jira] [Commented] (KAFKA-1227) Code dump of new producer

[ https://issues.apache.org/jira/browse/KAFKA-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890594#comment-13890594 ] Edward Ribeiro commented on KAFKA-1227: --- Two review board entries were created for t