slachiewicz merged pull request #50:
URL: https://github.com/apache/maven-site-plugin/pull/50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
dependabot[bot] opened a new pull request #50:
URL: https://github.com/apache/maven-site-plugin/pull/50
Bumps [maven-shared-utils](https://github.com/apache/maven-shared-utils)
from 3.3.3 to 3.3.4.
Commits
We have already moved ahead and the new Resolver should solve this issue.
This looks similar to the issue in Surefire which was closed as a bug of
Resoler. Michael is currently working on a new Resolver and he was
participating in the analysis of the bug too. So, maybe it is still the
same root
cstamas edited a comment on pull request #24:
URL:
https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830872440
Added some cleanup (properties may need more) and for fun disabled 3.0.5 in
ITs, and added 3.6.3 and 3.8.1, so ITs now run on "3.1.1", "3.2.5", "3.3.9",
cstamas commented on pull request #24:
URL:
https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830872440
Added some cleanup (properties may need more) and for fun disabled 3.0.5 mvn
in its, and added 3.6.3 and 3.8.1
--
This is an automated message from the Apache
we are in pain with this issue :-)
-D
On Sun, Jan 24, 2021 at 2:56 PM Tibor Digana wrote:
> Hi Falco,
>
> This is not the first time I have been talking about these principles in
> our team.
> Seven years ago and then in 2019. But sorry I cannot force the people to do
> it and they have to
cstamas closed pull request #30:
URL: https://github.com/apache/maven-artifact-transfer/pull/30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
cstamas commented on pull request #24:
URL:
https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830857877
> I think I know what you've done. Whereas I started with the single jar
approach, you separated the code into modules.
> I can't see the new structure, but I
rfscholte commented on pull request #24:
URL:
https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830853914
I think I know what you've done. Whereas I started with the single jar
approach, you separated the code into modules.
I can't see the new structure, but I
cstamas commented on a change in pull request #30:
URL:
https://github.com/apache/maven-artifact-transfer/pull/30#discussion_r624738405
##
File path: .github/workflows/maven.yml
##
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
pzygielo commented on a change in pull request #30:
URL:
https://github.com/apache/maven-artifact-transfer/pull/30#discussion_r624737531
##
File path: .github/workflows/maven.yml
##
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
pzygielo commented on a change in pull request #30:
URL:
https://github.com/apache/maven-artifact-transfer/pull/30#discussion_r624737531
##
File path: .github/workflows/maven.yml
##
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
cstamas commented on a change in pull request #30:
URL:
https://github.com/apache/maven-artifact-transfer/pull/30#discussion_r624737309
##
File path: .github/workflows/maven.yml
##
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
pzygielo commented on a change in pull request #30:
URL:
https://github.com/apache/maven-artifact-transfer/pull/30#discussion_r624737151
##
File path: .github/workflows/maven.yml
##
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
cstamas opened a new pull request #30:
URL: https://github.com/apache/maven-artifact-transfer/pull/30
To run also ITs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
cstamas commented on pull request #24:
URL:
https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830850967
So to say, "restructure" the code, make these modules and remove the
reflection cruft (to make easier to maintain and more readable), and then we
merge this PR,
cstamas commented on pull request #24:
URL:
https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830850698
> Can you explain why we need `Maven302RepositoryManager` instead of just
`Maven302RepositoryManager`?
Again, old code that I did not touch (aside of making
michael-o edited a comment on pull request #24:
URL:
https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830850011
Can you explain why we need `Maven302RepositoryManager` instead of just
`Maven302RepositoryManager`?
--
This is an automated message from the Apache
michael-o commented on pull request #24:
URL:
https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830850011
Can you explain why we need `Maven302RepositoryManager? instead of just
`Maven302RepositoryManager`?
--
This is an automated message from the Apache Git
michael-o commented on pull request #24:
URL:
https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830849772
>
>
> General remark @michael-o : I did not made any other code change then:
>
> * added ProjectBuildingRequest parameter to methods, removed
cstamas commented on pull request #24:
URL:
https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830849694
Applied PR comments (sans NPE, see above why), all ITs pass except the 3.0.5
(as before, as it's sisu does not speak sisu index)
--
This is an automated message
cstamas commented on a change in pull request #24:
URL:
https://github.com/apache/maven-artifact-transfer/pull/24#discussion_r624734298
##
File path: maven-artifact-transfer/pom.xml
##
@@ -0,0 +1,188 @@
+
+
+http://maven.apache.org/POM/4.0.0;
cstamas commented on a change in pull request #24:
URL:
https://github.com/apache/maven-artifact-transfer/pull/24#discussion_r624734274
##
File path: maven-artifact-transfer/pom.xml
##
@@ -0,0 +1,188 @@
+
+
+http://maven.apache.org/POM/4.0.0;
cstamas commented on a change in pull request #24:
URL:
https://github.com/apache/maven-artifact-transfer/pull/24#discussion_r624734205
##
File path: maven-3.1.x/pom.xml
##
@@ -0,0 +1,148 @@
+
+
+http://maven.apache.org/POM/4.0.0;
cstamas commented on a change in pull request #24:
URL:
https://github.com/apache/maven-artifact-transfer/pull/24#discussion_r624734173
##
File path:
maven-3.0.x/src/main/java/org/apache/maven/shared/transfer/repository/internal/Maven302RepositoryManager.java
##
@@ -20,18
cstamas commented on a change in pull request #24:
URL:
https://github.com/apache/maven-artifact-transfer/pull/24#discussion_r624734045
##
File path: maven-3.0.x/pom.xml
##
@@ -0,0 +1,148 @@
+
+
+http://maven.apache.org/POM/4.0.0;
cstamas commented on a change in pull request #24:
URL:
https://github.com/apache/maven-artifact-transfer/pull/24#discussion_r624730059
##
File path: maven-3.0.x/pom.xml
##
@@ -0,0 +1,148 @@
+
+
+http://maven.apache.org/POM/4.0.0;
cstamas edited a comment on pull request #24:
URL:
https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830844133
General remark @michael-o : I did not made any other code change then:
* added ProjectBuildingRequest parameter to methods, removed some unneeded
members
cstamas commented on pull request #24:
URL:
https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830844133
General remark @michael-o : I did not made any other code change then:
* added to methods ProjectBuildingRequest
* removed reflection bits, replaced with
michael-o commented on pull request #48:
URL: https://github.com/apache/maven-site-plugin/pull/48#issuecomment-830843997
The test looks convoluted to me. Why not fire up Jetty, and get the
`Content-Type` header from response? Done.
--
This is an automated message from the Apache Git
qualitesys commented on a change in pull request #48:
URL: https://github.com/apache/maven-site-plugin/pull/48#discussion_r624727891
##
File path: src/main/java/org/apache/maven/plugins/site/run/DoxiaFilter.java
##
@@ -114,6 +117,16 @@ public void doFilter( ServletRequest
michael-o commented on a change in pull request #24:
URL:
https://github.com/apache/maven-artifact-transfer/pull/24#discussion_r624720934
##
File path: maven-3.0.x/pom.xml
##
@@ -0,0 +1,148 @@
+
+
+http://maven.apache.org/POM/4.0.0;
dependabot[bot] commented on pull request #28:
URL:
https://github.com/apache/maven-artifact-transfer/pull/28#issuecomment-830804334
OK, I won't notify you again about this release, but will get in touch when
a new version is available.
If you change your mind, just re-open this PR
asfgit closed pull request #28:
URL: https://github.com/apache/maven-artifact-transfer/pull/28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
asfgit closed pull request #25:
URL: https://github.com/apache/maven-artifact-transfer/pull/25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
dependabot[bot] commented on pull request #25:
URL:
https://github.com/apache/maven-artifact-transfer/pull/25#issuecomment-830804164
OK, I won't notify you again about this release, but will get in touch when
a new version is available.
If you change your mind, just re-open this PR
dependabot[bot] commented on pull request #26:
URL:
https://github.com/apache/maven-artifact-transfer/pull/26#issuecomment-830804047
OK, I won't notify you again about this release, but will get in touch when
a new version is available.
If you change your mind, just re-open this PR
asfgit closed pull request #26:
URL: https://github.com/apache/maven-artifact-transfer/pull/26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
asfgit closed pull request #29:
URL: https://github.com/apache/maven-artifact-transfer/pull/29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
dependabot[bot] commented on pull request #29:
URL:
https://github.com/apache/maven-artifact-transfer/pull/29#issuecomment-830803994
OK, I won't notify you again about this release, but will get in touch when
a new version is available.
If you change your mind, just re-open this PR
asfgit closed pull request #27:
URL: https://github.com/apache/maven-artifact-transfer/pull/27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
dependabot[bot] commented on pull request #27:
URL:
https://github.com/apache/maven-artifact-transfer/pull/27#issuecomment-830803947
OK, I won't notify you again about this release, but will get in touch when
a new version is available.
If you change your mind, just re-open this PR
dependabot[bot] opened a new pull request #29:
URL: https://github.com/apache/maven-artifact-transfer/pull/29
Bumps [aether-impl](https://github.com/sonatype/sonatype-aether) from 1.7 to
1.13.1.
Commits
dependabot[bot] opened a new pull request #28:
URL: https://github.com/apache/maven-artifact-transfer/pull/28
Bumps
[maven-common-artifact-filters](https://github.com/apache/maven-common-artifact-filters)
from 3.1.0 to 3.2.0.
Commits
dependabot[bot] opened a new pull request #27:
URL: https://github.com/apache/maven-artifact-transfer/pull/27
Bumps [maven-artifact](https://github.com/apache/maven) from 3.0 to 3.8.1.
Commits
dependabot[bot] opened a new pull request #26:
URL: https://github.com/apache/maven-artifact-transfer/pull/26
Bumps aether-api from 0.9.0.M2 to 1.1.0.
[![Dependabot compatibility
dependabot[bot] opened a new pull request #25:
URL: https://github.com/apache/maven-artifact-transfer/pull/25
Bumps aether-util from 0.9.0.M2 to 1.1.0.
[