Github user nickwallen commented on the issue:
https://github.com/apache/incubator-metron/pull/380
Closing this PR. About to open another one with the fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ottobackwards commented on the issue:
https://github.com/apache/incubator-metron/pull/380
I think you closed the wrong one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user nickwallen commented on the issue:
https://github.com/apache/incubator-metron/pull/380
I was not happy with #381 . I will reopen it soon once I have a fix that I
am happy with.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user JonZeolla commented on the issue:
https://github.com/apache/incubator-metron/pull/380
@nickwallen Sounds reasonable, once #381 gets fleshed out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nickwallen commented on the issue:
https://github.com/apache/incubator-metron/pull/380
I believe that #381 is the real solution to this problem. This PR being
simply a work around. I would prefer to push #381 and close this PR.
Open to other's opinions though.
Github user dlyle65535 commented on the issue:
https://github.com/apache/incubator-metron/pull/380
Probably a dumb question, but doesn't integration-test run Failsafe?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user dlyle65535 commented on the issue:
https://github.com/apache/incubator-metron/pull/380
@JonZeolla - oh yeah, totally in agreement there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user JonZeolla commented on the issue:
https://github.com/apache/incubator-metron/pull/380
@dlyle65535 while we slightly disagree on semantics, I agree that this
should move forward for the short term. I'm primarily indicating that the dev
guide needs updated to account for si
Github user dlyle65535 commented on the issue:
https://github.com/apache/incubator-metron/pull/380
Alternatively, if you wanted a one-liner, I think you could @Ignore the
test class.
I didn't see @JonZeolla - add to the [DISCUSS] thread, so I'll answer here-
I don't agree tha
Github user ottobackwards commented on the issue:
https://github.com/apache/incubator-metron/pull/380
Would it be worth closing/reopening a PASSING PR to see if it too fails?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user JonZeolla commented on the issue:
https://github.com/apache/incubator-metron/pull/380
Doesn't this conflict with the merge requirements on the draft [Coding
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
page? Specifically:
* A
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/380
Agreed, this should be changed in the pom.
http://maven.apache.org/surefire/maven-surefire-plugin/examples/inclusion-exclusion.html
---
If your project is set up for it, you can reply to
Github user ottobackwards commented on the issue:
https://github.com/apache/incubator-metron/pull/380
Configuration only change. So, let's say that there is another pr that
changes that test, it can do so without worrying about the commented out code
etc. not a big deal, really jus
Github user nickwallen commented on the issue:
https://github.com/apache/incubator-metron/pull/380
Dunno. What are the advantages to doing it that way?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user ottobackwards commented on the issue:
https://github.com/apache/incubator-metron/pull/380
can this be done in the pom/surefire?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
15 matches
Mail list logo
