Niklas Gustavsson wrote:
> On Tue, May 4, 2010 at 5:34 PM, Bernd Fondermann
> wrote:
>> BTW, that's common in real life XMPP streams: arbitrary whitespaces.
>> Some clients send spaces as keep-alives.
>
> The problem struck me right after sending the last email (after which
> I had to run of to
Cancelling this vote. I've fixed the SFTP issue and will upload a new
candidate asap.
On Tue, May 4, 2010 at 15:19, Guillaume Nodet wrote:
> I've uploaded a RC for SSHD 0.4.0 at
> https://repository.apache.org/content/repositories/orgapachemina-003/
>
> The release notes are available at
>
I've uploaded a RC for SSHD 0.4.0 at
https://repository.apache.org/content/repositories/orgapachemina-008/
The release notes are available at
https://cwiki.apache.org/SSHD/sshd-040.html
Please review and vote.
--
Cheers,
Guillaume Nodet
Blog: http://gnodet.blogspot.
On Wed, May 5, 2010 at 10:53 AM, Bernd Fondermann wrote:
> Probably the test coverage is not sufficient.
That's a given for any code :-) As noted, we surely need more integration tests.
> Did you actually try to connect a real client to a real server?
Yes, I usually verify using Adium (which us
Make Vysper report the correct version on Version-IQ request
Key: VYSPER-202
URL: https://issues.apache.org/jira/browse/VYSPER-202
Project: VYSPER
Issue Type: Bug
Compone
On 5/5/10 11:52 AM, Guillaume Nodet wrote:
I've uploaded a RC for SSHD 0.4.0 at
https://repository.apache.org/content/repositories/orgapachemina-008/
The release notes are available at
https://cwiki.apache.org/SSHD/sshd-040.html
Please review and vote.
+1
--
Regards,
Cordialement,
Is this SFTP fix checked into trunk or 0.4 tag? I do not see any
changes to the SVN.
Regards,
Sai Pullabhotla
On Wed, May 5, 2010 at 4:52 AM, Guillaume Nodet wrote:
> I've uploaded a RC for SSHD 0.4.0 at
> https://repository.apache.org/content/repositories/orgapachemina-008/
>
> The release
Argh, I committed to my git repo and forgot to push the change.
On Wed, May 5, 2010 at 14:53, Sai Pullabhotla
wrote:
> Is this SFTP fix checked into trunk or 0.4 tag? I do not see any
> changes to the SVN.
>
> Regards,
> Sai Pullabhotla
>
>
>
>
>
> On Wed, May 5, 2010 at 4:52 AM, Guillaume Nodet
Committed at rev 941273. Could you give it a try asap please ? I'll wait
for your input before recutting the release.
On Wed, May 5, 2010 at 15:02, Guillaume Nodet wrote:
> Argh, I committed to my git repo and forgot to push the change.
>
>
> On Wed, May 5, 2010 at 14:53, Sai Pullabhotla <
> s
Okay, I got the fix and was able to see the directory listing using
FileZilla. However, a couple of issues:
1. Date/time on the files returned by the list are incorrect. Looks
like SSHD is always sending "Jan 01 00:00" for the date times.
2. I could not download or upload a file. Below is the trac
I think I got it to work a little better by changing the code in
SftpSubsystem.sendAbsoluteName to as follows:
line 743:
buffer.putString("/" + file.getPath().replace('\\', '/'));
In order to make it work correctly on *NIX systems, we might need a
check to determine whether or not we sho
[
https://issues.apache.org/jira/browse/VYSPER-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864329#action_12864329
]
Niklas Gustavsson commented on VYSPER-202:
--
How about we read this value from a pr
On Wed, May 5, 2010 at 15:33, Sai Pullabhotla
wrote:
> I think I got it to work a little better by changing the code in
> SftpSubsystem.sendAbsoluteName to as follows:
>
> line 743:
>
>buffer.putString("/" + file.getPath().replace('\\', '/'));
>
>
Let my try something like that.
> In or
I removed the second call to place the path in the buffer and seems to
be working fine.
Regards,
Sai Pullabhotla
How about something like this:
protected void sendAbsoluteName(int id, File file) throws IOException {
Buffer buffer = new Buffer();
buffer.putByte((byte) SSH_FXP_NAME);
buffer.putInt(id);
buffer.putInt(1);
String path = file.getPath();
if(File.s
[
https://issues.apache.org/jira/browse/VYSPER-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864335#action_12864335
]
Bernd Fondermann commented on VYSPER-202:
-
+1, that's exactly what i missed to ask.
Yeah, that's what I'm trying.
Let me try with removing the double name though.
On Wed, May 5, 2010 at 15:50, Sai Pullabhotla
wrote:
> How about something like this:
>
>protected void sendAbsoluteName(int id, File file) throws IOException {
>Buffer buffer = new Buffer();
>buffe
Niklas Gustavsson wrote:
>
> :-D Anyways, could you please verify the problem you had with MUC and
> default namespaces now?
Yes, I can verify that the problem has come back.
(Is that the right answer, or the wrong one?)
Bernd
Removing the second string works with FileZilla but fails with the sftp
command line utility.
On Wed, May 5, 2010 at 16:13, Guillaume Nodet wrote:
> Yeah, that's what I'm trying.
> Let me try with removing the double name though.
>
>
> On Wed, May 5, 2010 at 15:50, Sai Pullabhotla <
> sai.pullab
I've committed the changes. Could you give a try ?
On Wed, May 5, 2010 at 16:20, Guillaume Nodet wrote:
> Removing the second string works with FileZilla but fails with the sftp
> command line utility.
>
>
> On Wed, May 5, 2010 at 16:13, Guillaume Nodet wrote:
>
>> Yeah, that's what I'm trying
Bernd Fondermann wrote:
> Niklas Gustavsson wrote:
>> :-D Anyways, could you please verify the problem you had with MUC and
>> default namespaces now?
>
> Yes, I can verify that the problem has come back.
> (Is that the right answer, or the wrong one?)
... and the known patch fixes it.
Bernd
Btw, I also cancel this vote. I'll upload a new candidate once everyone is
happy ;-)
On Wed, May 5, 2010 at 11:52, Guillaume Nodet wrote:
> I've uploaded a RC for SSHD 0.4.0 at
> https://repository.apache.org/content/repositories/orgapachemina-008/
>
> The release notes are available at
> h
[
https://issues.apache.org/jira/browse/VYSPER-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864346#action_12864346
]
Niklas Gustavsson commented on VYSPER-202:
--
If you take care of reading for the pr
[
https://issues.apache.org/jira/browse/VYSPER-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864348#action_12864348
]
Bernd Fondermann commented on VYSPER-202:
-
deal.
> Make Vysper report the correct
I just noticed that the code checked in just replaces "\" with "/". I
think for best compliance on all operating systems and file systems,
it should replace File.separatorChar with "/". Not sure if there are
any file systems that use a separator other than "/" and "\".
Regards,
Sai Pullabhotla
Haven't seen any such system, but i can easily change that, it will be
cleaner.
On Wed, May 5, 2010 at 16:41, Sai Pullabhotla
wrote:
> I just noticed that the code checked in just replaces "\" with "/". I
> think for best compliance on all operating systems and file systems,
> it should replace F
Fixed, let me know if you find any other easily fixed issues.
On Wed, May 5, 2010 at 16:41, Sai Pullabhotla
wrote:
> I just noticed that the code checked in just replaces "\" with "/". I
> think for best compliance on all operating systems and file systems,
> it should replace File.separatorChar
On Wed, May 5, 2010 at 4:25 PM, Bernd Fondermann wrote:
> Bernd Fondermann wrote:
>> Niklas Gustavsson wrote:
>>> :-D Anyways, could you please verify the problem you had with MUC and
>>> default namespaces now?
>>
>> Yes, I can verify that the problem has come back.
>> (Is that the right answer,
How about the dates on the files?
Regards,
Sai Pullabhotla
On Wed, May 5, 2010 at 10:13 AM, Guillaume Nodet wrote:
> Fixed, let me know if you find any other easily fixed issues.
>
> On Wed, May 5, 2010 at 16:41, Sai Pullabhotla
> wrote:
>
>> I just noticed that the code checked in just repl
Oh, by the way, it works fine for me with just putting (sending) the
path just once in the buffer. Tried with native sftp client on Ubuntu
Linux as well as Putty's SFTP command line client, which is what
FileZilla uses internally. I wonder why that does not work for you.
Regards,
Sai Pullabhotla
Which dates ? I've fixed the "Jan 01 ..." thing if that's why you're
referring to.
But using filezilla, there are still things that we don't support, but i've
been able to download directories recursively without problems.
On Wed, May 5, 2010 at 17:49, Sai Pullabhotla
wrote:
> How about the dates
Okay, I see the fix for the dates, but they are still incorrect when
the client interprets its. Couple of things -
I believe time should be on a 24 hour clock basis - so the format need
to be changed to HH instead of hh.
The listing is not compatible with UNIX style listing. So files older
than 6
Gents,
Can we please change the topic of this email to a dev discussion... the [VOTE]
in it is probably not appropriate since [VOTE] indicates a real vote. Thanks!
Jeff
On May 5, 2010, at 10:43 AM, Sai Pullabhotla wrote:
> Okay, I see the fix for the dates, but they are still incorrect when
>
On Wed, May 5, 2010 at 17:25, Niklas Gustavsson wrote:
> On Wed, May 5, 2010 at 4:25 PM, Bernd Fondermann
> wrote:
>> Bernd Fondermann wrote:
>>> Niklas Gustavsson wrote:
:-D Anyways, could you please verify the problem you had with MUC and
default namespaces now?
>>>
>>> Yes, I can ve
Thanks for the pointer. The SFTP subsystem is now using that code.
Any more issues ?
On Wed, May 5, 2010 at 18:43, Sai Pullabhotla
wrote:
> Okay, I see the fix for the dates, but they are still incorrect when
> the client interprets its. Couple of things -
>
> I believe time should be on a 24 ho
On Wed, May 5, 2010 at 7:55 PM, Bernd Fondermann
wrote:
> The group chat problem is between Psi and Psi. But I didn't test that
> today, but will tomorrow.
Great, let me know the results (or how to reproduce it).
> And I don't think those xmlns="" should be there. Isn't this kind of
> overwritin
36 matches
Mail list logo