Re: Review Request 65239: PIG-5253: Pig Hadoop 3 support

2019-04-10 Thread Nandor Kollar via Review Board
> On Jan. 26, 2018, 4:58 p.m., Rohini Palaniswamy wrote: > > bin/pig > > Line 480 (original), 478 (patched) > > > > > > How does it work when both h2 and h3 jars are generated in one target? Is it possible to build

Re: Review Request 65239: PIG-5253: Pig Hadoop 3 support

2019-04-10 Thread Nandor Kollar via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65239/ --- (Updated April 10, 2019, 11:49 a.m.) Review request for pig, Daniel Dai, Koji

Re: Review Request 65239: PIG-5253: Pig Hadoop 3 support

2018-09-20 Thread Nandor Kollar via Review Board
> On Jan. 26, 2018, 4:58 p.m., Rohini Palaniswamy wrote: > > test/org/apache/pig/test/MiniCluster.java > > Line 107 (original), 112-114 (patched) > > > > > > Refer to YarnMiniCluster for what is written into each of

Re: Review Request 65239: PIG-5253: Pig Hadoop 3 support

2018-09-05 Thread Nandor Kollar via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65239/ --- (Updated Sept. 5, 2018, 4:37 p.m.) Review request for pig, Daniel Dai, Koji

Re: Review Request 65239: PIG-5253: Pig Hadoop 3 support

2018-09-05 Thread Nandor Kollar via Review Board
> On Jan. 22, 2018, 2:28 p.m., Adam Szita wrote: > > build.xml > > Line 1003 (original), 1071 (patched) > > > > > > Why is jar listed as new dependency target here? > > > > AFAIK compile-test already

Re: Review Request 65239: PIG-5253: Pig Hadoop 3 support

2018-02-19 Thread Nandor Kollar via Review Board
> On Jan. 26, 2018, 4:58 p.m., Rohini Palaniswamy wrote: > > test/org/apache/pig/test/MiniCluster.java > > Line 107 (original), 112-114 (patched) > > > > > > Refer to YarnMiniCluster for what is written into each of

Re: Review Request 65239: PIG-5253: Pig Hadoop 3 support

2018-02-19 Thread Nandor Kollar via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65239/ --- (Updated Feb. 19, 2018, 1:54 p.m.) Review request for pig, Daniel Dai, Koji

Re: Review Request 65239: PIG-5253: Pig Hadoop 3 support

2018-02-02 Thread Nandor Kollar via Review Board
> On Jan. 26, 2018, 4:58 p.m., Rohini Palaniswamy wrote: > > test/org/apache/pig/test/MiniCluster.java > > Line 107 (original), 112-114 (patched) > > > > > > Refer to YarnMiniCluster for what is written into each of

Re: Review Request 65239: PIG-5253: Pig Hadoop 3 support

2018-01-29 Thread Nandor Kollar via Review Board
> On Jan. 26, 2018, 4:58 p.m., Rohini Palaniswamy wrote: > > test/org/apache/pig/parser/TestQueryParserUtils.java > > Line 63 (original), 63 (patched) > > > > > > What is swebhdfs? secure webhdfs? Yes, it is secure

Review Request 65239: PIG-5253: Pig Hadoop 3 support

2018-01-19 Thread Nandor Kollar via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65239/ --- Review request for pig, Daniel Dai, Koji Noguchi, Rohini Palaniswamy, and Adam