Github user asfgit closed the pull request at:
https://github.com/apache/incubator-predictionio/pull/421
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/421#discussion_r134419406
--- Diff:
storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/ESPEvents.scala
---
@@ -107,37 +107,32 @@
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/421#discussion_r134416803
--- Diff:
storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/StorageClient.scala
---
@@ -18,27 +18,84
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/421#discussion_r134398339
--- Diff:
core/src/main/scala/org/apache/predictionio/workflow/CleanupFunctions.scala ---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the A
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/421#discussion_r134399760
--- Diff:
data/src/main/scala/org/apache/predictionio/data/storage/Storage.scala ---
@@ -461,4 +463,11 @@ object Storage extends Logging {
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/421#discussion_r134417513
--- Diff:
storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/StorageClient.scala
---
@@ -18,27 +18,84
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/421#discussion_r134419379
--- Diff:
storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/ESPEvents.scala
---
@@ -107,37 +107,32 @@
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/421#discussion_r134399019
--- Diff:
core/src/main/scala/org/apache/predictionio/workflow/CleanupFunctions.scala ---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the A
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/421#discussion_r134419425
--- Diff:
storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/ESPEvents.scala
---
@@ -107,37 +107,32 @@
Github user mars commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/421#discussion_r134630517
--- Diff:
storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/StorageClient.scala
---
@@ -18,27 +18,84 @@
10 matches
Mail list logo