[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...

2017-08-20 Thread Ritabrata-TW
Github user Ritabrata-TW commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @vongosling We do not need a messaging queue in our Project as of yet. Will be advocating for RocketMQ if the scenario arises. --- If your project is set up for it, you can reply t

[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...

2017-08-15 Thread vongosling
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @Ritabrata-TW Thanks for your attention for rocketmq community, whats' your scenario when using apache rocketmq in your company :-) --- If your project is set up for it, you can reply

[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...

2017-08-13 Thread Ritabrata-TW
Github user Ritabrata-TW commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @zhouxinyu Thanks a lot. Will look forward to working with you again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...

2017-08-13 Thread zhouxinyu
Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @Ritabrata-TW this PR has been merged into `develop` branch and will be released in next version, you can close it now safely. --- If your project is set up for it, you can reply to th

[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...

2017-08-12 Thread Ritabrata-TW
Github user Ritabrata-TW commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @zhouxinyu Thanks. I will keep the suggested things in mind next time. Please let me know if you need anything to close the PR. I would also like to get more involved with th

[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...

2017-08-11 Thread zhouxinyu
Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 Thanks @Ritabrata-TW , we will merge this PR soon, but please don't forget to add related unit tests and follow our [code style](http://rocketmq.incubator.apache.org/docs/code-guideline

[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...

2017-08-11 Thread vongosling
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @Ritabrata-TW I found so many code format in your PR, could you import our code style file as instruction, http://rocketmq.incubator.apache.org/docs/code-guidelines/ --- If your proj

[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...

2017-08-11 Thread Ritabrata-TW
Github user Ritabrata-TW commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @vongosling @zhouxinyu Anything else that I need to do on this? Otherwise, can you please have a look and merge it? --- If your project is set up for it, you can reply to this emai

[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...

2017-08-07 Thread Ritabrata-TW
Github user Ritabrata-TW commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @zhouxinyu My pleasure. I have set the merge target to develop. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...

2017-08-07 Thread Ritabrata-TW
Github user Ritabrata-TW commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @vsair The Travis build seems to have passed. Did you notice something wrong with the code style ? --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...

2017-08-06 Thread zhouxinyu
Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @Ritabrata-TW Hi, thanks for your contribution, and could you please set your merge target to `develop` branch which is our daily development branch? --- If your project is set up for

[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...

2017-08-06 Thread vsair
Github user vsair commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 Is there something wrong with your code style ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...

2017-08-06 Thread vongosling
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @Ritabrata-TW thanks, I will take a close look it later :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...

2017-08-04 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 [![Coverage Status](https://coveralls.io/builds/12692862/badge)](https://coveralls.io/builds/12692862) Coverage decreased (-0.3%) to 38.78% when pulling **dc2ce20af7715e45

[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...

2017-08-04 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 [![Coverage Status](https://coveralls.io/builds/12692862/badge)](https://coveralls.io/builds/12692862) Coverage decreased (-0.3%) to 38.78% when pulling **dc2ce20af7715e45

[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...

2017-08-04 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 [![Coverage Status](https://coveralls.io/builds/12692862/badge)](https://coveralls.io/builds/12692862) Coverage decreased (-0.3%) to 38.78% when pulling **dc2ce20af7715e45

[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...

2017-08-04 Thread Ritabrata-TW
Github user Ritabrata-TW commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @vongosling Sorry for the late response. I have changed the PR description according to the format suggested. I agree to what you said about splitting the big refactor into multiple