[GitHub] incubator-rocketmq pull request #134: Rito - #44 - Extracting out duplicated...

Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/134#discussion_r130238297 --- Diff: client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java --- @@ -1215,9 +1210,13 @@ public TopicRouteData getTopicRou

[GitHub] incubator-rocketmq pull request #134: Rito - #44 - Extracting out duplicated...

Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/134#discussion_r130238308 --- Diff: client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java --- @@ -1215,9 +1210,13 @@ public TopicRouteData getTopicRou

[GitHub] incubator-rocketmq pull request #134: Rito - #44 - Extracting out duplicated...

Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/134#discussion_r130238369 --- Diff: store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java --- @@ -717,22 +718,28 @@ public long getEarliestMessageTime(Str

[GitHub] incubator-rocketmq pull request #140: [ROCKETMQ-253]Compress RegisterBrokerB...

GitHub user lizhanhui opened a pull request: https://github.com/apache/incubator-rocketmq/pull/140 [ROCKETMQ-253]Compress RegisterBrokerBody Refer to the description part of [this issue](https://issues.apache.org/jira/browse/ROCKETMQ-253) please. You can merge this pull request int

[GitHub] incubator-rocketmq issue #140: [ROCKETMQ-253]Compress RegisterBrokerBody

Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/140 [](https://coveralls.io/builds/12613613) Coverage decreased (-0.08%) to 39.122% when pulling **43173b482f6faa

[GitHub] incubator-rocketmq issue #140: [ROCKETMQ-253]Compress RegisterBrokerBody

Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/140 [](https://coveralls.io/builds/12616048) Coverage decreased (-0.2%) to 39.04% when pulling **63ac649d9e528fca

[GitHub] incubator-rocketmq issue #139: [ROCKETMQ-242] mqclient can not fetch nameSrv...

Github user qqeasonchen commented on the issue: https://github.com/apache/incubator-rocketmq/pull/139 @lizhanhui pls help to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] incubator-rocketmq issue #140: [ROCKETMQ-253]Compress RegisterBrokerBody

Github user lindzh commented on the issue: https://github.com/apache/incubator-rocketmq/pull/140 Wonderfull,it's a good idea to make package smaller. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no