Re: Extending Scala style checks

FYI: scalastyle just merged in a patch to add support for external rules . I forget why I was following the linked issue, but I assume it's related to this discussion. Nick On Thu Oct 09 2014 at 2:56:30 AM Reynold Xin wrote

Re: Extending Scala style checks

Thanks. I added one. On Wed, Oct 8, 2014 at 8:49 AM, Nicholas Chammas wrote: > I've created SPARK-3849: Automate remaining Scala style rules > . > > Please create sub-tasks on this issue for rules that we have not automated > and let's work thro

Re: Extending Scala style checks

I've created SPARK-3849: Automate remaining Scala style rules . Please create sub-tasks on this issue for rules that we have not automated and let's work through them as possible. I went ahead and created the first sub-task, SPARK-3850: Scala styl

Re: Extending Scala style checks

For starters, do we have a list of all the Scala style rules that are currently not enforced automatically but are likely well-suited for automation? Let's put such a list together in a JIRA issue and work through implementing them. Nick On Thu, Oct 2, 2014 at 12:06 AM, Cheng Lian wrote: > Sin

Re: Extending Scala style checks

Since we can easily catch the list of all changed files in a PR, I think we can start with adding the no trailing space check for newly changed files only? On 10/2/14 9:24 AM, Nicholas Chammas wrote: Yeah, I remember that hell when I added PEP 8 to the build checks and fixed all the outstandin

Re: Extending Scala style checks

There is scalariform but it can be disruptive. Last time I ran it on Spark it didn't compile due to some xml interpolation problem. On Wednesday, October 1, 2014, Nicholas Chammas wrote: > Does anyone know if Scala has something equivalent to autopep8 > ? I

Re: Extending Scala style checks

Does anyone know if Scala has something equivalent to autopep8 ? It would help patch up the existing code base a lot quicker as we add in new style rules. ​ On Wed, Oct 1, 2014 at 9:24 PM, Nicholas Chammas wrote: > Yeah, I remember that hell when I added PE

Re: Extending Scala style checks

Yeah, I remember that hell when I added PEP 8 to the build checks and fixed all the outstanding Python style issues. I had to keep rebasing and resolving merge conflicts until the PR was merged. It's a rough process, but thankfully it's also a one-time process. I might be able to help with that in

Re: Extending Scala style checks

The hard part here is updating the existing code base... which is going to create merge conflicts with like all of the open PRs... On Wed, Oct 1, 2014 at 6:13 PM, Nicholas Chammas wrote: > Ah, since there appears to be a built-in rule for end-of-line whitespace, > Michael and Cheng, y'all should

Re: Extending Scala style checks

Ah, since there appears to be a built-in rule for end-of-line whitespace, Michael and Cheng, y'all should be able to add this in pretty easily. Nick On Wed, Oct 1, 2014 at 6:37 PM, Patrick Wendell wrote: > Hey Nick, > > We can always take built-in rules. Back when we added this Prashant > Sharm

Re: Extending Scala style checks

Hey Nick, We can always take built-in rules. Back when we added this Prashant Sharma actually did some great work that lets us write our own style rules in cases where rules don't exist. You can see some existing rules here: https://github.com/apache/spark/tree/master/project/spark-style/src/main

Re: Extending Scala style checks

Please take a look at WhitespaceEndOfLineChecker under: http://www.scalastyle.org/rules-0.1.0.html Cheers On Wed, Oct 1, 2014 at 2:01 PM, Nicholas Chammas wrote: > As discussed here , it would be > good to extend our Scala style checks to programmatica

Extending Scala style checks

As discussed here , it would be good to extend our Scala style checks to programmatically enforce as many of our style rules as possible. Does anyone know if it's relatively straightforward to enforce additional rules like the "no trailing spaces" rule me