[GitHub] thrift pull request #1312: Add context as first arg for client method.

Github user taozle closed the pull request at: https://github.com/apache/thrift/pull/1312 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] thrift pull request #1312: Add context as first arg for client method.

GitHub user taozle reopened a pull request: https://github.com/apache/thrift/pull/1312 Add context as first arg for client method. Related: https://issues.apache.org/jira/browse/THRIFT-4260 You can merge this pull request into a Git repository by running: $ git pull https://git

[jira] [Commented] (THRIFT-4260) Go context generation issue. Context is parameter in Interface not in implementation

[ https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16098175#comment-16098175 ] ASF GitHub Bot commented on THRIFT-4260: Github user taozle closed the pull reque

[jira] [Commented] (THRIFT-4260) Go context generation issue. Context is parameter in Interface not in implementation

[ https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16098176#comment-16098176 ] ASF GitHub Bot commented on THRIFT-4260: GitHub user taozle reopened a pull reque

[GitHub] thrift issue #1312: Add context as first arg for client method.

Github user taozle commented on the issue: https://github.com/apache/thrift/pull/1312 @dcelasun @Jens-G PTAL --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] thrift issue #1312: THRIFT-4260: Add context as first arg for client method.

Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1312 LGTM (once again, travis failure is unrelated) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[jira] [Commented] (THRIFT-4260) Go context generation issue. Context is parameter in Interface not in implementation

[ https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16098288#comment-16098288 ] ASF GitHub Bot commented on THRIFT-4260: Github user dcelasun commented on the is

[GitHub] thrift pull request #1311: Fix for constant assignments to optional fields i...

Github user davinchia commented on a diff in the pull request: https://github.com/apache/thrift/pull/1311#discussion_r129124617 --- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc --- @@ -424,6 +424,52 @@ bool t_go_generator::is_pointer_field(t_field* tfield, bool in_conta

[GitHub] thrift pull request #1312: THRIFT-4260: Add context as first arg for client ...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1312 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Commented] (THRIFT-4260) Go context generation issue. Context is parameter in Interface not in implementation

[ https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099187#comment-16099187 ] ASF GitHub Bot commented on THRIFT-4260: Github user asfgit closed the pull reque

[jira] [Resolved] (THRIFT-4260) Go context generation issue. Context is parameter in Interface not in implementation

[ https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-4260. Resolution: Fixed Fix Version/s: 0.11.0 Commited, thanks! > Go context generation issue. Co

[GitHub] thrift pull request #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThrea...

GitHub user Johnny-Liao opened a pull request: https://github.com/apache/thrift/pull/1313 THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSelectorServer model. Such as the title. More information see : https://issues.apache.org/jira/browse/THRIFT-4251 You can merge this pull re

[jira] [Commented] (THRIFT-4251) Epoll Selector Bug

[ https://issues.apache.org/jira/browse/THRIFT-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099579#comment-16099579 ] ASF GitHub Bot commented on THRIFT-4251: GitHub user Johnny-Liao opened a pull re