[jira] Commented: (VELOCITY-223) VMs that use a large number of directives and macros use excessive amounts of memory - over 4-6MB RAM per form

2008-07-13 Thread Will Glass-Husain (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613201#action_12613201 ] Will Glass-Husain commented on VELOCITY-223: Dear Lei, I cannot apply your p

[jira] Commented: (VELOCITY-223) VMs that use a large number of directives and macros use excessive amounts of memory - over 4-6MB RAM per form

2008-07-13 Thread Will Glass-Husain (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613199#action_12613199 ] Will Glass-Husain commented on VELOCITY-223: Hi, Thanks for all contribution

[jira] Commented: (VELOCITY-223) VMs that use a large number of directives and macros use excessive amounts of memory - over 4-6MB RAM per form

2007-05-03 Thread Lei Gu (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493509 ] Lei Gu commented on VELOCITY-223: - Hi Chris or Will, Please remove synchronized key word from ASTSetDirective.java'

[jira] Commented: (VELOCITY-223) VMs that use a large number of directives and macros use excessive amounts of memory - over 4-6MB RAM per form

2007-04-17 Thread Alexey Panchenko (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489612 ] Alexey Panchenko commented on VELOCITY-223: --- The reason to high memory usage is that each macro invocatio

[jira] Commented: (VELOCITY-223) VMs that use a large number of directives and macros use excessive amounts of memory - over 4-6MB RAM per form

2007-04-17 Thread Nathan Bubna (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489437 ] Nathan Bubna commented on VELOCITY-223: --- So, all told. I think if we drop the static Map for a ReferenceMap

[jira] Commented: (VELOCITY-223) VMs that use a large number of directives and macros use excessive amounts of memory - over 4-6MB RAM per form

2007-04-17 Thread Christopher Schultz (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489432 ] Christopher Schultz commented on VELOCITY-223: -- After looking at the (patched, above) code to Velocity

[jira] Commented: (VELOCITY-223) VMs that use a large number of directives and macros use excessive amounts of memory - over 4-6MB RAM per form

2007-04-17 Thread Nathan Bubna (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489434 ] Nathan Bubna commented on VELOCITY-223: --- Lei has tested and confirmed memory savings, and i see no reason to

[jira] Commented: (VELOCITY-223) VMs that use a large number of directives and macros use excessive amounts of memory - over 4-6MB RAM per form

2007-04-17 Thread Nathan Bubna (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489435 ] Nathan Bubna commented on VELOCITY-223: --- Oh, and to finish out my conversation with Lei, he acknowledged that

[jira] Commented: (VELOCITY-223) VMs that use a large number of directives and macros use excessive amounts of memory - over 4-6MB RAM per form

2007-04-17 Thread Will Glass-Husain (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489416 ] Will Glass-Husain commented on VELOCITY-223: that makes sense to me. the memory issue is a good explan

[jira] Commented: (VELOCITY-223) VMs that use a large number of directives and macros use excessive amounts of memory - over 4-6MB RAM per form

2007-04-17 Thread Christopher Schultz (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489392 ] Christopher Schultz commented on VELOCITY-223: -- Since Velocity already depends on commons-collections,

[jira] Commented: (VELOCITY-223) VMs that use a large number of directives and macros use excessive amounts of memory - over 4-6MB RAM per form

2007-04-17 Thread Alexey Panchenko (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489376 ] Alexey Panchenko commented on VELOCITY-223: --- Synchronization "stringImagePool.get(image)" should be insi

Re: [jira] Commented: (VELOCITY-223) VMs that use a large number of directives and macros use excessive amounts of memory - over 4-6MB RAM per form

2007-04-02 Thread Lei Gu
You got me there. I thought put will be called a lot less than get but you are right, we should be able to remove it as well. -- Lei Nathan Bubna wrote: > > On 4/2/07, Lei Gu <[EMAIL PROTECTED]> wrote: >> >> Hi Nathan, >> a) In the original code, a new copy of string image is constructed and >>

Re: [jira] Commented: (VELOCITY-223) VMs that use a large number of directives and macros use excessive amounts of memory - over 4-6MB RAM per form

2007-04-02 Thread Nathan Bubna
On 4/2/07, Lei Gu <[EMAIL PROTECTED]> wrote: Hi Nathan, a) In the original code, a new copy of string image is constructed and returned as part of the token, which is part of a node. When we cache templates, these nodes stay in memory forever or until the template itself is booted from the cache

Re: [jira] Commented: (VELOCITY-223) VMs that use a large number of directives and macros use excessive amounts of memory - over 4-6MB RAM per form

2007-04-02 Thread Lei Gu
Hi Nathan, a) In the original code, a new copy of string image is constructed and returned as part of the token, which is part of a node. When we cache templates, these nodes stay in memory forever or until the template itself is booted from the cache. We improved this by checking against the stri

[jira] Commented: (VELOCITY-223) VMs that use a large number of directives and macros use excessive amounts of memory - over 4-6MB RAM per form

2007-04-02 Thread Nathan Bubna (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486064 ] Nathan Bubna commented on VELOCITY-223: --- Those are great numbers! I'm excited to have a such potential boos

[jira] Commented: (VELOCITY-223) VMs that use a large number of directives and macros use excessive amounts of memory - over 4-6MB RAM per form

2007-04-02 Thread Will Glass-Husain (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486048 ] Will Glass-Husain commented on VELOCITY-223: Nice catch. One quick question. Have you tried the Strin

[jira] Commented: (VELOCITY-223) VMs that use a large number of directives and macros use excessive amounts of memory - over 4-6MB RAM per form

2007-04-02 Thread Will Glass-Husain (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486042 ] Will Glass-Husain commented on VELOCITY-223: Thanks, Lei! Also, see: http://www.mail-archive.com/dev@v

[jira] Commented: (VELOCITY-223) VMs that use a large number of directives and macros use excessive amounts of memory - over 4-6MB RAM per form

2007-02-26 Thread Ryan Smith (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475913 ] Ryan Smith commented on VELOCITY-223: - We have a web site where we use velocity to generate our HTML pages. Re