Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/650
yep.
---
Github user Reidd commented on the issue:
https://github.com/apache/zookeeper/pull/650
Sure, do you mean creating another PR for branch-3.5?
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/650
Committed to master branch. Thanks @Reidd !
Unfortunately commit script has died in the middle, so I wasn't able to
commit to 3.5
Would you please create a separate PR for that?
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/650
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2331/
---
Github user Reidd commented on the issue:
https://github.com/apache/zookeeper/pull/650
- Add descriptions about SetAclCommand.class
- Fix the variable overriding.
- Fix missed @Test annotation
- Add a test case for unsetAcl znode.
- Fix the wrong order of assertion.
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/650
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2306/
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/650
retest this please
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/650
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2292/
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/650
@Reidd please change the description now, you have added a UT :)
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/650
retest this please
---
Github user Reidd commented on the issue:
https://github.com/apache/zookeeper/pull/650
Failed UTs are unrelated, most of them are caused by timeout and oom.
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/650
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2291/
---
Github user Reidd commented on the issue:
https://github.com/apache/zookeeper/pull/650
I can add one if none exists.
---
Github user Reidd commented on the issue:
https://github.com/apache/zookeeper/pull/650
Can you give a pointer where are those cli related tests?
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/650
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2287/
---
15 matches
Mail list logo