Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71961): https://edk2.groups.io/g/devel/message/71961
Mute This Topic: https://groups.io/mt/80474615/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71962): https://edk2.groups.io/g/devel/message/71962
Mute This Topic: https://groups.io/mt/80474618/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71963): https://edk2.groups.io/g/devel/message/71963
Mute This Topic: https://groups.io/mt/80474620/21656
Group Owner: devel+ow...@edk2
On Mon, Feb 8, 2021 at 03:04 AM, PierreGondois wrote:
>
> +
> PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoffExtraActionLibNull.inf
>
Should
PeCoffExtraActionLib|ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.inf
be used here?
Re
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71966): https://edk2.groups.io/g/devel/message/71966
Mute This Topic: https://groups.io/mt/80474616/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71967): https://edk2.groups.io/g/devel/message/71967
Mute This Topic: https://groups.io/mt/80474621/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71968): https://edk2.groups.io/g/devel/message/71968
Mute This Topic: https://groups.io/mt/80474623/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71969): https://edk2.groups.io/g/devel/message/71969
Mute This Topic: https://groups.io/mt/80474624/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71970): https://edk2.groups.io/g/devel/message/71970
Mute This Topic: https://groups.io/mt/80474629/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71971): https://edk2.groups.io/g/devel/message/71971
Mute This Topic: https://groups.io/mt/80474626/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71972): https://edk2.groups.io/g/devel/message/71972
Mute This Topic: https://groups.io/mt/80474627/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71974): https://edk2.groups.io/g/devel/message/71974
Mute This Topic: https://groups.io/mt/80474628/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71975): https://edk2.groups.io/g/devel/message/71975
Mute This Topic: https://groups.io/mt/80474630/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71976): https://edk2.groups.io/g/devel/message/71976
Mute This Topic: https://groups.io/mt/80474631/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71977): https://edk2.groups.io/g/devel/message/71977
Mute This Topic: https://groups.io/mt/80474632/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71978): https://edk2.groups.io/g/devel/message/71978
Mute This Topic: https://groups.io/mt/80474633/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71982): https://edk2.groups.io/g/devel/message/71982
Mute This Topic: https://groups.io/mt/80474635/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71983): https://edk2.groups.io/g/devel/message/71983
Mute This Topic: https://groups.io/mt/80474637/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71984): https://edk2.groups.io/g/devel/message/71984
Mute This Topic: https://groups.io/mt/80474638/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71985): https://edk2.groups.io/g/devel/message/71985
Mute This Topic: https://groups.io/mt/80474639/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71986): https://edk2.groups.io/g/devel/message/71986
Mute This Topic: https://groups.io/mt/80474641/21656
Group Owner: devel+ow...@edk2
This patch also updates the ScmiMessageIdBasexxx for SCMI_MESSAGE_ID_BASE. The
patch subject line and commit message probably needs updating accordingly.
With that changed.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71989): https://edk2.groups.io/g/devel/message/71989
Mute This Topic: https://groups.io/mt/80474643/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71990): https://edk2.groups.io/g/devel/message/71990
Mute This Topic: https://groups.io/mt/80474644/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71994): https://edk2.groups.io/g/devel/message/71994
Mute This Topic: https://groups.io/mt/80474634/21656
Group Owner: devel+ow...@edk2
Hi Pierre,
Thanks for confirming that DebugPeCoffExtraActionLib & RvdPeCoffExtraActionLib
are being built as part of the [Components].
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply On
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72047): https://edk2.groups.io/g/devel/message/72047
Mute This Topic: https://groups.io/mt/80563972/21656
Group Owner: devel+ow...@edk2
Hi Sughosh,
Pushed as a2b5ea38a6fb..68e5ecc4d208
Regards,
Sami Mujawar
From: Sughosh Ganu
Sent: 22 February 2021 03:19 PM
To: Ard Biesheuvel ; Sami Mujawar
Cc: devel@edk2.groups.io; Ilias Apalodimas ;
Laszlo Ersek ; Leif Lindholm ;
michael.d.kin...@intel.com; Jiewen Yao ; Achin Gupta
e.org/show_bug.cgi?id=3216 ) - Add platform CI support
for Kvmtool'
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72110): https://edk2.groups.io/g/devel/message/72110
Mute This Topic: https://groups.io/mt/8003
EQ. So the remaining cases that could occur
are:
- the target sends FFA_MSG_SEND_DIRECT_RESP with a success or
failure code.
or
- FFA_MSG_SEND_DIRECT_REQ transmission failure.
Therefore, reorder the error handling conditions such that the
uninitialised variable issue is fixed.
Signed-of
Hi Leif,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
-Original Message-
From: Leif Lindholm
Sent: 25 February 2021 11:38 AM
To: Sami Mujawar
Cc: devel@edk2.groups.io; ardb+tianoc...@kernel.org; Matteo Carlini
; Ben Adderson ; nd
Subject: Re: [PATCH v1 1/1
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72190): https://edk2.groups.io/g/devel/message/72190
Mute This Topic: https://groups.io/mt/80850103/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72191): https://edk2.groups.io/g/devel/message/72191
Mute This Topic: https://groups.io/mt/80850104/21656
Group Owner: devel+ow...@edk2
/1596_kvmtool_ci_v2 and will submit it
shortly.
Regards,
Sami Mujawar
-Original Message-
From: gaoliming
Sent: 25 February 2021 02:31 PM
To: devel@edk2.groups.io; spbro...@outlook.com; Sami Mujawar
Cc: ardb+tianoc...@kernel.org; l...@nuviainc.com; sean.bro...@microsoft.com;
bret.barke
flagged by CLANG.
- move the repetitive code to a static helper function and add
documentation at the appropriate places.
- fix error handling in functions that invoke GetMemoryPermissions().
Signed-off-by: Sami Mujawar
---
The changes can be seen at:
https://github.com/samimujawar
Hi Ard,
Yes. This patch with fix the build failure reported by the CI.
Regards,
Sami Mujawar
From: Ard Biesheuvel
Sent: Friday, 26 February 2021, 6:46 pm
To: Sughosh Ganu; Liming Gao (Byosoft address)
Cc: devel@edk2.groups.io; Sami Mujawar; Ard Biesheuvel
build instructions and supported build hosts.
- Any other dependencies required to boot to the UEFI shell on Morello FVP.
This file could be added as a new patch in the v2 series.
Regards,
Sami Mujawar
-Original Message-
From: Chandni Cherukuri
Sent: 24 February 2021 01:12 PM
To: devel
Hi Chandni,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
-Original Message-
From: Chandni Cherukuri
Sent: 24 February 2021 01:12 PM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Leif Lindholm
; Sami Mujawar
Subject: [edk2-platforms][PATCH V1 1/5] Platform/ARM
Hi Chandni,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
-Original Message-
From: Chandni Cherukuri
Sent: 24 February 2021 01:12 PM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Leif Lindholm
; Sami Mujawar
Subject: [edk2-platforms][PATCH V1 2/5] Platform/ARM
Hi Chandni,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
-Original Message-
From: Chandni Cherukuri
Sent: 24 February 2021 01:12 PM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Leif Lindholm
; Sami Mujawar
Subject: [edk2-platforms][PATCH V1 4/5] Platform/ARM
Hi Chandni,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
-Original Message-
From: Chandni Cherukuri
Sent: 24 February 2021 01:12 PM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Leif Lindholm
; Sami Mujawar
Subject: [edk2-platforms][PATCH V1 3/5] Platform/ARM
Hi Chandni,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
-Original Message-
From: Chandni Cherukuri
Sent: 24 February 2021 01:12 PM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Leif Lindholm
; Sami Mujawar
Subject: [edk2-platforms][PATCH V1 5/5] Platform/ARM
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72281): https://edk2.groups.io/g/devel/message/72281
Mute This Topic: https://groups.io/mt/80650654/21656
Group Owner: devel+ow...@edk2
instructions and supported build hosts.
- Any other dependencies required to boot to the UEFI shell.
The Readme.md file could be added as a new patch in the v2 series.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72282
-block
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72283): https://edk2.groups.io/g/devel/message/72283
Mute This Topic: https://groups.io/mt/80650656/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe
cro as __builtin_offsetof is compiler specific.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72285): https://edk2.groups.io/g/devel/message/72285
Mute This Topic: https://groups.io/mt/80664134/21656
Group Owner: devel+ow..
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72287): https://edk2.groups.io/g/devel/message/72287
Mute This Topic: https://groups.io/mt/80905920/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72288): https://edk2.groups.io/g/devel/message/72288
Mute This Topic: https://groups.io/mt/80905921/21656
Group Owner: devel+ow...@edk2
ease.
Regards,
Sami Mujawar
-Original Message-
From: devel@edk2.groups.io On Behalf Of Ilias Apalodimas
via groups.io
Sent: 12 February 2021 05:35 PM
To: devel@edk2.groups.io; Sami Mujawar
Cc: ardb+tianoc...@kernel.org; sughosh.g...@linaro.org; l...@nuviainc.com;
Ilias Apalodimas
Sub
Hi Vivek,
Thank you for this patch.
For this series.
Reviewed-by: Sami Mujawar
I will merge this series once the merge window opens.
Regards,
Sami Mujawar
-Original Message-
From: Vivek Kumar Gautam
Sent: 05 March 2021 01:21 PM
To: devel@edk2.groups.io
Cc: ardb+tianoc
;PPTT Type 2 - Processor ID' is deprecated so don’t add this information.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72509): https://edk2.groups.io/g/devel/message/72509
Mute This Topic: https://groups.
Hi Sunny,
Thank you for this patch.
I will merge this change shortly with the typo fixed.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 22/03/2021, 08:07, "Ard Biesheuvel" wrote:
On Mon, 22 Mar 2021 at 07:13, Sunny Wang wrote:
>
> PL011 is not a valid AC
Base, NumLba * Instance->BlockSize, ~0UL);=0D
> + FreePool (Buf);=0D
> + }=0D
> +=0D
> + VA_END (Args);=0D
> +=0D
> + return EFI_SUCCESS;=0D
> +}=0D
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online
Hi Thomas,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73412): https://edk2.groups.io/g/devel/message/73412
Mute This Topic: https://groups.io/mt/81153228
Reviewed-by: Sami Mujawar sami.muja...@arm.com<mailto:sami.muja...@arm.com>
Regards,
Sami Mujawar
From: Ilias Apalodimas
Date: Saturday, 13 March 2021 at 18:32
To: devel@edk2.groups.io , Sami Mujawar
, Pierre Gondois
Cc: ardb+tianoc...@kernel.org ,
sughosh.g...@linaro.o
Hi Ilias,
From: Ilias Apalodimas
Date: Saturday, 27 March 2021 at 20:49
To: Sami Mujawar
Cc: devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH 1/3 v7] Drivers/OpTeeRpmb: Add an OP-TEE
backed RPMB driver
On Sat, Mar 27, 2021 at 01:25:41PM -0700, Sami Mujawar wrote:
> Hi Ilias,
>
&g
Hi ilias,
Thank you for this series.
Pushed as afb0ce7e9756..89f6170d6686
Regards,
Sami Mujawar
From: Ilias Apalodimas
Date: Saturday, 13 March 2021 at 18:32
To: devel@edk2.groups.io , Sami Mujawar
, Pierre Gondois
Cc: ardb+tianoc...@kernel.org ,
sughosh.g...@linaro.org , l
Hi Mike,
For DynamicTablesPkg, ArmPkg, ArmPlatformPkg, ArmVirtPkg & StandaloneMmPkg
Reviewed-by: Sami Mujawar ( sami.muja...@arm.com )
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84202): https://
Hi Mike,
Thanks a lot for these changes.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 06/12/2021, 01:18, "devel@edk2.groups.io on behalf of Michael D Kinney via
groups.io" wrote:
Hello EDK II Maintainers,
A detailed evaluation of the DEBUG_CODE() formatting issu
bs.dsc.inc
[LibraryClasses.common]
+ # Platform Library
+
ArmPlatformLib|Platform/ARM/Morello/Library/PlatformLib/PlatformLibFvp.inf
Can you update this accordingly, please?
With that changed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/12/2021 12:30 P
Hi Chandni,
Thank you for this patch.
Please find my feedback inline marked [SAMI].
With that updated,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/12/2021 12:30 PM, Chandni Cherukuri wrote:
It includes virutal memory map for Morello SoC platform.
Signed-off-by: Chandni
Hi Chandni,
Please find my feedback inline marked [SAMI].
With that fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/12/2021 12:30 PM, Chandni Cherukuri wrote:
This patch adds PlatformDxe support for Morello SoC platform.
It includes the registration of ramdisk device.
Signed
.
Otherwise, these changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/12/2021 12:30 PM, Chandni Cherukuri wrote:
This patch implements the configuration manager for Morello
SoC platform. It enables support for generating the following
ACPI tables for Morello SoC
Hi Chandni,
I would suggest adding a brief introduction about the Morello SoC
platform in the commit message.
Otherwise, this patch looks good to me.
With the commit message updated.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/12/2021 12:30 PM, Chandni Cherukuri wrote:
This
Hi Chandni,
Thank you for this patch.
I have a minor suggestion marked inline as [SAMI].
Otherwise this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/12/2021 12:30 PM, Chandni Cherukuri wrote:
From: Anurag Koul
A custom PCI Segment library is required
Hi Chandni,
Thank you for this patch.
Please find my feedback inline marked [SAMI].
With those addressed.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/12/2021 12:30 PM, Chandni Cherukuri wrote:
From: Anurag Koul
Morello platform requires a custom platform-specific PCI Express
Hi Chandni,
Please find my feedback marked inline as [SAMI].
With that fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/12/2021 12:30 PM, Chandni Cherukuri wrote:
From: Anurag Koul
Add definitions for both PCIe and CCIX Root Complex in PciHostBridge
Library. Also, use
Hi Chandni,
Please find my feedback inline marked [SAMI].
With those fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/12/2021 12:30 PM, Chandni Cherukuri wrote:
From: sah01
Support has been added to parse NT_FW_CONFIG DTB to get the
platform information.
Signed-off-by
Hi Chandni,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/12/2021 12:30 PM, Chandni Cherukuri wrote:
Morello SoC platform support has added and also
boot flow modified to reflect the new boot flow
for both Morello FVP and Morello SoC platforms
Signed-off
Hi Chris,
Thank you for this patch.
Please see my feedback below inline marked [SAMI].
Regards,
Sami Mujawar
On 08/12/2021 04:06 PM, Chris Jones wrote:
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
Update the PPTT generator with the CacheId field as defined in table
Hi Chris,
Thank you for this patch series.
Other than my feedback for optimisation in patch 7/7 (which I will
address before merging), this patch series looks good to me.
For this series,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 08/12/2021 04:06 PM, Chris Jones wrote
Merged as 0f1d7477c0a8..e81a81e5846e
Regards,
Sami Mujawar
On 09/12/2021 05:00 PM, Sami Mujawar via groups.io wrote:
Hi Chris,
Thank you for this patch series.
Other than my feedback for optimisation in patch 7/7 (which I will
address before merging), this patch series looks good to me
Hi Jiewen, Min,
Thank you for making the measurement protocol architecture neutral.
I will monitor the mailing list for any further CC measurement
interface/implementations. However, I request you to copy me, in case I miss
any patches.
Regards,
Sami Mujawar
From: Yao, Jiewen
Date: Sunday
Hi Pierre,
Thank you for this patch series.
This series looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 09/12/2021 09:24 AM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3682
As part of the DynamicTablesPkg
#x27;ll need to rebase on top of the
uncrustify changes in any case.
Sami, Leif: any comments?
I have some minor suggestions, that I will reply back shortly.
Regards,
Sami Mujawar
On 11/9/21 5:15 AM, Ard Biesheuvel wrote:
On Tue, 9 Nov 2021 at 12:57, Leif Lindholm wrote:
On Mon, Nov 08, 2
Hi Rebecca,
Thank you for this patch.
I believe the patch subject line needs to be updated to "...
ArmCallSmc0/1/2/3 ...". Other than that, this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 01/11/2021 10:11 PM, Rebecca Cran wrote:
New SMC helper
Hi Rebecca,
Thank you for this patch series.
The patch series does not apply on top of latest master, which I believe
is due to the Uncrustify changes.
I have some minor suggestions marked inline as [SAMI].
Otherwise this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami
Thanks,
Pushed as e07d27e24d5d..ec37fd9c1fbc
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84746): https://edk2.groups.io/g/devel/message/84746
Mute This Topic: https://groups.io/mt/87608847/21656
Group Owner
Hi Kun,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 30/11/2021 12:39 AM, Kun Qin via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3751
Current MM communicate routine from ArmPkg would conduct few
Hi Rebecca,
Thank you for reporting this issue.
We will try to recreate the problem and provide a fix.
Regards,
Sami Mujawar
From: devel@edk2.groups.io on behalf of Rebecca Cran via
groups.io
Date: Tuesday, 14 December 2021 at 01:53
To: edk2-devel-groups-io , Ard Biesheuvel
, Leif Lindholm
/tianocore.github.io/wiki/EDK-II-Code-Formatting
Regards,
Sami Mujawar
From: Attar, AbdulLateef (Abdul Lateef)
Date: Tuesday, 14 December 2021 at 11:18
To: Sami Mujawar , devel@edk2.groups.io
, Ray Ni , Zhichao Gao
Cc: nd
Subject: RE: [PATCH v3 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield
Hi Pierre,
Thank you for this patch series.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 09/12/2021 09:31 AM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
v4:
- Run uncrustify and apply the required formatting. [Pierre]
- No other change with v3. [Pierre]
v3:
- Populate the
Hi Chris,
Thanks for fixing this issue.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
From: Chris Jones
Date: Tuesday, 14 December 2021 at 12:38
To: devel@edk2.groups.io
Cc: ray...@intel.com , zhichao@intel.com
, rebe...@nuviainc.com , Sami
Mujawar , nd
Subject: [PATCH v1 1/1
Hi Pierre,
Thank you for this patch series.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 09/12/2021 09:32 AM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
v3:
- Run uncrustify and apply the required formatting. [Pierre]
- No other change with v2. [Pierre]
v2:
- Various small
Pushed as 9006967c8d24..38f6d78c3b62
Regards,
Sami Mujawar
On 09/12/2021 09:32 AM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
v3:
- Run uncrustify and apply the required formatting. [Pierre]
- No other change with v2. [Pierre]
v2:
- Various small fixes (change status returned
Hi Nhi,
These patches do not cleanly apply. I guess you would need to run
uncrustify for these patches.
Can you check, please?
Regards,
Sami Mujawar
On 01/12/2021 04:10 AM, Nhi Pham via groups.io wrote:
This patchset leverages the OemUpdateSmbiosInfo API functions from
OemMiscLib for
Hi Nhi,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 01/12/2021 04:10 AM, Nhi Pham via groups.io wrote:
This patch removes duplicate HII string definition in the
MiscSystemManufacturer.uni.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Hi Nhi,
Other than the code style issue (which I believe uncrustify will
complain about), this patch looks good to me.
With that fixed.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 01/12/2021 04:10 AM, Nhi Pham via groups.io wrote:
Typically, the information of the SMBIOS type 1
Hi Nhi,
I have a minor suggestion to use FixedPcdGetPtr(), other than that this
patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 01/12/2021 04:10 AM, Nhi Pham via groups.io wrote:
Currently, the serial and part number of a processor are filled with
fixed PCDs
Hi Rebecca,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 16/12/2021, 13:14, "Rebecca Cran" wrote:
On 12/16/21 2:32 AM, Ard Biesheuvel wrote:
> You appear to have missed a few instances:
>
> Platform/AMD/OverdriveBoard
Hi Ard,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 16/12/2021, 15:07, "Ard Biesheuvel via groups.io"
wrote:
On Thu, 16 Dec 2021 at 14:38, Marcin Juszkiewicz
wrote:
>
> W dniu 16.12.2021 o 14:16, Ard Biesheuvel pisze:
>
This patch series fixes the build breaks in SynQuacerEvalBoard.
Note: I have only tested that the build is fixed. I don't have
a board to test the functionality.
The changes can be seen at:
https://github.com/samimujawar/edk2-platforms/tree/2015_fix_arm_plat_build_break_v1
Sami Mujaw
BdsDxe depends on VariablePolicyHelperLib, so move it out from
VariableRuntimeDxe.inf and add it to LibraryClasses.DXE_DRIVER and
LibraryClasses.DXE_RUNTIME_DRIVER.
This is required to fix the build break in SynQuacerEvalBoard.dsc
Signed-off-by: Sami Mujawar
---
Platform/Socionext
EbcDxe is not supported for AArch32 builds of the firmware.
Therefore, move EbcDxe so that it is included only for AArch64
builds of the firmware.
Signed-off-by: Sami Mujawar
---
Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 4 +++-
Platform/Socionext/SynQuacerEvalBoard
ArmSoftFloatLib is required for the AARCH32 build of the firmware
for SynQuacerEvalBoard.
Therefore, add the missing ArmSoftFloatLib to SynQuacerEvalBoard.dsc
Signed-off-by: Sami Mujawar
---
Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 3 +++
1 file changed, 3 insertions
Hi Pierre,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The two following modules have the same GUID:
- Platform/ARM/VExpressPkg/Library/
ArmVExpressLibRTSM/ArmVExpressLibSec.inf
- Silicon
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The two following modules have the same GUID:
- Platform/ARM/Morello/Library/PciHostBridgeLib/
PciHostBridgeLibFvp.inf
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The two following modules have the same GUID:
- Platform/ARM/VExpressPkg/Library/
ArmVExpressLibRTSM/ArmVExpressLib.inf
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The two following packages have the same GUID:
- Platform/ARM/VExpressPkg/ArmVExpressPkg.dec
- edk2/ArmPlatformPkg
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
This patch fixes the following Ecc reported error:
'TAB' character is not allowed in source code,
please replace
701 - 800 of 1719 matches
Mail list logo
