Re: [Development] Qt 5.5.0 header diff: QtNetwork.diff

2015-06-08 Thread Giuseppe D'Angelo
Il 06/06/2015 15:26, Thiago Macieira ha scritto: The symmetry only existed because we added them to QSslSocket before QSslCertificate existed. I'd rather new API existed only in QSslConfiguration. That way, we don't need to duplicate in QSslSocket. Richard, Peter, do you concur on this? I can

Re: [Development] Qt 5.5.0 header diff: QtNetwork.diff

2015-06-07 Thread Knoll Lars
On 06/06/15 15:26, "development-bounces+lars.knoll=theqtcompany@qt-project.org on behalf of Thiago Macieira" wrote: >On Saturday 06 June 2015 14:22:20 Giuseppe D'Angelo wrote: >> Il 06/06/2015 13:27, Thiago Macieira ha scritto: >> > Then why do we need them in QSslSocket? >> >> Technical

Re: [Development] Qt 5.5.0 header diff: QtNetwork.diff

2015-06-06 Thread Thiago Macieira
On Saturday 06 June 2015 14:22:20 Giuseppe D'Angelo wrote: > Il 06/06/2015 13:27, Thiago Macieira ha scritto: > > Then why do we need them in QSslSocket? > > Technically they are be needed there, indeed, but I didn't want to cause > an API asymmetry with the other functions for ciphers, certificat

Re: [Development] Qt 5.5.0 header diff: QtNetwork.diff

2015-06-06 Thread Giuseppe D'Angelo
Il 06/06/2015 13:27, Thiago Macieira ha scritto: Then why do we need them in QSslSocket? Technically they are be needed there, indeed, but I didn't want to cause an API asymmetry with the other functions for ciphers, certificates and so on, that's all. -- Giuseppe D'Angelo | giuseppe.dang..

Re: [Development] Qt 5.5.0 header diff: QtNetwork.diff

2015-06-06 Thread Thiago Macieira
On Saturday 06 June 2015 11:30:39 Giuseppe D'Angelo wrote: > Il 06/06/2015 11:20, Thiago Macieira ha scritto: > > These should be in QSslConfiguration, not QSslSocket. > > They're in both, just like ciphers, certificates etc. Then why do we need them in QSslSocket? -- Thiago Macieira - thiago.ma

Re: [Development] Qt 5.5.0 header diff: QtNetwork.diff

2015-06-06 Thread Giuseppe D'Angelo
Il 06/06/2015 11:20, Thiago Macieira ha scritto: These should be in QSslConfiguration, not QSslSocket. They're in both, just like ciphers, certificates etc. -- Giuseppe D'Angelo | giuseppe.dang...@kdab.com | Software Engineer KDAB (UK) Ltd., a KDAB Group company | Tel: UK +44-1625-809908 KDAB

Re: [Development] Qt 5.5.0 header diff: QtNetwork.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:11:29 Frederik Gladhorn wrote: > +// EC settings. > +QVector ellipticCurves() const; > +void setEllipticCurves(const QVector &curves); > +static void setDefaultEllipticCurves(const QVector > &curves); +static QVector defaultEllipticCurves(); > +stat

[Development] Qt 5.5.0 header diff: QtNetwork.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/network/access/qabstractnetworkcache.h b/src/network/access/qabstractnetworkcache.h index b563090..352daa9 100644 --- a/src/network/access/qabstractnetworkcache.h +++ b/src/network/access/qabstractnetworkcache.h @@ -37,6 +37,7 @@ #include #ifndef QT_NO_SSL #include +#include