Re: [dm-devel] [PATCH 0/6] Overhaul memalloc_no*

2020-06-28 Thread Dave Chinner
On Sat, Jun 27, 2020 at 09:09:09AM -0400, Mikulas Patocka wrote: > > > On Sat, 27 Jun 2020, Dave Chinner wrote: > > > On Fri, Jun 26, 2020 at 11:02:19AM -0400, Mikulas Patocka wrote: > > > Hi > > > > > > I suggest to join memalloc_noio and memalloc_nofs into just one flag that > > > prevents

Re: [dm-devel] [PATCH 1/3 v2] crypto: introduce the flag CRYPTO_ALG_ALLOCATES_MEMORY

2020-06-28 Thread Eric Biggers
On Sun, Jun 28, 2020 at 03:07:49PM -0400, Mikulas Patocka wrote: > > > > cryptd_create_skcipher(), cryptd_create_hash(), cryptd_create_aead(), and > > crypto_rfc4309_create() are also missing setting the mask. > > > > pcrypt_create_aead() is missing both setting the mask and inheriting the > >

Re: [dm-devel] [PATCH 1/3 v2] crypto: introduce the flag CRYPTO_ALG_ALLOCATES_MEMORY

2020-06-28 Thread Eric Biggers
On Sun, Jun 28, 2020 at 03:07:49PM -0400, Mikulas Patocka wrote: > > > Also, "seqiv" instances can be created without CRYPTO_ALG_ALLOCATES_MEMORY > > set, > > despite seqiv_aead_encrypt() allocating memory. > > This comment wasn't addressed. - Eric -- dm-devel mailing list

Re: [dm-devel] [PATCH 1/3 v2] crypto: introduce the flag CRYPTO_ALG_ALLOCATES_MEMORY

2020-06-28 Thread Eric Biggers
On Sun, Jun 28, 2020 at 03:04:22PM -0400, Mikulas Patocka wrote: > > > Index: linux-2.6/crypto/authenc.c > > > === > > > --- linux-2.6.orig/crypto/authenc.c 2020-06-26 17:24:03.566417000 > > > +0200 > > > +++

Re: [dm-devel] [PATCH 1/3 v2] crypto: introduce the flag CRYPTO_ALG_ALLOCATES_MEMORY

2020-06-28 Thread Mikulas Patocka
On Fri, 26 Jun 2020, Eric Biggers wrote: > On Fri, Jun 26, 2020 at 09:46:17AM -0700, Eric Biggers wrote: > > On Fri, Jun 26, 2020 at 12:16:33PM -0400, Mikulas Patocka wrote: > > > +/* > > > + * Pass these flags down through the crypto API. > > > + */ > > > +#define CRYPTO_ALG_INHERITED_FLAGS

[dm-devel] [PATCH 1/3 v3] crypto: introduce the flag CRYPTO_ALG_ALLOCATES_MEMORY

2020-06-28 Thread Mikulas Patocka
Introduce a new flag CRYPTO_ALG_ALLOCATES_MEMORY and pass it down the crypto stack. If the flag is set, then the crypto driver allocates memory in its request routine. Such drivers are not suitable for disk encryption because GFP_ATOMIC allocation can fail anytime (causing random I/O errors) and

Re: [dm-devel] [PATCH 1/3 v2] crypto: introduce the flag CRYPTO_ALG_ALLOCATES_MEMORY

2020-06-28 Thread Mikulas Patocka
On Fri, 26 Jun 2020, Eric Biggers wrote: > On Fri, Jun 26, 2020 at 12:16:33PM -0400, Mikulas Patocka wrote: > > +/* > > + * Pass these flags down through the crypto API. > > + */ > > +#define CRYPTO_ALG_INHERITED_FLAGS (CRYPTO_ALG_ASYNC | > > CRYPTO_ALG_ALLOCATES_MEMORY) > > This comment is

Re: [dm-devel] dm-crypt hard lockup

2020-06-28 Thread Bart Van Assche
On 2020-06-26 02:07, Artur Paszkiewicz wrote: > I'm getting regular lockups which seem to be caused by dm-crypt. I > reproduced it on vanilla v5.8-rc2, but I started regularly seeing this > some time ago on openSUSE Tumbleweed kernels. It's easily reproducible > (every time, after about a minute)

Re: [dm-devel] [PATCH v4 1/4] dm dust: report some message results back to user directly

2020-06-28 Thread Mike Snitzer
It is on the dm-devel patchwork list to pick up for the 5.9 merge window. I've just been busy with other work. Thanks, Mike On Sat, Jun 27 2020 at 9:08pm -0400, yangerkun wrote: > Hi Mike, does there any advice for this patchset? > > Thanks, > Kun. > > 在 2020/6/20 5:10, Bryan Gurney 写道: >