Hi Jacopo,
On Thu, Jun 20, 2024 at 6:48 PM Jacopo Mondi
wrote:
> On Thu, Jun 20, 2024 at 02:48:49PM GMT, Geert Uytterhoeven wrote:
> > On Wed, Jun 19, 2024 at 9:46 PM Laurent Pinchart
> > wrote:
> > > On Wed, Jun 19, 2024 at 12:22:18PM +0200, Jacopo Mondi wrote:
>
e first CRTC of
second pair, but does have the second CRTC of the second pair.
> > + mutex_lock(>lock);
> > + rcar_du_group_write(rgrp, DPTSR, (rgrp->dptsr_planes << 16) |
> > + rgrp->dptsr_planes);
> > + mutex_u
>
> Signed-off-by: Jeff Johnson
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talk
igned-off-by: Jeff Johnson
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journali
the issue I was seeing on R-Car Gen3/Gen4 with rcar-du.
No regressions on R-Car Gen2 (rcar-du) and R-Mobile A1 (shmobile)
which didn't shown the warning in the first place.
Tested-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uy
softirqs last enabled at (5004): []
__do_softirq+0x1ac/0x3a8
softirqs last disabled at (4999): []
do_softirq+0xc/0x14
Interestingly, the warning is not triggered on R-Car Gen2 (arm32),
although arch/arm/mm/physaddr.c has a similar check.
Gr{oetje,eeting}s,
Geert
--
Hi Jocelyn,
On Mon, Jun 17, 2024 at 11:59 AM Jocelyn Falempe wrote:
> On 13/06/2024 21:18, Geert Uytterhoeven wrote:
> > Re-use the existing support for boot-up logos to draw a monochrome
> > graphical logo in the DRM panic handler. When no suitable graphical
> > logo i
r the kernel to print
> > messages ?
>
> Yes, but when writing the patch, I thought that if you have VT_CONSOLE=y
> and FRAMEBUFFER_CONSOLE=n, then there won't be any race condition, and
> drm_panic can be enabled safely.
> I don't know if that really matters, and if VT_CONSOLE has a
On Sun, Jun 16, 2024 at 11:08 AM Geert Uytterhoeven
wrote:
> On Sat, Jun 15, 2024 at 12:55 PM kernel test robot wrote:
> > kernel test robot noticed the following build errors:
> >
> > [auto build test ERROR on drm-misc/drm-misc-next]
> > [cannot apply to linus/mas
drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:
> https://github.com/intel-lab-lkp/linux/commits/Geert-Uytterhoeven/drm-panic-Fix-uninitialized-drm_scanout_b
Hi Jocelyn,
On Fri, Jun 14, 2024 at 11:55 AM Jocelyn Falempe wrote:
> On 13/06/2024 21:18, Geert Uytterhoeven wrote:
> > Re-use the existing support for boot-up logos to draw a monochrome
> > graphical logo in the DRM panic handler. When no suitable graphical
> > logo i
Hi Maxime,
On Fri, Jun 14, 2024 at 10:35 AM Maxime Ripard wrote:
> On Fri, Jun 14, 2024 at 08:58:26AM GMT, Geert Uytterhoeven wrote:
> > Looks like the top commit of last drm-misc PR [1] is part of the
> > drm-misc-next branch. but not of the for-linux-next branch, while
&g
Hi Stephen and Maxime,
On Fri, Jun 14, 2024 at 12:00 AM Stephen Rothwell wrote:
> On Thu, 13 Jun 2024 11:48:15 +0200 Geert Uytterhoeven
> wrote:
> > > > Has the drm-misc git repo moved?
> > >
> > > It moved to gitlab recently, the new url is
> &
a copy must be made for later use.
Signed-off-by: Geert Uytterhoeven
---
v2:
- Rebased,
- Inline trivial draw_logo_mono().
---
drivers/gpu/drm/drm_panic.c | 65 +
drivers/video/logo/Kconfig | 2 ++
2 files changed, 60 insertions(+), 7 deletions(-)
diff
Fix a misspelling of "formatter".
Fixes: 54034bebb22fd4be ("drm/panic: Add a kmsg panic screen")
Signed-off-by: Geert Uytterhoeven
---
v2:
- New.
---
drivers/gpu/drm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/Kconfig b/dri
calling drm_plane_helper_funcs.get_scanout_buffer().
Fixes: 24d07f114e4ec760 ("drm/panic: Add a set_pixel() callback to
drm_scanout_buffer")
Signed-off-by: Geert Uytterhoeven
---
v2:
- New.
---
drivers/gpu/drm/drm_panic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Rename variables related to the ASCII logo, to prepare for the advent of
support for graphical logos.
Signed-off-by: Geert Uytterhoeven
---
v2:
- Rebased.
---
drivers/gpu/drm/drm_panic.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm
],
- New cleanup [5/7],
- Inline trivial draw_logo_mono().
This has been tested with rcar-du.
Thanks for your comments!
Geert Uytterhoeven (7):
drm/panic: Fix uninitialized drm_scanout_buffer.set_pixel() crash
drm/panic: Fix off-by-one logo size checks
lib/fonts: Fix visiblity of SUN12x22
Use the drm_fb_clip_offset() helper instead of open-coding the same
operation.
Signed-off-by: Geert Uytterhoeven
---
DRM_PANIC already selects DRM_KMS_HELPER.
v2:
- New.
---
drivers/gpu/drm/drm_panic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm
re it belongs.
Split the dependency in two rules to improve readability.
Fixes: b94605a3889b9084 ("lib/fonts: Allow to select fonts for drm_panic")
Signed-off-by: Geert Uytterhoeven
---
v2:
- New.
---
lib/fonts/Kconfig | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
di
Logos that are either just as wide or just as high as the display work
fine.
Fixes: bf9fb17c6672868d ("drm/panic: Add a drm panic handler")
Signed-off-by: Geert Uytterhoeven
---
v2:
- Rebased.
---
drivers/gpu/drm/drm_panic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Hi Jocelyn,
CC sfr
On Thu, Jun 13, 2024 at 11:41 AM Jocelyn Falempe wrote:
> On 13/06/2024 11:32, Geert Uytterhoeven wrote:
> > On Thu, Jun 13, 2024 at 10:38 AM Jocelyn Falempe
> > wrote:
> >> On 12/06/2024 15:54, Geert Uytterhoeven wrote:
> >>> If d
Hi Jocelyn,
On Thu, Jun 13, 2024 at 10:38 AM Jocelyn Falempe wrote:
> On 12/06/2024 15:54, Geert Uytterhoeven wrote:
> > If drm/panic is enabled, a user-friendly message is shown on screen when
> > a kernel panic occurs, together with an ASCII art penguin logo.
> > Of co
Rename variables related to the ASCII logo, to prepare for the advent of
support for graphical logos.
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/drm_panic.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_panic.c b/drivers/gpu/drm
a copy must be made for later use.
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/drm_panic.c | 78 +
drivers/video/logo/Kconfig | 2 +
2 files changed, 73 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/drm_panic.c b/drivers/gpu/drm
Logos that are either just as wide or just as high as the display work
fine.
Fixes: bf9fb17c6672868d ("drm/panic: Add a drm panic handler")
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/drm_panic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drive
by the customary fix.
This has been tested with rcar-du.
Thanks for your comments!
Geert Uytterhoeven (3):
drm/panic: Fix off-by-one logo size checks
drm/panic: Rename logo to logo_ascii
drm/panic: Add support for drawing a monochrome graphical logo
drivers/gpu/drm/drm_panic.c | 81
The last user of the serial_console ASCII image was removed in v2.1.115.
Signed-off-by: Geert Uytterhoeven
---
include/linux/linux_logo.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/linux/linux_logo.h b/include/linux/linux_logo.h
index d4d5b93efe8435bd..e37699b7e8393df0 100644
As gcc-4.1 is no longer supported, the logo data can be made const
again. Hence revert commit 15e3252464432a29 ("fbdev: work around old
compiler bug").
Signed-off-by: Geert Uytterhoeven
---
drivers/video/logo/pnmtologo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
eady calls drm_atomic_helper_shutdown]
Signed-off-by: Geert Uytterhoeven
Reviewed-by: Laurent Pinchart
Reviewed-by: Sui Jingfeng
---
v3:
- Add Reviewed-by,
- Fix remaining references to drm_helper_force_disable_all(),
v2:
- Add Reviewed-by.
Tested on Atmark Techno Armadillo-800-EVA.
---
drive
Hi Doug,
On Tue, Jun 11, 2024 at 7:33 PM Doug Anderson wrote:
> On Wed, May 29, 2024 at 5:16 AM Geert Uytterhoeven
> wrote:
> >
> > From: Douglas Anderson
> >
> > Based on grepping through the source code, this driver appears to be
> > missing a call to dr
Hi Thierry,
On Thu, May 30, 2024 at 7:07 PM Thierry Reding wrote:
> Alternatively, maybe Kconfig could be taught about build dependencies?
git grep "depends on \$(" -- "*Kconf*"
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of
reg-names = "FRQCR", "CLKSTP00";
> +clocks = <>;
> +clock-names = "extal";
> +renesas,mode = <0>;
Nit: please move "renesas,mode" last.
> +#clock-cells = <1>;
> +#power-domain-cells = <0>;
eady calls drm_atomic_helper_shutdown]
Signed-off-by: Geert Uytterhoeven
Reviewed-by: Laurent Pinchart
---
v2:
- Add Reviewed-by.
Tested on Atmark Techno Armadillo-800-EVA.
---
drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/d
Add support for the drm_panic module for DU variants not using the
VSP-compositor, to display a message on the screen when a kernel panic
occurs.
Signed-off-by: Geert Uytterhoeven
---
Tested on Koelsch (R-Car M2-W).
Support for DU variants using the VSP-compositor is more convoluted,
and left
Add support for the drm_panic module, which displays a message on
the screen when a kernel panic occurs.
Signed-off-by: Geert Uytterhoeven
---
Tested on Armadillo-800-EVA.
---
drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion
On Mon, 27 May 2024, Geert Uytterhoeven wrote:
Below is the list of build error/warning regressions/improvements in
v6.10-rc1[1] compared to v6.9[2].
Summarized:
- build errors: +27/-20
- build warnings: +3/-1601
Happy fixing! ;-)
Thanks to the linux-next team for providing the build
egister %s pll clock (%d)\n" sounds more suitable to me.
> + node, clk_name, ret);
> + return ret;
> +}
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal con
way, we can reduce the overall size
> of the series a bit.
+1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to j
for two different things:
A. To enable a driver module that can be only built-in,
B. To enable an option or feature of a driver or subsystem.
Without this distinction, dependencies cannot be auto-propagated 100%
correctly. Fixing that would require introducing a third type (and possibly
renaming the
Hi Jani,
On Mon, Apr 22, 2024 at 7:15 PM Jani Nikula wrote:
> On Mon, 22 Apr 2024, Geert Uytterhoeven wrote:
> > On Mon, Apr 22, 2024 at 3:55 PM Arnd Bergmann wrote:
> >> I'm not sure where this misunderstanding comes from, as you
> >> seem to be repeating the same
t; There is no end to this, it just goes on and on, as the
> > dependencies of the selected symbols change over time. Often the
> > selects require unintuitive if patterns that are about the
> > implementation details of the symbol being selected.
>
> Agreed, tha
is interested in. Making a driver depend
on helper code means that the user needs to know which helpers to enable
first, which is very user-unfriendly.
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/display/Kconfig | 26 --
1 file changed, 12 insertions(+), 14 deletions
is interested in. Making a driver depend
on helper code means that the user needs to know which helpers to enable
first, which is very user-unfriendly.
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/Kconfig | 6 ++
drivers/gpu/drm/amd/amdgpu/Kconfig | 6
This reverts commit d1ef8fc18be6adbbffdee06fbb5b33699e2852be, as the
commit it fixes will be reverted, too.
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/exynos/Kconfig | 2 +-
drivers/gpu/drm/rockchip/Kconfig | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
This reverts commit 7fa678cc0a5648b5ea28629a2d21b9d4b6ac8f56, as the
commit it fixes will be reverted, too.
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/display/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/display/Kconfig b/drivers/gpu/drm/display/Kconfig
is interested in. Making a driver depend
on helper code means that the user needs to know which helpers to enable
first, which is very user-unfriendly.
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/bridge/Kconfig | 6 +++---
drivers/gpu/drm/bridge/analogix/Kconfig | 2 +-
drivers/gpu
is interested in. Making a driver depend
on helper code means that the user needs to know which helpers to enable
first, which is very user-unfriendly.
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/Kconfig | 2 +-
drivers/gpu/drm/amd/amdgpu/Kconfig | 2 +-
drivers/gpu
This reverts commit 0209df3b4731516fe77638bfc52ba2e9629c67cd, as the
commit it fixes (which is BTW not the commit in the Fixes: tag!) will be
reverted, too.
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/bridge/synopsys/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
is interested in. Making a driver depend
on helper code means that the user needs to know which helpers to enable
first, which is very user-unfriendly.
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/amd/amdgpu/Kconfig | 2 +-
drivers/gpu/drm/bridge/synopsys/Kconfig | 2 +-
drivers/gpu/drm
This reverts commit a57e191ebbaa0363dbf352cc37447c2230573e29, as the
commits it fixes will be reverted, too.
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/bridge/analogix/Kconfig | 2 +-
drivers/gpu/drm/rockchip/Kconfig| 2 +-
2 files changed, 2 insertions(+), 2 deletions
ean
adding dependencies to the source symbol.
Thanks for applying!
[1]
https://lore.kernel.org/r/20240327-kms-kconfig-helpers-v3-0-eafee11b8...@kernel.org/
Geert Uytterhoeven (11):
Revert "drm: fix DRM_DISPLAY_DP_HELPER dependencies, part 2"
Revert "drm/display: Select DRM_
is interested in. Making a driver depend
on helper code means that the user needs to know which helpers to enable
first, which is very user-unfriendly.
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/bridge/imx/Kconfig | 4 ++--
drivers/gpu/drm/imx/ipuv3/Kconfig | 5 ++---
drivers
is interested in. Making a driver depend
on helper code means that the user needs to know which helpers to enable
first, which is very user-unfriendly.
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/amd/amdgpu/Kconfig | 2 +-
drivers/gpu/drm/bridge/Kconfig | 2 +-
drivers/gpu/drm
ructures.
>
> Thanks! I don't see a __packed attribute on struct drm_connector, but
> I'll put it near by other bools in case that changes in the future.
FTR, don't add __packed unless you have a very good reason to do so.
With __packed, the compiler will emit multiple byte-accesses to
a
arts are an integral number of pages, based on fix.smem_{start,len}
resp. fix.mmio_{start,len}.
Old XFree86 used the MMIO part to implement hardware acceleration
when running on top of fbdev.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32
Hi Jani,
On Tue, Apr 9, 2024 at 1:13 PM Jani Nikula wrote:
> On Tue, 09 Apr 2024, Geert Uytterhoeven wrote:
> > On Tue, Apr 9, 2024 at 12:04 PM Jani Nikula
> > wrote:
> >> On Tue, 09 Apr 2024, Geert Uytterhoeven wrote:
> >> > The user should not n
mu_device_driver);
> #endif
[1] "[PATCH] clocksource/drivers/renesas-ostm: Avoid reprobe after
successful early probe"
https://lore.kernel.org/all/bd027379713cbaafa21ffe9e848ebb7f475ca0e7.1710930542.git.geert+rene...@glider.be/
Gr{oetje,eeting}s,
Geert
--
Hi Jani,
On Tue, Apr 9, 2024 at 12:04 PM Jani Nikula wrote:
> On Tue, 09 Apr 2024, Geert Uytterhoeven wrote:
> > The user should not need to know which helpers are needed for the driver
> > he is interested in. When a symbol selects another symbol, it should
> > just make
are needed for the driver
he is interested in. When a symbol selects another symbol, it should
just make sure the dependencies of the target symbol are met.
Thanks for reverting ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Li
explicitly.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say
s-...@vger.kernel.org
> Signed-off-by: Ville Syrjälä
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hack
Hi Sato-san,
On Thu, Apr 4, 2024 at 7:15 AM Yoshinori Sato
wrote:
> Add Renesas SH7751 SCIF.
>
> Signed-off-by: Yoshinori Sato
> Reviewed-by: Geert Uytterhoeven
> --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> +++ b/Documentation/devicetree/bindi
iodata,usl-5p # USL-5P
> + - const: renesas,sh7751r
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker.
property:
ex:
$ref: /schemas/types.yaml#/definitions/uint32
description: Extend bus holding time.
Please instead use an enum for the actual holding time ([ 0, 16, 32,
...]) in the DT bindings, and convert from actual holding time to
register value in the driver.
Gr{oetje,eeting
ivider_flags,
Likewise.
> const struct clk_div_table *table, spinlock_t *lock);
> struct clk *clk_register_divider_table(struct device *dev, const char *name,
> const char *parent_name, unsigned long flags,
> void __iomem *reg, u8 shift, u8 width,
&g
On Thu, Apr 4, 2024 at 7:16 AM Yoshinori Sato
wrote:
> Signed-off-by: Yoshinori Sato
My
Reviewed-by: Geert Uytterhoeven
on v6 is still valid.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In perso
Hi Sato-san,
On Thu, Apr 4, 2024 at 7:16 AM Yoshinori Sato
wrote:
> Signed-off-by: Yoshinori Sato
>From my comments for v6:
Please enhance the one-line summary, e.g.
sh: j2_mimas_v2: Update CPU compatible value
For the actual changes:
Reviewed-by: Geert Uytterhoeven
Gr{oetje,ee
};
Please read
https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conve
On Thu, Apr 4, 2024 at 7:15 AM Yoshinori Sato
wrote:
> Signed-off-by: Yoshinori Sato
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with techni
There is no point in asking the user about enabling DRM debug tracing
when configuring a kernel without DRM support.
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/Kconfig | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm
There is no point in asking the user about enforcing the DRM compiler
warning policy when configuring a kernel without DRM support.
Fixes: f89632a9e5fa6c47 ("drm: Add CONFIG_DRM_WERROR")
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/Kconfig | 2 +-
1 file changed, 1 inser
On Mon, 25 Mar 2024, Geert Uytterhoeven wrote:
Below is the list of build error/warning regressions/improvements in
v6.9-rc1[1] compared to v6.8[2].
Summarized:
- build errors: +8/-8
+ /kisskb/src/crypto/scompress.c: error: unused variable 'dst_page'
[-Werror=unused-variable]: => 174
nction names in BUG/WARNING messages). That change, if
> desired, can be made later.
Unfortunately this also increases kernel size in the CONFIG_KUNIT=m
case (ca. 80 KiB for atari_defconfig), making it less attractive to have
kunit and all tests enabled as modules in my standard kernel.
Gr{oetje,ee
On Thu, Mar 14, 2024 at 10:27 AM Geert Uytterhoeven
wrote:
> On Sat, Mar 9, 2024 at 3:34 PM David Laight wrote:
> > From: Maxime Ripard
> > > Sent: 04 March 2024 11:46
> > >
> > > On Mon, Mar 04, 2024 at 12:11:36PM +0100, Arnd Bergmann wrote:
> > > &g
; You could do:
> /* The max clock is 5.9GHz, split the divide */
> u32 diff = (u32)(clock / 8) / (200/8);
+1, as the issue is still present in current next, as per the recent
nagging from the build bots.
> The code should really use u32 and u64.
> Otherwise the sizes are d
On Wed, Mar 13, 2024 at 4:49 PM Thomas Zimmermann wrote:
> Replace the use of struct backlight_properties.fb_blank with a
> call to backlight_get_brightness(). The helper implement the same
> logic as the driver's function.
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Gee
_), \
> + : : "i" (__BUG_FUNC), \
> + "i" (__LINE__), \
> "i" (x),
Hi Thomas,
On Wed, Mar 13, 2024 at 10:24 AM Thomas Zimmermann wrote:
> Am 13.03.24 um 10:03 schrieb Geert Uytterhoeven:
> > On Wed, Mar 13, 2024 at 9:19 AM Thomas Zimmermann
> > wrote:
> >> Am 12.03.24 um 17:14 schrieb Geert Uytterhoeven:
> >>> On Tue, Mar 1
Hi Thomas,
On Wed, Mar 13, 2024 at 9:19 AM Thomas Zimmermann wrote:
> Am 12.03.24 um 17:14 schrieb Geert Uytterhoeven:
> > On Tue, Mar 12, 2024 at 4:48 PM Thomas Zimmermann
> > wrote:
> >> Add an fbdev emulation for SHMEM-based memory managers. The code is
>
"Failed to register client: %d\n", ret);
> + goto err_drm_client_init;
> + }
> +
> + drm_client_register(_helper->client);
> +
> + return;
> +
> +err_drm_client_init:
> + drm_fb_helper_unprepare(fb_helper);
> +
m68k.org
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
@intel.com
Signed-off-by: Geert Uytterhoeven
---
Jani: Feel free to pick this up as a dependency.
Else I will queue this in the m68k tree for v6.10.
arch/m68k/include/asm/pgtable.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/m68k/include/asm/pgtable.h b/arch/m68k/include/asm
Hi Maxime,
On Mon, Mar 4, 2024 at 11:20 AM Maxime Ripard wrote:
> On Mon, Mar 04, 2024 at 11:07:22AM +0100, Geert Uytterhoeven wrote:
> > On Mon, Mar 4, 2024 at 10:15 AM Maxime Ripard wrote:
> > > On Mon, Mar 04, 2024 at 09:12:38AM +0100, Geert Uytterhoeven wrote:
> >
eady calls drm_atomic_helper_shutdown]
Signed-off-by: Geert Uytterhoeven
Reviewed-by: Laurent Pinchart
---
v2:
- Add Reviewed-by.
Tested on Atmark Techno Armadillo-800-EVA.
---
drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/d
Hi Maxime,
On Mon, Mar 4, 2024 at 10:15 AM Maxime Ripard wrote:
> On Mon, Mar 04, 2024 at 09:12:38AM +0100, Geert Uytterhoeven wrote:
> > On Sun, Mar 3, 2024 at 10:30 AM Geert Uytterhoeven
> > wrote:
> > > On Sun, Mar 3, 2024 at 3:30 AM Randy Dunlap wrote:
> >
13a ("drm/sun4i: hdmi: Consolidate atomic_check and
> mode_valid")
> Reported-by: Geert Uytterhoeven
> Reported-by: Naresh Kamboju
> Closes:
> https://lore.kernel.org/r/CA+G9fYvG9KE15PGNoLu+SBVyShe+u5HBLQ81+kK9Zop6u=y...@mail.gmail.com/
> Reported-by: kernel test robot
&
On Sun, Mar 3, 2024 at 10:30 AM Geert Uytterhoeven wrote:
> On Sun, Mar 3, 2024 at 3:30 AM Randy Dunlap wrote:
> > On 3/2/24 14:10, Guenter Roeck wrote:
> > > While checkpatch is indeed of arguable value, I think it would help a
> > > lot not having to bother a
mail when builds get broken, and when they get
fixed again. I receive such emails for the m68k builds.
I have the feeling this is not used up to its full potential yet.
My initial plan with the "Build regressions/improvements in ..." emails
[1] was to fully automate this, and enabl
On Tue, Jan 9, 2024 at 9:24 AM Yoshinori Sato
wrote:
> Signed-off-by: Yoshinori Sato
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with techni
7750-cpg.h
> @@ -0,0 +1,26 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> + *
> + * Copyright 2023 Yoshinori Sato
> + */
> +
> +#ifndef __DT_BINDINGS_CLOCK_SH7750_H__
> +#define __DT_BINDINGS_CLOCK_SH7750_H__
> +
> +#define SH7750_CPG_PLLOUT 0
>
quot; here, and return an error code instead? ...
> + return cpg;
> +
> +unmap_clkstp00:
> + iounmap(cpg->clkstp00);
> +unmap_frqcr:
> + iounmap(cpg->frqcr);
> +cpg_free:
> + kfree(cpg);
> + return ERR_PTR(ret);
> +}
> +
> +static void __init sh7750_cpg_init(struct device_node *node)
> +{
> + cpg_data = sh7750_cpg_setup(node, cpg_feature[CPG_SH7750]);
> + if (IS_ERR(cpg_data))
> + cpg_data = NULL;
... then all cpg_data handling can be removed here...
> +}
> +static int sh7750_cpg_probe(struct platform_device *pdev)
> +{
> + u32 feature;
> +
> + if (cpg_data)
> + return 0;
> + feature = *(u32 *)of_device_get_match_data(>dev);
> + cpg_data = sh7750_cpg_setup(pdev->dev.of_node, feature);
> + if (IS_ERR(cpg_data))
> + return PTR_ERR(cpg_data);
> + return 0;
... and this can be simplified to
return sh7750_cpg_setup(...);
> +}
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi Sato-san,
On Tue, Jan 9, 2024 at 9:24 AM Yoshinori Sato
wrote:
> Signed-off-by: Yoshinori Sato
Thanks for your patch!
Please enhance the one-line summary, e.g.
sh: j2_mimas_v2: Update CPU compatible value
For the actual changes:
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eetin
> +
> +additionalProperties: true
> +
> +...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
DIANBIT(2)
> +#define CLK_GATE_REG_8BIT BIT(3)
> +#define CLK_GATE_REG_16BIT BIT(4)
>
> extern const struct clk_ops clk_gate_ops;
> struct clk_hw *__clk_hw_register_gate(struct device *dev,
The rest LGTM.
Gr{oetje,eeting}s,
gitlab.freedesktop.org/imagination/linux/-/blob/b3506b8bc45ed6d4005eb32a994df0e33d6613f1/arch/arm64/boot/dts/mediatek/mt8173.dtsi#L993-1006
[2]
https://gitlab.freedesktop.org/imagination/linux/-/blob/b3506b8bc45ed6d4005eb32a994df0e33d6613f1/Documentation/devicetree/bindings/gpu/img,powervr.yaml
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Tue, Feb 27, 2024 at 9:09 AM Geert Uytterhoeven wrote:
> On Tue, Feb 27, 2024 at 8:48 AM Geert Uytterhoeven
> wrote:
> > On Tue, Feb 27, 2024 at 4:46 AM Adam Ford wrote:
> > > Update the binding to add support for various Renesas SoC's with PowerVR
> > >
v1.fw
> powervr fd00.gpu: [drm] FW version v1.0 (build 6513336 OS)
>
> Signed-off-by: Adam Ford
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations
nitialized powervr 1.0.0 20230904 for fd00.gpu on minor 1
Reviewed-by: Geert Uytterhoeven
Tested-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technic
ersion v1.0 (build 6538781 OS)
[drm] Initialized powervr 1.0.0 20230904 for fd00.gpu on minor 1
>
> Signed-off-by: Adam Ford
Tested-by: Geert Uytterhoeven
> --- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> @@ -2771,6 +277
1 - 100 of 1794 matches
Mail list logo
