Re: [PATCH v6 04/12] spi: intel-dg: spi register with mtd

2024-09-19 Thread Mark Brown
On Thu, Sep 19, 2024 at 10:01:06AM +, Winkler, Tomas wrote: > > On Mon, Sep 16, 2024 at 04:49:20PM +0300, Alexander Usyskin wrote: > > > +static int intel_dg_spi_write(struct mtd_info *mtd, loff_t to, size_t > > > len, > > > + size_t *retlen, const u_char *buf) { > > > +

Re: [PATCH v6 02/12] spi: intel-dg: implement region enumeration

2024-09-19 Thread Mark Brown
On Thu, Sep 19, 2024 at 09:55:54AM +, Winkler, Tomas wrote: > > On Mon, Sep 16, 2024 at 04:49:18PM +0300, Alexander Usyskin wrote: > > > In intel-dg spi, there is no access to the spi controller, the > > > information is extracted from the descriptor region. > > Which information? I can't te

Re: [PATCH v6 01/12] spi: add driver for intel graphics on-die spi device

2024-09-19 Thread Mark Brown
On Thu, Sep 19, 2024 at 09:54:24AM +, Winkler, Tomas wrote: > > On Mon, Sep 16, 2024 at 04:49:17PM +0300, Alexander Usyskin wrote: > > > @@ -0,0 +1,142 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * Copyright(c) 2019-2024, Intel Corporation. All rights reserved. > > > + */

Re: [PATCH v6 00/12] spi: add driver for Intel discrete graphics

2024-09-19 Thread Mark Brown
On Thu, Sep 19, 2024 at 06:56:39AM +, Usyskin, Alexander wrote: > > On Mon, Sep 16, 2024 at 04:49:16PM +0300, Alexander Usyskin wrote: > > As far as I can tell this does not actually provide a SPI driver, there > > is no call to any SPI API that I've noticed here. The SPI framework > > does h

Re: [PATCH v6 00/12] spi: add driver for Intel discrete graphics

2024-09-18 Thread Mark Brown
On Mon, Sep 16, 2024 at 04:49:16PM +0300, Alexander Usyskin wrote: > Add driver for access to Intel discrete graphics card > internal SPI device. > Expose device on auxiliary bus by i915 and Xe drivers and > provide spi driver to register this device with MTD framework. As far as I can tell this d

Re: [PATCH v6 04/12] spi: intel-dg: spi register with mtd

2024-09-18 Thread Mark Brown
On Mon, Sep 16, 2024 at 04:49:20PM +0300, Alexander Usyskin wrote: > From: Tomas Winkler > > Register the on-die spi device with the mtd subsystem. > Refcount spi object on _get and _put mtd callbacks. This is a MTD driver, it should be in drivers/mtd. > +static int intel_dg_spi_erase(struct m

Re: [PATCH v6 02/12] spi: intel-dg: implement region enumeration

2024-09-18 Thread Mark Brown
On Mon, Sep 16, 2024 at 04:49:18PM +0300, Alexander Usyskin wrote: > In intel-dg spi, there is no access to the spi controller, > the information is extracted from the descriptor region. Which information? I can't tell what this patch is supposed to do; as with the first patch this shouldn't be

Re: [PATCH v6 01/12] spi: add driver for intel graphics on-die spi device

2024-09-18 Thread Mark Brown
On Mon, Sep 16, 2024 at 04:49:17PM +0300, Alexander Usyskin wrote: > Add auxiliary driver for intel discrete graphics > on-die spi device. This doesn't actually do anything AFAICT? It doesn't register with any subsystem or anything. Please don't submit empty boilerplate like this, submit a driv

Re: (subset) [PATCH v7 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-09-12 Thread Mark Brown
On Thu, Sep 12, 2024 at 03:51:00PM +0100, Lee Jones wrote: > On Wed, 04 Sep 2024, Mark Brown wrote: > > [03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC > > commit: 761cab667898d86c04867948f1b7aec1090be796 > Did you mean to hoover this up? It

Re: (subset) [PATCH v7 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-09-06 Thread Mark Brown
On Fri, Sep 06, 2024 at 12:23:23PM -0700, Nathan Chancellor wrote: > On Fri, Sep 06, 2024 at 07:27:01PM +0100, Mark Brown wrote: > > Are these just warnings introduced by recent versions of the toolchains? > > These commits passed an x86 allmodconfig with GCC 12 at each step (I di

Re: (subset) [PATCH v7 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-09-06 Thread Mark Brown
On Fri, Sep 06, 2024 at 07:27:04PM +0100, Mark Brown wrote: > These commits passed an x86 allmodconfig with GCC 12 at each step (I did > catch one warning there with another patch in the series that didn't get > applied) and 0day didn't say anything at any point. Oh, actu

Re: (subset) [PATCH v7 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-09-06 Thread Mark Brown
On Fri, Sep 06, 2024 at 11:03:48AM -0700, Nathan Chancellor wrote: > I am seeing several warnings/errors from both GCC and Clang with > ARCH=arm64 allmodconfig after this series appeared in next-20240906. > As far as I can tell, they appear to agree. I wondered how this was not > caught during the

Re: (subset) [PATCH v7 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-09-04 Thread Mark Brown
On Mon, 22 Jul 2024 08:53:29 +0200, Alexandre Mergnat wrote: > This serie aim to add the following audio support for the Genio 350-evk: > - Playback > - 2ch Headset Jack (Earphone) > - 1ch Line-out Jack (Speaker) > - 8ch HDMI Tx > - Capture > - 1ch DMIC (On-board Digital Microphone) > - 1

Re: (subset) [PATCH v6 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-09-04 Thread Mark Brown
On Wed, 19 Jun 2024 16:46:36 +0200, Alexandre Mergnat wrote: > This serie aim to add the following audio support for the Genio 350-evk: > - Playback > - 2ch Headset Jack (Earphone) > - 1ch Line-out Jack (Speaker) > - 8ch HDMI Tx > - Capture > - 1ch DMIC (On-board Digital Microphone) > - 1

Re: (subset) [PATCH v4 0/9] Add device tree for ArmSoM Sige 5 board

2024-09-03 Thread Mark Brown
On Tue, 03 Sep 2024 11:22:30 -0400, Detlev Casanova wrote: > Add the rk3576-armsom-sige5 device tree as well as its rk3576.dtsi base > and pinctrl information in rk3576-pinctrl.dtsi. > > The other commits add DT bindings documentation for the devices that > already work with the current correspond

Re: [PATCH v7 12/16] ASoC: codecs: add MT6357 support

2024-09-03 Thread Mark Brown
On Mon, Jul 22, 2024 at 08:53:41AM +0200, amerg...@baylibre.com wrote: > From: Nicolas Belin > > Add the support of MT6357 PMIC audio codec. This breaks the build: /build/stage/linux/sound/soc/codecs/mt6357.c: In function ‘mt6357_platform_driver_probe’: /build/stage/linux/sound/soc/codecs/mt63

Re: [PATCH] regulator: core: Stub devm_regulator_bulk_get_const() if !CONFIG_REGULATOR

2024-08-30 Thread Mark Brown
On Fri, 30 Aug 2024 07:35:12 -0700, Douglas Anderson wrote: > When adding devm_regulator_bulk_get_const() I missed adding a stub for > when CONFIG_REGULATOR is not enabled. Under certain conditions (like > randconfig testing) this can cause the compiler to reports errors > like: > > error: impli

Re: [PATCH v7 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-08-14 Thread Mark Brown
On Wed, Aug 14, 2024 at 10:23:12AM +0200, Alexandre Mergnat wrote: > Simple gentle ping, the serie seems ready to be applied. Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some

Re: [PATCH v2 3/9] ASoC: test-component: use new of_graph functions

2024-08-13 Thread Mark Brown
On Fri, Aug 09, 2024 at 04:22:38AM +, Kuninori Morimoto wrote: > Current test-component.c is using for_each_endpoint_of_node() > for parsing "port", because there was no "port" base loop before. > It has been assuming 1 port has 1 endpoint here. Acked-by

Re: [PATCH 6/9] ASoC: audio-graph-card2: use new of_graph functions

2024-08-06 Thread Mark Brown
On Tue, Aug 06, 2024 at 04:58:46AM +, Kuninori Morimoto wrote: > Now we can use new port related functions for port parsing. Use it. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH 5/9] ASoC: audio-graph-card: use new of_graph functions

2024-08-06 Thread Mark Brown
On Tue, Aug 06, 2024 at 04:58:42AM +, Kuninori Morimoto wrote: > Now we can use new port related functions for port parsing. Use it. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH 4/9] ASoC: rcar_snd: use new of_graph functions

2024-08-06 Thread Mark Brown
On Tue, Aug 06, 2024 at 04:58:38AM +, Kuninori Morimoto wrote: > Now we can use new port related functions for port parsing. Use it. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH v5 00/12] spi: add driver for Intel discrete graphics

2024-07-29 Thread Mark Brown
On Mon, Jul 29, 2024 at 11:43:14AM +0300, Alexander Usyskin wrote: > V5: depend solely on AUXILIARY_BUS, not on COMPILE_TEST > disable spi driver on virtual function in Xe, no spi device there > V4: fix white-spaces > add check for discrete graphics missed in i915 intel_spi_fini > V3: re

Re: linux-next: build failure after merge of the drm

2024-06-28 Thread Mark Brown
On Fri, Jun 28, 2024 at 07:58:23PM +0200, Michal Wajdeczko wrote: > On 28.06.2024 19:03, Mark Brown wrote: > > /tmp/next/build/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c: In function > > 'pf_get_threshold': > > /tmp/next/build/drivers/gpu/drm/xe/xe_gt_s

linux-next: build failure after merge of the drm

2024-06-28 Thread Mark Brown
Hi all, After merging the drm tree, today's linux-next build (x86_64 allmodconfig) failed like this: /tmp/next/build/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c: In function 'pf_get_threshold': /tmp/next/build/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c:1788:27: error: unused variable 'xe' [-Werr

linux-next: manual merge of the drm tree with the origin tree

2024-06-28 Thread Mark Brown
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/xe/xe_gt_idle.c between commit: 2470b141bfae2 ("drm/xe: move disable_c6 call") from the origin tree and commits: 6800e63cf97ba ("drm/xe: move disable_c6 call") 38e8c4184ea0e ("drm/xe: Enable Coarse Pow

linux-next: manual merge of the drm tree with the drm-fixes tree

2024-06-27 Thread Mark Brown
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h between commit: c223376b3019a ("drm/amd/swsmu: add MALL init support workaround for smu_v14_0_1") from the drm-fixes tree and commit: ec41bdd82e9b0 ("drm/amd/pm: Update PMFW

linux-next: manual merge of the drm tree with the origin tree

2024-06-27 Thread Mark Brown
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_init.c between commit: c03d770c0b014 ("drm/amd/display: Attempt to avoid empty TUs when endpoint is DPIA") from the origin tree and commit: 0127f0445f7c1 ("drm/amd/displa

linux-next: manual merge of the drm tree with the drm-fixes tree

2024-06-27 Thread Mark Brown
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c between commit: f6f49dda49db7 ("drm/amdgpu/atomfirmware: fix parsing of vram_info") from the drm-fixes tree and commit: 9a55c77978308 ("drm/amdgpu: fix getting vram info

Re: [PATCH v6 12/16] ASoC: codecs: add MT6357 support

2024-06-21 Thread Mark Brown
On Wed, Jun 19, 2024 at 04:46:48PM +0200, amerg...@baylibre.com wrote: > From: Nicolas Belin > > Add the support of MT6357 PMIC audio codec. This breaks an x86 allmodconfig build: /build/stage/linux/sound/soc/codecs/mt6357.c: In function ‘mt_delay_250_event’: /build/stage/linux/sound/soc/codecs

linux-next: manual merge of the drm tree with the drm-fixes tree

2024-06-21 Thread Mark Brown
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_init.c between commit: c03d770c0b014 ("drm/amd/display: Attempt to avoid empty TUs when endpoint is DPIA") from the drm-fixes tree and commits: 47745acc5e8dd ("drm/amd/di

Re: [PATCH v6 12/16] ASoC: codecs: add MT6357 support

2024-06-21 Thread Mark Brown
On Wed, Jun 19, 2024 at 04:46:48PM +0200, amerg...@baylibre.com wrote: > + /* gain default values*/ > + regmap_update_bits(priv->regmap, MT6357_AUDENC_ANA_CON0, > MT6357_AUDPREAMPLGAIN_MASK, > +UL_GAIN_0DB << MT6357_AUDPREAMPLGAIN_SFT); > + regmap_update_bits(p

Missing signoffs in the drm-next tree

2024-06-21 Thread Mark Brown
In today's drm tree commits 824a450c0d90a ("accel/habanalabs: gradual sleep in polling memory macro") fb0e9ebb93aa9 ("accel/habanalabs: move heartbeat work initialization to early init") ee6350c6c3300 ("accel/habanalabs: print timestamp of last PQ heartbeat on EQ heartbeat failure") 9948

Re: [PATCH v3 18/23] regulator: add s2dos05 regulator support

2024-06-19 Thread Mark Brown
On Wed, Jun 19, 2024 at 06:49:06PM +0300, Dzmitry Sankouski wrote: > вт, 18 июн. 2024 г. в 17:08, Mark Brown : > > On Tue, Jun 18, 2024 at 04:59:52PM +0300, Dzmitry Sankouski wrote: > > > +// SPDX-License-Identifier: GPL-2.0+ > > > +/* > > > + * s2dos05.

Re: [PATCH RESEND v5 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-06-18 Thread Mark Brown
On Mon, Jun 17, 2024 at 10:05:37AM +0200, Alexandre Mergnat wrote: > On 14/06/2024 11:31, Mark Brown wrote: > > I seem to remember you had review comments that needed addressing from > > AngeloGioacchino, why resend without addressing those? > I don't see any comment: &g

Re: [PATCH v3 18/23] regulator: add s2dos05 regulator support

2024-06-18 Thread Mark Brown
On Tue, Jun 18, 2024 at 04:59:52PM +0300, Dzmitry Sankouski wrote: > index ..3c58a1bd2262 > --- /dev/null > +++ b/drivers/regulator/s2dos05-regulator.c > @@ -0,0 +1,362 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * s2dos05.c - Regulator driver for the Samsung s2dos05 > + * Pl

linux-next: manual merge of the drm tree with the drm-intel-fixes tree

2024-06-17 Thread Mark Brown
Hi all, Today's linux-next merge of the drm tree got conflicts in: drivers/gpu/drm/xe/xe_gt_idle.c drivers/gpu/drm/xe/xe_guc_pc.c between commits: 2470b141bfae2 ("drm/xe: move disable_c6 call") 7c877115da419 ("drm/xe/xe_gt_idle: use GT forcewake domain assertion") from the drm-intel-fi

Re: [PATCH RFC 2/5] ASoC: hdmi-codec: pass data to get_dai_id too

2024-06-17 Thread Mark Brown
On Sat, Jun 15, 2024 at 08:53:31PM +0300, Dmitry Baryshkov wrote: > The upcoming DRM connector HDMI codec implementation is going to use > codec-specific data in the .get_dai_id to get drm_connector. Pass data > to the callback, as it is done with other hdmi_codec_ops callbacks. Acked

Re: [PATCH RESEND v5 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-06-14 Thread Mark Brown
On Fri, Jun 14, 2024 at 09:27:43AM +0200, Alexandre Mergnat wrote: > This serie aim to add the following audio support for the Genio 350-evk: > - Playback > - 2ch Headset Jack (Earphone) > - 1ch Line-out Jack (Speaker) > - 8ch HDMI Tx I seem to remember you had review comments that needed ad

Re: [PATCH v4 05/16] SoC: mediatek: mt8365: support audio clock control

2024-04-29 Thread Mark Brown
On Fri, Apr 26, 2024 at 07:22:34PM +0200, Alexandre Mergnat wrote: > Add audio clock wrapper and audio tuner control. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the

Re: [PATCH v3 07/13] drm: Make drivers depends on DRM_DW_HDMI

2024-04-22 Thread Mark Brown
On Tue, Apr 02, 2024 at 04:43:46PM +0100, Mark Brown wrote: > On Wed, Mar 27, 2024 at 11:57:02AM +0100, Maxime Ripard wrote: > > > DRM_DW_HDMI has a number of dependencies that might not be enabled. > > However, drivers were used to selecting it while not enforcing t

Re: [PATCH 0/7] drm/display: Fix display helpers depends on fallouts

2024-04-15 Thread Mark Brown
On Mon, Apr 15, 2024 at 01:21:47PM +0200, Maxime Ripard wrote: > On Wed, Apr 10, 2024 at 07:06:39PM +0100, Mark Brown wrote: > > Is there any news on getting the rest of this merged? It's been more > > than a week now and the Designware display controllers are all still

Re: [PATCH 0/7] drm/display: Fix display helpers depends on fallouts

2024-04-10 Thread Mark Brown
On Wed, Apr 03, 2024 at 12:56:18PM +0200, Maxime Ripard wrote: > Hi, > > Here's a series addressing the various regressions that were reported > after the Kconfig rework for the DRM display helpers. > > Let me know what you think, > Maxime Is there any news on getting the rest of this merged? I

Re: [PATCH 0/7] drm/display: Fix display helpers depends on fallouts

2024-04-03 Thread Mark Brown
nfig so Reviewed-by: Mark Brown Between the arm64 defconfig update not applying on -next and unrelated breakage on arm I didn't actually do a proper test. signature.asc Description: PGP signature

Re: [PATCH v3 07/13] drm: Make drivers depends on DRM_DW_HDMI

2024-04-02 Thread Mark Brown
On Wed, Mar 27, 2024 at 11:57:02AM +0100, Maxime Ripard wrote: > DRM_DW_HDMI has a number of dependencies that might not be enabled. > However, drivers were used to selecting it while not enforcing the > DRM_DW_HDMI dependencies. > > This could result in Kconfig warnings (and further build breaka

Re: (subset) [PATCH v2 0/4] drm: xlnx: zynqmp: Add DP audio support

2024-03-26 Thread Mark Brown
On Tue, 19 Mar 2024 10:22:35 +0200, Tomi Valkeinen wrote: > Add DisplayPort audio support for Xilinx ZynqMP platforms. > > This depends on patch adding cyclic DMA mode for DPDMA driver: > > https://lore.kernel.org/all/20240228042124.3074044-3-vishal.sa...@amd.com/ > > If that patch is missing, s

Re: (subset) [PATCH 0/4] drm: xlnx: zynqmp: Add DP audio support

2024-03-26 Thread Mark Brown
On Tue, 12 Mar 2024 11:41:01 +0200, Tomi Valkeinen wrote: > Add DisplayPort audio support for Xilinx ZynqMP platforms. > > This depends on patch adding cyclic DMA mode for DPDMA driver: > > https://lore.kernel.org/all/20240228042124.3074044-3-vishal.sa...@amd.com/ > > If that patch is missing, s

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-03-15 Thread Mark Brown
On Fri, Mar 15, 2024 at 06:36:19PM +0100, Alexandre Mergnat wrote: > On 15/03/2024 16:15, Mark Brown wrote: > > On Fri, Mar 15, 2024 at 04:05:21PM +0100, Alexandre Mergnat wrote: > > > > In the register. You only need to reset the gain to -40dB at the start > > > &

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-03-15 Thread Mark Brown
On Fri, Mar 15, 2024 at 04:05:21PM +0100, Alexandre Mergnat wrote: > On 15/03/2024 15:30, Mark Brown wrote: > > > Let me know, when you change de gain to do a ramp down (start from user > > > gain > > > to gain=-40db), next time for the ramp up, how/where d

Re: [PATCH 00/18] Add audio support for the MediaTek Genio 350-evk board

2024-03-15 Thread Mark Brown
On Tue, Mar 12, 2024 at 09:58:05AM +0100, Alexandre Mergnat wrote: > I'm a bit lost for mixer-test and pcm-test. > Currently, I cross-compile the alsa lib project to be able to build the > tests and put it on my board. > I can execute it, but I still have 2 issues: > 1) I've a lot of missing mod

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-03-15 Thread Mark Brown
On Fri, Mar 15, 2024 at 12:01:12PM +0100, Alexandre Mergnat wrote: > On 13/03/2024 18:23, Mark Brown wrote: > > On Tue, Mar 12, 2024 at 07:03:25PM +0100, Alexandre Mergnat wrote: > > > Actually you must save the values because the gain selected by the user > > > wil

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-03-13 Thread Mark Brown
On Wed, Mar 13, 2024 at 06:11:50PM +0100, Alexandre Mergnat wrote: > On 26/02/2024 17:09, Mark Brown wrote: > > > index ..13e95c227114 > > > --- /dev/null > > > +++ b/sound/soc/codecs/mt6357.c > > > @@ -0,0 +1,1805 @@ >

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-03-13 Thread Mark Brown
On Tue, Mar 12, 2024 at 07:03:25PM +0100, Alexandre Mergnat wrote: > On 26/02/2024 17:09, Mark Brown wrote: > > > + case MT6357_ZCD_CON2: > > > + regmap_read(priv->regmap, MT6357_ZCD_CON2, ®); > > > + priv->ana_gain[ANALOG_VOLUME_HP

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-01 Thread Mark Brown
On Fri, Mar 01, 2024 at 12:27:13PM +0200, Nikolai Kondrashov wrote: > On 2/29/24 10:21 PM, Linus Torvalds wrote: > > We already have the situation that the drm people have their own ci > > model. II'm ok with that, partly because then at least the maintainers > > of that subsystem can agree on the

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Mark Brown
On Thu, Feb 29, 2024 at 01:19:19PM +0200, Laurent Pinchart wrote: > On Thu, Feb 29, 2024 at 01:10:16PM +0200, Nikolai Kondrashov wrote: > > Of course. You're also welcome to join the #kernelci channel on libera.chat. > Isn't that a bit pointless if it's no the main IM channel ? It *was* the orig

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Mark Brown
On Thu, Feb 29, 2024 at 09:39:01AM +, Sakari Ailus wrote: > On Thu, Feb 29, 2024 at 01:07:25AM +0200, Laurent Pinchart wrote: > > > We have a Slack channel, #gitlab-ci, on the KernelCI Slack instance > > > https://kernelci.slack.com/ . > > > Feel free to join and contribute to the conversatio

Re: [PATCH v5 7/8] ASoC: dt-bindings: xmos, xvf3500: add XMOS XVF3500 voice processor

2024-02-28 Thread Mark Brown
On Wed, Feb 28, 2024 at 02:51:34PM +0100, Javier Carrasco wrote: > The XMOS XVF3500 VocalFusion Voice Processor[1] is a low-latency, 32-bit > multicore controller for voice processing. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH 00/18] Add audio support for the MediaTek Genio 350-evk board

2024-02-27 Thread Mark Brown
On Mon, Feb 26, 2024 at 03:01:38PM +0100, Alexandre Mergnat wrote: > This serie aim to add the following audio support for the Genio 350-evk: > - Playback > - 2ch Headset Jack (Earphone) > - 1ch Line-out Jack (Speaker) > - 8ch HDMI Tx > - Capture > - 1ch DMIC (On-board Digital Microphone) >

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-02-26 Thread Mark Brown
On Mon, Feb 26, 2024 at 03:01:50PM +0100, amerg...@baylibre.com wrote: > index ..13e95c227114 > --- /dev/null > +++ b/sound/soc/codecs/mt6357.c > @@ -0,0 +1,1805 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * MT6357 ALSA SoC audio codec driver > + * Please use a C++ comment for

Re: (subset) [PATCH v2 00/33] spi: get rid of some legacy macros

2024-02-12 Thread Mark Brown
On Mon, 22 Jan 2024 19:06:55 +0100, Uwe Kleine-König wrote: > this is v2 of this patch set. > > Changes since (implicit) v1, sent with Message-Id: > cover.1705348269.git.u.kleine-koe...@pengutronix.de: > > - Rebase to v6.8-rc1 > - Fix a build failure on sh > - Added the tags received in (impli

Re: [PATCH v3 00/32] spi: get rid of some legacy macros

2024-02-08 Thread Mark Brown
On Wed, 07 Feb 2024 19:40:14 +0100, Uwe Kleine-König wrote: > Changes since v2 > (https://lore.kernel.org/linux-spi/cover.1705944943.git.u.kleine-koe...@pengutronix.de): > > - Drop patch "mtd: rawnand: fsl_elbc: Let .probe retry if local bus is >missing" which doesn't belong into this series.

Re: [PATCH v2 00/33] spi: get rid of some legacy macros

2024-01-24 Thread Mark Brown
On Wed, Jan 24, 2024 at 09:13:49AM -0800, Greg Kroah-Hartman wrote: > On Mon, Jan 22, 2024 at 07:06:55PM +0100, Uwe Kleine-König wrote: > > Note that Jonathan Cameron has already applied patch 3 to his tree, it > > didn't appear in a public tree though yet. I still included it here to > > make the

Re: [PATCH v2 00/33] spi: get rid of some legacy macros

2024-01-22 Thread Mark Brown
On Mon, Jan 22, 2024 at 07:06:55PM +0100, Uwe Kleine-König wrote: > Note that Jonathan Cameron has already applied patch 3 to his tree, it > didn't appear in a public tree though yet. I still included it here to > make the kernel build bots happy. It's also going to be needed for buildability of

Re: [PATCH 00/33] spi: get rid of some legacy macros

2024-01-16 Thread Mark Brown
On Mon, Jan 15, 2024 at 09:12:46PM +0100, Uwe Kleine-König wrote: > In commit 8caab75fd2c2 ("spi: Generalize SPI "master" to "controller"") > some functions were renamed. Further some compat defines were introduced > to map the old names to the new ones. > Patch #18 and #19 touch the same driver,

Re: [PATCH v8 1/6] pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()

2023-12-12 Thread Mark Brown
come, an alternative would be to split the patch. > > Missing Acks so far: > > - Jean Delvare / Guenter Roeck for drivers/hwmon/pwm-fan.c > > - Javier Martinez Canillas for drivers/gpu/drm/solomon/ssd130x.c > > - Liam Girdwood / Mark Brown for drivers/regulator/pwm-

Re: [PATCH RESEND v2 1/3] drm/encoder: register per-encoder debugfs dir

2023-12-05 Thread Mark Brown
On Sun, Dec 03, 2023 at 02:53:13PM +0300, Dmitry Baryshkov wrote: > Each of connectors and CRTCs used by the DRM device provides debugfs > directory, which is used by several standard debugfs files and can > further be extended by the driver. Add such generic debugfs directories > for encoder. To

Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes

2023-11-24 Thread Mark Brown
On Wed, Nov 08, 2023 at 01:58:36PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The VDSO functions are defined as globals in the kernel sources but intended > to be called from userspace, so there is no need to declare them in a kernel > side header. This is in -next as commit 42874e4eb

Re: [PATCH 11/17] ASoC: dt-bindings: samsung-i2s: add specific compatibles for existing SoC

2023-11-08 Thread Mark Brown
gt; Documentation/devicetree/bindings/writing-bindings.rst state that: Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH] drm/bridge: adv7511: Convert to use maple tree register cache

2023-10-01 Thread Mark Brown
On Sat, Sep 30, 2023 at 12:38:17AM +0300, Laurent Pinchart wrote: > Out of curiosity, is this part of an effort to drop the rbtree cache ? Probably, yes - there's probably some drivers where it will make sense. signature.asc Description: PGP signature

[PATCH] drm/bridge: sn65dsi83: Convert to use maple tree register cache

2023-10-01 Thread Mark Brown
The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2

[PATCH] drm/bridge: lt9211: Convert to use maple tree register cache

2023-10-01 Thread Mark Brown
The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- drivers/gpu/drm/bridge/lontium-lt9211.c | 2

[PATCH 2/2] drm/panel: ili9322: Convert to use maple tree register cache

2023-10-01 Thread Mark Brown
The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- drivers/gpu/drm/panel/panel-ilitek-ili9322.c

[PATCH 0/2] drm/panel: ili9322: Minor regmap improvements

2023-10-01 Thread Mark Brown
These two patches provide some minor improvements to the ili9322 regmap API usage. Signed-off-by: Mark Brown --- Mark Brown (2): drm/panel: ili9322: Remove redundant volatle_reg() operation drm/panel: ili9322: Convert to use maple tree register cache drivers/gpu/drm/panel/panel

[PATCH 1/2] drm/panel: ili9322: Remove redundant volatle_reg() operation

2023-10-01 Thread Mark Brown
The ili9322 driver has a volatile_reg() operation in it's regmap which always returns false. This is redundant since it is the default in the regmap core, remove the operation for a trivial code size and performance improvement. Signed-off-by: Mark Brown --- drivers/gpu/drm/panel/panel-i

[PATCH] drm/bridge: icn6211: Convert to use maple tree register cache

2023-09-30 Thread Mark Brown
The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- drivers/gpu/drm/bridge/chipone-icn6211.c | 2

[PATCH] drm/bridge: tc358767: Convert to use maple tree register cache

2023-09-30 Thread Mark Brown
The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- drivers/gpu/drm/bridge/tc358767.c | 2 +- 1

[PATCH] drm/rockchip: vop2: Convert to use maple tree register cache

2023-09-30 Thread Mark Brown
The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c

[PATCH] drm/bridge: dpc3433: Convert to use maple tree register cache

2023-09-30 Thread Mark Brown
The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- drivers/gpu/drm/bridge/ti-dlpc3433.c | 2

[PATCH] drm/bridge: adv7511: Convert to use maple tree register cache

2023-09-29 Thread Mark Brown
The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c

Re: (subset) [PATCH 00/31] Fix and improve Rockchip RK3128 support

2023-09-26 Thread Mark Brown
On Tue, 29 Aug 2023 19:16:16 +0200, Alex Bee wrote: > this series fixes some issues I found when testing my "new" RK3128 board > with the mainline kernel and adds some core functionality like SMP bringup, > usb and networking. > > The propably most distinctive change is the split up of the DTs for

Re: [PATCH] spi: tegra: Fix missing IRQ check in tegra_slink_probe()

2023-09-12 Thread Mark Brown
On Sat, 26 Aug 2023 18:02:54 +0800, Zhang Shurong wrote: > This func misses checking for platform_get_irq()'s call and may passes the > negative error codes to request_irq(), which takes unsigned IRQ #, > causing it to fail with -EINVAL, overriding an original error code. > > Fix this by stop call

Re: (subset) [PATCH 00/11] add missing of_node_put

2023-09-11 Thread Mark Brown
On Thu, 07 Sep 2023 11:55:10 +0200, Julia Lawall wrote: > Add of_node_put on a break out of an of_node loop. > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [10/11] ASoC: rsnd: add missing of_node_put commit: 28115b1c4f2bb76e786436bf65

Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device()

2023-08-18 Thread Mark Brown
On Fri, Aug 18, 2023 at 06:32:28PM -0300, Jason Gunthorpe wrote: > It turns out several drivers are calling of_dma_configure() outside the > expected bus_type.dma_configure op. This ends up being mis-locked and > triggers a lockdep assertion, or instance: Acked-by: Mark Brown sign

Re: [v3 2/3] ASoC: mediatek: mt8186: correct the HDMI widgets

2023-08-03 Thread Mark Brown
On Thu, Aug 03, 2023 at 07:20:15AM +, Jiaxin Yu (俞家鑫) wrote: > I agree with you, in fact the speaker is indeed doing this way. But > about the hdmi that on the board, I did not find a defination link > snd_soc_dapm_hdmi, so I use snd_soc_dapm_line to replace. The purpose > is to control it lin

Re: [v3 2/3] ASoC: mediatek: mt8186: correct the HDMI widgets

2023-08-02 Thread Mark Brown
On Wed, Aug 02, 2023 at 02:52:57PM +, Jiaxin Yu (俞家鑫) wrote: > On Mon, 2023-07-31 at 12:50 +0100, Mark Brown wrote: > > On Mon, Jul 31, 2023 at 02:08:02AM +0800, Jiaxin Yu wrote: > > > Use SND_SOC_DAPM_LINE instead of SND_SOC_DAPM_OUTPUT to trigger > > > DAP

Re: [v3 2/3] ASoC: mediatek: mt8186: correct the HDMI widgets

2023-07-31 Thread Mark Brown
On Mon, Jul 31, 2023 at 02:08:02AM +0800, Jiaxin Yu wrote: > Use SND_SOC_DAPM_LINE instead of SND_SOC_DAPM_OUTPUT to trigger > DAPM events to hdmi-codec when userspace control the DPAM pin. Why? signature.asc Description: PGP signature

Re: (subset) [PATCH v3 0/4] Qualcomm REFGEN regulator

2023-07-12 Thread Mark Brown
On Mon, 03 Jul 2023 20:15:53 +0200, Konrad Dybcio wrote: > Recent Qualcomm SoCs have a REFGEN (reference voltage generator) regulator > responsible for providing a reference voltage to some on-SoC IPs (like DSI > or PHYs). It can be turned off when unused to save power. > > This series introduces

Re: [PATCH v3 0/4] Qualcomm REFGEN regulator

2023-07-03 Thread Mark Brown
On Mon, Jul 03, 2023 at 08:15:53PM +0200, Konrad Dybcio wrote: > Recent Qualcomm SoCs have a REFGEN (reference voltage generator) regulator > responsible for providing a reference voltage to some on-SoC IPs (like DSI > or PHYs). It can be turned off when unused to save power. > > This series intr

Re: [PATCH v2 2/4] regulator: Introduce Qualcomm REFGEN regulator driver

2023-06-30 Thread Mark Brown
On Thu, Jun 29, 2023 at 10:44:34PM +0200, Konrad Dybcio wrote: > On 29.06.2023 22:35, Konrad Dybcio wrote: > > Modern Qualcomm SoCs have a REFGEN (reference voltage generator) > > regulator, providing reference voltage to on-chip IP, like PHYs. > > > > Add a driver to support toggling that regulat

Re: [PATCH 2/4] regulator: Introduce Qualcomm REFGEN regulator driver

2023-06-28 Thread Mark Brown
On Wed, Jun 28, 2023 at 06:29:46PM +0200, Konrad Dybcio wrote: > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2017, 2019-2020, The Linux Foundation. All rights reserved. > + * Copyright (c) 2023, Linaro Limited > + */ Please use a C++ comment for the whole thing for consist

Re: linux-next: manual merge of the drm-misc tree with the mm-stable tree

2023-04-18 Thread Mark Brown
On Sun, Apr 16, 2023 at 09:58:50AM +0200, Daniel Vetter wrote: > Note there was a ppc compile fail, which is why we pushed the ttm revert. > That /should/ be fixed now, but would be good if you can confirm? According to Nathan (CCed) there's still issues with the interaction with the PowerPC tree

Re: linux-next: manual merge of the drm tree with the powerpc tree

2023-04-18 Thread Mark Brown
On Tue, Apr 18, 2023 at 11:21:45AM -0700, Nathan Chancellor wrote: > On Fri, Apr 14, 2023 at 05:55:10PM +0100, Mark Brown wrote: > > Done. > Thanks a lot, sorry for not saying it sooner! It looks like this > regressed in next-20230417 and next-20230418 though. Someone sent a m

Re: linux-next: manual merge of the drm-misc tree with the mm-stable tree

2023-04-17 Thread Mark Brown
On Sun, Apr 16, 2023 at 09:58:50AM +0200, Daniel Vetter wrote: > Note there was a ppc compile fail, which is why we pushed the ttm revert. > That /should/ be fixed now, but would be good if you can confirm? I don't have any PowerPC toolchains set up - I guess one of the community builders might h

Re: linux-next: manual merge of the drm tree with the powerpc tree

2023-04-14 Thread Mark Brown
On Thu, Apr 13, 2023 at 11:47:25AM -0700, Nathan Chancellor wrote: > On Wed, Apr 12, 2023 at 11:22:13AM +1000, Stephen Rothwell wrote: > select SND_HDA_COMPONENT if SND_HDA_CORE > # !CC_IS_CLANG: https://github.com/ClangBuiltLinux/linux/issues/1752 > - select DRM_AMD_DC_DCN if (X86

Re: [PATCH v3 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook

2023-04-05 Thread Mark Brown
On Wed, Apr 05, 2023 at 05:17:21PM +0200, Maxime Ripard wrote: > On Tue, Apr 04, 2023 at 04:26:18PM +0100, Mark Brown wrote: > > To be honest it's surprising that we'd have to manually specify this, I > > would expect to be able to reparent. I suspect it'd be bette

Re: [PATCH v3 64/65] ASoC: tlv320aic32x4: div: Switch to determine_rate

2023-04-05 Thread Mark Brown
On Tue, Apr 04, 2023 at 12:11:54PM +0200, Maxime Ripard wrote: > The driver does implement round_rate() though, which means that we can > change the rate of the clock, but we will never get to change the > parent. > However, It's hard to tell whether it's been done on purpose or not. > Since we'

Re: [PATCH v3 63/65] ASoC: tlv320aic32x4: pll: Switch to determine_rate

2023-04-05 Thread Mark Brown
On Tue, Apr 04, 2023 at 12:11:53PM +0200, Maxime Ripard wrote: > The driver does implement round_rate() though, which means that we can > change the rate of the clock, but we will never get to change the > parent. > However, It's hard to tell whether it's been done on purpose or not. > Since we'

Re: [PATCH v3 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook

2023-04-04 Thread Mark Brown
On Tue, Apr 04, 2023 at 12:11:33PM +0200, Maxime Ripard wrote: > The tlv320aic32x4 clkin clock implements a mux with a set_parent hook, > but doesn't provide a determine_rate implementation. > This is a bit odd, since set_parent() is there to, as its name implies, > change the parent of a clock. H

Re: [PATCH v3] ASoC: dt-bindings: maxim,max98371: Convert to DT schema

2023-04-03 Thread Mark Brown
On Sat, 01 Apr 2023 15:19:29 -0300, André Morishita wrote: > Convert the Maxim Integrated MAX98371 audio codec bindings to DT schema. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: dt-bindings: maxim,max98371: Convert to DT sch

Re: stable-rc/linux-5.10.y bisection: baseline.login on hp-x360-14-G1-sona

2023-03-21 Thread Mark Brown
On Tue, Mar 21, 2023 at 05:18:03AM -0700, KernelCI bot wrote: The KernelCI bisection bot found a boot bisection on one of the HP ChromeBooks in v5.10.175 triggered by b5005605013d ("drm/i915: Don't use BAR mappings for ring buffers with LLC"). The system appears to die very early in boot with no

  1   2   3   4   5   6   7   8   9   >