Reviewed-by: Jyri Sarha
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 2021-03-18 23:47, Dario Binacchi wrote:
Il 17/03/2021 09:19 Tomi Valkeinen ha scritto:
On 14/03/2021 17:13, Dario Binacchi wrote:
> As reported by TI spruh73x RM, the LCD pixel clock (LCD_PCLK) frequency
> is obtained by dividing LCD_CLK, the LCD controller reference clock,
> for CLKDIV:
>
,
I think this looks good now.
Reviewed-by: Jyri Sarha
For the series.
I'll wait a day or two if Tomi has something more to say and merge this
to drm-misc-next.
Best regards,
Jyri
Changes in v2:
- The patch has been added in version 2.
- Rename clk_div_rate to real_pclk_rate.
- Provide
On 2021-03-03 11:04, Yang Li wrote:
./drivers/gpu/drm/tilcdc/tilcdc_panel.c:402:3-8: No need to set .owner
here. The core will do it.
Remove .owner field if calls are used which set it automatically
Reported-by: Abaci Robot
Signed-off-by: Yang Li
Reviewed-by: Jyri Sarha
I'll merge
Thanks,
Reviewed-by: Jyri Sarha
for the series.
I'll merge these later today.
Best regards,
Jyri
On 2021-03-22 23:33, Dario Binacchi wrote:
The series was born from a patch to fix the LCD pixel clock setting.
Two additional patches have been added to this. One renames a
misleading
var
On 2021-02-09 5:09, quanyang.wang wrote:
Ping.
Could you resend the original patch (I have not received it) so I can
easily test and merge it?
I'll find some time to do it soon.
Best regards,
Jyri
On 1/29/21 3:58 PM, Tomi Valkeinen wrote:
Dropped the @ti.com addresses and added the new
mit")
Signed-off-by: Quanyang Wang
Reviewed-by: Jyri Sarha
Tested-by: Jyri Sarha
Thanks a lot! I think I have bumbed into this once or twice, but latelu
I have had time to look into this. I'll merge this to drm-misc-next
soon.
Best regards,
Jyri
---
drivers/gpu/drm/tilcdc/tilcdc
On 2021-02-08 4:32, Tian Tao wrote:
The code has been in a irq-disabled context since it is hard IRQ. There
is no necessity to do it again.
Signed-off-by: Tian Tao
Reviewed-by: Jyri Sarha
Tested-by: Jyri Sarha
I merge to this drm-misc-next soon.
Best regards,
Jyri
---
drivers/gpu/drm
On 2021-02-16 22:22, Dario Binacchi wrote:
The fdd property of the tilcdc_panel_info structure must set the reqdly
bit field (bit 12 to 19) of the raster control register. The previous
statement set the least significant bit instead.
Signed-off-by: Dario Binacchi
Reviewed-by: Jyri Sarha
e drivers")
Signed-off-by: Xiaomeng Tong
Thanks for the patch. Good catch.
Reviewed-by: Jyri Sarha
Tested-by: Jyri Sarha
I'll apply this to drm-misc-next in couple of days.
Best regards,
Jyri
---
drivers/gpu/drm/tilcdc/tilcdc_external.c | 8 +---
1 file changed, 5 insertions
flush_workqueue(E);
destroy_workqueue(E);
Signed-off-by: Christophe JAILLET
For tilcdc
Acked-by: Jyri Sarha
Thanks,
Jyri
---
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 1 -
drivers/gpu/drm/msm/dsi/dsi_host.c| 1 -
drivers/gpu/drm/msm/edp/edp_ctrl.c| 1 -
drivers/gpu/drm/msm/h
On 2021-10-26 3:00, Stephen Boyd wrote:
Use an aggregate driver instead of component ops so that we can get
proper driver probe ordering of the aggregate device with respect to
all
the component devices that make up the aggregate device.
Cc: Jyri Sarha
Cc: Tomi Valkeinen
Cc: Daniel Vetter
On 2020-12-16 9:59, Tomi Valkeinen wrote:
Update the maintainer email addresses for TI display drivers.
Signed-off-by: Tomi Valkeinen
Acked-by: Jyri Sarha
---
MAINTAINERS | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index
Please fix the bellow error and I will review and merge this. But in
future, please at least compile test you changes with relevant
configurations or alldefconfig before sending them to upstream!
Best regards,
Jyri
On 2021-12-15 22:35, kernel test robot wrote:
Hi Xiang,
Thank you for the pat
On 2021-12-16 11:44, Joe Perches wrote:
On Thu, 2021-12-16 at 17:26 +0800, Xiang wangx wrote:
struct of_device_id should normally be const.
[]
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
[]
@@ -60,7 +60,7 @@ void tilcdc_module_cleanup(struct tilcdc_m
On 2021-12-16 11:55, Xiang wangx wrote:
struct of_device_id should normally be const.
Signed-off-by: Xiang wangx
Reviewed-by: Jyri Sarha
Thanks,
Jyri
---
Changes since v1
* add const in line 63
Changes since v2
* removed line 63
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 +---
1 file
be available if it was set-up.
But only a few DRM drivers currently check for nomodeset, make this
driver
to also support the command line parameter.
Signed-off-by: Javier Martinez Canillas
Acked-by: Jyri Sarha
---
(no changes since v1)
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 3 +++
1
ch.
The first patch changes tda998x pdata, so if there are any out of tree
users of tda998x-driver the out of tree code needs to be updated.
Jyri Sarha (3):
drm/i2c: tda998x: Improve tda998x_configure_audio() audio related
pdata
drm/i2c: tda998x: Register ASoC hdmi-codec and add audio D
Define struct tda998x_audio_params in include/drm/i2c/tda998x.h and
use it in pdata and for tda998x_configure_audio() parameters. Also
updates tda998x_write_aif() to take struct hdmi_audio_infoframe *
directly as a parameter.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/i2c/tda998x_drv.c | 77
Add HDMI audio support. Adds mcasp0_pins, clk_mcasp0_fixed,
clk_mcasp0, mcasp0, sound node, and updates the tda19988 node to
follow the new binding.
Signed-off-by: Jyri Sarha
---
arch/arm/boot/dts/am335x-boneblack.dts | 71 --
1 file changed, 67 insertions(+), 4
[2]. There may still be some
identical lines left from the original patch and some of the ideas
have come from there.
[1] Documentation/devicetree/bindings/display/bridge/tda998x.txt
[2] http://mailman.alsa-project.org/pipermail/alsa-devel/2015-July/095255.html
Signed-off-by: Jyri Sarha
---
On 08/04/16 16:31, Russell King - ARM Linux wrote:
> On Tue, Aug 02, 2016 at 03:05:07PM +0300, Jyri Sarha wrote:
>> @@ -787,19 +792,13 @@ tda998x_configure_audio(struct tda998x_priv *priv,
>> reg_clear(priv, REG_AIP_CNTRL_0, AIP_CNTRL_0_RST_CTS);
>>
>>
On 08/04/16 17:07, Russell King - ARM Linux wrote:
> On Tue, Aug 02, 2016 at 03:05:08PM +0300, Jyri Sarha wrote:
>> +memcpy(audio.status, params->iec.status,
>> + min(sizeof(audio.status), sizeof(params->iec.status)));
>
> As mentioned in the other patch
On 08/06/16 01:19, Russell King - ARM Linux wrote:
>> > It'll pick up that as the DT device to hang things off which I'd expect
>> > to be the desired outcome given that this is a very similar situation to
>> > the MFD situation. I've not been following the full thread so there is
>> > probably co
Define struct tda998x_audio_params in include/drm/i2c/tda998x.h and
use it in pdata and for tda998x_configure_audio() parameters. Also
updates tda998x_write_aif() to take struct hdmi_audio_infoframe *
directly as a parameter.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/i2c/tda998x_drv.c | 84
Add HDMI audio support. Adds mcasp0_pins, clk_mcasp0_fixed,
clk_mcasp0, mcasp0, sound node, and updates the tda19988 node to
follow the new binding.
Signed-off-by: Jyri Sarha
---
arch/arm/boot/dts/am335x-boneblack.dts | 71 --
1 file changed, 67 insertions(+), 4
[2]. There may still be some
identical lines left from the original patch and some of the ideas
have come from there.
[1] Documentation/devicetree/bindings/display/bridge/tda998x.txt
[2] http://mailman.alsa-project.org/pipermail/alsa-devel/2015-July/095255.html
Signed-off-by: Jyri Sarha
---
ers from ASoC thread
- "dts/am335x-boneblack: SQUASH"
- Use corrected macros from dt-bindings/display/tda998x.h
[1] https://lists.freedesktop.org/archives/dri-devel/2016-August/114491.html
Jyri Sarha (3):
drm/i2c: tda998x: Improve tda998x_configure_audio() audio related
pdata
drm/i2
)
Jyri Sarha (29):
drm/tilcdc: Restore old dpms state in pm_resume()
drm/tilcdc: Move LCDC_SYNC_LOST handling inside if (ver == 2)
statement
drm/tilcdc: Write to LCDC_END_OF_INT_IND_REG at the end of IRQ
function
drm/tilcdc: Move waiting of LCDC_FRAME_DONE IRQ into
On 08/15/16 11:16, Teresa Remmet wrote:
> In function tilcdc_get_external_components the check for
> the remote port parent is not correct. We need a '||' instead of
> an '&&'.
>
> Signed-off-by: Teresa Remmet
> ---
> There has been send out a different version of this patch about a year ago.
> B
rature.tsp?baseLiteratureNumber=sprz360
Jyri Sarha (4):
drm/tilcdc: Remove drm_helper_disable_unused_functions() call
drm/tilcdc: Add blue-and-red-wiring -device tree property
drm/tilcdc: Choose console BPP that supports RGB
ARM: dts: am335x-boneblack: Convert BGR from LCDC to RGB in tda19988
.../devicetre
drm_helper_disable_unused_functions() should not be called by atomic
drivers.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 3404d24..e45c268
not found.
For more details see section 3.1.1 in AM335x Silicon Errata:
http://www.ti.com/general/docs/lit/getliterature.tsp?baseLiteratureNumber=sprz360
Signed-off-by: Jyri Sarha
---
.../devicetree/bindings/display/tilcdc/tilcdc.txt | 12 ++
drivers/gpu/drm/tilcdc/tilcdc_drv.c
but RGB formats, so we must choose such bytes per
pixel value that supports RGB.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 13 -
drivers/gpu/drm/tilcdc/tilcdc_drv.h | 1 -
drivers/gpu/drm/tilcdc/tilcdc_external.c | 7 +++
drivers/gpu/drm/tilcdc
u want to get 16 RGB mode (and 24 BGR mode), set tda19988
video-ports -property to 0x230145 and tilcdc blue-and-red-wiring
-property to "straight".
Signed-off-by: Jyri Sarha
---
arch/arm/boot/dts/am335x-boneblack.dts | 11 +++
1 file changed, 11 insertions(+)
diff --
On 08/18/16 22:17, Rob Herring wrote:
> On Tue, Aug 16, 2016 at 12:24:28PM +0300, Jyri Sarha wrote:
>> Add "blue-and-red-wiring"-device tree property and update devicetree
>> binding document. The red and blue components are reversed between 24
>> and 16 bit modes
The sii902x chip family supports also HDMI audio. Add binding for
describing the necessary i2s and mclk wiring for it.
Signed-off-by: Jyri Sarha
Reviewed-by: Rob Herring
---
.../bindings/display/bridge/sii902x.txt | 40 +++
1 file changed, 40 insertions(+)
diff --git a
Remove trailing white space from sii902x display bridge binding.
Signed-off-by: Jyri Sarha
Reviewed-by: Laurent Pinchart
Reviewed-by: Rob Herring
---
Documentation/devicetree/bindings/display/bridge/sii902x.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation
;Reviewed-by: Rob Herring "
Ther previous round:
https://patchwork.kernel.org/cover/10919173/
Jyri Sarha (5):
drm/bridge: sii902x: Set output mode to HDMI or DVI according to EDID
drm/bridge: sii902x: pixel clock unit is 10kHz instead of 1kHz
dt-bindings: display: sii902x: Remove trai
From: Tomi Valkeinen
The driver always sets InputBusFmt:EDGE to 0 (falling edge).
Add drm_bridge_timings's input_bus_flags to reflect that the bridge
samples on falling edges.
Signed-off-by: Tomi Valkeinen
Signed-off-by: Jyri Sarha
Reviewed-by: Andrzej Hajda
Reviewed-by: Laurent Pin
Set output mode to HDMI or DVI according to EDID HDMI signature.
Signed-off-by: Jyri Sarha
Reviewed-by: Andrzej Hajda
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/bridge/sii902x.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu
The pixel clock unit in the first two registers (0x00 and 0x01) of
sii9022 is 10kHz, not 1kHz as in struct drm_display_mode. Division by
10 fixes the issue.
Signed-off-by: Jyri Sarha
Reviewed-by: Andrzej Hajda
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/bridge/sii902x.c | 5 +++--
1
Implement HDMI audio support by using ASoC HDMI codec. The commit
implements the necessary callbacks and configuration for the HDMI
codec and registers a virtual platform device for the codec to attach.
Signed-off-by: Jyri Sarha
Reviewed-by: Andrzej Hajda
---
drivers/gpu/drm/bridge/sii902x.c
On 06/04/2019 09:06, Rob Herring wrote:
> On Tue, Apr 02, 2019 at 10:29:14AM +0300, Jyri Sarha wrote:
>> The sii902x chip family supports also HDMI audio. Add binding for
>> describing the necessary i2s and mclk wiring for it.
>>
>> Signed-off-by: Jyri Sarha
>> --
On 12/04/2019 11:52, Andrzej Hajda wrote:
> On 22.03.2019 09:06, Jyri Sarha wrote:
>> Implement HDMI audio support by using ASoC HDMI codec. The commit
>> implements the necessary callbacks and configuration for the HDMI
>> codec and registers a virtual platform device fo
On 12/04/2019 15:30, Andrzej Hajda wrote:
+static const unsigned int sii902x_mclk_div_table[] = {
+ 128, 256, 384, 512, 768, 1024, 1152, 192 };
+
+static int sii902x_select_mclk_div(u8 *i2s_config_reg, unsigned int rate,
+ unsigned int mclk)
>>>
From: Tomi Valkeinen
The driver always sets InputBusFmt:EDGE to 0 (falling edge).
Add drm_bridge_timings's input_bus_flags to reflect that the bridge
samples on falling edges.
Signed-off-by: Tomi Valkeinen
Signed-off-by: Jyri Sarha
Reviewed-by: Andrzej Hajda
Reviewed-by: Laurent Pin
Set output mode to HDMI or DVI according to EDID HDMI signature.
Signed-off-by: Jyri Sarha
Reviewed-by: Andrzej Hajda
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/bridge/sii902x.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu
The sii902x chip family supports also HDMI audio. Add binding for
describing the necessary i2s and mclk wiring for it.
Signed-off-by: Jyri Sarha
---
.../bindings/display/bridge/sii902x.txt | 41 +++
1 file changed, 41 insertions(+)
diff --git a/Documentation/devicetree
Remove trailing white space from sii902x display bridge binding.
Signed-off-by: Jyri Sarha
Reviewed-by: Laurent Pinchart
Reviewed-by: Rob Herring
---
Documentation/devicetree/bindings/display/bridge/sii902x.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation
x_select_mclk_div()
- Disable regmap locking since the driver specific locking should be enough
- Add missing mutex locking to the register access in the irq handler
The previous round:
https://patchwork.kernel.org/cover/10881169/
Jyri Sarha (5):
drm/bridge: sii902x: Set output mode to HDMI or D
The pixel clock unit in the first two registers (0x00 and 0x01) of
sii9022 is 10kHz, not 1kHz as in struct drm_display_mode. Division by
10 fixes the issue.
Signed-off-by: Jyri Sarha
Reviewed-by: Andrzej Hajda
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/bridge/sii902x.c | 5 +++--
1
Implement HDMI audio support by using ASoC HDMI codec. The commit
implements the necessary callbacks and configuration for the HDMI
codec and registers a virtual platform device for the codec to attach.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/bridge/sii902x.c | 469
Register cpufreq notifier after we have initialized the crtc and
unregister it before we remove the ctrc. Receiving a cpufreq notify
without crtc causes a crash.
Reported-by: Peter Ujfalusi
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 34 ++---
1
Jyri Sarha (1):
drm/tilcdc: Register cpufreq notifier after we have initialized crtc
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
--
Texas Instruments Finland
On 22/02/2019 18:40, Russell King - ARM Linux admin wrote:
> On Fri, Feb 22, 2019 at 03:27:43PM +, Russell King - ARM Linux admin
> wrote:
>> On Fri, Feb 22, 2019 at 05:20:15PM +0200, Peter Ujfalusi wrote:
>>> Hi Russell,
>>>
>>> On 22/02/2019 16.35, Russell King - ARM Linux admin wrote:
any effect on the actual
functionality.
Jyri Sarha (3):
drm/bridge: sii902x: Set output mode to HDMI or DVI according to EDID
drm/bridge: sii902x: Implement HDMI audio support
drm/bridge: sii902x: pixel clock unit is 10kHz instead of 1kHz
Tomi Valkeinen (1):
drm/bridge: sii902x: add
From: Tomi Valkeinen
The driver always sets InputBusFmt:EDGE to 0 (falling edge).
Add drm_bridge_timings's input_bus_flags to reflect that the bridge
samples on falling edges.
Signed-off-by: Tomi Valkeinen
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/bridge/sii902x.c | 7 +++
1
Implement HDMI audio support by using ASoC HDMI codec. The commit
implements the necessary callbacks and configuration for the HDMI
codec and registers a virtual platform device for the codec to attach.
Signed-off-by: Jyri Sarha
---
.../bindings/display/bridge/sii902x.txt | 24 +
drivers
The pixel clock unit in the first two registers (0x00 and 0x01) of
sii9022 is 10kHz, not 1kHz as in struct drm_display_mode. Division by
10 fixes the issue.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/bridge/sii902x.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a
Set output mode to HDMI or DVI according to EDID HDMI signature.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/bridge/sii902x.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
index 1afa000141d5..0e21fa419d27
tified formats work on BBB (McASP does not support right
justified format). With the above conditions:
Reviewed-by: Jyri Sarha
Tested-by: Jyri Sarha
> ---
> drivers/gpu/drm/i2c/tda998x_drv.c | 57
> ++-
> include/drm/i2c/tda998x.h |
ratio of BCLK to the sample rate. Implement support for this.
>
> Signed-off-by: Russell King
Works at least on Beaglebone-black.
Tested-by: Jyri Sarha
Reviewed-by: Jyri Sarha
> ---
> drivers/gpu/drm/i2c/tda998x_drv.c | 20 +---
> include/drm/i2c/td
On 25/02/2019 15:57, Andrzej Hajda wrote:
> On 25.02.2019 12:23, Jyri Sarha wrote:
>> Implement HDMI audio support by using ASoC HDMI codec. The commit
>> implements the necessary callbacks and configuration for the HDMI
>> codec and registers a virtual platform device fo
The pixel clock unit in the first two registers (0x00 and 0x01) of
sii9022 is 10kHz, not 1kHz as in struct drm_display_mode. Division by
10 fixes the issue.
Signed-off-by: Jyri Sarha
Reviewed-by: Andrzej Hajda
---
drivers/gpu/drm/bridge/sii902x.c | 5 +++--
1 file changed, 3 insertions(+), 2
"drm/bridge/sii902x: Fix EDID readback"-commit added a dependency to
I2C_MUX, but not indicate it in the Kconfig entry. Fix it by selecting
I2C_MUX for DRM_SII902X config option.
Fixes: 88664675239 ("drm/bridge/sii902x: Fix EDID readback")
Signed-off-by: Jyri Sarha
---
dr
Implement HDMI audio support by using ASoC HDMI codec. The commit
implements the necessary callbacks and configuration for the HDMI
codec and registers a virtual platform device for the codec to attach.
Signed-off-by: Jyri Sarha
---
.../bindings/display/bridge/sii902x.txt | 36
From: Tomi Valkeinen
The driver always sets InputBusFmt:EDGE to 0 (falling edge).
Add drm_bridge_timings's input_bus_flags to reflect that the bridge
samples on falling edges.
Signed-off-by: Tomi Valkeinen
Signed-off-by: Jyri Sarha
Reviewed-by: Andrzej Hajda
---
drivers/gpu/drm/b
Set output mode to HDMI or DVI according to EDID HDMI signature.
Signed-off-by: Jyri Sarha
Reviewed-by: Andrzej Hajda
---
drivers/gpu/drm/bridge/sii902x.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
index
-enable = <1 1 1 1>;
audio-i2s-pin-to-fifo = <0 1 2 3>;
Meaning that all fifos are enabled and SD0 is routed to fifo 0, SD1
to fifo 1, etc. I am not sure if the channel swap functionality
should show in dts binding.
Jyri Sarha (4):
drm/bridge: sii902x: Set output mode to
Earlier there were no mode_valid() helper for crtc and tilcdc had a
hack to over come this limitation. But now the mode_valid() helper is
there (has been since v4.13), so it is about time to get rid of that
hack.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 28
Jyri Sarha (2):
drm/tilcdc: Check drm_fb_cma_get_gem_obj() return value
drm/tilcdc: Remove obsolete crtc_mode_valid() hack
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 30
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 1 -
drivers/gpu/drm/tilcdc/tilcdc_drv.h | 2 -
drivers/gpu/drm
drm_fb_cma_get_gem_obj() may return NULL. The return value needs to be
checked before dereferencing the returned pointer.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
b/drivers/gpu
On 04/03/2019 14:52, Laurent Pinchart wrote:
> Hi Jyri,
>
> Thank you for the patch.
> On Wed, Feb 27, 2019 at 11:54:20PM +0200, Jyri Sarha wrote:
>> Set output mode to HDMI or DVI according to EDID HDMI signature.
>>
>> Signed-off-by: Jyri Sarha
>> Reviewed-b
On 04/03/2019 14:42, Laurent Pinchart wrote:
> Hi Jyri,
>
> On Wed, Feb 27, 2019 at 11:54:18PM +0200, Jyri Sarha wrote:
>> Changes since first version:
>> - Moved reviewed patches to front:
>> - drm/bridge: sii902x: add input_bus_flags
>> - drm/bridge: sii902
On 05/03/2019 17:43, Laurent Pinchart wrote:
> Hi Jyri,
>
> Thank you for the patch.
>
> On Thu, Feb 28, 2019 at 01:18:50PM +0200, Jyri Sarha wrote:
>> drm_fb_cma_get_gem_obj() may return NULL. The return value needs to be
>> checked before dereferencing the returned p
From: Tomi Valkeinen
The driver always sets InputBusFmt:EDGE to 0 (falling edge).
Add drm_bridge_timings's input_bus_flags to reflect that the bridge
samples on falling edges.
Signed-off-by: Tomi Valkeinen
Signed-off-by: Jyri Sarha
Reviewed-by: Andrzej Hajda
---
drivers/gpu/drm/b
Set output mode to HDMI or DVI according to EDID HDMI signature.
Signed-off-by: Jyri Sarha
Reviewed-by: Andrzej Hajda
---
drivers/gpu/drm/bridge/sii902x.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
index
Remove trailing white space from sii902x display bridge binding.
Signed-off-by: Jyri Sarha
---
Documentation/devicetree/bindings/display/bridge/sii902x.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/sii902x.txt
b
instead of 1kHz
The previous review round can be found here:
https://patchwork.kernel.org/cover/10832351/
Jyri Sarha (5):
drm/bridge: sii902x: Set output mode to HDMI or DVI according to EDID
drm/bridge: sii902x: pixel clock unit is 10kHz instead of 1kHz
dt-bindings: display: sii902x: Remove
The pixel clock unit in the first two registers (0x00 and 0x01) of
sii9022 is 10kHz, not 1kHz as in struct drm_display_mode. Division by
10 fixes the issue.
Signed-off-by: Jyri Sarha
Reviewed-by: Andrzej Hajda
---
drivers/gpu/drm/bridge/sii902x.c | 5 +++--
1 file changed, 3 insertions(+), 2
Implement HDMI audio support by using ASoC HDMI codec. The commit
implements the necessary callbacks and configuration for the HDMI
codec and registers a virtual platform device for the codec to attach.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/bridge/sii902x.c | 455
The sii902x chip family supports also HDMI audio. Add binding for
describing the necessary i2s and mclk wiring for it.
Signed-off-by: Jyri Sarha
---
.../bindings/display/bridge/sii902x.txt | 34 +++
include/dt-bindings/sound/sii902x-audio.h | 17 ++
2 files
;
- Improve indentation and add:
Reviewed-by: Laurent Pinchart
Jyri Sarha (2):
drm/tilcdc: Check drm_fb_cma_get_gem_obj() return value
drm/tilcdc: Remove obsolete crtc_mode_valid() hack
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 30
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 1
Earlier there were no mode_valid() helper for crtc and tilcdc had a
hack to over come this limitation. But now the mode_valid() helper is
there (has been since v4.13), so it is about time to get rid of that
hack.
Signed-off-by: Jyri Sarha
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm
with WARN.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
index 1067e702c22c..bc9f859f45dc 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
On 05/03/2019 21:21, Laurent Pinchart wrote:
> Hi Jyri,
>
> Thank you for the patch.
>
> On Thu, Feb 28, 2019 at 01:18:51PM +0200, Jyri Sarha wrote:
>> Earlier there were no mode_valid() helper for crtc and tilcdc had a
>> hack to over come this limitation. But now
On 13/03/2019 18:47, Laurent Pinchart wrote:
> Hello again,
>
> On Wed, Mar 13, 2019 at 06:29:19PM +0200, Laurent Pinchart wrote:
>> On Wed, Mar 13, 2019 at 06:01:07PM +0200, Jyri Sarha wrote:
>>> The sii902x chip family supports also HDMI audio. Add binding for
>>
On 13/03/2019 20:12, Laurent Pinchart wrote:
> Hi Jyri,
>
> On Wed, Mar 13, 2019 at 07:52:08PM +0200, Jyri Sarha wrote:
>> On 13/03/2019 18:47, Laurent Pinchart wrote:
>>> On Wed, Mar 13, 2019 at 06:29:19PM +0200, Laurent Pinchart wrote:
>>>> On Wed, Mar 13,
: ("Unsigned compared against 0")
> Fixes: ff5781634c41 ("drm/bridge: sii902x: Implement HDMI audio support")
> Signed-off-by: Colin Ian King
Oh, one of these slipped trough after all.
Acked-by: Jyri Sarha
> ---
> drivers/gpu/drm/bridge/sii902x.c | 2 +-
>
On 02/07/2019 18:47, Olivier Moysan wrote:
> Add devm_clk_get call to retrieve reference to master clock.
>
> Fixes: ff5781634c41 ("drm/bridge: sii902x: Implement HDMI audio support")
>
> Signed-off-by: Olivier Moysan
Reviewed-by: Jyri Sarha
I wonder how that lin
Olivier Moysan
Looking the specs again it looks like the mclk is requred for sii9020,
but not for sii9022 and sii9024.
So I guess it is fine to accept the configurations without the mclk.
Reviewed-by: Jyri Sarha
> ---
> Documentation/devicetree/bindings/display/bridge/sii902x.txt | 5 ++-
y: Olivier Moysan
Reviewed-by: Jyri Sarha
> ---
> drivers/gpu/drm/bridge/sii902x.c | 39 +++
> 1 file changed, 23 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/sii902x.c
> b/drivers/gpu/drm/bridge/sii902x.c
> ind
The sii902x chip family supports also HDMI audio. Add binding for
describing the necessary i2s and mclk wiring for it.
Signed-off-by: Jyri Sarha
---
.../bindings/display/bridge/sii902x.txt | 33 +++
1 file changed, 33 insertions(+)
diff --git a/Documentation/devicetree
From: Tomi Valkeinen
The driver always sets InputBusFmt:EDGE to 0 (falling edge).
Add drm_bridge_timings's input_bus_flags to reflect that the bridge
samples on falling edges.
Signed-off-by: Tomi Valkeinen
Signed-off-by: Jyri Sarha
Reviewed-by: Andrzej Hajda
Reviewed-by: Laurent Pin
x27;s reviewed-by to applicable patches
The already reviewed patches are in front. Not reviewed still:
- "dt-bindings: display: sii902x: Add HDMI audio bindings"
- "drm/bridge: sii902x: Implement HDMI audio support"
The previous round:
https://patchwork.kernel.org/project/dri-devel
Implement HDMI audio support by using ASoC HDMI codec. The commit
implements the necessary callbacks and configuration for the HDMI
codec and registers a virtual platform device for the codec to attach.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/bridge/sii902x.c | 460
Set output mode to HDMI or DVI according to EDID HDMI signature.
Signed-off-by: Jyri Sarha
Reviewed-by: Andrzej Hajda
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/bridge/sii902x.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu
Remove trailing white space from sii902x display bridge binding.
Signed-off-by: Jyri Sarha
Reviewed-by: Laurent Pinchart
---
Documentation/devicetree/bindings/display/bridge/sii902x.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings
The pixel clock unit in the first two registers (0x00 and 0x01) of
sii9022 is 10kHz, not 1kHz as in struct drm_display_mode. Division by
10 fixes the issue.
Signed-off-by: Jyri Sarha
Reviewed-by: Andrzej Hajda
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/bridge/sii902x.c | 5 +++--
1
1 - 100 of 1292 matches
Mail list logo
