On Thu, Jul 3, 2014 at 5:33 PM, Sachin Kamat
wrote:
> From: Sachin Kamat
>
> Makes the code a bit more readable.
>
> Signed-off-by: Sachin Kamat
> Signed-off-by: Sachin Kamat
> Acked-by: Laurent Pinchart
> ---
> drivers/gpu/drm/drm_gem_cma_helper.c |2 +-
>
e order of registration.
drivers/gpu/drm/exynos/exynos_drm_drv.c:768:1: warning: label
?err_unregister_pd? defined but not used [-Wunused-label]
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_drv.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/
On Wed, Jun 18, 2014 at 10:53 AM, Inki Dae wrote:
> On 2014? 06? 17? 20:38, Sachin Kamat wrote:
>> 'exynos_drm_pdev' was not getting unregistered if platform_driver_register()
>> failed. Fix the ordering to allow this. This also fixes the below warning by
>> movin
Hi Vikas,
On 1 August 2013 16:49, Vikas Sajjan wrote:
> While trying to get boot-logo up on exynos5420 SMDK which has eDP panel
> connected with resolution 2560x1600, following error occured even with
> IOMMU enabled:
> [0.88] [drm:lowlevel_buffer_allocate] *ERROR* failed to allocate buffer.
Hi Vikas,
On 2 August 2013 09:23, Vikas Sajjan wrote:
> Hi Tomasz,
>
>
> On 2 August 2013 04:50, Tomasz Figa wrote:
>>
>> Hi Vikas,
>>
>> On Thursday 01 of August 2013 16:49:32 Vikas Sajjan wrote:
>> > While trying to get boot-logo up on exynos5420 SMDK which has eDP panel
>> > connected with re
Hi Vikas,
On 6 August 2013 10:53, Vikas Sajjan wrote:
> While trying to get boot-logo up on exynos5420 SMDK which has eDP panel
> connected with resolution 2560x1600, following error occured even with
> IOMMU enabled:
> [0.88] [drm:lowlevel_buffer_allocate] *ERROR* failed to allocate buffer.
ion fails
> and if IOMMU is supported.
>
> Signed-off-by: Vikas Sajjan
> Signed-off-by: Arun Kumar
> Reviewed-by: Rob Clark
> ---
> changes since v3:
> - addressed nits pointed out by Sylwester Nawrocki
>
> and Sachin Kamat .
>
> change
Hi Chanho,
On 9 August 2013 13:10, Chanho Park wrote:
> This patch describes each nodes of rotator and specifies a example how to bind
> it.
>
> Signed-off-by: Chanho Park
> Cc: Thomas Abraham
> Cc: Kukjin Kim
> Cc: Inki Dae
> Signed-off-by: Kyungmin Park
> ---
> .../devicetree/bindings/gpu
Hi Chanho,
On 9 August 2013 13:10, Chanho Park wrote:
> The exynos4 platform is only dt-based since 3.10, we should convert driver
> data
> and ids to dt-based parsing methods. The rotator driver has a limit table to
> get
> size limit of input picture. Each SoCs has slightly different limit va
kfree handles null pointers. Hence this check is not necessary.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_buf.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_buf.c
b/drivers/gpu/drm/exynos/exynos_drm_buf.c
index b8ac06d
Add of.h explicitly for of_* APIs.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_ddc.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_fimc.c |1 +
drivers/gpu/drm/exynos/exynos_drm_fimd.c |1 +
drivers/gpu/drm/exynos/exynos_hdmi.c |1 +
drivers/gpu/drm/exynos
kzalloc already has built-in error messages. Hence remove
additional ones.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_buf.c |4 +---
drivers/gpu/drm/exynos/exynos_drm_connector.c |4 +---
drivers/gpu/drm/exynos/exynos_drm_crtc.c |4 +---
drivers/gpu
devm_kzalloc can fail. Hence check the pointer to avoid NULL pointer
dereferencing.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_iommu.c |9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_iommu.c
b/drivers/gpu/drm/exynos
Since commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT
for EXYNOS SoCs"), Exynos platform is DT only. Hence remove
all the conditional macros and make the driver DT only.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 54 +++
Since commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT
for EXYNOS SoCs"), Exynos platform is DT only. Hence remove
all the conditional macros and make the driver DT only.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_ddc.c | 11 +--
1 file changed, 1
Since commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT
for EXYNOS SoCs"), Exynos platform is DT only. Hence remove
all the conditional macros and make the driver DT only.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_hdmiphy.c | 11 +--
1 file
Since commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT
for EXYNOS SoCs"), Exynos platform is DT only. Hence remove
all the conditional macros and make the driver DT only.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c |4 +---
1 file changed, 1
Since commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT
for EXYNOS SoCs"), Exynos platform is DT only. Hence remove
all the conditional macros and make the driver DT only.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 70 ++-
Exynos is a DT-only platform. Add this info to Kconfig.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/Kconfig |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig
index 772c62a..80a251a 100644
--- a
Hi Tomasz,
On 22 August 2013 13:57, Tomasz Figa wrote:
> Hi Sachin,
>
> On Thursday 22 of August 2013 11:15:23 Sachin Kamat wrote:
>> Exynos is a DT-only platform. Add this info to Kconfig.
>>
>> Signed-off-by: Sachin Kamat
>> ---
>> drivers/gpu/dr
set is conflicted.
>
> Thanks,
> Inki Dae
>
>> -Original Message-
>> From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
>> Sent: Thursday, August 22, 2013 2:45 PM
>> To: dri-devel@lists.freedesktop.org
>> Cc: inki@samsung.com; jy0922.s...@samsung.c
Exynos is a DT-only platform. Add this info to Kconfig.
Signed-off-by: Sachin Kamat
---
Rebased this series on the latest Inki Dae's tree.
---
drivers/gpu/drm/exynos/Kconfig |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/Kconfig b/driver
Since commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT
for EXYNOS SoCs"), Exynos platform is DT only. Hence remove
all the conditional macros and make the driver DT only.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_ddc.c | 11 +--
1 file changed, 1
Since commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT
for EXYNOS SoCs"), Exynos platform is DT only. Hence remove
all the conditional macros and make the driver DT only.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c |4 +---
1 file changed, 1
Since commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT
for EXYNOS SoCs"), Exynos platform is DT only. Hence remove
all the conditional macros and make the driver DT only.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_hdmiphy.c | 11 +--
1 file
Since commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT
for EXYNOS SoCs"), Exynos platform is DT only. Hence remove
all the conditional macros and make the driver DT only.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 70 ++-
Since commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT
for EXYNOS SoCs"), Exynos platform is DT only. Hence remove
all the conditional macros and make the driver DT only.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 74 +--
with videomode"):
drivers/built-in.o: In function `exynos_drm_connector_get_modes':
drivers/gpu/drm/exynos/exynos_drm_connector.c:86:
undefined reference to `drm_display_mode_from_videomode'
Signed-off-by: Sachin Kamat
Cc: Andrzej Hajda
---
drivers/gpu/drm/exynos/Kconfig |2 +
Now that DRM_EXYNOS depends on OF, we do not need individual
drivers to depend on it.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/Kconfig |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig
index
: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_buf.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_buf.c
b/drivers/gpu/drm/exynos/exynos_drm_buf.c
index 3445a0f..d20a7af 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_buf.c
+++ b/drivers
*
drivers/gpu/drm/exynos/exynos_drm_fbdev.c:107:48: warning:
incorrect type in assignment (different address spaces)
drivers/gpu/drm/exynos/exynos_drm_fbdev.c:107:48:
expected void [noderef] *kvaddr
drivers/gpu/drm/exynos/exynos_drm_fbdev.c:107:48:got void *
Signed-off-by: Sachin Kamat
---
drivers
Hi Andrzej ,
I was testing the latest Linux kernel release (v3.12-rc1) on
Exynos4210 based Origen board.
I found a display regression with that. I do not get any display on
the LCD (other than backlight) with the latest kernel. Git bisect
pointed me to the following commit:
111e6055d4e0d35c6a4b6cd
Fixed a trivial typo.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index 868a14d..5d5b97d 100644
--- a/drivers
her properties with assumption of default
> 60Hz refresh rate.
>
> It could work before because of_get_fb_videomode calculated refresh rate
> from display-timings and with clock 5, the result was 0(due to
> rounding down in some division),
> so fimd assumed he should use
Hi,
On 18 September 2013 14:01, Andrzej Hajda wrote:
> Hi,
>
> You can just set this property to zero.
> of_parse_display_timing will not complain and
> you will have default settings.
Yes, that works fine. Thanks.
--
With warm regards,
Sachin
___
dr
Hi Rahul,
On 22 May 2014 10:46, Rahul Sharma wrote:
> From: Rahul Sharma
>
> Fimd probe is accessing fimd Registers without enabling the fimd
> gate clocks. If FIMD clocks are kept disabled in Uboot or disbaled
> during kernel boottime, the system hangs during boottime.
>
> This issue got surfac
Hi Rahul,
On 22 May 2014 19:41, Rahul Sharma wrote:
> Fimd probe is accessing fimd Registers without enabling the fimd
> gate clocks. If FIMD clocks are kept disabled in Uboot or disbaled
> during kernel boottime, the system hangs during boottime.
>
> This issue got surfaced when verifying with s
Silences the following warning:
WARNING: space prohibited before semicolon
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_dp_reg.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_dp_reg.c
b/drivers/gpu/drm/exynos
i2c.h was included twice.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_hdmi.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exynos_hdmi.c
index ed6176e..d3f9684 100644
--- a/drivers/gpu/drm/exynos
These symbols are local to this file.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_hdmi.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exynos_hdmi.c
index d3f9684..220f048 100644
gt; - if (IS_ERR(exynos_gem_obj))
> + if (IS_ERR(exynos_gem_obj)) {
> + dev_warn(dev->dev, "FB allocation failed.\n");
> return PTR_ERR(exynos_gem_obj);
> + }
>
> ret = exynos_drm_gem_handle_create(&exynos_gem_obj->base, file_priv,
> &args->handle);
> --
> 1.7.9.5
Otherwise looks good.
Reviewed-by: Sachin Kamat
--
With warm regards,
Sachin
On 22 May 2014 12:06, Rahul Sharma wrote:
> On 22 May 2014 11:51, Sachin Kamat wrote:
>> Hi Rahul,
> [snip]
>>>
>>> + clk_prepare_enable(ctx->bus_clk);
>>
>> Probably a check for its success?
>>
>>> + clk_prepare_enable(c
Hi Rahul,
On 22 May 2014 19:46, Rahul Sharma wrote:
> Hi Inki,
>
> This is another one which has not got reviewed. Please review.
Inki has applied a similar patch from Takashi [1].
[1] https://lkml.org/lkml/2014/5/9/24
--
With warm regards,
Sachin
exynos_dpi_of_find_panel_node is local to this file.
Signed-off-by: Sachin Kamat
---
These patches are based on Inki Dae's tree (exynos-drm-next branch).
---
drivers/gpu/drm/exynos/exynos_drm_dpi.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/e
On 23 May 2014 16:28, Andrzej Hajda wrote:
> The patch removes dependency on !ARCH_MULTIPLATFORM.
> This dependency seems to be not longer valid.
>
> Signed-off-by: Andrzej Hajda
Reviewed-by: Sachin Kamat
--
With warm regards,
Sachin
Hi Andrzej,
On 23 May 2014 13:17, Andrzej Hajda wrote:
> Hi Sachin,
>
> On 05/22/2014 07:02 AM, Sachin Kamat wrote:
>> i2c.h was included twice.
>>
>> Signed-off-by: Sachin Kamat
>> ---
>> drivers/gpu/drm/exynos/exynos_hdmi.c |1 -
>> 1 f
Hi Andrzej,
On 23 May 2014 16:27, Andrzej Hajda wrote:
> The patch fixes unlocking in exynos_drm_component_del.
This patch actually removes multiple unlocking issue.
>
> Signed-off-by: Andrzej Hajda
> ---
> Hi Inki,
>
> This patch is based on exynos_drm_next branch.
>
> Regards
> Andrzej
> ---
Makes the code a bit more readable.
Signed-off-by: Sachin Kamat
Cc: Laurent Pinchart
---
drivers/gpu/drm/drm_gem_cma_helper.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c
b/drivers/gpu/drm/drm_gem_cma_helper.c
index 05c97c5350a1
PTR_ERR_OR_ZERO simplifies the code.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_dp_core.c |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c
b/drivers/gpu/drm/exynos/exynos_dp_core.c
index ff63901..8b67f41
kfree handles null pointers. Hence this check is not necessary.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_buf.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_buf.c
b/drivers/gpu/drm/exynos/exynos_drm_buf.c
index b8ac06d
Add of.h explicitly for of_* APIs.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_ddc.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_fimc.c |1 +
drivers/gpu/drm/exynos/exynos_drm_fimd.c |1 +
drivers/gpu/drm/exynos/exynos_hdmi.c |1 +
drivers/gpu/drm/exynos
kzalloc already has built-in error messages. Hence remove
additional ones.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_buf.c |4 +---
drivers/gpu/drm/exynos/exynos_drm_connector.c |4 +---
drivers/gpu/drm/exynos/exynos_drm_crtc.c |4 +---
drivers/gpu
devm_kzalloc can fail. Hence check the pointer to avoid NULL pointer
dereferencing.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_iommu.c |9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_iommu.c
b/drivers/gpu/drm/exynos
Since commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT
for EXYNOS SoCs"), Exynos platform is DT only. Hence remove
all the conditional macros and make the driver DT only.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 54 +++
Since commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT
for EXYNOS SoCs"), Exynos platform is DT only. Hence remove
all the conditional macros and make the driver DT only.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_ddc.c | 11 +--
1 file changed, 1
Since commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT
for EXYNOS SoCs"), Exynos platform is DT only. Hence remove
all the conditional macros and make the driver DT only.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_hdmiphy.c | 11 +--
1 file
Since commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT
for EXYNOS SoCs"), Exynos platform is DT only. Hence remove
all the conditional macros and make the driver DT only.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c |4 +---
1 file changed, 1
Since commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT
for EXYNOS SoCs"), Exynos platform is DT only. Hence remove
all the conditional macros and make the driver DT only.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 70 ++-
Exynos is a DT-only platform. Add this info to Kconfig.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/Kconfig |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig
index 772c62a..80a251a 100644
--- a
Hi Tomasz,
On 22 August 2013 13:57, Tomasz Figa wrote:
> Hi Sachin,
>
> On Thursday 22 of August 2013 11:15:23 Sachin Kamat wrote:
>> Exynos is a DT-only platform. Add this info to Kconfig.
>>
>> Signed-off-by: Sachin Kamat
>> ---
>> drivers/gpu/dr
set is conflicted.
>
> Thanks,
> Inki Dae
>
>> -Original Message-
>> From: Sachin Kamat [mailto:sachin.kamat at linaro.org]
>> Sent: Thursday, August 22, 2013 2:45 PM
>> To: dri-devel at lists.freedesktop.org
>> Cc: inki.dae at samsung.com; jy0922.shim at sa
Since commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT
for EXYNOS SoCs"), Exynos platform is DT only. Hence remove
all the conditional macros and make the driver DT only.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_hdmiphy.c | 11 +--
1 file
Since commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT
for EXYNOS SoCs"), Exynos platform is DT only. Hence remove
all the conditional macros and make the driver DT only.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c |4 +---
1 file changed, 1
Since commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT
for EXYNOS SoCs"), Exynos platform is DT only. Hence remove
all the conditional macros and make the driver DT only.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 70 ++-
Exynos is a DT-only platform. Add this info to Kconfig.
Signed-off-by: Sachin Kamat
---
Rebased this series on the latest Inki Dae's tree.
---
drivers/gpu/drm/exynos/Kconfig |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/Kconfig b/driver
Since commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT
for EXYNOS SoCs"), Exynos platform is DT only. Hence remove
all the conditional macros and make the driver DT only.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_ddc.c | 11 +--
1 file changed, 1
Since commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT
for EXYNOS SoCs"), Exynos platform is DT only. Hence remove
all the conditional macros and make the driver DT only.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 74 +--
Hi Dave,
Please ignore this patch.
On 19 November 2012 15:14, Sachin Kamat wrote:
> kfree() on a NULL input is a no-op. Hence remove the check.
>
> Signed-off-by: Sachin Kamat
> ---
> This series is build tested on the latest linux-next (20121115).
> ---
> drivers/gpu/
On 21 November 2012 20:42, Sachin Kamat wrote:
> Hi Dave,
>
> Please ignore this patch.
>
>
Please ignore this mail. Sorry for the noise.
--
With warm regards,
Sachin
Hi Inki,
On 19 November 2012 15:32, Sachin Kamat wrote:
> On 19 November 2012 15:30, Inki Dae wrote:
>>
>>
>>> -Original Message-
>>> From: Sachin Kamat [mailto:sachin.kamat at linaro.org]
>>> Sent: Monday, November 19, 2012 6:5
[snip]
>> >> And NULL pointer checking was already done above like below,
>> >> if (overlay_ops && overlay_ops->disable)
>> >> overlay_ops->disable(manager->dev, zpos);
>> > Correct. But that check is applicable only for that one statement
>> > (overlay_ops->disable(manager-
devm_clk_get is device managed and makes error handling and exit code
simpler.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_mixer.c | 20 +---
1 files changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c
b/drivers/gpu
First 4 patches use devm_* APIs for simpler code and cleanup.
Last one fixes a potential bug.
Series is build tested and based on the exynos-drm-next branch of the
following tree:
git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git
Sachin Kamat (5):
drm/exynos: Use
devm_clk_get is device managed and makes error handling and exit code
simpler.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c |9 ++---
1 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
b/drivers/gpu/drm
devm_gpio_request is device managed and makes error handling and exit code
simpler.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_hdmi.c |8 ++--
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos
devm_clk_get is device managed and makes error handling and exit code
simpler.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
b/drivers/gpu/drm/exynos
Pointer was being dereferenced after freeing.
Fixes the following error:
drivers/gpu/drm/exynos/exynos_drm_g2d.c:323 g2d_userptr_put_dma_addr() error:
dereferencing freed memory 'g2d_userptr'
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c |2 +-
1 files
On 23 November 2012 12:10, Inki Dae wrote:
>
>
>> -Original Message-----
>> From: Sachin Kamat [mailto:sachin.kamat at linaro.org]
>> Sent: Friday, November 23, 2012 12:42 PM
>> To: dri-devel at lists.freedesktop.org
>> Cc: inki.dae at samsung.com; jy
On 23 November 2012 12:21, Inki Dae wrote:
[snip]
> With cleanup to hdmi_resources_init, we can remove hdmi_resource_cleanup
> function. So could you please re-send updated patches?
OK. I will update and re-send.
>
> You've been submitting patches into too small pieces.
> Because they are trivi
devm_clk_get is device managed and makes error handling and exit code
simpler.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_mixer.c | 59 +
1 files changed, 16 insertions(+), 43 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c
devm_* functions are device managed and make error handling and exit code
simpler.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 60 +++--
1 files changed, 13 insertions(+), 47 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
devm_clk_get is device managed and makes error handling and exit code
simpler.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 31 ++---
1 files changed, 7 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
; you send another one? Sorry for inconvenient. :)
He he.. no problem.. i will send another patch which just contains
removing clk_disable.
>
> Thanks,
> Inki Dae
>
>> -----Original Message-
>> From: Sachin Kamat [mailto:sachin.kamat at linaro.org]
>> Sent: F
Also fixes an error related to returning 'ret' without initialising
with error code.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 22 +-
1 files changed, 5 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_
Ok. Mailed you the combined patch.
On 24 November 2012 11:10, Inki Dae wrote:
>
>
>> -Original Message-----
>> From: Sachin Kamat [mailto:sachin.kamat at linaro.org]
>> Sent: Friday, November 23, 2012 7:06 PM
>> To: dri-devel at lists.freedesktop.org
devm_clk_get is device managed and makes error handling and exit code
simpler.
Also fixes an error related to returning 'ret' without initialising
with error code.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 31 ++---
1 files
ping
On 20 November 2012 11:23, Sachin Kamat wrote:
> nouveau_ttm.h was included twice.
>
> Signed-off-by: Sachin Kamat
> ---
> drivers/gpu/drm/nouveau/nouveau_drm.c |2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/no
ping..
On 20 November 2012 11:35, Sachin Kamat wrote:
> core/device.h was included twice.
>
> Signed-off-by: Sachin Kamat
> ---
> drivers/gpu/drm/nouveau/core/subdev/device/base.c |1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu
On 27 November 2012 09:09, Ben Skeggs wrote:
> On Tue, 2012-11-27 at 09:04 +0530, Sachin Kamat wrote:
>> ping
>>
>> On 20 November 2012 11:23, Sachin Kamat wrote:
>> > nouveau_ttm.h was included twice.
> I've queued it in my tree, thanks!
Thanks Ben. There
This series fixes some checkpatch warnings and errors in drm_fb_helper.c file.
Build tested using the linux-next tree of 20121114.
Sachin Kamat (3):
drm/fb_helper: Fix checkpatch errors
drm/fb_helper: Convert printk to pr_* and dev_*
drm/drm_fb_helper: Remove unnecessary braces
drivers
DIGITAL: s = "ON - dig"; break;
ERROR: trailing statements should be on next line
101: FILE: gpu/drm/drm_fb_helper.c:101:
case DRM_FORCE_ON: s = "ON"; break;
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/drm_fb_helper.c | 12 +---
1 files changed, 9 inser
Converted printks to pr_* and dev_* to silence checkpatch warnings.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/drm_fb_helper.c | 14 --
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index
Remove unnecessary braces to silence the following type of
checkpatch warnings:
WARNING: braces {} are not necessary for single statement blocks
WARNING: braces {} are not necessary for any arm of this statement
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/drm_fb_helper.c | 23
static?
drivers/gpu/drm/udl/udl_connector.c:106:35: warning:
symbol 'udl_connector_helper_funcs' was not declared. Should it be static?
drivers/gpu/drm/udl/udl_connector.c:112:28: warning:
symbol 'udl_connector_funcs' was not declared. Should it be static?
Signed-off-by
Fixes the following sparse warning:
drivers/gpu/drm/exynos/exynos_drm_fimd.c:65:25: warning:
symbol 'exynos4_fimd_driver_data' was not declared. Should it be static?
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c |2 +-
1 files changed, 1 insertions(+), 1
Fixes the following sparse warning:
drivers/gpu/drm/exynos/exynos_drm_fimd.c:69:25: warning:
symbol 'exynos5_fimd_driver_data' was not declared. Should it be static?
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c |2 +-
1 files changed, 1 insertions(+), 1
Check overlay_ops is not NULL as checked in the previous 'if' condition.
Fixes the following smatch error:
drivers/gpu/drm/exynos/exynos_drm_encoder.c:509
exynos_drm_encoder_plane_disable()
error: we previously assumed 'overlay_ops' could be null (see line 499)
Signed-
kfree() on a NULL input is a no-op. Hence remove the check.
Signed-off-by: Sachin Kamat
---
This series is build tested on the latest linux-next (20121115).
---
drivers/gpu/drm/drm_crtc.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc.c b
error: potential null dereference 'connector->edid_blob_ptr'.
(drm_property_create_blob returns null)
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/drm_crtc.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_c
rs/gpu/drm/drm_fb_helper.c:1272 drm_setup_crtcs() error:
potential null dereference 'crtcs'. (kcalloc returns null)
Signed-off-by: Sachin Kamat
---
Dependent on the following patch series:
http://comments.gmane.org/gmane.comp.video.dri.devel/76605
---
drivers/gpu/drm/drm_fb_helper.c |
1 - 100 of 395 matches
Mail list logo
