, possibly even more, as opposed to a single load from
a variant struct).
I would stay with the way used in s3c-fb driver, using variant structs
describing FIMD revisions.
Best regards,
Tomasz Figa
Best regards,
Jingoo Han
CC'ed Marek.
To Leela Krishna Amudala,
Don't add
, because of NULL driver_data.
P.S. I think you should CC linux-arm-kernel and linux-samsung-soc lists
when submitting patches related to ARM and Samsung SoCs.
Best regards,
--
Tomasz Figa
Samsung Poland RD Center
___
dri-devel mailing list
dri-devel
and s6e8ax0
LCD driver to use the v2 RFC of Common Display Framework. I have most of
the work done, I have just to solve several remaining problems.
Best regards,
--
Tomasz Figa
Samsung Poland RD Center
SW Solution Development, Linux Platform
___
dri-devel
Hi Laurent,
On Monday 24 of December 2012 15:12:28 Laurent Pinchart wrote:
Hi Tomasz,
On Friday 21 December 2012 11:00:52 Tomasz Figa wrote:
On Tuesday 18 of December 2012 08:31:30 Vikas Sajjan wrote:
On 17 December 2012 20:55, Laurent Pinchart wrote:
Hi Vikas,
Sorry
with the discussion about bus-less design.
Best regards,
--
Tomasz Figa
Samsung Poland RD Center
SW Solution Development, Linux Platform
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
used at
the moment and if frame done status monitoring will be ever needed, I
think a better way should be implemented.
Best regards,
--
Tomasz Figa
Samsung Poland RD Center
SW Solution Development, Linux Platform
___
dri-devel mailing list
dri-devel
On Tuesday 08 of January 2013 11:12:26 Marcus Lorentzon wrote:
On 01/08/2013 09:18 AM, Laurent Pinchart wrote:
On Thursday 27 December 2012 15:43:34 Tomasz Figa wrote:
On Monday 24 of December 2012 15:12:28 Laurent Pinchart wrote:
On Friday 21 December 2012 11:00:52 Tomasz Figa wrote
over entity state to userspace using
lcd device. However it can be used to demonstrate video source ops in use.
Feel free to comment as much as you can.
Tomasz Figa (4):
video: add display-core
video: add makefile kconfig
video: display: Add exynos-dsi video source driver
video: display
This patch adds new driver for DSI master block available in Samsung
Exynos SoCs. The driver is designed and written specifically for Common
Display Framework.
Signed-off-by: Tomasz Figa t.f...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/video/display/Kconfig
This patch adds Common Display Framework driver for Samsung s6e8ax0
MIPI DSI display panel.
Signed-off-by: Tomasz Figa t.f...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/video/display/Kconfig |3 +
drivers/video/display/Makefile|1
Hi Laurent,
On Saturday 02 of February 2013 11:39:59 Laurent Pinchart wrote:
Hi Tomasz,
Thank you for your RFC.
On Wednesday 30 January 2013 16:38:59 Tomasz Figa wrote:
Hi,
After pretty long time of trying to adapt Exynos-specific DSI display
support to Common Display Framework
On Thursday 07 of February 2013 15:04:30 Vikas Sajjan wrote:
Hi Figa,
On Wed, Jan 30, 2013 at 9:09 PM, Tomasz Figa t.f...@samsung.com wrote:
This patch adds Common Display Framework driver for Samsung s6e8ax0
MIPI DSI display panel.
Signed-off-by: Tomasz Figa t.f...@samsung.com
Hi,
On Monday 08 of April 2013 16:41:54 Viresh Kumar wrote:
On 8 April 2013 16:37, Vikas Sajjan vikas.saj...@linaro.org wrote:
While migrating to common clock framework (CCF), I found that the FIMD
clocks were pulled down by the CCF.
If CCF finds any clock(s) which has NOT been claimed by
On Sunday 21 of April 2013 13:23:10 Viresh Kumar wrote:
On 20 April 2013 20:56, Inki Dae inki@samsung.com wrote:
Sorry for being late. I think clk_prepare/unprepare are nothing to do
yet in case of Exynos but those might be used for in the future so
your patch looks good to me as is.
Hi Inki,
On Sunday 21 of April 2013 23:05:45 Inki Dae wrote:
2013/4/21 Tomasz Figa tomasz.f...@gmail.com
On Sunday 21 of April 2013 13:23:10 Viresh Kumar wrote:
On 20 April 2013 20:56, Inki Dae inki@samsung.com wrote:
Sorry for being late. I think clk_prepare/unprepare are nothing
Hi Inki,
On Sunday 21 of April 2013 22:36:08 Inki Dae wrote:
2013/4/21 Tomasz Figa tomasz.f...@gmail.com
Hi,
On Monday 08 of April 2013 16:41:54 Viresh Kumar wrote:
On 8 April 2013 16:37, Vikas Sajjan vikas.saj...@linaro.org wrote:
While migrating to common clock framework (CCF
, even though they are related to Samsung SoCs.
This patch adds pointers to linux-samsung-soc mailing list to affected
entries of MAINTAINERS file.
Signed-off-by: Tomasz Figa tomasz.f...@gmail.com
---
MAINTAINERS | 11 +++
1 file changed, 11 insertions(+)
diff --git a/MAINTAINERS b
On Sunday 21 of April 2013 22:36:08 Inki Dae wrote:
2013/4/21 Tomasz Figa tomasz.f...@gmail.com
Hi,
On Monday 08 of April 2013 16:41:54 Viresh Kumar wrote:
On 8 April 2013 16:37, Vikas Sajjan vikas.saj...@linaro.org wrote:
While migrating to common clock framework (CCF
On Monday 22 of April 2013 10:44:00 Viresh Kumar wrote:
On 21 April 2013 20:13, Tomasz Figa tomasz.f...@gmail.com wrote:
3) after those two changes, all that remains is to fix compliance with
Common Clock Framework, in other words:
s/clk_enable/clk_prepare_enable/
and
s
. This would mean that any user that from
some reasons don't want to use PM_RUNTIME, would not be able to use the driver
anymore.
Rafael, Kevin, do you have any opinion on this?
Best regards,
--
Tomasz Figa
Samsung Poland RD Center
SW Solution Development, Kernel and System Framework
On Monday 22 of April 2013 12:05:49 Sylwester Nawrocki wrote:
On 04/22/2013 11:56 AM, Tomasz Figa wrote:
On Monday 22 of April 2013 10:44:00 Viresh Kumar wrote:
On 21 April 2013 20:13, Tomasz Figa tomasz.f...@gmail.com wrote:
3) after those two changes, all that remains is to fix compliance
Hi Inki,
On Friday 26 of April 2013 14:03:10 Inki Dae wrote:
This patch fixes multiple definition error like below when building it
as moudle with device tree support.
drivers/gpu/drm/exynos/exynos_drm_g2d.o: In function `.LANCHOR1':
exynos_drm_g2d.c:(.rodata+0x6c): multiple definition of
On Friday 26 of April 2013 11:48:50 Sylwester Nawrocki wrote:
On 04/26/2013 10:20 AM, Inki Dae wrote:
Exactly right. it's my mistake. But now it seems that
__mode_of_device_table is multi defined at fimd and g2d side so there
still is module build error. :(
Since all drivers seem to be
Tree support:
Tested-by: Tomasz Figa tomasz.f...@gmail.com
Tomasz Figa (4):
drm/exynos: fimd: Hold pointer to driver data in context struct
drm/exynos: fimd: Add support for FIMD versions without SHADOWCON
register
drm/exynos: fimd: Add support for FIMD variants with clock selection
This patch adds pointer to driver data to fimd_context structure, to
remove the need to call drm_fimd_get_driver_data() each time access to
driver data is necessary.
Signed-off-by: Tomasz Figa tomasz.f...@gmail.com
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 5 +++--
1 file changed, 3
data.
Signed-off-by: Tomasz Figa tomasz.f...@gmail.com
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 69 +++-
1 file changed, 49 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index
, this patch sets the selection bitfield to use the special clock.
Signed-off-by: Tomasz Figa tomasz.f...@gmail.com
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
The FIMD block present on S3C6400/S3C6410 SoCs is compatible with this
driver, so it can be supported by it as well.
This patch adds appropriate device IDs and driver data to enable this
driver for S3C64xx SoCs.
Signed-off-by: Tomasz Figa tomasz.f...@gmail.com
---
drivers/gpu/drm/exynos
be retrieved, in addition to standard
video timings.
Signed-off-by: Tomasz Figa tomasz.f...@gmail.com
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
b/drivers/gpu/drm/exynos
Hi,
Recently I've been working a bit on a DRM driver for the GPU of Samsung
S3C6410 SoCs, which required me to familiarize a bit with exynos-drm, as
it already contains a KMS driver which is compatible with the SoC I'm
working with, making it a good place to put my driver in.
Reading through
Hi,
On Monday 13 of May 2013 20:24:01 Inki Dae wrote:
-Original Message-
From: Maarten Lankhorst [mailto:maarten.lankho...@canonical.com]
Sent: Monday, May 13, 2013 6:52 PM
To: Inki Dae
Cc: 'Rob Clark'; 'Daniel Vetter'; 'DRI mailing list'; linux-arm-
Hi,
On Wednesday 01 of May 2013 21:02:25 Tomasz Figa wrote:
Much of the code in Exynos DRM subsystem is generic enough to use
it for older (non-Exynos) Samsung SoCs as well, after minor
modifications.
This series starts adding support for previous SoCs to Exynos DRM by
introducing S3C64xx
Hi,
On Wednesday 01 of May 2013 22:00:25 Daniel Vetter wrote:
On Wed, May 01, 2013 at 09:06:09PM +0200, Tomasz Figa wrote:
This patch modifies the driver to perform two stage parsing of video
timings from device tree, to get timing information as struct
videomode, which contains more data
Hi Inki,
On Wednesday 22 of May 2013 15:37:14 Inki Dae wrote:
2013/5/22 Stéphane Marchesin stephane.marche...@gmail.com
On Tue, May 21, 2013 at 9:22 PM, Inki Dae inki@samsung.com
wrote:
2013/5/22 Stéphane Marchesin stephane.marche...@gmail.com
On Tue, May 21, 2013 at 1:08 AM,
On Wednesday 01 of May 2013 21:06:09 Tomasz Figa wrote:
This patch modifies the driver to perform two stage parsing of video
timings from device tree, to get timing information as struct videomode,
which contains more data than struct fb_videomode.
Thanks to this change, information about
On Sunday 19 of May 2013 13:26:57 Tomasz Figa wrote:
Hi,
On Wednesday 01 of May 2013 21:02:25 Tomasz Figa wrote:
Much of the code in Exynos DRM subsystem is generic enough to use
it for older (non-Exynos) Samsung SoCs as well, after minor
modifications.
This series starts adding
Hi Joonyoung,
On Thursday 06 of June 2013 13:30:49 Joonyoung Shim wrote:
On 05/19/2013 08:32 PM, Tomasz Figa wrote:
Hi,
On Wednesday 01 of May 2013 22:00:25 Daniel Vetter wrote:
On Wed, May 01, 2013 at 09:06:09PM +0200, Tomasz Figa wrote:
This patch modifies the driver to perform two
Hi Rahul,
On Tuesday 18 of June 2013 18:19:35 Rahul Sharma wrote:
This patch renames the combatible strings for hdmi, mixer, ddc
and hdmiphy. It follows the convention of using compatible string
which represent the SoC in which the IP was added for the first
time.
Signed-off-by: Rahul
@lists.freedesktop.org] On
Behalf Of Lucas Stach
Sent: Wednesday, June 19, 2013 4:59 PM
To: Tomasz Figa
Cc: kgene@samsung.com; devicetree-disc...@lists.ozlabs.org;
sw0312@samsung.com; jo...@samsung.com;
dri-devel@lists.freedesktop.org;
linux-samsung-...@vger.kernel.org
Hi Rahul,
On Thursday 20 of June 2013 07:41:53 Rahul Sharma wrote:
Hi Tomasz, Lucas,
How does this patch look to you ? Please share your views.
Looks fine now. Have my
Reviewed-by: Tomasz Figa t.f...@samsung.com
for the whole series.
Best regards,
Tomasz
regards,
Rahul Sharma
On Tuesday 02 of July 2013 16:04:49 Mark Brown wrote:
On Tue, Jul 02, 2013 at 09:21:32PM +0900, Inki Dae wrote:
Ensure that all externally accessed functions are correctly
prototyped
when defined in each file by making sure the headers with the
protoypes
are included in the file
Yongjun yongjun_...@trendmicro.com.cn
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Tomasz Figa t.f...@samsung.com
Best regards,
Tomasz
___
dri-devel mailing list
dri-devel
Hi,
On Sunday 14 of July 2013 00:09:55 Russell King - ARM Linux wrote:
On Sun, Jul 14, 2013 at 12:16:58AM +0200, Sylwester Nawrocki wrote:
On 07/13/2013 11:02 PM, Russell King - ARM Linux wrote:
On Sat, Jul 13, 2013 at 10:43:29PM +0200, Sylwester Nawrocki wrote:
I wasn't aware of it,
On Monday 22 of July 2013 16:00:22 Sylwester Nawrocki wrote:
On 07/22/2013 03:31 PM, Inki Dae wrote:
---Original Message-
From: linux-samsung-soc-ow...@vger.kernel.org
[mailto:linux-samsung-soc- ow...@vger.kernel.org] On Behalf Of
Lucas Stach
Sent: Monday, July 22, 2013 9:47
On Monday 22 of July 2013 15:49:25 Chanho Park wrote:
The exynos4 platform is only dt-based since 3.10, we should convert
driver data and ids to dt-based parsing methods. The rotator driver has
a limit table to get size limit. The minimum size of RGB888 format is 8
x 8 and maximum size is 8K x
Hi Vikas,
On Thursday 01 of August 2013 16:49:32 Vikas Sajjan wrote:
While trying to get boot-logo up on exynos5420 SMDK which has eDP panel
connected with resolution 2560x1600, following error occured even with
IOMMU enabled:
[0.88] [drm:lowlevel_buffer_allocate] *ERROR* failed to
Hi Vikas,
On Friday 02 of August 2013 12:08:52 Vikas Sajjan wrote:
Hi Rob,
On 2 August 2013 06:03, Rob Clark robdcl...@gmail.com wrote:
On Thu, Aug 1, 2013 at 7:20 PM, Tomasz Figa tomasz.f...@gmail.com
wrote:
Hi Vikas,
On Thursday 01 of August 2013 16:49:32 Vikas Sajjan wrote
.
Signed-off-by: Vikas Sajjan vikas.saj...@linaro.org
Signed-off-by: Arun Kumar arun...@samsung.com
---
changes since v1:
- Modified to add the fallback patch if CONTIG alloc fails as suggested
by Rob Clark robdcl...@gmail.com and Tomasz Figa
tomasz.f...@gmail.com.
- changed
Hi Chanho,
On Friday 09 of August 2013 16:40:49 Chanho Park wrote:
The exynos4 platform is only dt-based since 3.10, we should convert
driver data and ids to dt-based parsing methods. The rotator driver has
a limit table to get size limit of input picture. Each SoCs has slightly
different
On Friday 09 of August 2013 16:40:50 Chanho Park wrote:
This patch adds a rotator node for exynos4210. The exynos4210 has
different limitation of image size compared with later chips.
Signed-off-by: Chanho Park chanho61.p...@samsung.com
Cc: Thomas Abraham thomas.abra...@linaro.org
Cc:
Hi Chanho,
On Friday 09 of August 2013 16:40:53 Chanho Park wrote:
This patch describes each nodes of rotator and specifies a example how to
bind it.
Signed-off-by: Chanho Park chanho61.p...@samsung.com
Cc: Thomas Abraham thomas.abra...@linaro.org
Cc: Kukjin Kim kgene@samsung.com
Cc:
On Friday 09 of August 2013 10:38:30 Stephen Warren wrote:
On 08/09/2013 07:15 AM, Tomasz Figa wrote:
Hi Chanho,
On Friday 09 of August 2013 16:40:53 Chanho Park wrote:
This patch describes each nodes of rotator and specifies a example how
to bind it.
diff --git a/Documentation
Hi Shirish,
On Tuesday 13 of August 2013 12:39:27 Shirish S wrote:
For various revision of chipset if the signal pattern is changed for
every board, then the phy setting need to be updated correspondingly by
measuring the signal.
With the hdmiphy settings fixed in the driver the only way
a pixel format to a particular window layer
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 45
-- 1 files changed, 24 insertions(+), 21
deletions(-)
For the whole series:
Reviewed-by: Tomasz Figa t.f...@samsung.com
Best regards,
Tomasz
Hi Sachin,
On Thursday 22 of August 2013 11:15:23 Sachin Kamat wrote:
Exynos is a DT-only platform. Add this info to Kconfig.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/Kconfig |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
On Monday 30 of September 2013 00:08:46 Sylwester Nawrocki wrote:
On 09/28/2013 06:10 PM, Inki Dae wrote:
Any opinion from Device-Tree folks?
IMO, we should have same consensus on Shirish patches before
proceeding.
Rahul, it seems that DT people have no interest in this issue. So
Hi Sean,
On Thursday 10 of October 2013 20:30:13 Sean Paul wrote:
This patchset refactors parts of the exynos driver to move it closer to a
proper
drm driver (rather than just implementing a drm layer on top of the hardware
drivers). The hope is to get to a point where the dp/hdmi drivers
Hi Mark,
Thanks for reviving this series and sorry for not taking care of it
myself. Please see some comments inline.
On Tue, Feb 7, 2017 at 3:09 PM, Mark Yao <mark@rock-chips.com> wrote:
> From: Tomasz Figa <tf...@chromium.org>
>
> The API is not suitable for
Hi Mark,
On Tue, Feb 7, 2017 at 9:37 PM, Thierry Reding <thierry.red...@gmail.com> wrote:
> On Tue, Feb 07, 2017 at 04:39:33PM +0800, Mark Yao wrote:
>> From: Tomasz Figa <tf...@chromium.org>
>>
>> When converting the driver to use shmem-backed GEMs for IOMMU-ena
-lpthread is not always a valid flag to pull pthread support, especially
on Android it will fail to link due to a missing libpthread.so. The more
generic way to build-in pthread support is to use the -pthread CFLAG, so
let's use it instead.
Signed-off-by: Tomasz Figa <tf...@chromium.
Hi Zain,
On Mon, Feb 13, 2017 at 6:27 PM, zain wang wrote:
>
> The analogix_dp_transfer() will return -EBUSY if num_transferred is zero.
> But sometimes we will send a bare address packet to start the transaction,
> like drm_dp_i2c_xfer() show:
> ..
> /*
On Mon, Feb 20, 2017 at 1:04 PM, Zain Wang <w...@rock-chips.com> wrote:
> 在 2017/2/20 10:40, Tomasz Figa 写道:
>> On Mon, Feb 13, 2017 at 6:27 PM, zain wang <w...@rock-chips.com> wrote:
>>> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
>>
on for-next branch of Sean Paul's dogwood tree:
https://cgit.freedesktop.org/~seanpaul/dogwood/log/?h=for-next
git://people.freedesktop.org/~seanpaul/dogwood
Tomasz Figa (8):
drm/rockchip: Clear interrupt status bits before enabling
drm/rockchip: Get rid of some unnecessary code
drm/rockchip: Avoid
interrupt signalled, we have to clear the old bit before we
update the enable register.
Signed-off-by: Tomasz Figa
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers/gpu/drm/rockchip
unreferencing cursor framebuffers
asynchronously to the commit, which was what the helper expected.
Since both problems have been solved by previous patches, we can now
make the driver use the generic helper and remove custom waiting code.
Signed-off-by: Tomasz Figa
---
drivers/gpu/drm/rockchip
Current code implements prepare_fb and cleanup_fb callbacks only to
grab/release fb references, which is already done by atomic framework
when creating/destryoing plane state. Let's remove these
unused bits.
Signed-off-by: Tomasz Figa
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 18
uld be relatively low and in practice almost equal to the vop
hardirq handler running time.
Signed-off-by: Tomasz Figa
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 34 +
1 file changed, 34 insertions(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/driv
of code to unreference any changed framebuffer from a
flip work.
Signed-off-by: Tomasz Figa
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 41 +
1 file changed, 41 insertions(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers/gpu/drm/rockchip
t;drm/rockchip: Enable
vblank without event").
Signed-off-by: Tomasz Figa
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers/gpu/drm/rockchip/rockchip
for complete FB changes before) and lets us remove the manual window
update check.
Signed-off-by: Tomasz Figa
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 54 ++---
1 file changed, 10 insertions(+), 44 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b
After changes introduced by last patches, there is no useful data stored
in vop_plane_state struct. Let's remove it and make the driver use
generic plane state alone.
Signed-off-by: Tomasz Figa
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 94 +
1 file changed
)
Signed-off-by: Ãrjan Eide
Signed-off-by: Tomasz Figa
Cc: stable at vger.kernel.org
---
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
b/drivers/gpu/drm/rockchip/rockchip_drm_
Hi Mark,
On Sun, Sep 18, 2016 at 10:50 AM, Mark yao wrote:
> On 2016å¹´09æ14æ¥ 20:54, Tomasz Figa wrote:
>>
>> Current code implements prepare_fb and cleanup_fb callbacks only to
>> grab/release fb references, which is already done by atomic framework
>> when crea
Hi Mark,
Mark Yao rock-chips.com> writes:
>
> No functional changes, sort the vop registers to make
> code more readable.
I might have found a typo. I guess it could be just fixed in this patch,
if it's already moving the code around. Please see the comments inline.
>
> Signed-off-by: Mark
Hi Mark,
Mark Yao rock-chips.com> writes:
>
> Some new vop register support mask, bit[16-31] is mask,
> bit[0-15] is value, the mask is correspond to the value.
Please see my comments inline.
>
> Signed-off-by: Mark Yao rock-chips.com>
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c |
Hi Mark,
Mark Yao rock-chips.com> writes:
>
> There are two VOP in rk3399 chip, respectively VOP_BIG and VOP_LIT.
> most registers layout of this two vop is same, their framework are both
> VOP_FULL, the Major differences of this two is that:
Reviewed-by: Tomasz Figa
Best regards,
Tomasz
display controllers.
> +Big and little display controllers are not identical and have differing
> +feature sets on the rk3399.
I think this doesn't really need any explanation. If two separate
compatible strings are given, it means that the hardware is different. :)
Other than that,
Reviewed-by: Tomasz Figa
Best regards,
Tomasz
ff-by: Shunqian Zheng
> ---
> drivers/iommu/rockchip-iommu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Tomasz Figa
Best regards,
Tomasz
ned-off-by: Simon Xue
> Signed-off-by: Shunqian Zheng
> ---
> drivers/iommu/rockchip-iommu.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Tomasz Figa
Best regards,
Tomasz
Hi,
On Wed, Jun 8, 2016 at 10:26 PM, Shunqian Zheng
wrote:
> An virtual iommu without reg or interrupts for display.
> Adding this according to iommu driver changes.
>
> Signed-off-by: Shunqian Zheng
> ---
> arch/arm/boot/dts/rk3288.dtsi | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff
Hi,
On Wed, Jun 8, 2016 at 10:26 PM, Shunqian Zheng
wrote:
> An virtual master device like DRM need to attach to iommu
> domain to share the domain with VOP(the one with actual
> iommu slave). We currently check the group is NULL to indicate
> a virtual master, which is not true since we decide
Hi,
On Wed, Jun 8, 2016 at 10:26 PM, Shunqian Zheng
wrote:
> Rockchip DRM used the arm special API, arm_iommu_*(), to attach
> iommu for ARM32 SoCs. This patch convert to common iommu API
> so it would support ARM64 like RK3399.
>
> The general idea is domain_alloc(), attach_device() and
>
64 platform to be used with 64-bit SoCs equipped with this type of
IOMMU."
> Signed-off-by: Simon Xue
> Signed-off-by: Shunqian Zheng
> ---
> drivers/iommu/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Assuming that the above is fixed:
Reviewed-by: Tomasz Figa
Best regards,
Tomasz
Hi,
On Wed, Jun 8, 2016 at 10:26 PM, Shunqian Zheng
wrote:
> Use DMA API instead of architecture internal functions like
> __cpuc_flush_dcache_area() etc.
>
> To support the virtual device like DRM the virtual slave iommu
> added in the previous patch, attaching to which the DRM can use
> it
On Mon, Jun 13, 2016 at 6:56 PM, Shunqian Zheng
wrote:
> Hi
>
> On 2016å¹´06æ10æ¥ 17:10, Tomasz Figa wrote:
>>
>> Hi,
>>
>> On Wed, Jun 8, 2016 at 10:26 PM, Shunqian Zheng
>> wrote:
>>>
>>> Use DMA API instead of architecture i
On Mon, Jun 13, 2016 at 7:31 PM, Shunqian Zheng
wrote:
> HI,
>
>
> On 2016å¹´06æ13æ¥ 18:21, Tomasz Figa wrote:
>>
>> On Mon, Jun 13, 2016 at 6:56 PM, Shunqian Zheng
>> wrote:
>>>
>>> Hi
>>>
>>> On 2016å¹´06æ10æ¥ 17:10, Tomas
Hi Yakir,
Yakir Yang rock-chips.com> writes:
> >> Required properties:
> >> -- compatible: "rockchip,rk3288-edp";
> >> +- compatible: "rockchip,rk3288-edp",
> >> + "rockchip,rk3399-edp";
> > As commented by Tomasz on gerrit, there is a pre-existing typo here.
> > Specifically
> - Make panel detect to an optional action
> - correct the register bit define error in ANALOGIX_DP_PLL_REG_1
This version looks good to me. For all patches in the series:
Reviewed-by: Tomasz Figa
Best regards,
Tomasz
this patch
> creates a iommu when attaching.
>
> Signed-off-by: Shunqian Zheng
> Suggested-by: Tomasz Figa
To clarify, I don't really like the idea of virtual IOMMU, however it
is registered, dts or manually, but I don't think there is any other
reasonable way of dealing wi
Hi Shunqian,
On Wed, Jun 15, 2016 at 9:04 PM, Shunqian Zheng
wrote:
> Rockchip DRM used the arm special API, arm_iommu_*(), to attach
> iommu for ARM32 SoCs. This patch convert to common iommu API
> so it would support ARM64 like RK3399.
>
> The general idea is domain_alloc(), attach_device()
Hi Shunqian,
On Wed, Jun 15, 2016 at 9:04 PM, Shunqian Zheng
wrote:
> Use DMA API instead of architecture internal functions like
> __cpuc_flush_dcache_area() etc.
>
> To support the virtual device like DRM the virtual slave iommu
> added in the previous patch, attaching to which the DRM can
the, now
unnecessary, call to drm_connector_register_all() from driver code.
Fixes: f706974a69b6 ("drm/rockchip: Drop drm_driver.load/unload callbacks")
Signed-off-by: Tomasz Figa
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 18 +++---
1 file changed, 7 inserti
for rk_iommu_ops
iommu/rockchip: Enable Rockchip IOMMU on ARM64
Tomasz Figa (1):
drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 100 ++--
drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 3 +
drivers/gpu/drm/rockchip
clear.
Signed-off-by: Simon Xue
Signed-off-by: Shunqian Zheng
Reviewed-on: https://chromium-review.googlesource.com/346325
Reviewed-by: Douglas Anderson
Signed-off-by: Tomasz Figa
---
drivers/iommu/rockchip-iommu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/d
"iommu/rockchip: Reconstruct to support multi slaves")
Signed-off-by: Shunqian Zheng
Signed-off-by: Tomasz Figa
---
drivers/iommu/rockchip-iommu.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu
not introduce any functional changes until the driver
is made to attach subdevices into an IOMMU domain with the generic IOMMU
API, which will happen in following patch. Based heavily on GEM
implementation of Tegra DRM driver.
Signed-off-by: Tomasz Figa
---
drivers/gpu/drm/rockchip
d some device. To overcome this, a simple platform device is
registered for each allocated IOMMU domain.
With this patch, this driver can be used on both ARM and ARM64
platforms, such as RK3288 and RK3399 respectively.
Signed-off-by: Shunqian Zheng
Signed-off-by: Tomasz Figa
---
drivers/iommu/ro
gement, there is no need to use DMA API anymore and this patch wires
things to use the new method.
Signed-off-by: Shunqian Zheng
Signed-off-by: Tomasz Figa
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 100 +++-
1 file changed, 53 insertions(+), 47 deletions(-)
diff --git a/d
From: Simon Xue <x...@rock-chips.com>
This patch makes it possible to compile the rockchip-iommu driver on
ARM64, so that it can be used with 64-bit SoCs equipped with this type
of IOMMU.
Signed-off-by: Simon Xue
Signed-off-by: Shunqian Zheng
Signed-off-by: Tomasz Figa
---
drivers
https://chromium-review.googlesource.com/346326
Reviewed-by: Douglas Anderson
Signed-off-by: Tomasz Figa
---
drivers/iommu/rockchip-iommu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c
index 5a9659a..53fa0d9 100644
--- a/drivers
1 - 100 of 413 matches
Mail list logo