This patch replaces "UINT" with "unsigned
int" in Adapter.h
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Adapter.h | 84 -
1 file changed, 42 insertions(+), 42 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapte
This patch replace "UCHAR" with "u8"
in Adapter.h
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Adapter.h | 82 -
1 file changed, 41 insertions(+), 41 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
index
This patch replaces "USHORT" with "unsigned
short" in Adapter.h
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Adapter.h | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
i
This patch replaces "ULONG" with "unsigned
long", or "u32" for ipv4 addresses, in
Adapter.h. For ipv4 addresses, all
formating is change to match u32 definition.
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Adapter.h | 42 -
drivers/staging/bcm/
This patch removes typedef for _U_IP_ADDRESS, and
changes the name of the struct to bcm_ip_address. In
addition, any calls to struct "U_IP_ADDRESS" are
changed to call directly.
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Adapter.h |8
1 file changed, 4 insertions(+), 4 de
These patches fix several issues in Adapter.h
Kevin McKinney (11):
Staging: bcm: Fix WARNING: space prohibited before semicolon.
Staging: bcm: Remove typedef for _U_IP_ADDRESS and call directly.
Staging: bcm: Replace USHORT with unsigned short in Adapter.h
Staging: bcm: Replaces UCHAR with
This patch removes a space before semicolon as
specified by checkpatch.pl.
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Adapter.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
index d6c9630..11fd7f1 1
This patch replaces "B_UINT16" with "u16"
in Adapter.h
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Adapter.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
index a5dab86..01788d3 100644
--- a/driv
This patch replaces "B_UINT8" with "u8"
in Adapter.h
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Adapter.h |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
index 01788d3..f7620ab 100644
--- a/dr
This patch replaces "UINT32" with "u32"
in Adapter.h
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Adapter.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
index f7620ab..35f480a 100644
--- a/
This patch replaces "LARGE_INTEGER" with "u64"
in Adapter.h
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Adapter.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
index 7055b83..c373bc0 100644
--- a
This patch replaces "PVOID" with "void *"
in Adapter.h
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Adapter.h | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
index 32343e3..7055b
Checking if MAC address is valid using is_valid_ether_addr() is already done in
of_get_mac_address().
Signed-off-by: Luka Perkov
---
drivers/staging/octeon/ethernet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon/ethernet.c
b/drivers/staging/octeon/e
Hi Greg,
> > If you write it like this:
> >
> > return !ret ? ret : -ETIMEDOUT;
> >
> > checkpatch shouldn't complain.
>
> No, but I will.
>
> That's horrid code, please be specific and readable, no one should ever
> use ?: syntax except within function parameters.
why then don't we defin
On Mon, Oct 28, 2013 at 3:11 PM, Greg KH wrote:
> On Mon, Oct 28, 2013 at 10:51:38PM +0100, Andi Shyti wrote:
>> > - return (ret == 0) ? ret : -ETIMEDOUT ;
>> > + if (ret == 0)
>> > + return ret;
>> > + else
>> > + return -ETIMEDOUT;
>>
>> I actually like more the origina
On Mon, Oct 28, 2013 at 10:51:38PM +0100, Andi Shyti wrote:
> > - return (ret == 0) ? ret : -ETIMEDOUT ;
> > + if (ret == 0)
> > + return ret;
> > + else
> > + return -ETIMEDOUT;
>
> I actually like more the original version.
>
> If you write it like this:
>
> ret
> - return (ret == 0) ? ret : -ETIMEDOUT ;
> + if (ret == 0)
> + return ret;
> + else
> + return -ETIMEDOUT;
I actually like more the original version.
If you write it like this:
return !ret ? ret : -ETIMEDOUT;
checkpatch shouldn't complain.
Andi
___
On Mon, Oct 28, 2013 at 2:08 PM, Greg KH wrote:
> On Mon, Oct 28, 2013 at 01:19:29PM -0700, Lisa Nguyen wrote:
>> Rewrite the return statement in vpfe_video.c to eliminate the
>> use of a ternary operator. This will prevent the checkpatch.pl
>> script from generating a warning saying to remove ()
On Mon, Oct 28, 2013 at 06:26:49PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam
>
> This is based on the initial work done by Sascha Hauer and Tony Prisk.
It looks like you've also taken some of the suggestions I've made too -
like the voltage drive and symbol transmit control settings.
It
Rewrite the return statement in vpfe_video.c to eliminate the
use of a ternary operator. This will prevent the checkpatch.pl
script from generating a warning saying to remove () from
this particular return statement.
Signed-off-by: Lisa Nguyen
---
drivers/staging/media/davinci_vpfe/vpfe_video.c
On Mon, Oct 28, 2013 at 01:35:47AM -0700, Lisa Nguyen wrote:
> Before I continue cleaning up the files for the bcm driver, I
> am asking for feedback to make sure the changes I've proposed
> so far are acceptable.
Looks good to me, I'll queue these up, thanks.
greg k-h
_
On Mon, Oct 28, 2013 at 01:19:29PM -0700, Lisa Nguyen wrote:
> Rewrite the return statement in vpfe_video.c to eliminate the
> use of a ternary operator. This will prevent the checkpatch.pl
> script from generating a warning saying to remove () from
> this particular return statement.
>
> Signed-o
On Mon, Oct 28, 2013 at 06:26:49PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam
>
> This is based on the initial work done by Sascha Hauer and Tony Prisk.
What is "this"?
And why is new support being added to this driver instead of working to
get it out of staging?
I thought we went throu
Remove unnecessary spaces before semicolons to meet kernel
coding style.
Signed-off-by: Lisa Nguyen
---
drivers/staging/media/davinci_vpfe/dm365_ipipe.c| 2 +-
drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c | 4 ++--
drivers/staging/media/davinci_vpfe/dm365_isif.c | 2 +-
3 files ch
On Mon, Oct 28, 2013 at 08:21:48AM -0700, Greg Kroah-Hartman wrote:
> On Mon, Oct 28, 2013 at 12:12:17PM +0800, rucsoftsec wrote:
> > By the way, the bug is found by our group, so I typed the name of it. Does
> > it
> > OK?
>
> No, that is not allowed.
To expand on this, kernel development is do
On Mon, Oct 28, 2013 at 12:12:17PM +0800, rucsoftsec wrote:
Please do not send HTML email, the mailing lists delete it.
> I am so sorry! I made something wrong when genenrating the patch. I will do it
> again soon later.
Your other patches are also incorrect, sorry.
> By the way, the bug is fou
Remove user-defined BOOLEAN data type with C bool data
type.
Signed-off-by: Lisa Nguyen
---
drivers/staging/bcm/Adapter.h | 118 +++---
drivers/staging/bcm/CmHost.c | 6 +-
drivers/staging/bcm/CmHost.h | 2 +-
drivers/staging/bcm/
Before I continue cleaning up the files for the bcm driver, I
am asking for feedback to make sure the changes I've proposed
so far are acceptable.
In the staging/bcm/Typedefs.h file, the original code included
these user-defined types:
#define FALSE 0
typedef char BOOLEAN;
It wouldn't make se
On Fri, Oct 25, 2013 at 05:07:18PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun
>
> In case of error, the function platform_device_register_simple() returns
> ERR_PTR() and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
>
> Signed-off-by: Wei Yon
29 matches
Mail list logo
