[PATCH] staging: gdm72xx: fix leaks at failure path in gdm_usb_probe()

Error handling code in gdm_usb_probe() misses to deallocate tx_ and rx_structs and to do usb_put_dev(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/staging/gdm72xx/gdm_usb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/d

Re: vme_tsi148 question

On Wed, Feb 5, 2014 at 1:38 PM, Michael Kenney wrote: > On Wed, Feb 5, 2014 at 1:22 PM, Martyn Welch wrote: >> >> >> >> On 5 February 2014 17:41, Greg KH wrote: >>> >>> On Tue, Feb 04, 2014 at 06:34:13PM +, Martyn Welch wrote: >>> > On 04/02/14 16:34, Michael Kenney wrote: >>> > >Hi Martyn,

Re: [PATCH 0/8] Fix some bugs/races in imx-drm

On Wed, Feb 05, 2014 at 12:02:49PM -0800, Greg Kroah-Hartman wrote: > On Tue, Dec 17, 2013 at 05:13:48PM -0800, Greg Kroah-Hartman wrote: > > I'll apply these after the first round goes into Linus's tree to make > > the merging easier (i.e. after the next -rc). > > Now applied. Thanks. I'll see

[PATCH v2] staging: comedi: adv_pci1710: fix analog output readback value

The last value written to a analog output channel is cached in the private data of this driver for readback. Currently, the wrong value is cached in the (*insn_write) functions. The current code stores the data[n] value for readback afer the loop has written all the values. At this time 'n' points

Re: vme_tsi148 question

On Wed, Feb 5, 2014 at 1:22 PM, Martyn Welch wrote: > > > > On 5 February 2014 17:41, Greg KH wrote: >> >> On Tue, Feb 04, 2014 at 06:34:13PM +, Martyn Welch wrote: >> > On 04/02/14 16:34, Michael Kenney wrote: >> > >Hi Martyn, >> > > >> > >On Tue, Feb 4, 2014 at 7:28 AM, Martyn Welch > > >

[PATCH] imx-drm: imx-hdmi: Remove parentheses from returns

From: Fabio Estevam Fix the following checkpatch warnings: ERROR: return is not a function, parentheses are not required #462: FILE: drivers/staging/imx-drm/imx-hdmi.c:462: + return (hdmi->hdmi_data.enc_in_format != ERROR: return is not a function, parentheses are not required #468: FILE:

Re: [PATCH 0/8] Fix some bugs/races in imx-drm

On Tue, Dec 17, 2013 at 05:13:48PM -0800, Greg Kroah-Hartman wrote: > On Tue, Dec 17, 2013 at 07:09:56PM +, Russell King - ARM Linux wrote: > > On Tue, Dec 17, 2013 at 08:05:41AM -0800, Greg Kroah-Hartman wrote: > > > On Tue, Dec 17, 2013 at 03:17:02PM +, Russell King - ARM Linux wrote: > >

Re: Q: comedi timeouts

On Wed, Feb 05, 2014 at 06:02:04PM +, Hartley Sweeten wrote: > On Wednesday, February 05, 2014 10:40 AM, Greg KH wrote: > > On Tue, Feb 04, 2014 at 06:59:43PM +, Hartley Sweeten wrote: > >> I'm in the process of cleaning up all the "timeout" code in the > >> comedi drivers. The general for

Re: Q: comedi timeouts

On Tue, Feb 04, 2014 at 06:59:43PM +, Hartley Sweeten wrote: > Hello all, > > I'm in the process of cleaning up all the "timeout" code in the > comedi drivers. The general form of the timeout code in all > the drivers is: > > static int foo_eoc(struct comedi_device *dev, unsigned long timeou

RE: Q: comedi timeouts

On Wednesday, February 05, 2014 10:40 AM, Greg KH wrote: > On Tue, Feb 04, 2014 at 06:59:43PM +, Hartley Sweeten wrote: >> I'm in the process of cleaning up all the "timeout" code in the >> comedi drivers. The general form of the timeout code in all >> the drivers is: >> >> static int foo_eoc

Re: vme_tsi148 question

On Tue, Feb 04, 2014 at 06:34:13PM +, Martyn Welch wrote: > On 04/02/14 16:34, Michael Kenney wrote: > >Hi Martyn, > > > >On Tue, Feb 4, 2014 at 7:28 AM, Martyn Welch >> wrote: > > > >On 28/12/13 00:34, Michael Kenney wrote: > > > >Hi Martyn, > > > >

[PATCH RESEND 3/3] staging: et131x: fix make W=1 build warning

fix make W=1 warning: drivers/staging/et131x/et131x.c: In function ‘et1310_setup_device_for_multicast’: drivers/staging/et131x/et131x.c:1052:6: warning: variable ‘pm_csr’ set but not used [-Wunused-but-set-variable] u32 pm_csr; ^ drivers/staging/et131x/et131x.c: In function ‘et1310_setup_

[PATCH RESEND 1/3] staging: et131x: stop read when hit max delay in et131x_phy_mii_read

stop read and return error when hit max delay time. Signed-off-by: Zhao, Gang Acked-by: Mark Einon --- Acked at post: http://article.gmane.org/gmane.linux.kernel/1599347 drivers/staging/et131x/et131x.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/et131x/et131x.c b/dri

[PATCH RESEND 2/3] staging: et131x: remove spinlock adapter->lock

adapter->lock is only used in et131x_multicast(), which is eventually called by network stack function __dev_set_rx_mode(). __dev_set_rx_mode() is always called by (net_device *)dev->addr_list_lock hold, to protect from concurrent access. So adapter->lock is redundant. Signed-off-by: Zhao, Gang A

Re: rtl8821ae.

> Looks good. It would be best to submit the bugfixes first like where > you add error checking for pci_map_single(). Yes, this is exactly what I started to do this morning :) I'm preparing a patchseries where I extracting fixes or improvements unrelated to rtl8187se, including pci_map_single fix

Re: [PATCH] et131x: fix allocation failures

add Cc to devel mailing list On Wed, 2014-02-05 at 19:56:19 +0800, Alan wrote: > We should check the ring allocations don't fail. > If we get a fail we need to clean up properly. The allocator assumes the > deallocator will be used on failure, but it isn't. Fix this and add a > missing check again

Re: rtl8821ae.

> > Somehow I missed this patch. Do you know if John Linville picked it up? > AFAIK no.. > I'm not sure if the ANAPARAM3 register could handle a 16-bit write on an > RTL8187B. To be cautious, I wrote and have tested the attached patch using a > union. The patch includes a fix for an undefined sym