Get rid of the rc = -1 initialization. Return a meaningful error on
failure in the function, or, the rc from a called function if it fails.
Signed-off-by: Benjamin Romer
---
v2: Put the goto back in.
v3: sent the wrong version of the patch by mistake.
---
drivers/staging/unisys/visorbus
Get rid of the rc = -1 initialization. Return a meaningful error on
failure in the function, or, the rc from a called function if it fails.
Signed-off-by: Benjamin Romer
---
v2: Put the goto back in.
---
drivers/staging/unisys/visorbus/visorbus_main.c | 10 ++
1 file changed, 6
The value of rc is set by calling a function, so there's no need to
initialize it to -1, or anything at all.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/vis
Get rid of the rc = -1 initialization, and remove the goto
mess entirely. Return a meaningful error on failure in the function, or
the rc from a called function if it fails.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorbus_main.c | 18 --
1 file changed
Instead of returning -1, return -ENODEV when there is no probe function
found for the device.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b
The other error paths return meaningful error codes, except for the one
when registering a device, which just returned -1. Let's return ENODEV
when it fails to register instead.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
1 file changed, 1 inse
This series cleans up all the places where rc = -1 was being done, either
as initialization, or to return an error value. In some places, it can
just be removed, but other places it was better to cleaning up goto
statements and eliminate the -1 at the same time.
Benjamin Romer (7):
staging
Remove the rc, the = -1, and all the goto mess here and just return
directly with a meaningful error number.
The caller only cares about success/failure right now, that needs to be
addressed in a later patch series.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus
: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorbus_main.c | 42 +
1 file changed, 22 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b/drivers/staging/unisys/visorbus/visorbus_main.c
index 2d3ed4e..e170e0a 100644
--- a
Remove the unnecessary rc and goto messiness, and just handle freeing
the memory before returning an error in the one place where that needs
to happen.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorbus_main.c | 16
1 file changed, 4 insertions(+), 12
From: Erik Arfvidson
This patch fixes the following types of check patch warnings:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
v2: the patch was rebased.
v3: the patch was rebased
parser_param_start() had a goto Away, which went to nothing but
a return statement. Remove the goto, the CamelCased label, and
just return directly.
Signed-off-by: Benjamin Romer
---
v2: the patch was rebased.
v3: the patch was rebased.
---
drivers/staging/unisys/visorbus/visorchipset.c | 6
From: Erik Arfvidson
This patch simply fixes all trailing */ by modifying the comments
structures while trying to reduce the total number of lines
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
v2: the patch was rebased.
v3: the patch was rebased.
---
drivers/staging/unisys
From: Erik Arfvidson
This patch fixes the following checkpatch warning:
spaces preferred around that ‘*’ or ‘|’
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
v2: the patch was rebased.
v3: address Sudip's comment about a change being made to a NULL comparison
From: Erik Arfvidson
This patch fixes checkpatch's no space is necessary after a cast
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
v2: the patch was rebased.
v3: the patch was rebased.
---
drivers/staging/unisys/visorbus/visorchipset.c | 6 +++---
1 file chang
From: Erik Arfvidson
This patch fixes the following type of check patch warnings:
Comparison to NULL could be written
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
v2: the patch was rebased.
v3: address a comment from Sudip about a change to a NULL comparison that
was
From: Erik Arfvidson
This patches resolves the NULL comparison checkpatch warnings
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
v2: the patch was rebased.
v3: the patch was rebased.
---
drivers/staging/unisys/visorbus/vbusdeviceinfo.h | 4 ++--
1 file changed, 2
From: Erik Arfvidson
This patch fixes all the Block comments by using a trailing */
on a separate line
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
v2: the patch was rebased.
v3: the patch was rebased.
---
drivers/staging/unisys/visorbus/visorchipset.c | 16
From: Erik Arfvidson
This patch fixes the following types of check patch warnings:
Block comments use a trailing */ on a separate line
Comment alignments
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
v2: the patch was rebased.
v3: the patch was rebased
From: Erik Arfvidson
This patch fixes the following types of check patch warnings:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
v2: the patch was rebased.
v3: the
From: Erik Arfvidson
This patch fixes the following types of check patch warnings:
else is not generally useful after a break or return
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
v2: the patch was rebased.
v3: the patch was rebased.
---
drivers/staging/unisys/visornic
From: Erik Arfvidson
Fixes checkpatch trailing */ comment in vbusdeviceinfo.h
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
v2: the patch was rebased.
v3: the patch was rebased.
---
drivers/staging/unisys/visorbus/vbusdeviceinfo.h | 3 ++-
1 file changed, 2 insertions
From: Erik Arfvidson
This patch simply cleans up all checkpatch comment issues
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
v2: the patch was rebased.
v3: the patch was rebased.
---
drivers/staging/unisys/include/guestlinuxdebug.h | 13 +++--
1 file changed, 7
From: Erik Arfvidson
this patch removes the following checkpatch warnings:
please use a blank line after …
Please don’t use multiple blank lines
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
v2: the patch was rebased.
v3: the patch was rebased.
---
drivers
acceptable as is.
- Two patches were modified to move a fix to a NULL comparison into the
correct patch.
Benjamin Romer (1):
staging: unisys: remove unnecessary goto
Erik Arfvidson (13):
staging: unisys: Fix guestlinuxdebug.h comments
staging: unisys: fix comments for controlvmchannel.h
From: Erik Arfvidson
This patch simply fixes all trailing */ by modifying the comments
structures while trying to reduce the total number of lines
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/controlvmchannel.h | 237 +++--
1
Fix the only fixable parenthesis alignment issue in
visorchipset.c. The rest are unworkable because of the length
of the symbol names used.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
From: Erik Arfvidson
This patch fixes the following types of check patch warnings:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
.../staging/unisys/visorinput/ultrainputreport.h
From: Erik Arfvidson
This patch fixes the following types of check patch warnings:
else is not generally useful after a break or return
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visornic/visornic_main.c | 4 ++--
1 file changed, 2 insertions(+), 2
From: Erik Arfvidson
This patch fixes all the Block comments by using a trailing */
on a separate line
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff
From: Erik Arfvidson
this patch removes the following checkpatch warnings:
please use a blank line after …
Please don’t use multiple blank lines
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 3 +--
1 file
From: Erik Arfvidson
This patch fixes checkpatch's no space is necessary after a cast
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/st
From: Erik Arfvidson
This patches resolves the NULL comparison checkpatch warnings
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/vbusdeviceinfo.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys
From: Erik Arfvidson
Fixes checkpatch trailing */ comment in vbusdeviceinfo.h
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/vbusdeviceinfo.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus
From: Erik Arfvidson
This patch fixes the following types of check patch warnings:
Alignment should match open parenthesis
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visornic/visornic_main.c | 10 +-
1 file changed, 5 insertions(+), 5
From: Erik Arfvidson
This patch fixes the following type of check patch warnings:
Comparison to NULL could be written
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions
From: Erik Arfvidson
This patch fixes the following types of check patch warnings:
Block comments use a trailing */ on a separate line
Comment alignments
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorbus_main.c | 6
From: Erik Arfvidson
This patch fixes the following checkpatch warning:
spaces preferred around that ‘*’ or ‘|’
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff
parser_param_start() had a goto Away, which went to nothing but
a return statement. Remove the goto, the CamelCased label, and
just return directly.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff
This patch series cleans up all the remaining issues reported by
checkpatch.pl that can be fixed. The series was rebased against
the current contents of staging-next.
Benjamin Romer (2):
staging: unisys: remove unnecessary goto
staging: unisys: fix parenthesis in toolaction_show()
Erik
From: Erik Arfvidson
This patch fixes the following types of check patch warnings:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visornic
From: Erik Arfvidson
This patch simply cleans up all checkpatch comment issues
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/guestlinuxdebug.h | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging
From: David Kershner
>From napi documentation you should only process the amount your
budget allows, if you go over it just wait for the next napi poll
to continue.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visornic/visornic_main.c |
Fix the only fixable parenthesis alignment issue in
visorchipset.c. The rest are unworkable because of the length
of the symbol names used.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
parser_param_start() had a goto Away, which went to nothing but
a return statement. Remove the goto, the CamelCased label, and
just return directly.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff
From: Erik Arfvidson
This patch fixes the following types of check patch warnings:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visornic
From: Erik Arfvidson
This patch fixes the following types of check patch warnings:
Alignment should match open parenthesis
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visornic/visornic_main.c | 10 +-
1 file changed, 5 insertions(+), 5
From: Erik Arfvidson
This patch fixes the following types of check patch warnings:
Block comments use a trailing */ on a separate line
Comment alignments
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorbus_main.c | 6
From: Erik Arfvidson
This patch fixes the following types of check patch warnings:
else is not generally useful after a break or return
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visornic/visornic_main.c | 4 ++--
1 file changed, 2 insertions(+), 2
From: Erik Arfvidson
This patch fixes all the Block comments by using a trailing */
on a separate line
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff
From: Erik Arfvidson
This patch fixes the following type of check patch warning:
Blank lines aren't necessary before a close brace '}'
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visornic/visornic_main.c | 1 -
1 file changed, 1 de
From: Erik Arfvidson
This patch fixes the following checkpatch warning:
spaces preferred around that ‘*’ or ‘|’
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff
From: Erik Arfvidson
This patch simply cleans up all checkpatch comment issues
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/guestlinuxdebug.h | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging
This set of patches cleans up all remaining checkpatch formatting warnings
in the Unisys driver series.
Erik Arfvidson (15):
staging: unisys: Fix guestlinuxdebug.h comments
staging: unisys: fix comments for controlvmchannel.h
staging: unisys: Fix NULL comparison vbusdeviceinfo.h
staging: u
From: Erik Arfvidson
this patch removes the following checkpatch warnings:
please use a blank line after …
Please don’t use multiple blank lines
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 3 +--
1 file
From: Erik Arfvidson
This patch fixes checkpatch's no space is necessary after a cast
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/st
From: Erik Arfvidson
Fixes checkpatch trailing */ comment in vbusdeviceinfo.h
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/vbusdeviceinfo.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus
From: Erik Arfvidson
This patch fixes the following type of check patch warnings:
Comparison to NULL could be written
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions
From: Erik Arfvidson
This patch fixes the following types of check patch warnings:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
.../staging/unisys/visorinput/ultrainputreport.h
From: Erik Arfvidson
This patch simply fixes all trailing */ by modifying the comments
structures while trying to reduce the total number of lines
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/controlvmchannel.h | 237 +++--
1
From: Erik Arfvidson
This patches resolves the NULL comparison checkpatch warnings
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/vbusdeviceinfo.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys
We should provide more information in the Kconfig help for visorbus and
visorinput.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/Kconfig | 7 ++-
drivers/staging/unisys/visorinput/Kconfig | 7 ++-
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a
From: Erik Arfvidson
This patch fixes the following types of check patch warnings:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
.../staging/unisys/visorinput/ultrainputreport.h
From: Erik Arfvidson
This patch fixes the checkpatch warning messages in
controlvmcompletionstatus.h. All the warning messages in this file are
caused by "Block comments use atrailing */ on a separate line"
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
.../unisy
From: Erik Arfvidson
Fixes trailling */ from vbuschannel.h and alignment issue on the
same comment block
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/vbuschannel.h | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a
From: Erik Arfvidson
This fixes last checkpatch warning:
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/visorbus.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
From: Erik Arfvidson
This patch simply cleans up all checkpatch warnings and fixes
styling
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/guestlinuxdebug.h | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a
From: Erik Arfvidson
This patch fixes check warning from checkpatch.pl in the macro definition
CHECK: spaces preferred around that '+' (ctx:VxV)
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/iochannel.h | 3 ++-
1 file changed, 2
This series takes care of checkpatch.pl issues found recently, as the
current version now inspects comment formatting. In addition, some
spacing and alignment issues are corrected.
Erik Arfvidson (14):
staging: unisys: iochannel fix block comments
staging: unisys: iochannel.h remove redundant
From: Erik Arfvidson
This patch fixes all the checkpatch.pl block commments that use a
trailing */ in channel.h
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/channel.h | 114 ++-
1 file changed, 67 insertions(+), 47
From: Erik Arfvidson
This patch fixes last checkpatch warning for vbushelper.h
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/vbushelper.h | 3 ++-
1 file changed, 2 insertions(+), 1
From: Erik Arfvidson
Fixed last warning message from checkpatch.pl by removing the
wordiness of the comment
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/iochannel.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers
From: Erik Arfvidson
This patch fixes the last checkpatch warning about:
Block comments use a trailing */ on a separate line
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchannel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
From: Erik Arfvidson
iochannel cleanup redudant comments in function declarations.
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/iochannel.h | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/staging
From: Erik Arfvidson
This patch fixes checkpatch.pl message:
CHECK: Alignment should match open parenthesis
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/periodic_work.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff
From: Erik Arfvidson
This patch fixes all the checkpatch Block comments use a trailing
*/ while keeping comments clean.
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/vmcallinterface.h | 34 ++-
1 file changed, 15
From: Erik Arfvidson
This patch fixes warning messages from checkpatch.pl specifically:
WARNING: Block comments use a trailing */ on a separate lines
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/iochannel.h | 137
From: David Kershner
Since visorbus now supports s-Par interrupts it will
handle the polling/interrupt mode for us.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visornic/visornic_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
From: David Kershner
Visorbus handles interrupt states for the drivers now, don't need
to handle it in the driver.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorhba/visorhba_main.c | 14 --
1 file changed, 14 deletions(-)
diff
processing
its queue.
Visorinput, visorhba, and visornic were all updated to call the new
function.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/visorbus.h | 2 ++
drivers/staging/unisys/visorbus/visorbus_main.c | 9 +++--
drivers
-by: Benjamin Romer
---
drivers/staging/unisys/include/visorbus.h | 2 +
drivers/staging/unisys/visorbus/visorbus_main.c | 65 ++---
2 files changed, 59 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/unisys/include/visorbus.h
b/drivers/staging/unisys
Sell
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/visorbus.h | 5 +
drivers/staging/unisys/visorbus/visorbus_main.c | 118 ++--
drivers/staging/unisys/visorbus/visorchannel.c | 1 +
drivers/staging/unisys/visorbus/visorchipset.c | 17
From: David Kershner
Add support to visorbus to update the features in the channel queues.
Signal queues features is the memory location to disable/enable signal
queue interrupts.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/visorbus.h
From: David Kershner
We can remove the semaphore from around the interrupt callback in
dev_periodic_work().
Signed-off-by: David Kershner
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 --
1 file changed, 2 deletions(-)
diff
From: David Kershner
Every channel has an s-Par channel state associated with it. This patch
correctly sets of the channels.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorbus_main.c | 32 -
1 file changed, 31
From: David Kershner
Instead of having our own timer to set off a interrupt, use the shared code
from visorbus. When visorbus gets s-Par interrupts working we will
automatically get support from it.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys
sing it in
visorinput_channel_interrupt().
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorinput/visorinput.c | 26 ++
1 file changed, 18 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/unisys/visorinput/visorinput.c
b/drive
This patch series adds a centralized infrastructure and device support
for channel interrupts sent to s-Par virtual devices. With these changes,
the visorhba device is ~80% faster than with only polling, and visornic
receives a speedup of over 3500% (from ~9Mb/s to between 360Mb/s and
390Mb/s).
Da
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorhba/visorhba_main.c | 114 +++-
1 file changed, 52 insertions(+), 62 deletions(-)
diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
b/drivers/staging/unisys/visorhba/visorhba_
From: David Kershner
Use ms_to_jiffies for the periodic work queue instead of raw jiffies.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging
From: David Kershner
>From napi documentation you should only process the amount your
budget allows, if you go over it just wait for the next napi poll
to continue.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visornic/visornic_main.c
From: David Kershner
Need access functions to set channel polling
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorbus_main.c | 55 +
1 file changed, 55 insertions(+)
diff --git a/drivers/staging/unisys/visorbus
to use a workqueue to do it asynchronously.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
v2: the patch was resubmitted.
---
drivers/staging/unisys/visorinput/visorinput.c | 71 ++
1 file changed, 71 insertions(+)
diff --git a/drivers/staging/unisys/visor
This patch series fixes visorinput to remove the dependency on FB and
add dependency to INPUT, cleans up some formatting issues found with
checkpatch.pl, and adds the capability to change screen resolutions
without breaking mouse functionality.
This is a resubmission of the series.
Tim Sell (7):
From: Tim Sell
This was an obvious omission, as visorinput is an input-class driver.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
v2: the patch was resubmitted.
---
drivers/staging/unisys/visorinput/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
()), after
which we may quickly find ourselves in visorinput_open(), where we enable
interrupts, and hence may call visorinput_channel_interrupt().
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
v2: the patch was resubmitted.
---
drivers/staging/unisys/visorinput/visorinput.c | 12
implementations, mouse.x_resolution and mouse.y_resolution are always just
initialized to 0 by the back-end, and only 1024x768 is supported, but
coding it this way will allow other resolutions to work in the future.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
v2: the patch was
From: Tim Sell
The dev_info() messages at init time are particularly useful for mapping
visor devices to input devices.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
v2: the patch was resubmitted.
---
drivers/staging/unisys/visorinput/visorinput.c | 11 +++
1 file
From: Tim Sell
This is NOT technically required for the code as it stands now, but will
be needed for subsequent patches.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
v2: resources are released in the reverse order they were acquired, as per
Dan Carpenter's co
From: Tim Sell
This commit sanity checks so that if a change resolution request is ever
received for a non-mouse device, that an error message will be logged and
the message will be ignored.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
v2: the patch was resubmitted.
---
drivers
1 - 100 of 1097 matches
Mail list logo
