On 10/1/18 12:49 PM, Lidza Louina wrote:
On Mon, Oct 1, 2018 at 8:09 AM Mark Hounschell <mailto:ma...@compro.net>> wrote:
On 9/28/18 3:59 PM, Lidza Louina wrote:
> I haven't done work on this driver in a long time. I looked up the
> devices, and they see
On 9/28/18 3:59 PM, Lidza Louina wrote:
I haven't done work on this driver in a long time. I looked up the
devices, and they seem to already have an existing Linux driver:
https://www.digi.com/products/usb-and-serial-connectivity/serial-cards/digineo and
https://www.digi.com/support/productdeta
On 09/15/2015 09:05 AM, Greg Kroah-Hartman wrote:
On Tue, Sep 15, 2015 at 08:56:10AM -0400, Mark Hounschell wrote:
Removes myself from the MAINTAINERS file for the dgap driver.
There appears to be no way to get the firmware files required
by the dgap driver into the linux-firmware tree. The
respond
to an inquiry concerning it or its firmware.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
Cc: Ben Hutchings
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index cf1a98d..1c19938 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3394,7
On 03/15/2015 08:07 AM, Mark Hounschell wrote:
On 03/14/2015 04:44 AM, Greg KH wrote:
On Fri, Mar 13, 2015 at 04:55:55PM -0400, Mark Hounschell wrote:
On 03/12/2015 12:14 PM, Giedrius Statkevičius wrote:
On 2015.03.12 12:08, Greg KH wrote:
On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius
On 03/14/2015 04:44 AM, Greg KH wrote:
On Fri, Mar 13, 2015 at 04:55:55PM -0400, Mark Hounschell wrote:
On 03/12/2015 12:14 PM, Giedrius Statkevičius wrote:
On 2015.03.12 12:08, Greg KH wrote:
On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote:
Remove BOARD_FAILED and
On 03/12/2015 12:14 PM, Giedrius Statkevičius wrote:
On 2015.03.12 12:08, Greg KH wrote:
On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote:
Remove BOARD_FAILED and don't save dgnc_boards which failed to
initialize.
Assign the result of kzalloc() to brd in dgnc_found_board()
On 12/03/2014 06:37 PM, Joe Perches wrote:
On Wed, 2014-12-03 at 21:30 +, Sean Cleator wrote:
A patch to fix the rest of the long line warnings in the dgnc_cls.h file
found by the checkpatch.pl tool
checkpatch is a brainless little tool.
You should prefer to develop a readable style rathe
On 10/29/2014 05:22 AM, Greg KH wrote:
On Sun, Oct 26, 2014 at 11:08:54AM +0900, Daeseok Youn wrote:
Re-arrange the functions for removing forward declarations.
Tested-by: Mark Hounschell
Signed-off-by: Daeseok Youn
---
RESEND: This patch is tested all by Mark.
It is good to merge. Greg
On 10/14/2014 08:01 AM, Mark Hounschell wrote:
On 10/13/2014 10:04 PM, Greg KH wrote:
On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote:
On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote:
Hi,
2014-10-13 12:25 GMT+09:00 Greg KH :
On Mon, Oct 13, 2014 at 11:34:25AM +0900
On 10/21/2014 07:33 AM, David Binderman wrote:
Hello there,
1.
[linux-3.18-rc1/drivers/staging/dgap/dgap.c:6692]: (warning) Logical
disjunction always evaluates to true: conc_type != 65 || conc_type != 66.
Source code is
if (conc_type == 0 || conc_type != CX ||
On 10/13/2014 10:04 PM, Greg KH wrote:
On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote:
On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote:
Hi,
2014-10-13 12:25 GMT+09:00 Greg KH :
On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote:
Re-arrange the functions for remov
On 07/31/2014 07:14 PM, DaeSeok Youn wrote:
Hi, Mark
2014-07-31 21:44 GMT+09:00 Mark Hounschell :
On 07/31/2014 12:02 AM, Daeseok Youn wrote:
When a configration file is parsed with dgap_parsefile(),
makes nodes for saving configrations for board.
Making a node will allocate node memory and
On 07/31/2014 12:02 AM, Daeseok Youn wrote:
When a configration file is parsed with dgap_parsefile(),
makes nodes for saving configrations for board.
Making a node will allocate node memory and strings for saving
configrations with kstrdup().
So these are freed when dgap is unloaded or failed t
On 07/16/2014 09:35 PM, Daeseok Youn wrote:
> When a configration file is parsed with dgap_parsefile(),
> makes nodes for saving configrations for board.
>
> Making a node will allocate node memory and strings for saving
> configrations with kstrdup().
>
> So these are freed when dgap is unloaded
On 07/16/2014 08:42 PM, DaeSeok Youn wrote:
2014-07-16 23:17 GMT+09:00 Mark Hounschell :
On 07/16/2014 05:26 AM, DaeSeok Youn wrote:
2014-07-16 8:50 GMT+09:00 Greg KH :
On Wed, Jul 16, 2014 at 08:21:30AM +0900, DaeSeok Youn wrote:
Hi,
2014-07-16 0:29 GMT+09:00 Greg KH :
On Tue, Jul 15
On 07/16/2014 05:26 AM, DaeSeok Youn wrote:
2014-07-16 8:50 GMT+09:00 Greg KH :
On Wed, Jul 16, 2014 at 08:21:30AM +0900, DaeSeok Youn wrote:
Hi,
2014-07-16 0:29 GMT+09:00 Greg KH :
On Tue, Jul 15, 2014 at 06:11:44PM +0900, Daeseok Youn wrote:
The dgap_err() is printing a message with pr_err
On 07/15/2014 11:30 AM, Greg KH wrote:
On Tue, Jul 15, 2014 at 06:14:25PM +0900, Daeseok Youn wrote:
When a configration file is parsed with dgap_parsefile(),
makes nodes for saving configrations for board.
configuration files should not be parsed in the kernel at all. That
logic should be re
Hi Dan,
I've been away for a while but should be able to find some time to work
on the dgap driver some more. Do you have a TODO list?
Thanks
Mark
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listin
Replaces ENXIO with EIO errno
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 44 ++--
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index
Simplify ugly dgap_find_config function
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
Tested-by: Mark Hounschell
---
drivers/staging/dgap/dgap.c | 84 +++--
1 file changed, 43 insertions(+), 41 deletions(-)
diff --git a/drivers/staging/dgap
refactors NULL conditionals
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
Tested-by: Mark Hounschell
---
drivers/staging/dgap/dgap.c | 64 ++---
1 file changed, 32 insertions(+), 32 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b
On 05/28/2014 06:11 AM, Dan Carpenter wrote:
> On Wed, May 28, 2014 at 06:29:38PM +0900, DaeSeok Youn wrote:
>>> In your patch it has:
>>> + dgap_tty_uninit(brd, false);
>>>
>>> But it should only be "false" if dgap_tty_init() failed. If
>>> dgap_tty_register_ports() fails then it should be
We don't need to use GFP_ATOMIC at driver load time
so use GFP_KERNEL instead.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
Tested-by: Mark Hounschell
---
drivers/staging/dgap/dgap.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging
Simplify dgap_config_get_useintr and dgap_config_get_altpin
changing the case statement to an if statement.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
Tested-by: Mark Hounschell
---
drivers/staging/dgap/dgap.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff
This patch replaces double negativeconditionals
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
Tested-by: Mark Hounschell
---
drivers/staging/dgap/dgap.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging
Removes more extra white space and tabs
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 178 +---
1 file changed, 86 insertions(+), 92 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap
Removes unnecessary initialization of variables in declarations
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
Tested-by: Mark Hounschell
---
drivers/staging/dgap/dgap.c | 175 +---
1 file changed, 84 insertions(+), 91 deletions(-)
diff --git a
On 05/22/2014 04:38 PM, Dan Carpenter wrote:
> On Thu, May 22, 2014 at 01:49:22PM -0400, Mark Hounschell wrote:
>> I understand that unnecessarily initializing them is wrong. But if they
>> do need initialized, is it preferred to do it in the declaration or in
>> the c
I understand that unnecessarily initializing them is wrong. But if they
do need initialized, is it preferred to do it in the declaration or in
the code before it is used?
Thanks
Mark
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.li
Removes dgap_savestring function to use kstrdup instead.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
Tested-by: Mark Hounschell
---
drivers/staging/dgap/dgap.c | 44 +++-
1 file changed, 15 insertions(+), 29 deletions(-)
diff --git a/drivers
On 05/21/2014 03:59 PM, Dan Carpenter wrote:
> On Wed, May 21, 2014 at 01:03:09PM -0400, Mark Hounschell wrote:
>> This patch fixes an smatch warning about a missing break
>> in a case statement.
>>
>
> I would prefer if we leave the code as-is and fix Smatch. Th
This patch removes an unnecessary test. We've already
tested it by the time we get here with no possiblity
of it being changed.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
Tested-by: Mark Hounschell
---
drivers/staging/dgap/dgap.c | 10 --
1 file changed, 10 dele
This patch removes a false comment
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index b3ad3ac..6816cf7 100644
--- a/drivers/staging/dgap/dgap.c
The sniff buffer was a /proc filesystem file. This
module no longer uses /proc. This patch removes
the deaed code associated with the sniff buffer.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
Tested-by: Mark Hounschell
---
drivers/staging/dgap/dgap.c | 124
This patch fixes a smatch warning about an unsigned
integer being tested for less than zero.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
Tested-by: Mark Hounschell
---
drivers/staging/dgap/dgap.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
This patch fixes an smatch warning about a missing break
in a case statement.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
Tested-by: Mark Hounschell
---
drivers/staging/dgap/dgap.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c
Add Mark Hounschell to the MAINTAINERs list for the dgap driver
Signed-off-by: Mark Hounschell
Suggested-by: Dan Carpenter
Cc: Greg Kroah-Hartman
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index da68679..c9be346 100644
--- a/MAINTAINERS
+++ b
On 05/16/2014 07:52 AM, Mark Hounschell wrote:
> On 05/15/2014 06:49 PM, Dan Carpenter wrote:
>> On Fri, May 16, 2014 at 12:27:01AM +0200, Christian Engelmayer wrote:
>>> Hi,
>>>
>>> As I got a bit queued up for dgap, I just noticed that commit 542f3d5
On 05/15/2014 06:49 PM, Dan Carpenter wrote:
> On Fri, May 16, 2014 at 12:27:01AM +0200, Christian Engelmayer wrote:
>> Hi,
>>
>> As I got a bit queued up for dgap, I just noticed that commit 542f3d5a states
>> to add Mark to the maintainers list for dgap, while the patch addresses the
>> dgnc entr
I have some patches submitted almost 3 weeks ago that I have not
received any email responses to. When should I think about resubmitting
them? Or should I just be more patient?
Thanks
Mark
___
devel mailing list
de...@linuxdriverproject.org
http://driver
This patch gets rid of the obvious CamelCases
from both dgap.c and dgap.h
Signed-off-by: Mark Hounschell
Tested-by: Mark Hounschell
Suggested-by: Dan Carpenter
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 228 ++--
drivers/staging/dgap
I get the sparse warning:
drivers/staging/dgap/dgap.c:367:25: warning: too long initializer-string
for array of char
It's referring to INIT_C_CC in the following code segment.
static struct ktermios DgapDefaultTermios = {
.c_iflag = (DEFAULT_IFLAGS), /* iflags */
.c_of
Add Mark Hounschell to the MAINTAINERs list for the dgap driver
Signed-off-by: Mark Hounschell
Suggested-by: Dan Carpenter
Cc: Greg Kroah-Hartman
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index e67ea24..1bf556a 100644
--- a/MAINTAINERS
+++ b
This patch just cleans up the ugly dgap_init_one function
Signed-off-by: Mark Hounschell
Suggested-by: Dan Carpenter
Tested-by: Mark Hounschell
---
drivers/staging/dgap/dgap.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c
patch 1: check return values of dgap_tty_register and dgap_finalize_board_init
patch 2: removes 2 unnecessary conditionals
patch 3: only allow driver to configure MAXBOARDS (32)
--
1.8.1.4
___
devel mailing list
de...@linuxdriverproject.org
http://dr
Remove 2 unnessessary conditionals. They are always
false in this code path.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 32 ++--
1 file changed, 14 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c
Check the return values of dgap_tty_register and
dgap_finalize_board_init. If they fail for a
particular board we should not be able to try
to use that board. IE. no device entries shall
be created for that board.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap
Insure we don't allow configuring more than MAXBOARDS (32).
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index b834c83..f597432 100644
On 04/25/2014 08:59 AM, Dan Carpenter wrote:
> On Fri, Apr 25, 2014 at 08:29:41AM -0400, Mark Hounschell wrote:
>> On 04/25/2014 07:02 AM, DaeSeok Youn wrote:
>>> Hi, Dan.
>>>
>>> 2014-04-25 18:26 GMT+09:00 Dan Carpenter :
>>>> Mark, maybe you shoul
This patch fixes a few more sparse warnings related to __iomem
version 2 excludes a change that actually caused a new sparse
warning.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 37 +++--
1 file changed, 19 insertions
On 04/25/2014 09:44 AM, Dan Carpenter wrote:
> On Fri, Apr 25, 2014 at 09:38:48AM -0400, Mark Hounschell wrote:
>> This patch just backs out a change in a previous patch
>> that generated a new sparse warning.
>>
>
> Could you redo the previous change instead? Or ha
This patch just backs out a change in a previous patch
that generated a new sparse warning.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging
On 04/25/2014 07:02 AM, DaeSeok Youn wrote:
> Hi, Dan.
>
> 2014-04-25 18:26 GMT+09:00 Dan Carpenter :
>> Mark, maybe you should add yourself to the MAINTAINERS entry for this
>> driver?
>>
I'll look into this. I am clueless on what that would actually mean.
>> On Fri, Apr 25, 2014 at 04:04:59PM
This patch fixes sparse warnings:
warning: Using plain integer as NULL pointer
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/dgap
This patch fixes a sparse warning:
warning: symbol 'dgap_poll_lock' was not declared. Should it be static?
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dga
Oops, ignore this. I got the subject wrong. resending...
Mark
On 04/24/2014 10:31 AM, Mark Hounschell wrote:
> This patch fixes a sparse warning:
>
> warning: symbol 'dgap_poll_lock' was not declared. Should it be static?
>
> Signed-off-by: Mark Hounschell
This patch fixes a sparse warning:
warning: symbol 'dgap_poll_lock' was not declared. Should it be static?
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dga
This patch fixes a few more sparse warnings related to __iomem
Signed-off-by: Mark Hounschell
Tested-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 37 +++--
1 file changed, 19 insertions(+), 18 deletions(-)
diff --git a/drivers
This patch fixes a few misc sparse warnings related to __iomem
Signed-off-by: Mark Hounschell
Tested-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 20 ++--
drivers/staging/dgap/dgap.h | 6 +++---
2 files changed, 13 insertions(+), 13 deletions
This patch fixes sparse warnings for the entire cm_t structure
This entire structure defines a hardware segment
Signed-off-by: Mark Hounschell
Tested-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 8
drivers/staging/dgap/dgap.h | 2 +-
2 files changed, 5
This patch fixes sparse warnings for the entire bs_t structure
This entire structure defines a hardware segment
Signed-off-by: Mark Hounschell
Tested-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 22 +++---
drivers/staging/dgap/dgap.h | 4
This patch fixes sparse warnings for the
re_map_membase and re_map_port variables.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 24
drivers/staging/dgap/dgap.h | 4 ++--
2 files changed, 14 insertions(+), 14 deletions
This patch series fixes 2 different BUGS that didn't
reveal themselves until the 3.15 series started.
patch 1 fixes how we insure the config data
is a string. The original code is clearly
just wrong. After many loads/unloads of the
driver, various OOPs would occure. None of
which indicated this
This patch fixes an OOPS caused by a pointer being
changed between the malloc and free.
Signed-off-by: Mark Hounschell
Tested-by: Mark Hounschell
Reported-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion
This patch changes the way we insure the config data
is a string. Clearly this was just wrong. After a
certain number of loads/unloads various OOPs were
generated indicating something other than this driver
had a problem. It was this driver.
Signed-off-by: Mark Hounschell
Tested-by: Mark
The latest staging tree based on 3.15-rc1 has revealed a bug that I
introduced into the dgap driver way back. Various oops occur when
loading and unloading the driver multiple times in succession. The oops
never actually indicate anything dgap driver related. When I send a
patch to fix the problem,
On 04/15/2014 06:01 AM, Dan Carpenter wrote:
> On Mon, Apr 14, 2014 at 03:17:19PM -0400, Mark Hounschell wrote:
>> On 04/14/2014 11:49 AM, Greg Kroah-Hartman wrote:
>>> On Tue, Mar 25, 2014 at 04:38:14PM -0400, Mark Hounschell wrote:
>>>> The config file is curre
This patch removes the uchar typedef in dgap.h
and changes all uses of it to u8.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 100 ++--
drivers/staging/dgap/dgap.h | 65 ++--
2 files
On 04/14/2014 11:49 AM, Greg Kroah-Hartman wrote:
> On Tue, Mar 25, 2014 at 04:38:14PM -0400, Mark Hounschell wrote:
>> The config file is currently read for each board found.
>> It only needs to be read one time. The buffer it is read
>> into can now be freed immediate
On 04/14/2014 12:00 PM, Greg Kroah-Hartman wrote:
> On Thu, Apr 03, 2014 at 08:57:56AM -0400, Mark Hounschell wrote:
>> This patch removes the uchar define in dgap.h and
>> changes all uses of uchar to u8.
>>
>> Signed-off-by: Mark Hounschell
>> Tested-by: Ma
On 04/03/2014 04:51 AM, Dan Carpenter wrote:
On Tue, Mar 25, 2014 at 04:38:15PM -0400, Mark Hounschell wrote:
This patch fixes a checkpatch warning
"Macros with complex values should be enclosed in parenthesis"
Really this is a bug in checkpatch.pl. We have the source for that, so
On 04/03/2014 04:56 AM, Dan Carpenter wrote:
On Tue, Mar 25, 2014 at 04:38:18PM -0400, Mark Hounschell wrote:
This patch fixes a checkpatch warning about adding typedefs
in dgap.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.h | 2 +-
1 file changed
On 03/28/2014 09:08 AM, Mark Hounschell wrote:
> On 03/28/2014 07:34 AM, Dan Carpenter wrote:
>> These patches are fine and they were applied already.
>>
>> On Wed, Mar 12, 2014 at 12:50:55PM -0400, Mark Hounschell wrote:
>>> @@ -4368,15 +4364,16 @@ static void dg
On 03/28/2014 07:34 AM, Dan Carpenter wrote:
> These patches are fine and they were applied already.
>
> On Wed, Mar 12, 2014 at 12:50:55PM -0400, Mark Hounschell wrote:
>> @@ -4368,15 +4364,16 @@ static void dgap_do_bios_load(struct board_t *brd,
>> uchar _
checkpatch now gives 0 warnings or errors on both dgap.c and dgap.h
so I'm now looking at sparse errors/warnings. There are many and I'm
not really clear as to the best way to address them. This is my first
exposure to sparse. A quick internet search reveals that using "__iomem"
in some way is the
The config file is currently read for each board found.
It only needs to be read one time. The buffer it is read
into can now be freed immediately after it is parsed
instead of at driver unload time.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 18
This patch just fixes a pr_info. brd->state is not proper
at this point in time.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/d
This patch removes excessive empty lines from dgap.h
not previously caught.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.h | 26 --
1 file changed, 26 deletions(-)
diff --git a/drivers/staging/dgap/dgap.h b/drivers/staging/dgap
This patch fixes a checkpatch warning
"Macros with complex values should be enclosed in parenthesis"
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgap/dgap.h
patch 1: remove some extra empty lines not previously caught.
patch 2: the firmware loading provess loads the config file
for each board found. It only needs to load it once.
patch 3: fixes a checkpatch warning about a macro needing parenthesis
patch 4: removes volatiles from dgap.h as rec
This patch fixes a checkpatch warning about adding typedefs
in dgap.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgap/dgap.h b/drivers/staging/dgap/dgap.h
index
This patch fixes checkpatch warnings about using volatiles in dgap.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
Tested-by: Mark Hounschell
---
drivers/staging/dgap/dgap.h | 152 ++--
1 file changed, 76 insertions(+), 76 deletions(-)
diff
This patch fixes some whitespace warnings as reported
by checkpatch in dgap.h.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.h | 47 +++--
1 file changed, 24 insertions(+), 23 deletions(-)
diff --git a/drivers
This patch fixes several 80+ char line warnings as reported
by checkpatch in dgap.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.h | 244 +++-
1 file changed, 129 insertions(+), 115 deletions(-)
diff --git a
This patch removes some unused code in dgap.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.h | 53 -
1 file changed, 53 deletions(-)
diff --git a/drivers/staging/dgap/dgap.h b/drivers/staging/dgap/dgap.h
index
This patch removes some unused code in dgap.c.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index a5fc3c7..ea66c9f 100644
--- a/drivers
This patch removes some unneeded comments from dgap.c
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 29 -
1 file changed, 29 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index ea66c9f
patch 1 removes some unused code in dgap.c
patch 2 removes some unneeded comments in dgap.c
patch 3 fixes some whitespace warnings by checkpatch in dgap.h
patch 4 fixes several 80+ char lines in dgap.h.
Note that many of these 80+ char lines
are lines using "volatile" which also
This patch fixes all the simple_strtol and simple_strtoul warnings
as reported by checkpatch. After this patch, checkpatch will report
zero errors or warnings on dgap.c.
Signed-off-by: Mark Hounschell
Tested-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 69
On 03/19/2014 11:49 AM, Greg Kroah-Hartman wrote:
Your subject [02/xx] seems a bit odd :)
Oops. The xx was there in my patches until I knew how many there would
be in the series. Forgot to change it. Sorry. Want me to redo? Easy enough.
___
devel
patch 1 re-factors some code to fix warnings by
checkpatch about 80+ char lines. This patch was
suggested by Dan Carpenter. A test case for this
patch has been written and used and used to show
the patch to be correct.
patch 2 gets rid of the DGAP_LOCK and DGAP_UNLOCK macros
patch 3 re-factors
This patch replaces the DGAP_LOCK and DGAP_UNLOCK macros with
spin_lock_irqsave spin_unlock_irqrestore.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 442 ++--
drivers/staging/dgap/dgap.h | 7 -
2 files changed
This patch fixes more 80+ char lines as reported by checkpatch
Signed-off-by: Mark Hounschell
Tested-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 40 +---
1 file changed, 25 insertions(+), 15 deletions(-)
diff --git a
This patch re-factors some code to fix some 80+ lines as reported by checkpatch.
This patch was suggested and authored by Dan Carpenter. A test case for this
patch has been written and used to show the patch to be correct.
Suggested-by: Dan Carpenter
Signed-off-by: Mark Hounschell
Tested-by
On 03/07/2014 05:46 PM, Dan Carpenter wrote:
I still prefer my patch. Unless I'm missing something? Could you
review it and I will submit it as a patch tomorrow.
regards,
dan carpenter
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index d00283a226a2..783cd75a2d96 1006
This patch adds a pr_info per board that indicates
board number, type, etc..
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index ddeff5f
This patch removes unused brd->state states previously
used in the userland firmware download process.
Signed-off-by: Mark Hounschell
Tested-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 5 -
drivers/staging/dgap/dgap.h | 17 -
2 fi
This patch removes more unneeded brd-state states
Signed-off-by: Mark Hounschell
Tested-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 35 +--
drivers/staging/dgap/dgap.h | 2 --
2 files changed, 17 insertions(+), 20 deletions
The only driver states we need now is READY or !READY.
No need for a sysfs method of seeing those 2 states so
the sysfs entries for dgap_driver_state is also removed.
Signed-off-by: Mark Hounschell
Tested-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 26
1 - 100 of 238 matches
Mail list logo
