> These results for Toeplitz are not plausible. Given random input you
> cannot expect any hash function to produce such uniform results. I
> suspect either your input data is biased or how your applying the hash
> is.
>
> When I run 64 random IPv4 3-tuples through Toeplitz and Jenkins I get
>
On Wed, 2016-01-13 at 23:10 +, Haiyang Zhang wrote:
> I have done a comparison of the Toeplitz v.s. Jenkins Hash algorithms,
> and found that the Toeplitz provides much better distribution of the
> connections into send-indirection-table entries. See the data below --
> showing how many
> I have done a comparison of the Toeplitz v.s. Jenkins Hash algorithms,
> and found that the Toeplitz provides much better distribution of the
> connections into send-indirection-table entries. See the data below --
> showing how many TCP connections are distributed into each of the
> sixteen
uk.ukuu.org.uk>; David Miller <da...@davemloft.net>;
> vkuzn...@redhat.com; net...@vger.kernel.org; KY Srinivasan
> <k...@microsoft.com>; de...@linuxdriverproject.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH net-next] hv_netvsc: don't make assumptions on
> struct flow_ke
rguk.ukuu.org.uk>
>> Cc: Tom Herbert <t...@herbertland.com>; Haiyang Zhang
>> <haiya...@microsoft.com>; David Miller <da...@davemloft.net>;
>> vkuzn...@redhat.com; net...@vger.kernel.org; KY Srinivasan
>> <k...@microsoft.com>; de...@linuxdriverproject.or
On Thu, 2016-01-14 at 17:53 +, One Thousand Gnomes wrote:
> > These results for Toeplitz are not plausible. Given random input you
> > cannot expect any hash function to produce such uniform results. I
> > suspect either your input data is biased or how your applying the hash
> > is.
> >
> >
nd.com>; Haiyang Zhang
>> >> <haiya...@microsoft.com>; David Miller <da...@davemloft.net>;
>> >> vkuzn...@redhat.com; net...@vger.kernel.org; KY Srinivasan
>> >> <k...@microsoft.com>; de...@linuxdriverproject.org; linux-
>> >> ker...@vge
; One Thousand Gnomes
>> >> <gno...@lxorguk.ukuu.org.uk>; David Miller <da...@davemloft.net>;
>> >> vkuzn...@redhat.com; net...@vger.kernel.org; KY Srinivasan
>> >> <k...@microsoft.com>; de...@linuxdriverproject.org; linux-
>> >> ker...@vge
uk.ukuu.org.uk>; David Miller <da...@davemloft.net>;
> vkuzn...@redhat.com; net...@vger.kernel.org; KY Srinivasan
> <k...@microsoft.com>; de...@linuxdriverproject.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH net-next] hv_netvsc: don't make assumptions on
> struct flow_k
@microsoft.com>; David Miller <da...@davemloft.net>;
> vkuzn...@redhat.com; net...@vger.kernel.org; KY Srinivasan
> <k...@microsoft.com>; de...@linuxdriverproject.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH net-next] hv_netvsc: don't make assumptions on
> struct flow_k
uk.ukuu.org.uk>; David Miller <da...@davemloft.net>;
> vkuzn...@redhat.com; net...@vger.kernel.org; KY Srinivasan
> <k...@microsoft.com>; de...@linuxdriverproject.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH net-next] hv_netvsc: don't make assumptions on
> struct flow_k
From: Tom Herbert
Date: Thu, 14 Jan 2016 13:44:24 -0800
> The fact that we can negatively affect the output of Toeplitz so
> predictably is actually a liability and not a benefit. This sort of
> thing can be the basis of a DOS attack and is why we kicked out XOR
> hash in
On Thu, 2016-01-14 at 20:23 +, Haiyang Zhang wrote:
>
> For non-random inputs, I used the port selection of iperf that increases
> the port number by 2 for each connection. Only send-port numbers are
> different, other values are the same. I also tested some other fixed
> increment,
riverproject.org; linux-
> ker...@vger.kernel.org; eric.duma...@gmail.com
> Subject: Re: [PATCH net-next] hv_netvsc: don't make assumptions on
> struct flow_keys layout
>
> From: Vitaly Kuznetsov <vkuzn...@redhat.com>
> Date: Thu, 7 Jan 2016 10:33:09 +0100
>
> >
From: Haiyang Zhang
Date: Wed, 13 Jan 2016 23:10:57 +
> I have done a comparison of the Toeplitz v.s. Jenkins Hash algorithms,
> and found that the Toeplitz provides much better distribution of the
> connections into send-indirection-table entries.
This fails to
From: Vitaly Kuznetsov
Date: Thu, 7 Jan 2016 10:33:09 +0100
> Recent changes to 'struct flow_keys' (e.g commit d34af823ff40 ("net: Add
> VLAN ID to flow_keys")) introduced a performance regression in netvsc
> driver. Is problem is, however, not the above mentioned commit
t
> <eric.duma...@gmail.com>
> Cc: Tom Herbert <t...@herbertland.com>; net...@vger.kernel.org;
> Haiyang Zhang <haiya...@microsoft.com>; de...@linuxdriverproject.org;
> linux-ker...@vger.kernel.org; David Miller <da...@davemloft.net>
> Subject: Re: [PATCH
@vger.kernel.org; KY
> Srinivasan <k...@microsoft.com>; Haiyang Zhang <haiya...@microsoft.com>;
> de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; David Miller
> <da...@davemloft.net>
> Subject: Re: [PATCH net-next] hv_netvsc: don't make assumptions on
> stru
On Thu, Jan 7, 2016 at 4:52 AM, Eric Dumazet wrote:
> On Thu, 2016-01-07 at 10:33 +0100, Vitaly Kuznetsov wrote:
>> Recent changes to 'struct flow_keys' (e.g commit d34af823ff40 ("net: Add
>> VLAN ID to flow_keys")) introduced a performance regression in netvsc
>> driver.
On 16-01-07 05:28 AM, Vitaly Kuznetsov wrote:
> Eric Dumazet writes:
>
>> On Thu, 2016-01-07 at 10:33 +0100, Vitaly Kuznetsov wrote:
>>> Recent changes to 'struct flow_keys' (e.g commit d34af823ff40 ("net: Add
>>> VLAN ID to flow_keys")) introduced a performance
On Thu, 2016-01-07 at 10:33 +0100, Vitaly Kuznetsov wrote:
> Recent changes to 'struct flow_keys' (e.g commit d34af823ff40 ("net: Add
> VLAN ID to flow_keys")) introduced a performance regression in netvsc
> driver. Is problem is, however, not the above mentioned commit but the
> fact that
Herbert <t...@herbertland.com>; net...@vger.kernel.org; KY
> Srinivasan <k...@microsoft.com>; Haiyang Zhang <haiya...@microsoft.com>;
> de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; David Miller
> <da...@davemloft.net>
> Subject: Re: [PATCH
rnel.org; David Miller
>> <da...@davemloft.net>
>> Subject: Re: [PATCH net-next] hv_netvsc: don't make assumptions on struct
>> flow_keys layout
>>
>> On 16-01-07 05:28 AM, Vitaly Kuznetsov wrote:
>>> Eric Dumazet <eric.duma...@gmail.com> writes:
>&
23 matches
Mail list logo