thub?
Thanks,
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Would be interested if there is any measureable difference in performance
from this change.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing lis
ccepted.
Erik
--
------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Erik de Castro Lopo wrote:
> Hopefull the final release candidate:
>
> http://mega-nerd.com/tmp/flac-1.3.3rc3.tar.xz
> http://mega-nerd.com/tmp/flac-1.3.3rc3.tar.xz.asc
I am assuming everyone was happy with that and that I can release
a new version.
Erik de Castro Lopo wrote:
Hopefull the final release candidate:
http://mega-nerd.com/tmp/flac-1.3.3rc3.tar.xz
http://mega-nerd.com/tmp/flac-1.3.3rc3.tar.xz.asc
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com
I will roll one more pre-release, probably today.
Erik
--
------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Erik de Castro Lopo wrote:
> Which build system are your using? Any chance of a patch?
I just checked, and the autotool build system should just do the
right thing on Solaris. Maybe you are using the CMake build
system and should try the other one.
E
s only added for Linux whereas it would be better to
> check
> on all operating systems if the function is in librt.
Which build system are your using? Any chance of a patch?
Erik
--
----------
Erik de
Erik de Castro Lopo wrote:
> I have a new pre-reelase (with a GPG signature) up here:
New version:
http://mega-nerd.com/tmp/flac-1.3.3rc2.tar.xz
http://mega-nerd.com/tmp/flac-1.3.3rc2.tar.xz.asc
Erik
--
--
Erik
27;PACKAGE_VERSION="1.3.3rc1"' in
> src/libFLAC/libFLAC_dynamic.vcxproj and libFLAC_static.vcxproj.
Never mind, I responded before the coffee had kicked in.
I can do that.
Erik
--
--
Erik de Castro Lopo
http://ww
Erik de Castro Lopo wrote:
> Janne Hyvärinen wrote:
>
> > Minor changes needed for Visual Studio as the version is defined in the
> > project files.
> >
> > Replace 'PACKAGE_VERSION=\"1.3.2\"' with
> > 'PACKAGE_VERSION
verifying if any hand edit I do is correct.
For that reason I reall do need a proper diff. Sorry,
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
ull release within a week.
Cheers,
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
BT and/or IC ?
> Do I need to get permission from you?
As long as you abide by the license, you do not ned to ask for
permission from me or anyone else.
Cheers,
Erik
--
----------
Erik de Castro Lopo
http://www.m
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
e possible to compile libFLAC as UWP.
Was submitted via github and has been merged.
Thanks!
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
f
hanks!
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
lvqcl wrote:
> There was a fix for a bug in MSVC 2015 update2:
> https://github.com/xiph/flac/commit/94a61241b02064c7d9fe508f72a742f2a90b8492
Applied, thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-ne
ved.
Erik
--
------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
e ?
That is more than sufficient.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
mind).
> My proposal is to not generate it by default (with libFLAC) for a
> non-ogg target.
Hmm, I'm a little wary of changing the behaviour after FLAC has be in
the wild and widely used. I'll take a look at other options when I
look at the PR.
Cheers,
Erik
--
-------
t vorbis comment is part of the official
specfication of FLAC and hence should probably not even be made optional.
You can probably avoid it by using the library directly instead of using
the flac command line program.
Erik
--
--------
ization from
> "init_stream_internal_" into a new "FLAC__stream_encoder_restart" function.
I would theoretically accept a patch that allows direct access to the
functionality you seek, as long as it doesn't change the existing API.
Erik
--
ll compile for that as is.
Erik
--
------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Baoshan Sheng wrote:
> After upgraded to 1.3.2, when compiling using Xcode, I received many errors
> on `#if ... FLAC__HAS_X86INTRIN` lines. I noticed the `defined` before
> `FLAC__HAS_X86INTRIN` is removed by contributor Erik de Castro Lopo.
>
> Could someone provide a way to c
e FLAC to encode.
If you can test with normal music signals and still see the same
results then you may get some more interest.
Erik
--
------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
tating
the code with a comment to tell the compiler that the fall through
is intentional.
I'll install gcc 7 and fix these ASAP.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
__
lvqcl,
I would appreciate it if you could have a look at this PR on Github.
It updates the file `lpc_intrin_sse.c`.
https://github.com/xiph/flac/pull/33
Cheers,
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com
Ruud van Asseldonk wrote:
> Here you go.
Wonderful. Thank you!
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
h
frame, minus the number of wasted bits per sample of
> the subframe (and possibly plus one for a difference channel).
>
> I hope this helps future implementers.
I would love to see a patch against the documentation for this.
Erik
--
--------
g unless someone actually runs into the problem.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Erik de Castro Lopo wrote:
> > Notice the warning was given only for the WAVE file produced by the
> > flac reference executable.
>
> I agree. The flac decoder should not generate WAV files which it
> warns about when encoding.
Fixed
nt.
Erik
--
------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
m that is part of
https://mega-nerd.com/libsndfile/
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
lex than that.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Michael W. Bombardieri wrote:
> The --sign option in flac can be signed or unsigned,
> but the error message mentions "uint32_t".
Applied. Thanks.
Erik
--
----------
Erik de Castro Lopo
http://w
lvqcl wrote:
> The attached patch fixes a few typos.
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
h
Olivier Tristan wrote:
> Please find attached a patch that fixes the OSX build with llvm
> only __asm__ is supported but GCC support both so it's not an issue using
> this one AFAIK.
Applied. Thanks.
Erik
--
------
Olivier Tristan wrote:
> Here is a patch that fixes the issue.
>
> There are multiple way to fix it though.
Applied. Thanks.
Erik
--
------
Erik de Castro Lopo
http://www.mega
hanks.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
lvqcl wrote:
>
> The patch is attached.
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xi
lvqcl wrote:
>
> Ok, will do it, but currently xiph git still contains old code.
Sorry, should be updated now.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
fl
sn't very useful before, and now it's
> even less useful. I don't see a reason to keep it.
Sorry, this patch fails to apply on top of the others. Would
you be able to rebase against what's currently in the tree?
Thanks,
Erik
--
--------
open parenthesis because its easier to read.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
ied. Thanks.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Applied. Thanks.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
lvqcl wrote:
> This patch adds const to some variables, to make code slightly easier to
> read.
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
__
lvqcl wrote:
> Maybe it's simpler to add
>
> #ifndef __has_attribute
> #define __has_attribute(x) 0
> #endif
Good suggestion. Seems to work. Current PR is here:
https://github.com/xiph/flac/pull/30
Erik
--
------
r__ >= 6)) /* clang */
which I have tested with clang 3.6. If someone has an earlier version
of clang and can verify that it work, I'll drop the version number.
Erik
--
------
Erik de Castro Lopo
http://www.mega-nerd.com/
> is ok for GCC because "defined __clang__" is false and
> preprocessor shouldn't try to parse "__has_attribute(...)" part.
I agree. I would call that error a compiler bug.
Erik
--
--
Erik de Cast
such as vpabsd/vpaddd/vphaddd, so
> this function was compiled properly.
Thanks. Patch applied.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev ma
Erik de Castro Lopo wrote:
> What am I looking for? Is posting the before and after versions
> sufficient?
Disassembly of the object files (before and after) is here:
http://mega-nerd.com/tmp/stream_encoder_intrin_avx2-before.txt
http://mega-nerd.com/tmp/stream_encoder_intri
give consistent results.
> Or at least, dows it affect disassembly of functions
> such as FLAC__precompute_partition_info_sums_intrin_avx2()?
What am I looking for? Is posting the before and after versions
sufficient?
Erik
--
--------
hanks.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
ARTIST=Chuck_Woolery
ARTIST=Vern
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
David Seifert wrote:
> ---
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mail
s mean that `-O2` and `-O3` will end up in CFLAGS?
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
lvqcl wrote:
> This patch fixes bracket placement, extra space, etc
> in lpc_intrin_sse2.c and lpc_intrin_sse41.c
Both patches applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-ne
ainer.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
ebug this.
The command line you provided is importing tags from stdin and you haven't
provided the data that is being fed into metaflac's stdin.
Erik
--
----------
Erik de Castro Lopo
lvqcl wrote:
> Description: redefine inline as __inline only for C, not for C++.
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing l
06170.html
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Ozkan Sezer wrote:
> Anyways, with the changed exports.h patch, every need should
> be met now..
Sorry, which patch is that?
Erik
--
--
Erik de Castro Lopo
http://www.mega-ne
.
Please provide the command that causes this. It would also be useful
if you could make the cue sheet available.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
hanks.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
| 4 ++--
> src/test_libFLAC/encoders.c | 8
> 7 files changed, 16 insertions(+), 15 deletions(-)
Applied. minus the incorrect fix to charset.c.
Erik
--
----------
Erik de Castro Lopo
*to = newbuf ? newbuf : tobuf;
> +free(newbuf);
That bit is not actually correct. I've corrected that idependently.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
__
s.
Cheers,
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
| 4 ++--
> src/test_libFLAC/encoders.c | 8
> 7 files changed, 16 insertions(+), 15 deletions(-)
Interesting! What version of cppcheck are you running? With what
options? I currently run cppcheck over FLAC in CI.
Erik
--
---------
lvqcl wrote:
> Thanks. But I can't see new file share/msvc2005_int.h in
> the current git snapshot.
Yeah, fixed in a later commit. This is why I prefer git patches
over plain diffs :).
Erik
--
------
Erik de Castr
Studio compilers with _MSC_VER < 1600 (i.e. MSVS 2005 and 2008).
Thats a really great solution to this problem. Applied!
Cheers,
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
__
David Seifert wrote:
> ---
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mail
; type, not
> 'unsigned int' or 'uint32_t'.
Applied. Thanks.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
view.html
MD5SUM is of the un-encoded audio data and of the whole stream.
Erik
--
------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists
lvqcl wrote:
> Ok, Visual Studio doesn't complain if idx is declared as uint32_t.
As expected :).
Erik
--
------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mail
use unsigned long variable there.
Sorry, I disagree on the idea of using `unsigned long` exactly because
anyone that comes from Unix will assume that is `uint64_t`. Better to
use `uint32_t` which is totally platform independant and unambiguous.
Erik
--
-
loops` which from memory provides a
significant boost in encoding/decoding speed.
What's the best way to fix all this stuff but still turning
`-funroll-loops` be default?
Erik
--
----------
Erik de Castro Lopo
http://
OS is WinRT/non-desktop?
And I defer to others like lvqcl for what we do and do not
support on Windows.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailin
ied. Thanks.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
working.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
David Seifert wrote:
> * This is required, as otherwise -Wl,--as-needed could fail.
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mail
David Seifert wrote:
> ---
> Makefile.am | 6 +-
> configure.ac | 5 +
> 2 files changed, 10 insertions(+), 1 deletion(-)
Applied. Thanks.
Erik
--
----------
Erik de Castro Lopo
http://www.m
lation paths for the
> documentation that differ from what is currently coded in the various
> Makefile.am's.
Thanks for these David. I'll have a look.
Erik
--
----------
Erik de Castro L
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
ous we
*want* that to be a compile error!
> Other than that, it compiles everything without errors.
Thanks!
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing l
Ozkan Sezer wrote:
> Attached patch works around for DJGPP missing wcswidth()
> in flac/utils.c:strlen_console()
Applied, thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-ne
Ozkan Sezer wrote:
> Attached patch adds support nasm coff obj format for djgpp
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing l
ll I've just pushed a patch that purges the code base of `unsigned`.
Please test and let us know how it goes.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev
sn't.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Peter Korsgaard wrote:
> Not all linux hosts match the *-pc-linux-gnu wildcard, causing build
> failures for older glibc versions where we need to link with -lrt for
> clock_gettime - E.G.:
Applied. Thanks.
Erik
--
-----
Christian Weisgerber wrote:
> FWIW, here's a minimal fix to deal with this.
Applied. Thanks.
Erik
--
------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing l
lvqcl.mail wrote:
> Erik de Castro Lopo wrote:
>
> > This fix probably warrants a new release, but I'll hold off for a
> > week or so to make sure nothing else needs fixing.
>
> Speaking of which... the attched patch fixes building when UNICODE
> preprocessor
t.
Erik
--
------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Ozkan Sezer wrote:
> Also, the xiph downloads page https://xiph.org/downloads/ still lists
> 1.3.1 for flac download.
Thats a different issue that I'm still chasing.
Erik
--
------
Erik de Castro Lopo
http://www.me
ac/ site is missing the
1.3.2 files.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
to make sure nothing else needs fixing.
Thanks,
Erik
--
------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listi
ifferent matter.
Erik
--
------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
and CPU was this?
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
1 - 100 of 1117 matches
Mail list logo