Re: [flac-dev] Possible overflow of _candidate_bits in stream_encoder.c

2020-07-08 Thread Erik de Castro Lopo
thub? Thanks, Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] Possible overflow of _candidate_bits in stream_encoder.c

2020-07-06 Thread Erik de Castro Lopo
Would be interested if there is any measureable difference in performance from this change. Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing lis

Re: [flac-dev] Mid-Stream Meta Data Updates for ICEcast

2019-08-29 Thread Erik de Castro Lopo
ccepted. Erik -- ------ Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] Prelease now available

2019-07-19 Thread Erik de Castro Lopo
Erik de Castro Lopo wrote: > Hopefull the final release candidate: > > http://mega-nerd.com/tmp/flac-1.3.3rc3.tar.xz > http://mega-nerd.com/tmp/flac-1.3.3rc3.tar.xz.asc I am assuming everyone was happy with that and that I can release a new version.

Re: [flac-dev] Prelease now available

2019-07-17 Thread Erik de Castro Lopo
Erik de Castro Lopo wrote: Hopefull the final release candidate: http://mega-nerd.com/tmp/flac-1.3.3rc3.tar.xz http://mega-nerd.com/tmp/flac-1.3.3rc3.tar.xz.asc Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com

Re: [flac-dev] Prelease now available

2019-07-16 Thread Erik de Castro Lopo
I will roll one more pre-release, probably today. Erik -- ------ Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] Prelease now available

2019-07-16 Thread Erik de Castro Lopo
Erik de Castro Lopo wrote: > Which build system are your using? Any chance of a patch? I just checked, and the autotool build system should just do the right thing on Solaris. Maybe you are using the CMake build system and should try the other one. E

Re: [flac-dev] Prelease now available

2019-07-15 Thread Erik de Castro Lopo
s only added for Linux whereas it would be better to > check > on all operating systems if the function is in librt. Which build system are your using? Any chance of a patch? Erik -- ---------- Erik de

Re: [flac-dev] Prelease now available

2019-07-14 Thread Erik de Castro Lopo
Erik de Castro Lopo wrote: > I have a new pre-reelase (with a GPG signature) up here: New version: http://mega-nerd.com/tmp/flac-1.3.3rc2.tar.xz http://mega-nerd.com/tmp/flac-1.3.3rc2.tar.xz.asc Erik -- -- Erik

Re: [flac-dev] Prelease now available

2019-07-14 Thread Erik de Castro Lopo
27;PACKAGE_VERSION="1.3.3rc1"' in > src/libFLAC/libFLAC_dynamic.vcxproj  and libFLAC_static.vcxproj. Never mind, I responded before the coffee had kicked in. I can do that. Erik -- -- Erik de Castro Lopo http://ww

Re: [flac-dev] Prelease now available

2019-07-14 Thread Erik de Castro Lopo
Erik de Castro Lopo wrote: > Janne Hyvärinen wrote: > > > Minor changes needed for Visual Studio as the version is defined in the > > project files. > > > > Replace 'PACKAGE_VERSION=\"1.3.2\"' with > > 'PACKAGE_VERSION

Re: [flac-dev] Prelease now available

2019-07-14 Thread Erik de Castro Lopo
verifying if any hand edit I do is correct. For that reason I reall do need a proper diff. Sorry, Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

[flac-dev] Prelease now available

2019-07-13 Thread Erik de Castro Lopo
ull release within a week. Cheers, Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] Inquiry about use case

2019-06-19 Thread Erik de Castro Lopo
BT and/or IC ? > Do I need to get permission from you? As long as you abide by the license, you do not ned to ask for permission from me or anyone else. Cheers, Erik -- ---------- Erik de Castro Lopo http://www.m

[flac-dev] Proposal to remove the Visual Studio project files

2019-04-29 Thread Erik de Castro Lopo
-- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] [PATCH] move CreateFile() function from libFLAC

2018-08-18 Thread Erik de Castro Lopo
e possible to compile libFLAC as UWP. Was submitted via github and has been merged. Thanks! Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list f

Re: [flac-dev] [PATCH] Fix more GCC warnings about case fall-through

2018-05-05 Thread Erik de Castro Lopo
hanks! Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] [PATCH] More generic version of MSVC bug workaround

2018-05-05 Thread Erik de Castro Lopo
lvqcl wrote: > There was a fix for a bug in MSVC 2015 update2: > https://github.com/xiph/flac/commit/94a61241b02064c7d9fe508f72a742f2a90b8492 Applied, thanks. Erik -- -- Erik de Castro Lopo http://www.mega-ne

Re: [flac-dev] Question: MSVS 2005/2008 support?

2018-05-03 Thread Erik de Castro Lopo
ved. Erik -- ------ Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] Using FLAC encoder in my software

2018-02-28 Thread Erik de Castro Lopo
e ? That is more than sufficient. Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] libFLAC optimizations request

2018-02-08 Thread Erik de Castro Lopo
mind). > My proposal is to not generate it by default (with libFLAC) for a > non-ogg target. Hmm, I'm a little wary of changing the behaviour after FLAC has be in the wild and widely used. I'll take a look at other options when I look at the PR. Cheers, Erik -- -------

Re: [flac-dev] libFLAC optimizations request

2018-02-03 Thread Erik de Castro Lopo
t vorbis comment is part of the official specfication of FLAC and hence should probably not even be made optional. You can probably avoid it by using the library directly instead of using the flac command line program. Erik -- --------

Re: [flac-dev] libFLAC optimizations request

2018-02-03 Thread Erik de Castro Lopo
ization from > "init_stream_internal_" into a new "FLAC__stream_encoder_restart" function. I would theoretically accept a patch that allows direct access to the functionality you seek, as long as it doesn't change the existing API. Erik --

Re: [flac-dev] FLAC Port on to Cortex-M7

2017-12-16 Thread Erik de Castro Lopo
ll compile for that as is. Erik -- ------ Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] Build failed on macOS after upgrade to 1.3.2

2017-09-13 Thread Erik de Castro Lopo
Baoshan Sheng wrote: > After upgraded to 1.3.2, when compiling using Xcode, I received many errors > on `#if ... FLAC__HAS_X86INTRIN` lines. I noticed the `defined` before > `FLAC__HAS_X86INTRIN` is removed by contributor Erik de Castro Lopo. > > Could someone provide a way to c

Re: [flac-dev] FLAC compression experiment

2017-08-19 Thread Erik de Castro Lopo
e FLAC to encode. If you can test with normal music signals and still see the same results then you may get some more interest. Erik -- ------ Erik de Castro Lopo http://www.mega-nerd.com/ ___

Re: [flac-dev] GCC7: -Wimplicit-fallthrough

2017-06-26 Thread Erik de Castro Lopo
tating the code with a comment to tell the compiler that the fall through is intentional. I'll install gcc 7 and fix these ASAP. Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ __

[flac-dev] PR on Github

2017-06-24 Thread Erik de Castro Lopo
lvqcl, I would appreciate it if you could have a look at this PR on Github. It updates the file `lpc_intrin_sse.c`. https://github.com/xiph/flac/pull/33 Cheers, Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com

Re: [flac-dev] [PATCH] doc: Add notes about subframe sample size

2017-06-12 Thread Erik de Castro Lopo
Ruud van Asseldonk wrote: > Here you go. Wonderful. Thank you! Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org h

Re: [flac-dev] [Cellar] FLAC Markdown

2017-06-07 Thread Erik de Castro Lopo
frame, minus the number of wasted bits per sample of > the subframe (and possibly plus one for a difference channel). > > I hope this helps future implementers. I would love to see a patch against the documentation for this. Erik -- --------

Re: [flac-dev] warning that legacy WAVE file has format type 1 but bits-per-sample is 24

2017-05-27 Thread Erik de Castro Lopo
g unless someone actually runs into the problem. Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] warning that legacy WAVE file has format type 1 but bits-per-sample is 24

2017-05-27 Thread Erik de Castro Lopo
Erik de Castro Lopo wrote: > > Notice the warning was given only for the WAVE file produced by the > > flac reference executable. > > I agree. The flac decoder should not generate WAV files which it > warns about when encoding. Fixed

Re: [flac-dev] warning that legacy WAVE file has format type 1 but bits-per-sample is 24

2017-05-26 Thread Erik de Castro Lopo
nt. Erik -- ------ Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] warning that legacy WAVE file has format type 1 but bits-per-sample is 24

2017-05-26 Thread Erik de Castro Lopo
m that is part of https://mega-nerd.com/libsndfile/ Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] libFLAC with Android NDK: use of undeclared identifier 'SIZE_MAX'

2017-05-03 Thread Erik de Castro Lopo
Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

[flac-dev] Windows Universal Platform?

2017-04-19 Thread Erik de Castro Lopo
-- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] FLAC decoding

2017-04-18 Thread Erik de Castro Lopo
lex than that. Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] error message for flac --sign

2017-04-16 Thread Erik de Castro Lopo
Michael W. Bombardieri wrote: > The --sign option in flac can be signed or unsigned, > but the error message mentions "uint32_t". Applied. Thanks. Erik -- ---------- Erik de Castro Lopo http://w

Re: [flac-dev] [PATCH] some typos in header files.

2017-03-20 Thread Erik de Castro Lopo
lvqcl wrote: > The attached patch fixes a few typos. Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org h

Re: [flac-dev] [PATCH] fix LLVM compile

2017-03-01 Thread Erik de Castro Lopo
Olivier Tristan wrote: > Please find attached a patch that fixes the OSX build with llvm > only __asm__ is supported but GCC support both so it's not an issue using > this one AFAIK. Applied. Thanks. Erik -- ------

Re: [flac-dev] Flac build issue in debug win x32

2017-02-23 Thread Erik de Castro Lopo
Olivier Tristan wrote: > Here is a patch that fixes the issue. > > There are multiple way to fix it though. Applied. Thanks. Erik -- ------ Erik de Castro Lopo http://www.mega

Re: [flac-dev] [PATCH 6/5] comments in stream_decoder.c

2017-02-21 Thread Erik de Castro Lopo
hanks. Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] [PATCH 5/5] SIMD: remove outdated SSE2 code

2017-02-21 Thread Erik de Castro Lopo
lvqcl wrote: > > The patch is attached. Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xi

Re: [flac-dev] [PATCH 5/5] SIMD: remove outdated SSE2 code

2017-02-20 Thread Erik de Castro Lopo
lvqcl wrote: > > Ok, will do it, but currently xiph git still contains old code. Sorry, should be updated now. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ fl

Re: [flac-dev] [PATCH 5/5] SIMD: remove outdated SSE2 code

2017-02-19 Thread Erik de Castro Lopo
sn't very useful before, and now it's > even less useful. I don't see a reason to keep it. Sorry, this patch fails to apply on top of the others. Would you be able to rebase against what's currently in the tree? Thanks, Erik -- --------

Re: [flac-dev] [PATCH 2/5] SIMD: remove extra space

2017-02-19 Thread Erik de Castro Lopo
open parenthesis because its easier to read. Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] [PATCH 4/5] SIMD: accelerate decoding of 16-bit FLAC

2017-02-19 Thread Erik de Castro Lopo
ied. Thanks. Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] [PATCH 3/5] SIMD: accelerate decoding of some 24-bit FLAC

2017-02-19 Thread Erik de Castro Lopo
Applied. Thanks. Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] [PATCH 1/5] SIMD: add const qualifier

2017-02-19 Thread Erik de Castro Lopo
lvqcl wrote: > This patch adds const to some variables, to make code slightly easier to > read. Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ __

Re: [flac-dev] about "cpu.h: Fix compiler detection" patch

2017-02-17 Thread Erik de Castro Lopo
lvqcl wrote: > Maybe it's simpler to add > > #ifndef __has_attribute > #define __has_attribute(x) 0 > #endif Good suggestion. Seems to work. Current PR is here: https://github.com/xiph/flac/pull/30 Erik -- ------

Re: [flac-dev] about "cpu.h: Fix compiler detection" patch

2017-02-16 Thread Erik de Castro Lopo
r__ >= 6)) /* clang */ which I have tested with clang 3.6. If someone has an earlier version of clang and can verify that it work, I'll drop the version number. Erik -- ------ Erik de Castro Lopo http://www.mega-nerd.com/

Re: [flac-dev] about "cpu.h: Fix compiler detection" patch

2017-02-15 Thread Erik de Castro Lopo
> is ok for GCC because "defined __clang__" is false and > preprocessor shouldn't try to parse "__has_attribute(...)" part. I agree. I would call that error a compiler bug. Erik -- -- Erik de Cast

Re: [flac-dev] [PATCH] cpu.h: add defines for clang

2017-02-12 Thread Erik de Castro Lopo
such as vpabsd/vpaddd/vphaddd, so > this function was compiled properly. Thanks. Patch applied. Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev ma

Re: [flac-dev] [PATCH] cpu.h: add defines for clang

2017-02-11 Thread Erik de Castro Lopo
Erik de Castro Lopo wrote: > What am I looking for? Is posting the before and after versions > sufficient? Disassembly of the object files (before and after) is here: http://mega-nerd.com/tmp/stream_encoder_intrin_avx2-before.txt http://mega-nerd.com/tmp/stream_encoder_intri

Re: [flac-dev] [PATCH] cpu.h: add defines for clang

2017-02-11 Thread Erik de Castro Lopo
give consistent results. > Or at least, dows it affect disassembly of functions > such as FLAC__precompute_partition_info_sums_intrin_avx2()? What am I looking for? Is posting the before and after versions sufficient? Erik -- --------

Re: [flac-dev] [PATCH] Fix compile with cygwin

2017-02-09 Thread Erik de Castro Lopo
hanks. Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] Re-release of version 1.3.2?

2017-02-06 Thread Erik de Castro Lopo
ARTIST=Chuck_Woolery ARTIST=Vern -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] [PATCH] Clean up CFLAGS detecting code and add AX macro for _FORTIFY_SOURCE

2017-02-06 Thread Erik de Castro Lopo
David Seifert wrote: > --- Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mail

Re: [flac-dev] [PATCH] Clean up CFLAGS detecting code and add AX macro for _FORTIFY_SOURCE

2017-02-05 Thread Erik de Castro Lopo
s mean that `-O2` and `-O3` will end up in CFLAGS? Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] [PATCH 1/2] for lpc_intrin_sseNN.c

2017-01-31 Thread Erik de Castro Lopo
lvqcl wrote: > This patch fixes bracket placement, extra space, etc > in lpc_intrin_sse2.c and lpc_intrin_sse41.c Both patches applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-ne

Re: [flac-dev] Flac multi channel

2017-01-28 Thread Erik de Castro Lopo
ainer. Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] metaflac crashes adding cuesheet

2017-01-24 Thread Erik de Castro Lopo
ebug this. The command line you provided is importing tags from stdin and you haven't provided the data that is being fed into metaflac's stdin. Erik -- ---------- Erik de Castro Lopo

Re: [flac-dev] [PATCH] for compat.h

2017-01-23 Thread Erik de Castro Lopo
lvqcl wrote: > Description: redefine inline as __inline only for C, not for C++. Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing l

Re: [flac-dev] os/2 support using Watcom

2017-01-23 Thread Erik de Castro Lopo
06170.html Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] os/2 support using Watcom

2017-01-23 Thread Erik de Castro Lopo
Ozkan Sezer wrote: > Anyways, with the changed exports.h patch, every need should > be met now.. Sorry, which patch is that? Erik -- -- Erik de Castro Lopo http://www.mega-ne

Re: [flac-dev] metaflac crashes adding cuesheet

2017-01-23 Thread Erik de Castro Lopo
. Please provide the command that causes this. It would also be useful if you could make the cue sheet available. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] [PATCH 1/2] Do not override CFLAGS, as CFLAGS is a user flag.

2017-01-19 Thread Erik de Castro Lopo
hanks. Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] [PATCH] Fix cppcheck warnings

2017-01-19 Thread Erik de Castro Lopo
| 4 ++-- > src/test_libFLAC/encoders.c | 8 > 7 files changed, 16 insertions(+), 15 deletions(-) Applied. minus the incorrect fix to charset.c. Erik -- ---------- Erik de Castro Lopo

Re: [flac-dev] [PATCH] Fix cppcheck warnings

2017-01-19 Thread Erik de Castro Lopo
*to = newbuf ? newbuf : tobuf; > +free(newbuf); That bit is not actually correct. I've corrected that idependently. Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ __

Re: [flac-dev] [PATCH] Fix cppcheck warnings

2017-01-19 Thread Erik de Castro Lopo
s. Cheers, Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] [PATCH] Fix cppcheck warnings

2017-01-18 Thread Erik de Castro Lopo
| 4 ++-- > src/test_libFLAC/encoders.c | 8 > 7 files changed, 16 insertions(+), 15 deletions(-) Interesting! What version of cppcheck are you running? With what options? I currently run cppcheck over FLAC in CI. Erik -- ---------

Re: [flac-dev] [PATCH] fix MSVC 2005/2008 build

2017-01-18 Thread Erik de Castro Lopo
lvqcl wrote: > Thanks. But I can't see new file share/msvc2005_int.h in > the current git snapshot. Yeah, fixed in a later commit. This is why I prefer git patches over plain diffs :). Erik -- ------ Erik de Castr

Re: [flac-dev] [PATCH] fix MSVC 2005/2008 build

2017-01-18 Thread Erik de Castro Lopo
Studio compilers with _MSC_VER < 1600 (i.e. MSVS 2005 and 2008). Thats a really great solution to this problem. Applied! Cheers, Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ __

Re: [flac-dev] [PATCH 2/2] Only compile and run tests when running 'make check'

2017-01-17 Thread Erik de Castro Lopo
David Seifert wrote: > --- Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mail

Re: [flac-dev] [PATCH] fix getopt.c

2017-01-16 Thread Erik de Castro Lopo
; type, not > 'unsigned int' or 'uint32_t'. Applied. Thanks. Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] How is the MD5 hash calculated?

2017-01-16 Thread Erik de Castro Lopo
view.html MD5SUM is of the un-encoded audio data and of the whole stream. Erik -- ------ Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists

Re: [flac-dev] unsigned int and FLAC__uint32 are used interchangeably

2017-01-14 Thread Erik de Castro Lopo
lvqcl wrote: > Ok, Visual Studio doesn't complain if idx is declared as uint32_t. As expected :). Erik -- ------ Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mail

Re: [flac-dev] unsigned int and FLAC__uint32 are used interchangeably

2017-01-14 Thread Erik de Castro Lopo
use unsigned long variable there. Sorry, I disagree on the idea of using `unsigned long` exactly because anyone that comes from Unix will assume that is `uint64_t`. Better to use `uint32_t` which is totally platform independant and unambiguous. Erik -- -

Re: [flac-dev] [PATCH 1/4] Do not override CFLAGS, as CFLAGS is a user flag.

2017-01-14 Thread Erik de Castro Lopo
loops` which from memory provides a significant boost in encoding/decoding speed. What's the best way to fix all this stuff but still turning `-funroll-loops` be default? Erik -- ---------- Erik de Castro Lopo http://

Re: [flac-dev] [PATCH 0/5] Allow multiple targets to be disabled

2017-01-14 Thread Erik de Castro Lopo
OS is WinRT/non-desktop? And I defer to others like lvqcl for what we do and do not support on Windows. Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailin

Re: [flac-dev] [PATCH] add missing string.h include to cpu.c (for memset())

2017-01-14 Thread Erik de Castro Lopo
ied. Thanks. Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] [PATCH 3/4] Honor user's $(htmldir) and do not override GNU defaults for $(docdir)

2017-01-14 Thread Erik de Castro Lopo
working. Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] [PATCH 4/4] When using libtool, use LTLIBICONV instead.

2017-01-14 Thread Erik de Castro Lopo
David Seifert wrote: > * This is required, as otherwise -Wl,--as-needed could fail. Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mail

Re: [flac-dev] [PATCH 2/4] Make building/installing examples optional

2017-01-14 Thread Erik de Castro Lopo
David Seifert wrote: > --- > Makefile.am | 6 +- > configure.ac | 5 + > 2 files changed, 10 insertions(+), 1 deletion(-) Applied. Thanks. Erik -- ---------- Erik de Castro Lopo http://www.m

Re: [flac-dev] Upstreaming Gentoo patches

2017-01-14 Thread Erik de Castro Lopo
lation paths for the > documentation that differ from what is currently coded in the various > Makefile.am's. Thanks for these David. I'll have a look. Erik -- ---------- Erik de Castro L

Re: [flac-dev] unsigned int and FLAC__uint32 are used interchangeably

2017-01-14 Thread Erik de Castro Lopo
Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] unsigned int and FLAC__uint32 are used interchangeably

2017-01-14 Thread Erik de Castro Lopo
ous we *want* that to be a compile error! > Other than that, it compiles everything without errors. Thanks! Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing l

Re: [flac-dev] [PATCH] workaround for DJGPP missing wcswidth()

2017-01-13 Thread Erik de Castro Lopo
Ozkan Sezer wrote: > Attached patch works around for DJGPP missing wcswidth() > in flac/utils.c:strlen_console() Applied, thanks. Erik -- -- Erik de Castro Lopo http://www.mega-ne

Re: [flac-dev] [PATCH] support nasm coff obj format for djgpp

2017-01-13 Thread Erik de Castro Lopo
Ozkan Sezer wrote: > Attached patch adds support nasm coff obj format for djgpp Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing l

Re: [flac-dev] unsigned int and FLAC__uint32 are used interchangeably

2017-01-13 Thread Erik de Castro Lopo
ll I've just pushed a patch that purges the code base of `unsigned`. Please test and let us know how it goes. Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev

Re: [flac-dev] unsigned int and FLAC__uint32 are used interchangeably

2017-01-13 Thread Erik de Castro Lopo
sn't. Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] [PATCH] configure.ac: relax linux OS detection

2017-01-13 Thread Erik de Castro Lopo
Peter Korsgaard wrote: > Not all linux hosts match the *-pc-linux-gnu wildcard, causing build > failures for older glibc versions where we need to link with -lrt for > clock_gettime - E.G.: Applied. Thanks. Erik -- -----

Re: [flac-dev] 1.3.2: FLAC__CPUINFO_IA32_CPUID_SSE3 undeclared

2017-01-13 Thread Erik de Castro Lopo
Christian Weisgerber wrote: > FWIW, here's a minimal fix to deal with this. Applied. Thanks. Erik -- ------ Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing l

Re: [flac-dev] [PATCH] fix compile in MSVC if UNICODE is defined (SF bug 447)

2017-01-03 Thread Erik de Castro Lopo
lvqcl.mail wrote: > Erik de Castro Lopo wrote: > > > This fix probably warrants a new release, but I'll hold off for a > > week or so to make sure nothing else needs fixing. > > Speaking of which... the attched patch fixes building when UNICODE > preprocessor

Re: [flac-dev] FLAC 1.3.2 has been released

2017-01-03 Thread Erik de Castro Lopo
t. Erik -- ------ Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] FLAC 1.3.2 has been released

2017-01-03 Thread Erik de Castro Lopo
Ozkan Sezer wrote: > Also, the xiph downloads page https://xiph.org/downloads/ still lists > 1.3.1 for flac download. Thats a different issue that I'm still chasing. Erik -- ------ Erik de Castro Lopo http://www.me

Re: [flac-dev] FLAC 1.3.2 has been released

2017-01-02 Thread Erik de Castro Lopo
ac/ site is missing the 1.3.2 files. Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] FLAC 1.3.2 has been released

2017-01-02 Thread Erik de Castro Lopo
to make sure nothing else needs fixing. Thanks, Erik -- ------ Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listi

Re: [flac-dev] FLAC 1.3.2 has been released

2017-01-02 Thread Erik de Castro Lopo
ifferent matter. Erik -- ------ Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] FLAC 1.3.2 has been released

2017-01-02 Thread Erik de Castro Lopo
and CPU was this? Erik -- ---------- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

  1   2   3   4   5   6   7   8   9   10   >