Re: [Flent-users] [tohojo/flent] packet loss stats (#106)

2017-10-16 Thread Pete Heist
> On Oct 16, 2017, at 10:16 PM, Dave Täht wrote: > > > Also, If there's a reason I should do my tests with iperf2 instead, I'm all > > ears, as I'm a "scientist," not attached to my own work. :) I read that > > they're > Cross checking is always good. True, don’t need to find out in 2019 about

Re: [Flent-users] [tohojo/flent] packet loss stats (#106)

2017-10-16 Thread Pete Heist
> On Oct 16, 2017, at 5:54 PM, Toke Høiland-Jørgensen > wrote: > > Hmm, I see your point about explicit being better, but again it's > surprising. A compromise could be to detect it and warn the user > explicitly (i.e., instead of just printing out the whole help message > you could go "you spe

Re: [Flent-users] [tohojo/flent] packet loss stats (#106)

2017-10-16 Thread Dave Täht
Pete Heist writes: > Thanks! I made most of your changes (-o was particularly broken, so this is a > better solution), except: > > * I'm still thinking about whether to default durations to seconds or not. I'm > using Go's default duration flag parsing, and I like the explicitness of > seei

Re: [Flent-users] [tohojo/flent] packet loss stats (#106)

2017-10-16 Thread Toke Høiland-Jørgensen
Pete Heist writes: > Thanks! I made most of your changes (-o was particularly broken, so > this is a better solution), except: Cool! > - I'm still thinking about whether to default durations to seconds or > not. I'm using Go's default duration flag parsing, and I like the > explicitness of seei

Re: [Flent-users] [tohojo/flent] packet loss stats (#106)

2017-10-16 Thread Pete Heist
Thanks! I made most of your changes (-o was particularly broken, so this is a better solution), except: - I'm still thinking about whether to default durations to seconds or not. I'm using Go's default duration flag parsing, and I like the explicitness of seeing the units. - I like that the JSO