Re: LOR: filedesc structure - pipe mutex

2002-12-07 Thread Robert Watson
On Fri, 6 Dec 2002, Kris Kennaway wrote: On Fri, Dec 06, 2002 at 07:18:03PM -0800, Lars Eggert wrote: I'm getting this too: After discussing this with various people on IRC, it was determined that this is not the place where the reversal is occurring, but since witness doesn't have the

Re: LOR: filedesc structure - pipe mutex

2002-12-07 Thread Robert Watson
BTW, one upshot of this whole event is that we should probably be hard-coding the lock order of all important locks rather than allowing it to be automatically determined. We'd uncover problems of this sort much faster and much more easily, and it would provide better documentation of the

Re: LOR: filedesc structure - pipe mutex

2002-12-07 Thread Kris Kennaway
On Sat, Dec 07, 2002 at 08:58:26AM -0500, Robert Watson wrote: On Fri, 6 Dec 2002, Kris Kennaway wrote: On Fri, Dec 06, 2002 at 07:18:03PM -0800, Lars Eggert wrote: I'm getting this too: After discussing this with various people on IRC, it was determined that this is not the

Re: LOR: filedesc structure - pipe mutex

2002-12-07 Thread John Baldwin
On 07-Dec-2002 Robert Watson wrote: BTW, one upshot of this whole event is that we should probably be hard-coding the lock order of all important locks rather than allowing it to be automatically determined. We'd uncover problems of this sort much faster and much more easily, and it would

Re: LOR: filedesc structure - pipe mutex

2002-12-06 Thread Kris Kennaway
On Fri, Dec 06, 2002 at 02:36:49PM -0800, Lars Eggert wrote: On today's -current: lock order reversal 1st 0xc6948234 filedesc structure (filedesc structure) @ /usr/src/sys/kern/sys_generic.c:901 2nd 0xc691f380 pipe mutex (pipe mutex) @ /usr/src/sys/kern/sys_pipe.c:1239

Re: LOR: filedesc structure - pipe mutex

2002-12-06 Thread Lars Eggert
On 12/6/2002 6:22 PM, Kris Kennaway wrote: On Fri, Dec 06, 2002 at 02:36:49PM -0800, Lars Eggert wrote: On today's -current: lock order reversal 1st 0xc6948234 filedesc structure (filedesc structure) @ /usr/src/sys/kern/sys_generic.c:901 2nd 0xc691f380 pipe mutex (pipe mutex) @

Re: LOR: filedesc structure - pipe mutex

2002-12-06 Thread Kris Kennaway
On Fri, Dec 06, 2002 at 07:18:03PM -0800, Lars Eggert wrote: I'm getting this too: Have you gotten this before today? I haven't, and I'm wondering if I see it because I'm running with jhb@'s witness patch for the other LOR. Does your kernel have that patch, too? (Excuse me if that

Re: LOR: filedesc structure - pipe mutex

2002-12-06 Thread Robert Watson
On Fri, 6 Dec 2002, Kris Kennaway wrote: I'm getting this too: Local package initialization:lock order reversal 1st 0xc449ad34 filedesc structure (filedesc structure) @ /local0/src-client/sys/kern/sys_generic.c:901 2nd 0xc4146780 pipe mutex (pipe mutex) @

Re: LOR: filedesc structure - pipe mutex

2002-12-06 Thread Kris Kennaway
On Fri, Dec 06, 2002 at 07:18:03PM -0800, Lars Eggert wrote: I'm getting this too: After discussing this with various people on IRC, it was determined that this is not the place where the reversal is occurring, but since witness doesn't have the lock order defined it has to guess, and in this