Re: [Freedreno] [Mesa-dev] XDC 2020 feedback and comments

2020-09-21 Thread Jason Ekstrand
First off, I think you all did a fantastic job. I felt that things ran very smoothly and, as far as the talks themselves go, I think it went almost as smoothly as an in-person XDC. I'm really quite impressed. I do have a couple pieces of more nuanced feedback: 1. I think we were maybe a bit to

Re: [Freedreno] [Mesa-dev] [RFC 1/4] nir: Add a new intrinsic 'load_image_stride'

2019-01-26 Thread Jason Ekstrand
Mind suffixing it with _ir3 or something since it's a back-end-specific intrinsic? Incidentally, this looks a lot like load_image_param_intel. On January 25, 2019 07:48:54 Eduardo Lima Mitev wrote: This is an internal intrinsic intended to be injected by a (freedreno-specific) 'lower_sampler

Re: [Freedreno] [Mesa-dev] [PATCH 1/2] nir: allow texture offsets with cube maps

2017-11-20 Thread Jason Ekstrand
On Mon, Nov 20, 2017 at 4:10 PM, Ilia Mirkin wrote: > On Mon, Nov 20, 2017 at 7:08 PM, Jason Ekstrand > wrote: > > On Mon, Nov 20, 2017 at 3:11 PM, Ilia Mirkin > wrote: > >> > >> On Mon, Nov 20, 2017 at 5:16 PM, Jason Ekstrand > >> wrote: > >&

Re: [Freedreno] [Mesa-dev] [PATCH 1/2] nir: allow texture offsets with cube maps

2017-11-20 Thread Jason Ekstrand
On Mon, Nov 20, 2017 at 3:11 PM, Ilia Mirkin wrote: > On Mon, Nov 20, 2017 at 5:16 PM, Jason Ekstrand > wrote: > > On Sun, Nov 19, 2017 at 11:54 AM, Ilia Mirkin > wrote: > >> > >> GL doesn't have this, but some hardware supports it. This is convenient

Re: [Freedreno] [Mesa-dev] [PATCH 1/2] nir: allow texture offsets with cube maps

2017-11-20 Thread Jason Ekstrand
On Sun, Nov 19, 2017 at 11:54 AM, Ilia Mirkin wrote: > GL doesn't have this, but some hardware supports it. This is convenient > for lowering tg4 to plain texture calls, which is necessary on Adreno > A4xx hardware. > > Signed-off-by: Ilia Mirkin > --- > src/compiler/nir/nir.h | 15

Re: [Freedreno] [PATCH 03/12] list: fix list_replace() for empty lists

2016-07-02 Thread Jason Ekstrand
On Jul 2, 2016 9:52 AM, "Rob Clark" wrote: > > Before, it would happily copy list_head next/prev (ie. pointer to the > *from* list_head), leaving things in a confused state and causing much > mayhem. Heh, so it would... Thanks for fixing that. Reviewed-by: Jason Ekstrand