[Freeipa-devel] [freeipa PR#856][opened] adtrustinstance: fix a bug + pep8, py3 fixes

2017-06-06 Thread stlaz via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/856 Author: stlaz Title: #856: adtrustinstance: fix a bug + pep8, py3 fixes Action: opened PR body: """ There was a bug in adtrustinstance where there was a comparison of a number to a string which was tailored so that it would always pass (or at le

[Freeipa-devel] [freeipa PR#856][+py3] adtrustinstance: fix a bug + pep8, py3 fixes

2017-06-06 Thread stlaz via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/856 Title: #856: adtrustinstance: fix a bug + pep8, py3 fixes Label: +py3 ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedo

[Freeipa-devel] [freeipa PR#833][comment] Fixes traceback in log and corrects console output

2017-06-06 Thread stlaz via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/833 Title: #833: Fixes traceback in log and corrects console output stlaz commented: """ Yes, I believe that when base DN of a search is not found, we should not be generally treating this gently. """ See the full comment at https://github.com/free

[Freeipa-devel] [freeipa PR#833][comment] Fixes traceback in log and corrects console output

2017-06-06 Thread HonzaCholasta via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/833 Title: #833: Fixes traceback in log and corrects console output HonzaCholasta commented: """ NACK. Please don't "fix" the framework with workarounds for ill-behaved commands, this needs to be fixed in the trust plugin. """ See the full comment a

[Freeipa-devel] [freeipa PR#833][-ack] Fixes traceback in log and corrects console output

2017-06-06 Thread HonzaCholasta via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/833 Title: #833: Fixes traceback in log and corrects console output Label: -ack ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@list

[Freeipa-devel] [freeipa PR#855][comment] Prevent issues with older clients

2017-06-06 Thread simo5 via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/855 Title: #855: Prevent issues with older clients simo5 commented: """ I thought just defining it as None in the constants was enough ? We do not want to set a kinit_lifetime entry in defaults.conf, I am ok with the default being None for now I thin

[Freeipa-devel] [freeipa PR#855][comment] Prevent issues with older clients

2017-06-06 Thread abbra via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/855 Title: #855: Prevent issues with older clients abbra commented: """ Pylint failed: ``` * Module ipaserver.rpcserver ipaserver/rpcserver.py:973: [E1101(no-member), login_password.kinit] Class 'env' has no 'kinit_lifetime' member) make:

[Freeipa-devel] [freeipa PR#833][+ack] Fixes traceback in log and corrects console output

2017-06-06 Thread felipevolpone via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/833 Title: #833: Fixes traceback in log and corrects console output Label: +ack ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@list

[Freeipa-devel] [freeipa PR#833][comment] Fixes traceback in log and corrects console output

2017-06-06 Thread felipevolpone via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/833 Title: #833: Fixes traceback in log and corrects console output felipevolpone commented: """ Tested and it works. Looks good to me. """ See the full comment at https://github.com/freeipa/freeipa/pull/833#issuecomment-306559399 _

[Freeipa-devel] [freeipa PR#855][comment] Prevent issues with older clients

2017-06-06 Thread simo5 via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/855 Title: #855: Prevent issues with older clients simo5 commented: """ In my test setup I verified the cookie does not have the MaxAge setting, and that kinit_lifetime properly causes the session to expire after the lifetime indicated. """ See the

[Freeipa-devel] [freeipa PR#855][comment] Prevent issues with older clients

2017-06-06 Thread simo5 via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/855 Title: #855: Prevent issues with older clients simo5 commented: """ Fixes https://pagure.io/freeipa/issue/6774 """ See the full comment at https://github.com/freeipa/freeipa/pull/855#issuecomment-306538965 ___

[Freeipa-devel] [freeipa PR#855][opened] Prevent issues with older clients

2017-06-06 Thread simo5 via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/855 Author: simo5 Title: #855: Prevent issues with older clients Action: opened PR body: """ Older clients have issues parsing cookies, and cannot handle well the MaxAge setting. So the first patch is about removing it. Unfortunately this means co

[Freeipa-devel] [freeipa PR#848][comment] sssd.py: Deprecating no-sssd option.

2017-06-06 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/848 Title: #848: sssd.py: Deprecating no-sssd option. MartinBasti commented: """ Please fill `changelog` in the ticket about this change. """ See the full comment at https://github.com/freeipa/freeipa/pull/848#issuecomment-306537875

[Freeipa-devel] [freeipa PR#836][closed] Only warn when specified server IP addresses don't match intf

2017-06-06 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/836 Author: MartinBasti Title: #836: Only warn when specified server IP addresses don't match intf Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/836/head:pr836 git c

[Freeipa-devel] [freeipa PR#836][comment] Only warn when specified server IP addresses don't match intf

2017-06-06 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/836 Title: #836: Only warn when specified server IP addresses don't match intf MartinBasti commented: """ master: * 6637980af6069623d944d9d592cbadba20b610a2 Only warn when specified server IP addresses don't match intf ipa-4-5: * 6206ac8bd23250bd

[Freeipa-devel] [freeipa PR#836][+pushed] Only warn when specified server IP addresses don't match intf

2017-06-06 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/836 Title: #836: Only warn when specified server IP addresses don't match intf Label: +pushed ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-de

[Freeipa-devel] [freeipa PR#854][comment] RFC: server-side smart card auth advise plugin

2017-06-06 Thread abbra via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/854 Title: #854: RFC: server-side smart card auth advise plugin abbra commented: """ It looks good, thanks. One small comment is that we probably want to allow the script to work on non-RPM platforms as well (Debian or Ubuntu too) where `yum` does n

[Freeipa-devel] [freeipa PR#854][opened] RFC: server-side smart card auth advise plugin

2017-06-06 Thread martbab via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/854 Author: martbab Title: #854: RFC: server-side smart card auth advise plugin Action: opened PR body: """ This advise plugin generates a script which configures all the components required for successful processing of smart card auth requests on I

[Freeipa-devel] [freeipa PR#853][comment] x509,certdb: handle certificates as bytes

2017-06-06 Thread stlaz via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/853 Title: #853: x509,certdb: handle certificates as bytes stlaz commented: """ This will require some more refactoring, adding WIP label. Basically, `Bytes` parameter only base64-decodes its value if it's of `unicode`/`str` instance (Python2/Python

[Freeipa-devel] [freeipa PR#853][+WIP] x509,certdb: handle certificates as bytes

2017-06-06 Thread stlaz via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/853 Title: #853: x509,certdb: handle certificates as bytes Label: +WIP ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorah

[Freeipa-devel] [freeipa PR#843][closed] [WIP] Fixing test_installation.py tests

2017-06-06 Thread felipevolpone via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/843 Author: felipevolpone Title: #843: [WIP] Fixing test_installation.py tests Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/843/head:pr843 git checkout pr843 __

[Freeipa-devel] [freeipa PR#836][comment] Only warn when specified server IP addresses don't match intf

2017-06-06 Thread tomaskrizek via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/836 Title: #836: Only warn when specified server IP addresses don't match intf tomaskrizek commented: """ Thanks for the updates, looks good now. """ See the full comment at https://github.com/freeipa/freeipa/pull/836#issuecomment-306482223 ___

[Freeipa-devel] [freeipa PR#836][+ack] Only warn when specified server IP addresses don't match intf

2017-06-06 Thread tomaskrizek via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/836 Title: #836: Only warn when specified server IP addresses don't match intf Label: +ack ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel

[Freeipa-devel] [freeipa PR#836][+prioritized] Only warn when specified server IP addresses don't match intf

2017-06-06 Thread pvoborni via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/836 Title: #836: Only warn when specified server IP addresses don't match intf Label: +prioritized ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freei

[Freeipa-devel] [freeipa PR#841][+prioritized] ipa-kdb: use canonical principal in certauth plugin

2017-06-06 Thread pvoborni via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/841 Title: #841: ipa-kdb: use canonical principal in certauth plugin Label: +prioritized ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-l

[Freeipa-devel] [freeipa PR#847][closed] Turn off OCSP check

2017-06-06 Thread martbab via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/847 Author: pvomacka Title: #847: Turn off OCSP check Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/847/head:pr847 git checkout pr847 ___

[Freeipa-devel] [freeipa PR#847][comment] Turn off OCSP check

2017-06-06 Thread martbab via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/847 Title: #847: Turn off OCSP check martbab commented: """ ipa-4-5: * 51b361f475b3e25ace982873beb05cafcba95808 Turn off OCSP check master: * 566361e63d4a670460df3dbb28b9d19f38eaea2d Turn off OCSP check """ See the full comment at https://gith

[Freeipa-devel] [freeipa PR#847][+pushed] Turn off OCSP check

2017-06-06 Thread martbab via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/847 Title: #847: Turn off OCSP check Label: +pushed ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org

[Freeipa-devel] [freeipa PR#847][+ack] Turn off OCSP check

2017-06-06 Thread martbab via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/847 Title: #847: Turn off OCSP check Label: +ack ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org

[Freeipa-devel] [freeipa PR#852][closed] pkinit manage: introduce ipa-pkinit-manage

2017-06-06 Thread martbab via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/852 Author: HonzaCholasta Title: #852: pkinit manage: introduce ipa-pkinit-manage Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/852/head:pr852 git checkout pr852 ___

[Freeipa-devel] [freeipa PR#852][+pushed] pkinit manage: introduce ipa-pkinit-manage

2017-06-06 Thread martbab via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/852 Title: #852: pkinit manage: introduce ipa-pkinit-manage Label: +pushed ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fed

[Freeipa-devel] [freeipa PR#852][comment] pkinit manage: introduce ipa-pkinit-manage

2017-06-06 Thread martbab via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/852 Title: #852: pkinit manage: introduce ipa-pkinit-manage martbab commented: """ ipa-4-5: * 1b62e5aac9d9668604e82879c020bff310fa549f server certinstall: update KDC master entry * c072135340bc8e75f621e2b9163b1347b9eb528f pkinit manage: introduce i

[Freeipa-devel] [freeipa PR#852][+ack] pkinit manage: introduce ipa-pkinit-manage

2017-06-06 Thread martbab via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/852 Title: #852: pkinit manage: introduce ipa-pkinit-manage Label: +ack ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedora

[Freeipa-devel] [freeipa PR#836][comment] Only warn when specified server IP addresses don't match intf

2017-06-06 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/836 Title: #836: Only warn when specified server IP addresses don't match intf MartinBasti commented: """ I don't see reason why not, PR updated. """ See the full comment at https://github.com/freeipa/freeipa/pull/836#issuecomment-306457326

[Freeipa-devel] [freeipa PR#836][synchronized] Only warn when specified server IP addresses don't match intf

2017-06-06 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/836 Author: MartinBasti Title: #836: Only warn when specified server IP addresses don't match intf Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/836/head:pr836

[Freeipa-devel] [freeipa PR#838][+py3] Explicitly ask for py2 dependencies in py2 packages

2017-06-06 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/838 Title: #838: Explicitly ask for py2 dependencies in py2 packages Label: +py3 ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lis

[Freeipa-devel] [freeipa PR#847][synchronized] Turn off OCSP check

2017-06-06 Thread pvomacka via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/847 Author: pvomacka Title: #847: Turn off OCSP check Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/847/head:pr847 git checkout pr847 From f5c5d8721ef6728a5725

[Freeipa-devel] [freeipa PR#843][comment] [WIP] Fixing test_installation.py tests

2017-06-06 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/843 Title: #843: [WIP] Fixing test_installation.py tests MartinBasti commented: """ IIRC that those tests used to pass, so it may be a new bug in IPA or it just suffer from domino effect caused by `ipa-ca` issues. I actually don't understand what yo