Re: [Freeipa-devel] [PATCH] Fix File parameter validation when prompting.

2010-01-29 Thread Pavel Zuna
John Dennis wrote: I've been thinking about this a bit more. I wonder if part of the inelegance is due to the fact we're trying to shoehorn two distinct concepts into one item when a proper relationship does not exist. It does not seem logical that a file is a subclass of a string which is

Re: [Freeipa-devel] [PATCH] 362 remove group pwd policy on group deletion

2010-01-29 Thread Pavel Zuna
Rob Crittenden wrote: Try to remove a group password policy when a group is deleted. No need to leave that hanging around. rob The self parameter is missing in the post_callback, it's not a static method. auto-ack when this is fixed. :) Pavel

Re: [Freeipa-devel] [PATCH] Fix File parameter validation when prompting.

2010-01-29 Thread John Dennis
On 01/29/2010 07:53 AM, Pavel Zuna wrote: John Dennis wrote: In this scheme the you don't need to keep state, you don't need to special case any code, you can use the existing normalize and validate mechanisms. The problem here is that validate/normalize can only be used on final values passed

Re: [Freeipa-devel] [PATCH] Fix File parameter validation when prompting.

2010-01-29 Thread Pavel Zuna
John Dennis wrote: On 01/29/2010 07:53 AM, Pavel Zuna wrote: John Dennis wrote: In this scheme the you don't need to keep state, you don't need to special case any code, you can use the existing normalize and validate mechanisms. The problem here is that validate/normalize can only be used on

Re: [Freeipa-devel] [PATCH] 355 allow named to use ldapi

2010-01-29 Thread Jenny Galipeau
https://bugzilla.redhat.com/show_bug.cgi?id=558984 :-) Jason Gerard DeRose wrote: On Wed, 2010-01-27 at 14:53 -0500, Rob Crittenden wrote: Add SELinux rules so named can communicate to the DS over ldapi. This should fix the installation error when --setup-dns is set and SELinux is

Re: [Freeipa-devel] [PATCH] 360 be smarter about decoding certs

2010-01-29 Thread Rob Crittenden
John Dennis wrote: On 01/28/2010 10:30 PM, Rob Crittenden wrote: John Dennis wrote: On 01/28/2010 04:15 PM, Rob Crittenden wrote: Gah, got the description mixed up with the last patch :-( Be a bit smarter about decoding certificates that might be base64 encoded. First see if it only contains

Re: [Freeipa-devel] [PATCH] 362 remove group pwd policy on group deletion

2010-01-29 Thread Rob Crittenden
Pavel Zuna wrote: Rob Crittenden wrote: Try to remove a group password policy when a group is deleted. No need to leave that hanging around. rob The self parameter is missing in the post_callback, it's not a static method. auto-ack when this is fixed. :) Pavel Wow, great catch. Amazing

Re: [Freeipa-devel] [PATCH] 355 allow named to use ldapi

2010-01-29 Thread Rob Crittenden
Jenny Galipeau wrote: https://bugzilla.redhat.com/show_bug.cgi?id=558984 :-) Jason Gerard DeRose wrote: On Wed, 2010-01-27 at 14:53 -0500, Rob Crittenden wrote: Add SELinux rules so named can communicate to the DS over ldapi. This should fix the installation error when --setup-dns is set

Re: [Freeipa-devel] [PATCH] 360 be smarter about decoding certs

2010-01-29 Thread John Dennis
On 01/29/2010 09:28 AM, Rob Crittenden wrote: John Dennis wrote: On 01/28/2010 10:30 PM, Rob Crittenden wrote: John Dennis wrote: On 01/28/2010 04:15 PM, Rob Crittenden wrote: Gah, got the description mixed up with the last patch :-( Be a bit smarter about decoding certificates that might

Re: [Freeipa-devel] [PATCH] 360 be smarter about decoding certs

2010-01-29 Thread Rob Crittenden
John Dennis wrote: On 01/29/2010 09:28 AM, Rob Crittenden wrote: John Dennis wrote: On 01/28/2010 10:30 PM, Rob Crittenden wrote: John Dennis wrote: On 01/28/2010 04:15 PM, Rob Crittenden wrote: Gah, got the description mixed up with the last patch :-( Be a bit smarter about decoding

Re: [Freeipa-devel] [PATCH] 360 be smarter about decoding certs

2010-01-29 Thread John Dennis
On 01/29/2010 11:26 AM, Rob Crittenden wrote: John Dennis wrote: On 01/29/2010 09:28 AM, Rob Crittenden wrote: John Dennis wrote: On 01/28/2010 10:30 PM, Rob Crittenden wrote: John Dennis wrote: On 01/28/2010 04:15 PM, Rob Crittenden wrote: Gah, got the description mixed up with the last